* [U-Boot] [PATCH] spl: remove redundant call to parse_image_header()
@ 2016-11-16 11:15 Tomas Melin
2016-11-16 11:33 ` Lokesh Vutla
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tomas Melin @ 2016-11-16 11:15 UTC (permalink / raw)
To: u-boot
Image header was checked twice.
Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---
common/spl/spl_ymodem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c
index 13e8e51..957894d 100644
--- a/common/spl/spl_ymodem.c
+++ b/common/spl/spl_ymodem.c
@@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image,
while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0)
size += res;
} else {
- spl_parse_image_header(spl_image, (struct image_header *)buf);
ret = spl_parse_image_header(spl_image,
(struct image_header *)buf);
if (ret)
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] spl: remove redundant call to parse_image_header()
2016-11-16 11:15 [U-Boot] [PATCH] spl: remove redundant call to parse_image_header() Tomas Melin
@ 2016-11-16 11:33 ` Lokesh Vutla
2016-11-18 1:15 ` Simon Glass
2016-11-29 0:56 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Lokesh Vutla @ 2016-11-16 11:33 UTC (permalink / raw)
To: u-boot
+ Tom
On Wednesday 16 November 2016 04:45 PM, Tomas Melin wrote:
> Image header was checked twice.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> common/spl/spl_ymodem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c
> index 13e8e51..957894d 100644
> --- a/common/spl/spl_ymodem.c
> +++ b/common/spl/spl_ymodem.c
> @@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image,
> while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0)
> size += res;
> } else {
> - spl_parse_image_header(spl_image, (struct image_header *)buf);
> ret = spl_parse_image_header(spl_image,
> (struct image_header *)buf);
> if (ret)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] spl: remove redundant call to parse_image_header()
2016-11-16 11:15 [U-Boot] [PATCH] spl: remove redundant call to parse_image_header() Tomas Melin
2016-11-16 11:33 ` Lokesh Vutla
@ 2016-11-18 1:15 ` Simon Glass
2016-11-29 0:56 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2016-11-18 1:15 UTC (permalink / raw)
To: u-boot
On 16 November 2016 at 04:15, Tomas Melin <tomas.melin@vaisala.com> wrote:
> Image header was checked twice.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
> ---
> common/spl/spl_ymodem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c
> index 13e8e51..957894d 100644
> --- a/common/spl/spl_ymodem.c
> +++ b/common/spl/spl_ymodem.c
> @@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image,
> while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0)
> size += res;
> } else {
> - spl_parse_image_header(spl_image, (struct image_header *)buf);
> ret = spl_parse_image_header(spl_image,
> (struct image_header *)buf);
> if (ret)
> --
> 2.1.4
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] spl: remove redundant call to parse_image_header()
2016-11-16 11:15 [U-Boot] [PATCH] spl: remove redundant call to parse_image_header() Tomas Melin
2016-11-16 11:33 ` Lokesh Vutla
2016-11-18 1:15 ` Simon Glass
@ 2016-11-29 0:56 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-11-29 0:56 UTC (permalink / raw)
To: u-boot
On Wed, Nov 16, 2016 at 01:15:05PM +0200, tomas.melin at vaisala.com wrote:
> Image header was checked twice.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
> Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/8b973f1d/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-29 0:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-16 11:15 [U-Boot] [PATCH] spl: remove redundant call to parse_image_header() Tomas Melin
2016-11-16 11:33 ` Lokesh Vutla
2016-11-18 1:15 ` Simon Glass
2016-11-29 0:56 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.