* [PATCH] spi-nor: add dual read support for s25fl128s
@ 2016-08-15 16:46 Heiner Kallweit
2016-09-05 5:39 ` [PATCH v2] spi-nor: fix flags " Heiner Kallweit
2016-09-05 20:54 ` [PATCH v3] " Heiner Kallweit
0 siblings, 2 replies; 7+ messages in thread
From: Heiner Kallweit @ 2016-08-15 16:46 UTC (permalink / raw)
To: Brian Norris, MTD Mailing List
The Spansion S25FL128S also supports the dual read mode.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..4f8e488 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -905,7 +905,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
{ "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
- { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) },
+ { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
--
2.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2] spi-nor: fix flags for s25fl128s
2016-08-15 16:46 [PATCH] spi-nor: add dual read support for s25fl128s Heiner Kallweit
@ 2016-09-05 5:39 ` Heiner Kallweit
2016-09-05 19:09 ` Jagan Teki
2016-09-05 20:54 ` [PATCH v3] " Heiner Kallweit
1 sibling, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2016-09-05 5:39 UTC (permalink / raw)
To: Brian Norris, MTD Mailing List
The Spansion S25FL128S also supports dual read mode.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- In addition remove SECT_4K flag. 4K erases are supported,
but not uniformly.
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..4f8e488 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -905,7 +905,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
{ "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
- { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) },
+ { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
--
2.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] spi-nor: fix flags for s25fl128s
2016-09-05 5:39 ` [PATCH v2] spi-nor: fix flags " Heiner Kallweit
@ 2016-09-05 19:09 ` Jagan Teki
0 siblings, 0 replies; 7+ messages in thread
From: Jagan Teki @ 2016-09-05 19:09 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Brian Norris, MTD Mailing List
On Mon, Sep 5, 2016 at 11:09 AM, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> The Spansion S25FL128S also supports dual read mode.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - In addition remove SECT_4K flag. 4K erases are supported,
> but not uniformly.
Better to mention this on to commit body as well.
Reviewed-by: Jagan Teki <jteki@openedev.com>
thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] spi-nor: fix flags for s25fl128s
2016-08-15 16:46 [PATCH] spi-nor: add dual read support for s25fl128s Heiner Kallweit
2016-09-05 5:39 ` [PATCH v2] spi-nor: fix flags " Heiner Kallweit
@ 2016-09-05 20:54 ` Heiner Kallweit
2016-10-27 21:13 ` [PATCH RESEND v3] mtd: " Heiner Kallweit
1 sibling, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2016-09-05 20:54 UTC (permalink / raw)
To: Brian Norris; +Cc: MTD Mailing List, Jagan Teki
The Spansion S25FL128S also supports dual read mode.
In addition remove flag SECT_4K. 4K erases are supported,
but not uniformly.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jagan Teki <jteki@openedev.com>
---
v2:
- In addition remove SECT_4K flag. 4K erases are supported,
but not uniformly.
v3:
- mention removal of SECT_4K also in actual commit message
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..4f8e488 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -905,7 +905,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
{ "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
- { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) },
+ { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
--
2.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH RESEND v3] mtd: spi-nor: fix flags for s25fl128s
2016-09-05 20:54 ` [PATCH v3] " Heiner Kallweit
@ 2016-10-27 21:13 ` Heiner Kallweit
2016-10-29 17:54 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2016-10-27 21:13 UTC (permalink / raw)
Cc: Brian Norris, MTD Mailing List, Jagan Teki, Cyrille Pitchen
The Spansion S25FL128S also supports dual read mode.
In addition remove flag SECT_4K. 4K erases are supported,
but not uniformly.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jagan Teki <jteki@openedev.com>
---
v2:
- In addition remove SECT_4K flag. 4K erases are supported,
but not uniformly.
v3:
- mention removal of SECT_4K also in actual commit message
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..4f8e488 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -905,7 +905,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
{ "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
- { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) },
+ { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
--
2.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH RESEND v3] mtd: spi-nor: fix flags for s25fl128s
2016-10-27 21:13 ` [PATCH RESEND v3] mtd: " Heiner Kallweit
@ 2016-10-29 17:54 ` Marek Vasut
2016-11-28 8:16 ` Cyrille Pitchen
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2016-10-29 17:54 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Jagan Teki, Cyrille Pitchen, Brian Norris, MTD Mailing List
On 10/27/2016 11:13 PM, Heiner Kallweit wrote:
> The Spansion S25FL128S also supports dual read mode.
> In addition remove flag SECT_4K. 4K erases are supported,
> but not uniformly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Reviewed-by: Jagan Teki <jteki@openedev.com>
Acked-by: Marek Vasut <marek.vasut@gmail.com>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v3] mtd: spi-nor: fix flags for s25fl128s
2016-10-29 17:54 ` Marek Vasut
@ 2016-11-28 8:16 ` Cyrille Pitchen
0 siblings, 0 replies; 7+ messages in thread
From: Cyrille Pitchen @ 2016-11-28 8:16 UTC (permalink / raw)
To: Marek Vasut, Heiner Kallweit; +Cc: Jagan Teki, Brian Norris, MTD Mailing List
Le 29/10/2016 à 19:54, Marek Vasut a écrit :
> On 10/27/2016 11:13 PM, Heiner Kallweit wrote:
>> The Spansion S25FL128S also supports dual read mode.
>> In addition remove flag SECT_4K. 4K erases are supported,
>> but not uniformly.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> Reviewed-by: Jagan Teki <jteki@openedev.com>
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>
Applied to git://github.com/spi-nor/linux.git
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-28 8:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 16:46 [PATCH] spi-nor: add dual read support for s25fl128s Heiner Kallweit
2016-09-05 5:39 ` [PATCH v2] spi-nor: fix flags " Heiner Kallweit
2016-09-05 19:09 ` Jagan Teki
2016-09-05 20:54 ` [PATCH v3] " Heiner Kallweit
2016-10-27 21:13 ` [PATCH RESEND v3] mtd: " Heiner Kallweit
2016-10-29 17:54 ` Marek Vasut
2016-11-28 8:16 ` Cyrille Pitchen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.