All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] mmc: mv_sdhci: zero out sdhci_host structure
@ 2018-04-16 14:08 Matt Pelland
  2018-04-16 15:13 ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Pelland @ 2018-04-16 14:08 UTC (permalink / raw)
  To: u-boot

The mv_sdhci driver was not zeroing the sdhci_host structure it
allocates causing random access violations in parts of the mmc core
where the "ops" member pointers are checked and called if not NULL.

Signed-off-by: Matt Pelland <mpelland@starry.com>
---
 drivers/mmc/mv_sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
index 69aa87babe..0ed0d38c90 100644
--- a/drivers/mmc/mv_sdhci.c
+++ b/drivers/mmc/mv_sdhci.c
@@ -68,7 +68,7 @@ static char *MVSDH_NAME = "mv_sdh";
 int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks)
 {
 	struct sdhci_host *host = NULL;
-	host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host));
+	host = calloc(1, sizeof(*host));
 	if (!host) {
 		printf("sdh_host malloc fail!\n");
 		return -ENOMEM;
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] mmc: mv_sdhci: zero out sdhci_host structure
  2018-04-16 14:08 [U-Boot] [PATCH v2] mmc: mv_sdhci: zero out sdhci_host structure Matt Pelland
@ 2018-04-16 15:13 ` Stefan Roese
  2018-04-17  8:50   ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2018-04-16 15:13 UTC (permalink / raw)
  To: u-boot

On 16.04.2018 16:08, Matt Pelland wrote:
> The mv_sdhci driver was not zeroing the sdhci_host structure it
> allocates causing random access violations in parts of the mmc core
> where the "ops" member pointers are checked and called if not NULL.
> 
> Signed-off-by: Matt Pelland <mpelland@starry.com>
> ---
>   drivers/mmc/mv_sdhci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 69aa87babe..0ed0d38c90 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -68,7 +68,7 @@ static char *MVSDH_NAME = "mv_sdh";
>   int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks)
>   {
>   	struct sdhci_host *host = NULL;
> -	host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host));
> +	host = calloc(1, sizeof(*host));
>   	if (!host) {
>   		printf("sdh_host malloc fail!\n");
>   		return -ENOMEM;
> 

Looks good, so:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] mmc: mv_sdhci: zero out sdhci_host structure
  2018-04-16 15:13 ` Stefan Roese
@ 2018-04-17  8:50   ` Stefan Roese
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2018-04-17  8:50 UTC (permalink / raw)
  To: u-boot

On 16.04.2018 17:13, Stefan Roese wrote:
> On 16.04.2018 16:08, Matt Pelland wrote:
>> The mv_sdhci driver was not zeroing the sdhci_host structure it
>> allocates causing random access violations in parts of the mmc core
>> where the "ops" member pointers are checked and called if not NULL.
>>
>> Signed-off-by: Matt Pelland <mpelland@starry.com>
>> ---
>>   drivers/mmc/mv_sdhci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
>> index 69aa87babe..0ed0d38c90 100644
>> --- a/drivers/mmc/mv_sdhci.c
>> +++ b/drivers/mmc/mv_sdhci.c
>> @@ -68,7 +68,7 @@ static char *MVSDH_NAME = "mv_sdh";
>>   int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 
>> quirks)
>>   {
>>       struct sdhci_host *host = NULL;
>> -    host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host));
>> +    host = calloc(1, sizeof(*host));
>>       if (!host) {
>>           printf("sdh_host malloc fail!\n");
>>           return -ENOMEM;
>>
> 
> Looks good, so:
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-17  8:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 14:08 [U-Boot] [PATCH v2] mmc: mv_sdhci: zero out sdhci_host structure Matt Pelland
2018-04-16 15:13 ` Stefan Roese
2018-04-17  8:50   ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.