From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lorenzo.bianconi-qxv4g6HH51o@public.gmane.org Subject: Re: [PATCH v3 2/2] Documentation: dt: iio: humidity: add hts221 sensor device binding Date: Sun, 9 Oct 2016 11:32:39 +0100 [thread overview] Message-ID: <975bb745-cf11-1c6c-aa73-71e00bf1a42b@kernel.org> (raw) In-Reply-To: <1475912752-6444-3-git-send-email-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> On 08/10/16 08:45, Lorenzo Bianconi wrote: > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> > --- > .../devicetree/bindings/iio/humidity/hts221.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/hts221.txt > > diff --git a/Documentation/devicetree/bindings/iio/humidity/hts221.txt b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > new file mode 100644 > index 0000000..46a152c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > @@ -0,0 +1,19 @@ > +* HTS221 STM humidity + temperature sensor > + > +Required properties: > +- compatible: should be "st,hts221" > +- reg: i2c address of the sensor / spi cs line > + > +Optional properties: > +- interrupts: interrupt mapping for GPIO IRQ. It should be configured with > + flags IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING It might not be a gpio irq. Plenty of IRQ only chips out there that you can't use for general purpose reading (you can't explicitly read their state). > +- interrupt-parent: should be the phandle for the interrupt controller Convention here is to add a cross reference to the main interrupt docs. We have been a bit lax on this in some IIO drivers but might as well be good with a new one. Otherwise this looks good to me. Thanks, Jonathan > + > +Example: > + > +hts221@5f { > + compatible = "st,hts221"; > + reg = <0x5f>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_EDGE_RISING>; > +}; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, lorenzo.bianconi@st.com Subject: Re: [PATCH v3 2/2] Documentation: dt: iio: humidity: add hts221 sensor device binding Date: Sun, 9 Oct 2016 11:32:39 +0100 [thread overview] Message-ID: <975bb745-cf11-1c6c-aa73-71e00bf1a42b@kernel.org> (raw) In-Reply-To: <1475912752-6444-3-git-send-email-lorenzo.bianconi@st.com> On 08/10/16 08:45, Lorenzo Bianconi wrote: > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> > --- > .../devicetree/bindings/iio/humidity/hts221.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/hts221.txt > > diff --git a/Documentation/devicetree/bindings/iio/humidity/hts221.txt b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > new file mode 100644 > index 0000000..46a152c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > @@ -0,0 +1,19 @@ > +* HTS221 STM humidity + temperature sensor > + > +Required properties: > +- compatible: should be "st,hts221" > +- reg: i2c address of the sensor / spi cs line > + > +Optional properties: > +- interrupts: interrupt mapping for GPIO IRQ. It should be configured with > + flags IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING It might not be a gpio irq. Plenty of IRQ only chips out there that you can't use for general purpose reading (you can't explicitly read their state). > +- interrupt-parent: should be the phandle for the interrupt controller Convention here is to add a cross reference to the main interrupt docs. We have been a bit lax on this in some IIO drivers but might as well be good with a new one. Otherwise this looks good to me. Thanks, Jonathan > + > +Example: > + > +hts221@5f { > + compatible = "st,hts221"; > + reg = <0x5f>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_EDGE_RISING>; > +}; >
next prev parent reply other threads:[~2016-10-09 10:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-08 7:45 [PATCH v3 0/2] add support to STM HTS221 humidity + temperature sensor Lorenzo Bianconi 2016-10-08 7:45 ` Lorenzo Bianconi [not found] ` <1475912752-6444-1-git-send-email-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2016-10-08 7:45 ` [PATCH v3 1/2] iio: humidity: add support to hts221 rh/temp combo device Lorenzo Bianconi 2016-10-08 7:45 ` Lorenzo Bianconi [not found] ` <1475912752-6444-2-git-send-email-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2016-10-09 10:31 ` Jonathan Cameron 2016-10-09 10:31 ` Jonathan Cameron 2016-10-11 13:13 ` Lorenzo BIANCONI 2016-10-11 18:41 ` Jonathan Cameron 2016-10-08 7:45 ` [PATCH v3 2/2] Documentation: dt: iio: humidity: add hts221 sensor device binding Lorenzo Bianconi 2016-10-08 7:45 ` Lorenzo Bianconi [not found] ` <1475912752-6444-3-git-send-email-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2016-10-09 10:32 ` Jonathan Cameron [this message] 2016-10-09 10:32 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=975bb745-cf11-1c6c-aa73-71e00bf1a42b@kernel.org \ --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=lorenzo.bianconi-qxv4g6HH51o@public.gmane.org \ --cc=lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.