[PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

Add intel_guc_submission_is_enabled() function to determine if
GuC submission is active.

v2: No need to look at engine to determine if submission is enabled.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1779f600fcfb..7d032f57fc6e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2044,4 +2044,10 @@ i915_coherent_map_type(struct drm_i915_private *i915)
 	return HAS_LLC(i915) ? I915_MAP_WB : I915_MAP_WC;
 }
 
+static inline bool intel_guc_submission_is_enabled(struct intel_guc *guc)
+{
+	return intel_guc_is_submission_supported(guc) &&
+		intel_guc_is_running(guc);
+}
+
 #endif
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

Add intel_guc_submission_is_enabled() function to determine if
GuC submission is active.

v2: No need to look at engine to determine if submission is enabled.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1779f600fcfb..7d032f57fc6e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2044,4 +2044,10 @@ i915_coherent_map_type(struct drm_i915_private *i915)
 	return HAS_LLC(i915) ? I915_MAP_WB : I915_MAP_WC;
 }
 
+static inline bool intel_guc_submission_is_enabled(struct intel_guc *guc)
+{
+	return intel_guc_is_submission_supported(guc) &&
+		intel_guc_is_running(guc);
+}
+
 #endif
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. We can remove the GuC suspend/resume entirely as we do
not need to save the GuC submission status.

v2: Do not suspend/resume the GuC on platforms that do not support
    Guc Submission.
v3: Fix typo, move suspend logic to remove goto.
v4: Use intel_guc_submission_is_enabled() to check GuC submission
    status.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
 2 files changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 019ae6486e8d..92d9305c0d73 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
 		GUC_POWER_D1, /* any value greater than GUC_POWER_D0 */
 	};
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to suspend the GuC.
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	/*
 	 * The ENTER_S_STATE action queues the save/restore operation in GuC FW
 	 * and then returns, so waiting on the H2G is not enough to guarantee
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 629b19377a29..4dd43b99a334 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool enable_communication)
 	if (enable_communication)
 		guc_enable_communication(guc);
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to resume the GuC but we do need to enable the
+	 * GuC communication on resume (above).
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	err = intel_guc_resume(guc);
 	if (err) {
 		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. We can remove the GuC suspend/resume entirely as we do
not need to save the GuC submission status.

v2: Do not suspend/resume the GuC on platforms that do not support
    Guc Submission.
v3: Fix typo, move suspend logic to remove goto.
v4: Use intel_guc_submission_is_enabled() to check GuC submission
    status.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
 2 files changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 019ae6486e8d..92d9305c0d73 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
 		GUC_POWER_D1, /* any value greater than GUC_POWER_D0 */
 	};
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to suspend the GuC.
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	/*
 	 * The ENTER_S_STATE action queues the save/restore operation in GuC FW
 	 * and then returns, so waiting on the H2G is not enough to guarantee
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 629b19377a29..4dd43b99a334 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool enable_communication)
 	if (enable_communication)
 		guc_enable_communication(guc);
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to resume the GuC but we do need to enable the
+	 * GuC communication on resume (above).
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	err = intel_guc_resume(guc);
 	if (err) {
 		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 2522 bytes --]

On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
> 
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. We can remove the GuC suspend/resume entirely as we do
> not need to save the GuC submission status.
> 
> v2: Do not suspend/resume the GuC on platforms that do not support
>     Guc Submission.
> v3: Fix typo, move suspend logic to remove goto.
> v4: Use intel_guc_submission_is_enabled() to check GuC submission
>     status.
> 
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>

Any reason not to just combine both of these into a single patch?

Thanks,
Stuart

> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 019ae6486e8d..92d9305c0d73 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
>  		GUC_POWER_D1, /* any value greater than GUC_POWER_D0 */
>  	};
>  
> +	/*
> +	 * If GuC communication is enabled but submission is not
> supported,
> +	 * we do not need to suspend the GuC.
> +	 */
> +	if (!intel_guc_submission_is_enabled(guc))
> +		return 0;
> +
>  	/*
>  	 * The ENTER_S_STATE action queues the save/restore operation
> in GuC FW
>  	 * and then returns, so waiting on the H2G is not enough to
> guarantee
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index 629b19377a29..4dd43b99a334 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool
> enable_communication)
>  	if (enable_communication)
>  		guc_enable_communication(guc);
>  
> +	/*
> +	 * If GuC communication is enabled but submission is not
> supported,
> +	 * we do not need to resume the GuC but we do need to enable
> the
> +	 * GuC communication on resume (above).
> +	 */
> +	if (!intel_guc_submission_is_enabled(guc))
> +		return 0;
> +
>  	err = intel_guc_resume(guc);
>  	if (err) {
>  		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 2522 bytes --]

On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
> 
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. We can remove the GuC suspend/resume entirely as we do
> not need to save the GuC submission status.
> 
> v2: Do not suspend/resume the GuC on platforms that do not support
>     Guc Submission.
> v3: Fix typo, move suspend logic to remove goto.
> v4: Use intel_guc_submission_is_enabled() to check GuC submission
>     status.
> 
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>

Any reason not to just combine both of these into a single patch?

Thanks,
Stuart

> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 019ae6486e8d..92d9305c0d73 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
>  		GUC_POWER_D1, /* any value greater than GUC_POWER_D0 */
>  	};
>  
> +	/*
> +	 * If GuC communication is enabled but submission is not
> supported,
> +	 * we do not need to suspend the GuC.
> +	 */
> +	if (!intel_guc_submission_is_enabled(guc))
> +		return 0;
> +
>  	/*
>  	 * The ENTER_S_STATE action queues the save/restore operation
> in GuC FW
>  	 * and then returns, so waiting on the H2G is not enough to
> guarantee
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index 629b19377a29..4dd43b99a334 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool
> enable_communication)
>  	if (enable_communication)
>  		guc_enable_communication(guc);
>  
> +	/*
> +	 * If GuC communication is enabled but submission is not
> supported,
> +	 * we do not need to resume the GuC but we do need to enable
> the
> +	 * GuC communication on resume (above).
> +	 */
> +	if (!intel_guc_submission_is_enabled(guc))
> +		return 0;
> +
>  	err = intel_guc_resume(guc);
>  	if (err) {
>  		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Chris Wilson]

Quoting Summers, Stuart (2019-11-15 17:12:58)
> On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> > 
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > not need to save the GuC submission status.
> > 
> > v2: Do not suspend/resume the GuC on platforms that do not support
> >     Guc Submission.
> > v3: Fix typo, move suspend logic to remove goto.
> > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> >     status.
> > 
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> 
> Any reason not to just combine both of these into a single patch?

Also please remember to include the bugzilla link, ask if the reporter
wants to be credited, and most important of all a Fixes: so we can
backport it correctly. If there is no singular cause, point at the
"guc/huc enabling by default" patch.

Last but not least, think about how did we miss in this CI and provide
a Testcase: to verify that it is fixed and stays fixed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Chris Wilson]

Quoting Summers, Stuart (2019-11-15 17:12:58)
> On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> > 
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > not need to save the GuC submission status.
> > 
> > v2: Do not suspend/resume the GuC on platforms that do not support
> >     Guc Submission.
> > v3: Fix typo, move suspend logic to remove goto.
> > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> >     status.
> > 
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> 
> Any reason not to just combine both of these into a single patch?

Also please remember to include the bugzilla link, ask if the reporter
wants to be credited, and most important of all a Fixes: so we can
backport it correctly. If there is no singular cause, point at the
"guc/huc enabling by default" patch.

Last but not least, think about how did we miss in this CI and provide
a Testcase: to verify that it is fixed and stays fixed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Friday, November 15, 2019 9:20 AM
> To: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC
> action on platforms w/o GuC submission
> 
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > >
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > >
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.
> 
> Last but not least, think about how did we miss in this CI and provide
> a Testcase: to verify that it is fixed and stays fixed.
> -Chris

Will do, thanks Chris.

don

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Friday, November 15, 2019 9:20 AM
> To: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC
> action on platforms w/o GuC submission
> 
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > >
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > >
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.
> 
> Last but not least, think about how did we miss in this CI and provide
> a Testcase: to verify that it is fixed and stays fixed.
> -Chris

Will do, thanks Chris.

don

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Tomas Janousek]

Don, Chris,

On Fri, Nov 15, 2019 at 05:19:59PM +0000, Chris Wilson wrote:
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > > 
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > > 
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > > 
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > 
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.

This comment of mine can help with the Fixes: line:
https://bugs.freedesktop.org/show_bug.cgi?id=111623#c20

> I bisected this to [cc80b2ef24898dc62242e194270200b01ca758d1] drm/i915/guc:
> Change platform default GuC mode -- I've been running with enable_guc=-1. If
> I had been running with enable_guc=3, I guess it would've bisected to
> [a2904ade3dc28cf1a1b7deded41f4369f75e664c] drm/i915/guc: Don't allow GuC
> submission.
>
> Anyway, it seems that on this Kaby Lake system, loading HuC without GuC
> submission leads to the GPU not entering rc6 and thus keeping the package
> out of C-states. Obviously then it doesn't matter what GuC version it is, be
> it 9.39 or 32.0.3 or whatever.

Also, as mentioned in another comment:

Tested-by: Tomas Janousek <tomi@nomi.cz>

(Do note that I'm running a backport to 5.3,
https://bugs.freedesktop.org/attachment.cgi?id=145969, not drm-tip.)

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Tomas Janousek]

Don, Chris,

On Fri, Nov 15, 2019 at 05:19:59PM +0000, Chris Wilson wrote:
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > > 
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > > 
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > > 
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > 
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.

This comment of mine can help with the Fixes: line:
https://bugs.freedesktop.org/show_bug.cgi?id=111623#c20

> I bisected this to [cc80b2ef24898dc62242e194270200b01ca758d1] drm/i915/guc:
> Change platform default GuC mode -- I've been running with enable_guc=-1. If
> I had been running with enable_guc=3, I guess it would've bisected to
> [a2904ade3dc28cf1a1b7deded41f4369f75e664c] drm/i915/guc: Don't allow GuC
> submission.
>
> Anyway, it seems that on this Kaby Lake system, loading HuC without GuC
> submission leads to the GPU not entering rc6 and thus keeping the package
> out of C-states. Obviously then it doesn't matter what GuC version it is, be
> it 9.39 or 32.0.3 or whatever.

Also, as mentioned in another comment:

Tested-by: Tomas Janousek <tomi@nomi.cz>

(Do note that I'm running a backport to 5.3,
https://bugs.freedesktop.org/attachment.cgi?id=145969, not drm-tip.)

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Tomas Janousek <tomi@nomi.cz>
> Sent: Friday, November 15, 2019 9:29 AM
> To: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on
> platforms w/o GuC submission
> 
> Don, Chris,
> 
> Also, as mentioned in another comment:
> 
> Tested-by: Tomas Janousek <tomi@nomi.cz>
> 

Thanks, Tomas. I replied to your comment earlier today. I'll include your
'Tested-by'.

Thanks,

don


> (Do note that I'm running a backport to 5.3,
> https://bugs.freedesktop.org/attachment.cgi?id=145969, not drm-tip.)
> 
> --
> Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Tomas Janousek <tomi@nomi.cz>
> Sent: Friday, November 15, 2019 9:29 AM
> To: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on
> platforms w/o GuC submission
> 
> Don, Chris,
> 
> Also, as mentioned in another comment:
> 
> Tested-by: Tomas Janousek <tomi@nomi.cz>
> 

Thanks, Tomas. I replied to your comment earlier today. I'll include your
'Tested-by'.

Thanks,

don


> (Do note that I'm running a backport to 5.3,
> https://bugs.freedesktop.org/attachment.cgi?id=145969, not drm-tip.)
> 
> --
> Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

Hi Stuart/Chris,

> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Friday, November 15, 2019 9:20 AM
> To: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC
> action on platforms w/o GuC submission
> 
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > >
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > >
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.
> 
> Last but not least, think about how did we miss in this CI and provide
> a Testcase: to verify that it is fixed and stays fixed.
> -Chris


Hi Stuart/Chris.

Actually, I'll just combine them now. I think your point is valid and being a single
patch will make it easier to backport and track wrt to Chris's comments.

Thanks,

don

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

Hi Stuart/Chris,

> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Friday, November 15, 2019 9:20 AM
> To: Hiatt, Don <don.hiatt@intel.com>; Summers, Stuart
> <stuart.summers@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC
> action on platforms w/o GuC submission
> 
> Quoting Summers, Stuart (2019-11-15 17:12:58)
> > On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > On some platforms (e.g. KBL) that do not support GuC submission, but
> > > the user enabled the GuC communication (e.g for HuC authentication)
> > > calling the GuC EXIT_S_STATE action results in lose of ability to
> > > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > > not need to save the GuC submission status.
> > >
> > > v2: Do not suspend/resume the GuC on platforms that do not support
> > >     Guc Submission.
> > > v3: Fix typo, move suspend logic to remove goto.
> > > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> > >     status.
> > >
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >
> > Any reason not to just combine both of these into a single patch?
> 
> Also please remember to include the bugzilla link, ask if the reporter
> wants to be credited, and most important of all a Fixes: so we can
> backport it correctly. If there is no singular cause, point at the
> "guc/huc enabling by default" patch.
> 
> Last but not least, think about how did we miss in this CI and provide
> a Testcase: to verify that it is fixed and stays fixed.
> -Chris


Hi Stuart/Chris.

Actually, I'll just combine them now. I think your point is valid and being a single
patch will make it easier to backport and track wrt to Chris's comments.

Thanks,

don

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Summers, Stuart <stuart.summers@intel.com>
> Sent: Friday, November 15, 2019 9:13 AM
> 
> On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > not need to save the GuC submission status.
> >
> > v2: Do not suspend/resume the GuC on platforms that do not support
> >     Guc Submission.
> > v3: Fix typo, move suspend logic to remove goto.
> > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> >     status.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> 
> Any reason not to just combine both of these into a single patch?
> 
> Thanks,
> Stuart
> 

I didn't combine them for two reasons:
1) I wasn't sure if there'd be an ask to use intel_guc_submission_is_enabled() in
    other places.
2) The git log entry highlights the introduction of a new function available for use.

I'll combine them if that's the consensus. 

don

> > ---
> >  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
> >  drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 019ae6486e8d..92d9305c0d73 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
> >  		GUC_POWER_D1, /* any value greater than GUC_POWER_D0
> */
> >  	};
> >
> > +	/*
> > +	 * If GuC communication is enabled but submission is not
> > supported,
> > +	 * we do not need to suspend the GuC.
> > +	 */
> > +	if (!intel_guc_submission_is_enabled(guc))
> > +		return 0;
> > +
> >  	/*
> >  	 * The ENTER_S_STATE action queues the save/restore operation
> > in GuC FW
> >  	 * and then returns, so waiting on the H2G is not enough to
> > guarantee
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > index 629b19377a29..4dd43b99a334 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > @@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool
> > enable_communication)
> >  	if (enable_communication)
> >  		guc_enable_communication(guc);
> >
> > +	/*
> > +	 * If GuC communication is enabled but submission is not
> > supported,
> > +	 * we do not need to resume the GuC but we do need to enable
> > the
> > +	 * GuC communication on resume (above).
> > +	 */
> > +	if (!intel_guc_submission_is_enabled(guc))
> > +		return 0;
> > +
> >  	err = intel_guc_resume(guc);
> >  	if (err) {
> >  		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[Hiatt, Don]

> From: Summers, Stuart <stuart.summers@intel.com>
> Sent: Friday, November 15, 2019 9:13 AM
> 
> On Thu, 2019-11-14 at 17:11 -0800, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. We can remove the GuC suspend/resume entirely as we do
> > not need to save the GuC submission status.
> >
> > v2: Do not suspend/resume the GuC on platforms that do not support
> >     Guc Submission.
> > v3: Fix typo, move suspend logic to remove goto.
> > v4: Use intel_guc_submission_is_enabled() to check GuC submission
> >     status.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> 
> Any reason not to just combine both of these into a single patch?
> 
> Thanks,
> Stuart
> 

I didn't combine them for two reasons:
1) I wasn't sure if there'd be an ask to use intel_guc_submission_is_enabled() in
    other places.
2) The git log entry highlights the introduction of a new function available for use.

I'll combine them if that's the consensus. 

don

> > ---
> >  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
> >  drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 019ae6486e8d..92d9305c0d73 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
> >  		GUC_POWER_D1, /* any value greater than GUC_POWER_D0
> */
> >  	};
> >
> > +	/*
> > +	 * If GuC communication is enabled but submission is not
> > supported,
> > +	 * we do not need to suspend the GuC.
> > +	 */
> > +	if (!intel_guc_submission_is_enabled(guc))
> > +		return 0;
> > +
> >  	/*
> >  	 * The ENTER_S_STATE action queues the save/restore operation
> > in GuC FW
> >  	 * and then returns, so waiting on the H2G is not enough to
> > guarantee
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > index 629b19377a29..4dd43b99a334 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > @@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool
> > enable_communication)
> >  	if (enable_communication)
> >  		guc_enable_communication(guc);
> >
> > +	/*
> > +	 * If GuC communication is enabled but submission is not
> > supported,
> > +	 * we do not need to resume the GuC but we do need to enable
> > the
> > +	 * GuC communication on resume (above).
> > +	 */
> > +	if (!intel_guc_submission_is_enabled(guc))
> > +		return 0;
> > +
> >  	err = intel_guc_resume(guc);
> >  	if (err) {
> >  		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.
URL   : https://patchwork.freedesktop.org/series/69499/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7348 -> Patchwork_15271
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html

Known issues
------------

  Here are the changes found in Patchwork_15271 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][1] -> [FAIL][2] ([fdo#108511])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_execlists:
    - fi-icl-dsi:         [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-icl-dsi/igt@i915_selftest@live_execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/fi-icl-dsi/igt@i915_selftest@live_execlists.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
  [fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260


Participating hosts (48 -> 45)
------------------------------

  Additional (1): fi-byt-j1900 
  Missing    (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7348 -> Patchwork_15271

  CI-20190529: 20190529
  CI_DRM_7348: 70e2f594be151db66cf74acd86b5d5155c311780 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15271: 19ac0e31d3cc9a0ed78ed103a2c419325b964cdf @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

19ac0e31d3cc drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission
53fb770b5d3f drm/i915/guc: Add GuC method to determine if submission is active.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.
URL   : https://patchwork.freedesktop.org/series/69499/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7348 -> Patchwork_15271
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html

Known issues
------------

  Here are the changes found in Patchwork_15271 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][1] -> [FAIL][2] ([fdo#108511])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_execlists:
    - fi-icl-dsi:         [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-icl-dsi/igt@i915_selftest@live_execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/fi-icl-dsi/igt@i915_selftest@live_execlists.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
  [fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260


Participating hosts (48 -> 45)
------------------------------

  Additional (1): fi-byt-j1900 
  Missing    (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7348 -> Patchwork_15271

  CI-20190529: 20190529
  CI_DRM_7348: 70e2f594be151db66cf74acd86b5d5155c311780 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15271: 19ac0e31d3cc9a0ed78ed103a2c419325b964cdf @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

19ac0e31d3cc drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission
53fb770b5d3f drm/i915/guc: Add GuC method to determine if submission is active.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.
URL   : https://patchwork.freedesktop.org/series/69499/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7348_full -> Patchwork_15271_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15271_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_parse_blt@batch-without-end}:
    - shard-iclb:         NOTRUN -> [SKIP][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_parse_blt@batch-without-end.html

  * {igt@gem_exec_parse_blt@batch-zero-length}:
    - shard-tglb:         NOTRUN -> [SKIP][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb8/igt@gem_exec_parse_blt@batch-zero-length.html

  * {igt@gem_exec_reloc@basic-spin-blt}:
    - shard-glk:          NOTRUN -> [TIMEOUT][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-glk5/igt@gem_exec_reloc@basic-spin-blt.html

  
Known issues
------------

  Here are the changes found in Patchwork_15271_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111832]) +1 similar issue
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_ctx_isolation@vecs0-s3.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb7/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_ctx_switch@all-light:
    - shard-tglb:         [PASS][8] -> [INCOMPLETE][9] ([fdo#111672])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@gem_ctx_switch@all-light.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@gem_ctx_switch@all-light.html

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-snb:          [PASS][10] -> [FAIL][11] ([fdo#111946])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb5/igt@gem_eio@in-flight-contexts-10ms.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][12] -> [SKIP][13] ([fdo#112146]) +9 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][14] -> [SKIP][15] ([fdo#109276]) +9 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-kbl:          [PASS][16] -> [INCOMPLETE][17] ([fdo#103665] / [fdo#112068 ])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@gem_persistent_relocs@forked-thrashing.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl4/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_sync@basic-all:
    - shard-tglb:         [PASS][18] -> [INCOMPLETE][19] ([fdo#111647])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb8/igt@gem_sync@basic-all.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@gem_sync@basic-all.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-snb:          [PASS][20] -> [DMESG-WARN][21] ([fdo#111870]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
    - shard-hsw:          [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - shard-skl:          [PASS][24] -> [DMESG-WARN][25] ([fdo#106107])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl8/igt@kms_color@pipe-a-ctm-0-75.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][26] -> [INCOMPLETE][27] ([fdo#103665])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
    - shard-hsw:          [PASS][28] -> [FAIL][29] ([fdo#103355])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][30] -> [FAIL][31] ([fdo#105363])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [PASS][32] -> [DMESG-WARN][33] ([fdo#108566]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][34] -> [FAIL][35] ([fdo#103167]) +2 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-badstride:
    - shard-tglb:         [PASS][36] -> [FAIL][37] ([fdo#103167]) +4 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-badstride.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-badstride.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-tglb:         [PASS][38] -> [INCOMPLETE][39] ([fdo#111832] / [fdo#111850]) +3 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][40] -> [FAIL][41] ([fdo#108145] / [fdo#110403])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#103166])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][44] -> [SKIP][45] ([fdo#109441]) +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][46] -> [DMESG-WARN][47] ([fdo#108566]) +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [PASS][48] -> [SKIP][49] ([fdo#112080]) +6 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs1-clean:
    - shard-iclb:         [SKIP][50] ([fdo#109276] / [fdo#112080]) -> [PASS][51] +2 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb7/igt@gem_ctx_isolation@vcs1-clean.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html

  * igt@gem_exec_parallel@fds:
    - shard-tglb:         [INCOMPLETE][52] ([fdo#111867]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_parallel@fds.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb8/igt@gem_exec_parallel@fds.html

  * igt@gem_exec_reuse@single:
    - shard-tglb:         [INCOMPLETE][54] ([fdo#111747]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_exec_reuse@single.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb1/igt@gem_exec_reuse@single.html

  * igt@gem_exec_schedule@deep-bsd:
    - shard-iclb:         [SKIP][56] ([fdo#112146]) -> [PASS][57] +3 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_exec_schedule@deep-bsd.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_schedule@deep-bsd.html

  * igt@gem_exec_schedule@preempt-queue-blt:
    - shard-tglb:         [INCOMPLETE][58] ([fdo#111677]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@gem_exec_schedule@preempt-queue-blt.html

  * igt@gem_exec_schedule@preempt-queue-bsd1:
    - shard-iclb:         [SKIP][60] ([fdo#109276]) -> [PASS][61] +16 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - shard-tglb:         [INCOMPLETE][62] ([fdo#111850]) -> [PASS][63] +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@gem_exec_suspend@basic-s4-devices.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb7/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@gem_sync@basic-store-all:
    - shard-tglb:         [INCOMPLETE][64] ([fdo#111647]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_sync@basic-store-all.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb9/igt@gem_sync@basic-store-all.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-snb:          [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67] +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [FAIL][68] ([fdo#111830 ]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [SKIP][70] ([fdo#109271]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb7/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          [INCOMPLETE][72] ([fdo#103665] / [fdo#107807]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl2/igt@i915_pm_rpm@system-suspend-execbuf.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl1/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_suspend@debugfs-reader:
    - shard-kbl:          [DMESG-WARN][74] ([fdo#108566]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl3/igt@i915_suspend@debugfs-reader.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl7/igt@i915_suspend@debugfs-reader.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][76] ([fdo#105363]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-hsw:          [INCOMPLETE][78] ([fdo#103540]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_flip_tiling@flip-to-x-tiled:
    - shard-skl:          [FAIL][80] ([fdo#108134]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_flip_tiling@flip-to-x-tiled.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl3/igt@kms_flip_tiling@flip-to-x-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [FAIL][82] ([fdo#103167]) -> [PASS][83] +2 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
    - shard-iclb:         [FAIL][84] ([fdo#103167]) -> [PASS][85] +3 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][86] ([fdo#108145] / [fdo#110403]) -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][88] ([fdo#108341]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@kms_psr@no_drrs.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb2/igt@kms_psr@no_drrs.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][90] ([fdo#99912]) -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl2/igt@kms_setmode@basic.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-apl1/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-tglb:         [INCOMPLETE][92] ([fdo#111832] / [fdo#111850]) -> [PASS][93] +3 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [SKIP][94] ([fdo#112080]) -> [PASS][95] +10 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb7/igt@perf_pmu@busy-check-all-vcs1.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb1/igt@perf_pmu@busy-check-all-vcs1.html

  * igt@prime_vgem@sync-render:
    - shard-tglb:         [INCOMPLETE][96] ([fdo#111612]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb5/igt@prime_vgem@sync-render.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb2/igt@prime_vgem@sync-render.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv-switch:
    - shard-iclb:         [SKIP][98] ([fdo#109276] / [fdo#112080]) -> [FAIL][99] ([fdo#111329])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [DMESG-WARN][100] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][101] ([fdo#111870])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-skl:          [FAIL][102] ([fdo#111830 ]) -> [INCOMPLETE][103] ([fdo#108972])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl10/igt@i915_pm_dc@dc6-dpms.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl6/igt@i915_pm_dc@dc6-dpms.html

  * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking:
    - shard-tglb:         [SKIP][104] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][105] ([fdo#112021 ])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html

  * igt@kms_dp_dsc@basic-dsc-e

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.
URL   : https://patchwork.freedesktop.org/series/69499/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7348_full -> Patchwork_15271_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15271_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_parse_blt@batch-without-end}:
    - shard-iclb:         NOTRUN -> [SKIP][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_parse_blt@batch-without-end.html

  * {igt@gem_exec_parse_blt@batch-zero-length}:
    - shard-tglb:         NOTRUN -> [SKIP][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb8/igt@gem_exec_parse_blt@batch-zero-length.html

  * {igt@gem_exec_reloc@basic-spin-blt}:
    - shard-glk:          NOTRUN -> [TIMEOUT][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-glk5/igt@gem_exec_reloc@basic-spin-blt.html

  
Known issues
------------

  Here are the changes found in Patchwork_15271_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111832]) +1 similar issue
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_ctx_isolation@vecs0-s3.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb7/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_ctx_switch@all-light:
    - shard-tglb:         [PASS][8] -> [INCOMPLETE][9] ([fdo#111672])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@gem_ctx_switch@all-light.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@gem_ctx_switch@all-light.html

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-snb:          [PASS][10] -> [FAIL][11] ([fdo#111946])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb5/igt@gem_eio@in-flight-contexts-10ms.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][12] -> [SKIP][13] ([fdo#112146]) +9 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][14] -> [SKIP][15] ([fdo#109276]) +9 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-kbl:          [PASS][16] -> [INCOMPLETE][17] ([fdo#103665] / [fdo#112068 ])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@gem_persistent_relocs@forked-thrashing.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl4/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_sync@basic-all:
    - shard-tglb:         [PASS][18] -> [INCOMPLETE][19] ([fdo#111647])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb8/igt@gem_sync@basic-all.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@gem_sync@basic-all.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-snb:          [PASS][20] -> [DMESG-WARN][21] ([fdo#111870]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
    - shard-hsw:          [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - shard-skl:          [PASS][24] -> [DMESG-WARN][25] ([fdo#106107])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl8/igt@kms_color@pipe-a-ctm-0-75.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][26] -> [INCOMPLETE][27] ([fdo#103665])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
    - shard-hsw:          [PASS][28] -> [FAIL][29] ([fdo#103355])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][30] -> [FAIL][31] ([fdo#105363])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [PASS][32] -> [DMESG-WARN][33] ([fdo#108566]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][34] -> [FAIL][35] ([fdo#103167]) +2 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-badstride:
    - shard-tglb:         [PASS][36] -> [FAIL][37] ([fdo#103167]) +4 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-badstride.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-badstride.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-tglb:         [PASS][38] -> [INCOMPLETE][39] ([fdo#111832] / [fdo#111850]) +3 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][40] -> [FAIL][41] ([fdo#108145] / [fdo#110403])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#103166])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][44] -> [SKIP][45] ([fdo#109441]) +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][46] -> [DMESG-WARN][47] ([fdo#108566]) +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [PASS][48] -> [SKIP][49] ([fdo#112080]) +6 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs1-clean:
    - shard-iclb:         [SKIP][50] ([fdo#109276] / [fdo#112080]) -> [PASS][51] +2 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb7/igt@gem_ctx_isolation@vcs1-clean.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html

  * igt@gem_exec_parallel@fds:
    - shard-tglb:         [INCOMPLETE][52] ([fdo#111867]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_parallel@fds.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb8/igt@gem_exec_parallel@fds.html

  * igt@gem_exec_reuse@single:
    - shard-tglb:         [INCOMPLETE][54] ([fdo#111747]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_exec_reuse@single.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb1/igt@gem_exec_reuse@single.html

  * igt@gem_exec_schedule@deep-bsd:
    - shard-iclb:         [SKIP][56] ([fdo#112146]) -> [PASS][57] +3 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_exec_schedule@deep-bsd.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb3/igt@gem_exec_schedule@deep-bsd.html

  * igt@gem_exec_schedule@preempt-queue-blt:
    - shard-tglb:         [INCOMPLETE][58] ([fdo#111677]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb3/igt@gem_exec_schedule@preempt-queue-blt.html

  * igt@gem_exec_schedule@preempt-queue-bsd1:
    - shard-iclb:         [SKIP][60] ([fdo#109276]) -> [PASS][61] +16 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - shard-tglb:         [INCOMPLETE][62] ([fdo#111850]) -> [PASS][63] +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@gem_exec_suspend@basic-s4-devices.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb7/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@gem_sync@basic-store-all:
    - shard-tglb:         [INCOMPLETE][64] ([fdo#111647]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_sync@basic-store-all.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb9/igt@gem_sync@basic-store-all.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-snb:          [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67] +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [FAIL][68] ([fdo#111830 ]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [SKIP][70] ([fdo#109271]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb7/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          [INCOMPLETE][72] ([fdo#103665] / [fdo#107807]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl2/igt@i915_pm_rpm@system-suspend-execbuf.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl1/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_suspend@debugfs-reader:
    - shard-kbl:          [DMESG-WARN][74] ([fdo#108566]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl3/igt@i915_suspend@debugfs-reader.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-kbl7/igt@i915_suspend@debugfs-reader.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][76] ([fdo#105363]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-hsw:          [INCOMPLETE][78] ([fdo#103540]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_flip_tiling@flip-to-x-tiled:
    - shard-skl:          [FAIL][80] ([fdo#108134]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_flip_tiling@flip-to-x-tiled.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl3/igt@kms_flip_tiling@flip-to-x-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [FAIL][82] ([fdo#103167]) -> [PASS][83] +2 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
    - shard-iclb:         [FAIL][84] ([fdo#103167]) -> [PASS][85] +3 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][86] ([fdo#108145] / [fdo#110403]) -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][88] ([fdo#108341]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@kms_psr@no_drrs.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb2/igt@kms_psr@no_drrs.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][90] ([fdo#99912]) -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl2/igt@kms_setmode@basic.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-apl1/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-tglb:         [INCOMPLETE][92] ([fdo#111832] / [fdo#111850]) -> [PASS][93] +3 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [SKIP][94] ([fdo#112080]) -> [PASS][95] +10 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb7/igt@perf_pmu@busy-check-all-vcs1.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb1/igt@perf_pmu@busy-check-all-vcs1.html

  * igt@prime_vgem@sync-render:
    - shard-tglb:         [INCOMPLETE][96] ([fdo#111612]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb5/igt@prime_vgem@sync-render.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb2/igt@prime_vgem@sync-render.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv-switch:
    - shard-iclb:         [SKIP][98] ([fdo#109276] / [fdo#112080]) -> [FAIL][99] ([fdo#111329])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [DMESG-WARN][100] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][101] ([fdo#111870])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-skl:          [FAIL][102] ([fdo#111830 ]) -> [INCOMPLETE][103] ([fdo#108972])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl10/igt@i915_pm_dc@dc6-dpms.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-skl6/igt@i915_pm_dc@dc6-dpms.html

  * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking:
    - shard-tglb:         [SKIP][104] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][105] ([fdo#112021 ])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html

  * igt@kms_dp_dsc@basic-dsc-e

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15271/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

Add intel_guc_submission_is_enabled() function to determine if
GuC submission is active. Based on code by Michal Wajdeczko.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h |  1 +
 drivers/gpu/drm/i915/i915_drv.h                   | 14 ++++++++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 2498c55e0ea5..0aaef7c07879 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1081,7 +1081,7 @@ static void guc_interrupts_release(struct intel_gt *gt)
 	rps->pm_intrmsk_mbz &= ~ARAT_EXPIRED_INTRMSK;
 }
 
-static void guc_set_default_submission(struct intel_engine_cs *engine)
+void guc_set_default_submission(struct intel_engine_cs *engine)
 {
 	/*
 	 * We inherit a bunch of functions from execlists that we'd like
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
index 54d716828352..a0132f061ebc 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
@@ -63,5 +63,6 @@ void intel_guc_submission_disable(struct intel_guc *guc);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
+void guc_set_default_submission(struct intel_engine_cs *engine);
 
 #endif
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e0f67babe20..878d574bb1c1 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -78,8 +78,10 @@
 
 #include "gt/intel_lrc.h"
 #include "gt/intel_engine.h"
+#include "gt/intel_gt.h"
 #include "gt/intel_gt_types.h"
 #include "gt/intel_workarounds.h"
+#include "gt/uc/intel_guc_submission.h"
 #include "gt/uc/intel_uc.h"
 
 #include "intel_device_info.h"
@@ -2032,4 +2034,16 @@ i915_coherent_map_type(struct drm_i915_private *i915)
 	return HAS_LLC(i915) ? I915_MAP_WB : I915_MAP_WC;
 }
 
+static inline bool intel_guc_submission_is_enabled(struct intel_guc *guc)
+{
+	struct intel_gt *gt = guc_to_gt(guc);
+	struct intel_engine_cs *engine;
+	enum intel_engine_id id;
+
+	for_each_engine(engine, gt, id)
+		return engine->set_default_submission ==
+			guc_set_default_submission;
+	return false;
+}
+
 #endif
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

[don.hiatt]

From: Don Hiatt <don.hiatt@intel.com>

On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. We can remove the GuC suspend/resume entirely as we do
not need to save the GuC submission status.

v2: Do not suspend/resume the GuC on platforms that do not support
    Guc Submission.
v3: Fix typo, move suspend logic to remove goto.
v4: Use intel_guc_submission_is_enabled() to check GuC submission
    status.

Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 +++++++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c  | 8 ++++++++
 2 files changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 019ae6486e8d..92d9305c0d73 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -553,6 +553,13 @@ int intel_guc_suspend(struct intel_guc *guc)
 		GUC_POWER_D1, /* any value greater than GUC_POWER_D0 */
 	};
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to suspend the GuC.
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	/*
 	 * The ENTER_S_STATE action queues the save/restore operation in GuC FW
 	 * and then returns, so waiting on the H2G is not enough to guarantee
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 629b19377a29..4dd43b99a334 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -605,6 +605,14 @@ static int __uc_resume(struct intel_uc *uc, bool enable_communication)
 	if (enable_communication)
 		guc_enable_communication(guc);
 
+	/*
+	 * If GuC communication is enabled but submission is not supported,
+	 * we do not need to resume the GuC but we do need to enable the
+	 * GuC communication on resume (above).
+	 */
+	if (!intel_guc_submission_is_enabled(guc))
+		return 0;
+
 	err = intel_guc_resume(guc);
 	if (err) {
 		DRM_DEBUG_DRIVER("Failed to resume GuC, err=%d", err);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx