From: Jason Wang <jasowang@redhat.com> To: Xie Yongji <xieyongji@bytedance.com>, mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, parav@nvidia.com, bob.liu@oracle.com, hch@infradead.org, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC v4 04/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Date: Tue, 2 Mar 2021 14:50:37 +0800 [thread overview] Message-ID: <977e44fe-63ec-a695-11a5-d7c584124294@redhat.com> (raw) In-Reply-To: <20210223115048.435-5-xieyongji@bytedance.com> On 2021/2/23 7:50 下午, Xie Yongji wrote: > Add an opaque pointer for DMA mapping. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 +++--- > drivers/vhost/vdpa.c | 2 +- > include/linux/vdpa.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index d5942842432d..5cfc262ce055 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -512,14 +512,14 @@ static int vdpasim_set_map(struct vdpa_device *vdpa, > } > > static int vdpasim_dma_map(struct vdpa_device *vdpa, u64 iova, u64 size, > - u64 pa, u32 perm) > + u64 pa, u32 perm, void *opaque) > { > struct vdpasim *vdpasim = vdpa_to_sim(vdpa); > int ret; > > spin_lock(&vdpasim->iommu_lock); > - ret = vhost_iotlb_add_range(vdpasim->iommu, iova, iova + size - 1, pa, > - perm); > + ret = vhost_iotlb_add_range_ctx(vdpasim->iommu, iova, iova + size - 1, > + pa, perm, opaque); > spin_unlock(&vdpasim->iommu_lock); > > return ret; > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 5500e3bf05c1..70857fe3263c 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -544,7 +544,7 @@ static int vhost_vdpa_map(struct vhost_vdpa *v, > return r; > > if (ops->dma_map) { > - r = ops->dma_map(vdpa, iova, size, pa, perm); > + r = ops->dma_map(vdpa, iova, size, pa, perm, NULL); > } else if (ops->set_map) { > if (!v->in_batch) > r = ops->set_map(vdpa, dev->iotlb); > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 4ab5494503a8..93dca2c328ae 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -241,7 +241,7 @@ struct vdpa_config_ops { > /* DMA ops */ > int (*set_map)(struct vdpa_device *vdev, struct vhost_iotlb *iotlb); > int (*dma_map)(struct vdpa_device *vdev, u64 iova, u64 size, > - u64 pa, u32 perm); > + u64 pa, u32 perm, void *opaque); > int (*dma_unmap)(struct vdpa_device *vdev, u64 iova, u64 size); > > /* Free device resources */
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Xie Yongji <xieyongji@bytedance.com>, mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, parav@nvidia.com, bob.liu@oracle.com, hch@infradead.org, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net Cc: linux-aio@kvack.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [RFC v4 04/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Date: Tue, 2 Mar 2021 14:50:37 +0800 [thread overview] Message-ID: <977e44fe-63ec-a695-11a5-d7c584124294@redhat.com> (raw) In-Reply-To: <20210223115048.435-5-xieyongji@bytedance.com> On 2021/2/23 7:50 下午, Xie Yongji wrote: > Add an opaque pointer for DMA mapping. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 +++--- > drivers/vhost/vdpa.c | 2 +- > include/linux/vdpa.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index d5942842432d..5cfc262ce055 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -512,14 +512,14 @@ static int vdpasim_set_map(struct vdpa_device *vdpa, > } > > static int vdpasim_dma_map(struct vdpa_device *vdpa, u64 iova, u64 size, > - u64 pa, u32 perm) > + u64 pa, u32 perm, void *opaque) > { > struct vdpasim *vdpasim = vdpa_to_sim(vdpa); > int ret; > > spin_lock(&vdpasim->iommu_lock); > - ret = vhost_iotlb_add_range(vdpasim->iommu, iova, iova + size - 1, pa, > - perm); > + ret = vhost_iotlb_add_range_ctx(vdpasim->iommu, iova, iova + size - 1, > + pa, perm, opaque); > spin_unlock(&vdpasim->iommu_lock); > > return ret; > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 5500e3bf05c1..70857fe3263c 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -544,7 +544,7 @@ static int vhost_vdpa_map(struct vhost_vdpa *v, > return r; > > if (ops->dma_map) { > - r = ops->dma_map(vdpa, iova, size, pa, perm); > + r = ops->dma_map(vdpa, iova, size, pa, perm, NULL); > } else if (ops->set_map) { > if (!v->in_batch) > r = ops->set_map(vdpa, dev->iotlb); > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 4ab5494503a8..93dca2c328ae 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -241,7 +241,7 @@ struct vdpa_config_ops { > /* DMA ops */ > int (*set_map)(struct vdpa_device *vdev, struct vhost_iotlb *iotlb); > int (*dma_map)(struct vdpa_device *vdev, u64 iova, u64 size, > - u64 pa, u32 perm); > + u64 pa, u32 perm, void *opaque); > int (*dma_unmap)(struct vdpa_device *vdev, u64 iova, u64 size); > > /* Free device resources */ _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-03-02 9:01 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-23 11:50 [RFC v4 00/11] Introduce VDUSE - vDPA Device in Userspace Xie Yongji 2021-02-23 11:50 ` [RFC v4 01/11] eventfd: Increase the recursion depth of eventfd_signal() Xie Yongji 2021-03-02 6:44 ` Jason Wang 2021-03-02 6:44 ` Jason Wang 2021-03-02 10:32 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 02/11] vhost-vdpa: protect concurrent access to vhost device iotlb Xie Yongji 2021-03-02 6:47 ` Jason Wang 2021-03-02 6:47 ` Jason Wang 2021-03-02 10:20 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 03/11] vhost-iotlb: Add an opaque pointer for vhost IOTLB Xie Yongji 2021-03-02 6:49 ` Jason Wang 2021-03-02 6:49 ` Jason Wang 2021-02-23 11:50 ` [RFC v4 04/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Xie Yongji 2021-03-02 6:50 ` Jason Wang [this message] 2021-03-02 6:50 ` Jason Wang 2021-02-23 11:50 ` [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping Xie Yongji 2021-02-24 7:37 ` Dan Carpenter 2021-02-24 7:37 ` Dan Carpenter 2021-03-03 10:52 ` Mika Penttilä 2021-03-03 12:45 ` Yongji Xie 2021-03-03 13:38 ` Mika Penttilä 2021-03-04 3:07 ` Jason Wang 2021-03-04 3:07 ` Jason Wang 2021-03-04 5:40 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver Xie Yongji 2021-03-04 4:20 ` Jason Wang 2021-03-04 4:20 ` Jason Wang 2021-03-04 5:12 ` Yongji Xie 2021-03-05 3:35 ` Jason Wang 2021-03-05 3:35 ` Jason Wang 2021-03-05 6:15 ` Yongji Xie 2021-03-05 6:51 ` Jason Wang 2021-03-05 7:13 ` Yongji Xie 2021-03-05 7:27 ` Jason Wang 2021-03-05 7:27 ` Jason Wang 2021-03-05 7:59 ` Yongji Xie 2021-03-08 3:17 ` Jason Wang 2021-03-08 3:17 ` Jason Wang 2021-03-08 3:45 ` Yongji Xie 2021-03-08 3:52 ` Jason Wang 2021-03-08 3:52 ` Jason Wang 2021-03-08 5:05 ` Yongji Xie 2021-03-08 7:04 ` Jason Wang 2021-03-08 7:04 ` Jason Wang 2021-03-08 7:08 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji 2021-02-23 15:44 ` kernel test robot 2021-02-23 20:24 ` kernel test robot 2021-03-04 6:27 ` Jason Wang 2021-03-04 6:27 ` Jason Wang 2021-03-04 8:05 ` Yongji Xie 2021-03-05 3:20 ` Jason Wang 2021-03-05 3:20 ` Jason Wang 2021-03-05 3:49 ` Yongji Xie 2021-03-10 12:58 ` Jason Wang 2021-03-10 12:58 ` Jason Wang 2021-03-11 2:28 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 08/11] vduse: Add config interrupt support Xie Yongji 2021-02-23 11:50 ` [RFC v4 09/11] Documentation: Add documentation for VDUSE Xie Yongji 2021-03-04 6:39 ` Jason Wang 2021-03-04 6:39 ` Jason Wang 2021-03-04 10:35 ` Yongji Xie 2021-02-23 11:50 ` [RFC v4 10/11] vduse: Introduce a workqueue for irq injection Xie Yongji 2021-03-04 6:59 ` Jason Wang 2021-03-04 6:59 ` Jason Wang 2021-03-04 8:58 ` Yongji Xie 2021-03-05 3:04 ` Jason Wang 2021-03-05 3:04 ` Jason Wang 2021-03-05 3:30 ` Yongji Xie 2021-03-05 3:42 ` Jason Wang 2021-03-05 3:42 ` Jason Wang 2021-03-05 6:36 ` Yongji Xie 2021-03-05 7:01 ` Jason Wang 2021-03-05 7:01 ` Jason Wang 2021-03-05 7:27 ` Yongji Xie 2021-03-05 7:36 ` Jason Wang 2021-03-05 7:36 ` Jason Wang 2021-03-05 8:12 ` Yongji Xie 2021-03-08 3:04 ` Jason Wang 2021-03-08 3:04 ` Jason Wang 2021-03-08 4:50 ` Yongji Xie 2021-03-08 7:01 ` Jason Wang 2021-03-08 7:01 ` Jason Wang 2021-03-08 7:16 ` Yongji Xie 2021-03-08 7:29 ` Jason Wang 2021-03-08 7:29 ` Jason Wang 2021-02-23 11:50 ` [RFC v4 11/11] vduse: Support binding irq to the specified cpu Xie Yongji 2021-03-04 7:30 ` Jason Wang 2021-03-04 7:30 ` Jason Wang 2021-03-04 8:19 ` Yongji Xie 2021-03-05 3:11 ` Jason Wang 2021-03-05 3:11 ` Jason Wang 2021-03-05 3:37 ` Yongji Xie 2021-03-05 3:44 ` Jason Wang 2021-03-05 3:44 ` Jason Wang 2021-03-05 6:40 ` Yongji Xie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=977e44fe-63ec-a695-11a5-d7c584124294@redhat.com \ --to=jasowang@redhat.com \ --cc=axboe@kernel.dk \ --cc=bcrl@kvack.org \ --cc=bob.liu@oracle.com \ --cc=corbet@lwn.net \ --cc=hch@infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-aio@kvack.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=parav@nvidia.com \ --cc=rdunlap@infradead.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=viro@zeniv.linux.org.uk \ --cc=virtualization@lists.linux-foundation.org \ --cc=willy@infradead.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.