* [PATCH] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
[not found] <cover.1522766852.git.lorenzo.bianconi@redhat.com>
@ 2018-04-03 14:52 ` Lorenzo Bianconi
2018-04-03 19:10 ` Felix Fietkau
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2018-04-03 14:52 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless
Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value
has already set to 0 on 5GHz band
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
index f28c55746cea..cbf185e9f707 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
@@ -294,7 +294,6 @@ mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band)
} else {
mt76_wr(dev, MT_TX0_RF_GAIN_CORR, 0x383c023c);
mt76_wr(dev, MT_TX1_RF_GAIN_CORR, 0x24282e28);
- mt76_wr(dev, MT_TX_ALC_CFG_4, 0);
}
}
}
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
2018-04-03 14:52 ` [PATCH] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Lorenzo Bianconi
@ 2018-04-03 19:10 ` Felix Fietkau
2018-04-03 20:08 ` Lorenzo Bianconi
0 siblings, 1 reply; 3+ messages in thread
From: Felix Fietkau @ 2018-04-03 19:10 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless
On 2018-04-03 16:52, Lorenzo Bianconi wrote:
> Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value
> has already set to 0 on 5GHz band
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
If I read the code correctly, I think it makes more sense to remove the
previous initialization, in order to have the writes to that register
grouped together.
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
2018-04-03 19:10 ` Felix Fietkau
@ 2018-04-03 20:08 ` Lorenzo Bianconi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2018-04-03 20:08 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless
> On 2018-04-03 16:52, Lorenzo Bianconi wrote:
>> Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value
>> has already set to 0 on 5GHz band
>>
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> If I read the code correctly, I think it makes more sense to remove the
> previous initialization, in order to have the writes to that register
> grouped together.
>
> - Felix
Ack, will do in v2
Regards,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-03 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1522766852.git.lorenzo.bianconi@redhat.com>
2018-04-03 14:52 ` [PATCH] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Lorenzo Bianconi
2018-04-03 19:10 ` Felix Fietkau
2018-04-03 20:08 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.