All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
	nathanl@linux.ibm.com, haren@linux.vnet.ibm.com,
	npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] watchdog: export watchdog_mutex and lockup_detector_reconfigure
Date: Fri, 24 Jun 2022 14:45:37 +0200	[thread overview]
Message-ID: <97ae3ac2-c0a8-d675-50a4-0daf960c7f05@linux.ibm.com> (raw)
In-Reply-To: <YrWF0w3mpYA//BX6@infradead.org>

On 24/06/2022, 11:37:23, Christoph Hellwig wrote:
> On Tue, Jun 14, 2022 at 03:54:12PM +0200, Laurent Dufour wrote:
>> The watchdog_mutex is exported to allow some variable to be changed under
>> its protection and prevent any conflict.
>> The lockup_detector_reconfigure() function is exported and is expected to
>> be called under the protection of watchdog_mutex.
> 
> Please provide an actual function accessor instead of directly touching
> a global lock.

Thanks Christoph,

I'll try to not touch to that mutex, if that's not doable, I'll create
function accessor as you're suggesting.


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Dufour <ldufour@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: nathanl@linux.ibm.com, linux-kernel@vger.kernel.org,
	npiggin@gmail.com, paulus@samba.org,
	linuxppc-dev@lists.ozlabs.org, haren@linux.vnet.ibm.com
Subject: Re: [PATCH v2 2/4] watchdog: export watchdog_mutex and lockup_detector_reconfigure
Date: Fri, 24 Jun 2022 14:45:37 +0200	[thread overview]
Message-ID: <97ae3ac2-c0a8-d675-50a4-0daf960c7f05@linux.ibm.com> (raw)
In-Reply-To: <YrWF0w3mpYA//BX6@infradead.org>

On 24/06/2022, 11:37:23, Christoph Hellwig wrote:
> On Tue, Jun 14, 2022 at 03:54:12PM +0200, Laurent Dufour wrote:
>> The watchdog_mutex is exported to allow some variable to be changed under
>> its protection and prevent any conflict.
>> The lockup_detector_reconfigure() function is exported and is expected to
>> be called under the protection of watchdog_mutex.
> 
> Please provide an actual function accessor instead of directly touching
> a global lock.

Thanks Christoph,

I'll try to not touch to that mutex, if that's not doable, I'll create
function accessor as you're suggesting.


  reply	other threads:[~2022-06-24 12:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 13:54 [PATCH v2 0/4] Extending NMI watchdog during LPM Laurent Dufour
2022-06-14 13:54 ` [PATCH v2 1/4] powerpc/mobility: Wait for memory transfer to complete Laurent Dufour
2022-06-21 16:52   ` Nathan Lynch
2022-06-14 13:54 ` [PATCH v2 2/4] watchdog: export watchdog_mutex and lockup_detector_reconfigure Laurent Dufour
2022-06-24  6:31   ` Michael Ellerman
2022-06-24  8:27     ` Laurent Dufour
2022-06-24  9:37   ` Christoph Hellwig
2022-06-24  9:37     ` Christoph Hellwig
2022-06-24 12:45     ` Laurent Dufour [this message]
2022-06-24 12:45       ` Laurent Dufour
2022-06-14 13:54 ` [PATCH v2 3/4] powerpc/watchdog: introduce a LPM factor Laurent Dufour
2022-06-22  9:26   ` kernel test robot
2022-06-22  9:26     ` kernel test robot
2022-06-14 13:54 ` [PATCH v2 4/4] pseries/mobility: Set NMI watchdog factor during LPM Laurent Dufour
2022-06-23 17:28   ` Nathan Lynch
2022-06-23 17:28     ` Nathan Lynch
2022-06-24 14:09     ` Laurent Dufour
2022-06-24 14:09       ` Laurent Dufour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97ae3ac2-c0a8-d675-50a4-0daf960c7f05@linux.ibm.com \
    --to=ldufour@linux.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=haren@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nathanl@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.