From: Randy Dunlap <rdunlap@infradead.org>
To: Arnd Bergmann <arnd@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jacob Keller <jacob.e.keller@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Dave Ertman <david.m.ertman@intel.com>,
Shannon Nelson <snelson@pensando.io>,
Richard Cochran <richardcochran@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] igc: fix PTP dependency
Date: Mon, 27 Sep 2021 10:25:36 -0700 [thread overview]
Message-ID: <97f24334-839f-ba32-c343-73f7aba5b912@infradead.org> (raw)
In-Reply-To: <20210927131730.1587671-1-arnd@kernel.org>
On 9/27/21 6:17 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The igc driver was accidentally left out of the Kconfig rework for PTP,
> it needs the same dependency as the others:
>
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_tsync_interrupt':
> igc_main.c:(.text+0x1b288): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b308): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b8cc): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info':
>
> Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Same patch is already merged in linux-next (via net tree).
Thanks.
> ---
> drivers/net/ethernet/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
> index b0b6f90deb7d..ed8ea63bb172 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -335,6 +335,7 @@ config IGC
> tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
> default n
> depends on PCI
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
> family of adapters.
>
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igc: fix PTP dependency
Date: Mon, 27 Sep 2021 10:25:36 -0700 [thread overview]
Message-ID: <97f24334-839f-ba32-c343-73f7aba5b912@infradead.org> (raw)
In-Reply-To: <20210927131730.1587671-1-arnd@kernel.org>
On 9/27/21 6:17 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The igc driver was accidentally left out of the Kconfig rework for PTP,
> it needs the same dependency as the others:
>
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_tsync_interrupt':
> igc_main.c:(.text+0x1b288): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b308): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b8cc): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info':
>
> Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Same patch is already merged in linux-next (via net tree).
Thanks.
> ---
> drivers/net/ethernet/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
> index b0b6f90deb7d..ed8ea63bb172 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -335,6 +335,7 @@ config IGC
> tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
> default n
> depends on PCI
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
> family of adapters.
>
--
~Randy
next prev parent reply other threads:[~2021-09-27 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 13:17 [PATCH] igc: fix PTP dependency Arnd Bergmann
2021-09-27 13:17 ` [Intel-wired-lan] " Arnd Bergmann
2021-09-27 17:25 ` Randy Dunlap [this message]
2021-09-27 17:25 ` Randy Dunlap
2021-09-27 17:33 ` Randy Dunlap
2021-09-27 17:33 ` [Intel-wired-lan] " Randy Dunlap
2021-09-27 22:35 ` Keller, Jacob E
2021-09-27 22:35 ` [Intel-wired-lan] " Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f24334-839f-ba32-c343-73f7aba5b912@infradead.org \
--to=rdunlap@infradead.org \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=shiraz.saleem@intel.com \
--cc=snelson@pensando.io \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.