From: Ezequiel Garcia <ezequiel@collabora.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Cc: Collabora Kernel ML <kernel@collabora.com>,
matthias.bgg@gmail.com, drinkcat@chromium.org,
hsinyi@chromium.org, Jitao Shi <jitao.shi@mediatek.com>,
Daniel Kurtz <djkurtz@chromium.org>, Ulrich Hecht <uli@fpond.eu>,
linux-arm-kernel@lists.infradead.org,
Andrzej Hajda <a.hajda@samsung.com>,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-mediatek@lists.infradead.org,
David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Wed, 18 Dec 2019 14:22:00 -0300 [thread overview]
Message-ID: <980c181ad15153ee0af4ea20ac2a7265cd2b56f1.camel@collabora.com> (raw)
In-Reply-To: <9e38774d-0028-6988-1be1-2e726c5ed4ab@collabora.com>
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote:
> Hi Ezequiel,
>
> Many thanks for the review, I am just preparing the next version to send.
>
[..]
> > > +
> > > +#define PAGE1_VSTART 0x6b
> > > +#define PAGE2_SPI_CFG3 0x82
> > > +#define I2C_TO_SPI_RESET 0x20
> > > +#define PAGE2_ROMADD_BYTE1 0x8e
> > > +#define PAGE2_ROMADD_BYTE2 0x8f
> > > +#define PAGE2_SWSPI_WDATA 0x90
> > > +#define PAGE2_SWSPI_RDATA 0x91
> > > +#define PAGE2_SWSPI_LEN 0x92
> > > +#define PAGE2_SWSPI_CTL 0x93
> > > +#define TRIGGER_NO_READBACK 0x05
> > > +#define TRIGGER_READBACK 0x01
> > > +#define PAGE2_SPI_STATUS 0x9e
> > > +#define SPI_READY 0x0c
> > > +#define PAGE2_GPIO_L 0xa6
> > > +#define PAGE2_GPIO_H 0xa7
> > > +#define PS_GPIO9 BIT(1)
> > > +#define PAGE2_IROM_CTRL 0xb0
> > > +#define IROM_ENABLE 0xc0
> > > +#define IROM_DISABLE 0x80
> > > +#define PAGE2_SW_RESET 0xbc
> > > +#define SPI_SW_RESET BIT(7)
> > > +#define MPU_SW_RESET BIT(6)
> > > +#define PAGE2_ENCTLSPI_WR 0xda
> > > +#define PAGE2_I2C_BYPASS 0xea
> > > +#define I2C_BYPASS_EN 0xd0
> > > +#define PAGE2_MCS_EN 0xf3
> > > +#define MCS_EN BIT(0)
> > > +#define PAGE3_SET_ADD 0xfe
> > > +#define PAGE3_SET_VAL 0xff
> > > +#define VDO_CTL_ADD 0x13
> > > +#define VDO_DIS 0x18
> > > +#define VDO_EN 0x1c
> > > +#define PAGE4_REV_L 0xf0
> > > +#define PAGE4_REV_H 0xf1
> > > +#define PAGE4_CHIP_L 0xf2
> > > +#define PAGE4_CHIP_H 0xf3
> > > +
> > > +#define PAGE0_DP_CNTL 0
> >
> > Unused macro.
> >
> > > +#define PAGE1_VDO_BDG 1
> > > +#define PAGE2_TOP_CNTL 2
> > > +#define PAGE3_DSI_CNTL1 3
> > > +#define PAGE4_MIPI_PHY 4
> >
> > Ditto... maybe others as well?
> >
>
> I removed all the unused macros.
>
In this case, given these PAGEX_XXX refer
to the I2C ancillaries, maybe you can leave them.
Moreover, I'd put them in an enum, to emphasize
their relationship.
Regards,
Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
drinkcat@chromium.org, Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrzej Hajda <a.hajda@samsung.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
hsinyi@chromium.org, matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Wed, 18 Dec 2019 14:22:00 -0300 [thread overview]
Message-ID: <980c181ad15153ee0af4ea20ac2a7265cd2b56f1.camel@collabora.com> (raw)
In-Reply-To: <9e38774d-0028-6988-1be1-2e726c5ed4ab@collabora.com>
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote:
> Hi Ezequiel,
>
> Many thanks for the review, I am just preparing the next version to send.
>
[..]
> > > +
> > > +#define PAGE1_VSTART 0x6b
> > > +#define PAGE2_SPI_CFG3 0x82
> > > +#define I2C_TO_SPI_RESET 0x20
> > > +#define PAGE2_ROMADD_BYTE1 0x8e
> > > +#define PAGE2_ROMADD_BYTE2 0x8f
> > > +#define PAGE2_SWSPI_WDATA 0x90
> > > +#define PAGE2_SWSPI_RDATA 0x91
> > > +#define PAGE2_SWSPI_LEN 0x92
> > > +#define PAGE2_SWSPI_CTL 0x93
> > > +#define TRIGGER_NO_READBACK 0x05
> > > +#define TRIGGER_READBACK 0x01
> > > +#define PAGE2_SPI_STATUS 0x9e
> > > +#define SPI_READY 0x0c
> > > +#define PAGE2_GPIO_L 0xa6
> > > +#define PAGE2_GPIO_H 0xa7
> > > +#define PS_GPIO9 BIT(1)
> > > +#define PAGE2_IROM_CTRL 0xb0
> > > +#define IROM_ENABLE 0xc0
> > > +#define IROM_DISABLE 0x80
> > > +#define PAGE2_SW_RESET 0xbc
> > > +#define SPI_SW_RESET BIT(7)
> > > +#define MPU_SW_RESET BIT(6)
> > > +#define PAGE2_ENCTLSPI_WR 0xda
> > > +#define PAGE2_I2C_BYPASS 0xea
> > > +#define I2C_BYPASS_EN 0xd0
> > > +#define PAGE2_MCS_EN 0xf3
> > > +#define MCS_EN BIT(0)
> > > +#define PAGE3_SET_ADD 0xfe
> > > +#define PAGE3_SET_VAL 0xff
> > > +#define VDO_CTL_ADD 0x13
> > > +#define VDO_DIS 0x18
> > > +#define VDO_EN 0x1c
> > > +#define PAGE4_REV_L 0xf0
> > > +#define PAGE4_REV_H 0xf1
> > > +#define PAGE4_CHIP_L 0xf2
> > > +#define PAGE4_CHIP_H 0xf3
> > > +
> > > +#define PAGE0_DP_CNTL 0
> >
> > Unused macro.
> >
> > > +#define PAGE1_VDO_BDG 1
> > > +#define PAGE2_TOP_CNTL 2
> > > +#define PAGE3_DSI_CNTL1 3
> > > +#define PAGE4_MIPI_PHY 4
> >
> > Ditto... maybe others as well?
> >
>
> I removed all the unused macros.
>
In this case, given these PAGEX_XXX refer
to the I2C ancillaries, maybe you can leave them.
Moreover, I'd put them in an enum, to emphasize
their relationship.
Regards,
Ezequiel
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
drinkcat@chromium.org, Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
hsinyi@chromium.org, matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Wed, 18 Dec 2019 14:22:00 -0300 [thread overview]
Message-ID: <980c181ad15153ee0af4ea20ac2a7265cd2b56f1.camel@collabora.com> (raw)
In-Reply-To: <9e38774d-0028-6988-1be1-2e726c5ed4ab@collabora.com>
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote:
> Hi Ezequiel,
>
> Many thanks for the review, I am just preparing the next version to send.
>
[..]
> > > +
> > > +#define PAGE1_VSTART 0x6b
> > > +#define PAGE2_SPI_CFG3 0x82
> > > +#define I2C_TO_SPI_RESET 0x20
> > > +#define PAGE2_ROMADD_BYTE1 0x8e
> > > +#define PAGE2_ROMADD_BYTE2 0x8f
> > > +#define PAGE2_SWSPI_WDATA 0x90
> > > +#define PAGE2_SWSPI_RDATA 0x91
> > > +#define PAGE2_SWSPI_LEN 0x92
> > > +#define PAGE2_SWSPI_CTL 0x93
> > > +#define TRIGGER_NO_READBACK 0x05
> > > +#define TRIGGER_READBACK 0x01
> > > +#define PAGE2_SPI_STATUS 0x9e
> > > +#define SPI_READY 0x0c
> > > +#define PAGE2_GPIO_L 0xa6
> > > +#define PAGE2_GPIO_H 0xa7
> > > +#define PS_GPIO9 BIT(1)
> > > +#define PAGE2_IROM_CTRL 0xb0
> > > +#define IROM_ENABLE 0xc0
> > > +#define IROM_DISABLE 0x80
> > > +#define PAGE2_SW_RESET 0xbc
> > > +#define SPI_SW_RESET BIT(7)
> > > +#define MPU_SW_RESET BIT(6)
> > > +#define PAGE2_ENCTLSPI_WR 0xda
> > > +#define PAGE2_I2C_BYPASS 0xea
> > > +#define I2C_BYPASS_EN 0xd0
> > > +#define PAGE2_MCS_EN 0xf3
> > > +#define MCS_EN BIT(0)
> > > +#define PAGE3_SET_ADD 0xfe
> > > +#define PAGE3_SET_VAL 0xff
> > > +#define VDO_CTL_ADD 0x13
> > > +#define VDO_DIS 0x18
> > > +#define VDO_EN 0x1c
> > > +#define PAGE4_REV_L 0xf0
> > > +#define PAGE4_REV_H 0xf1
> > > +#define PAGE4_CHIP_L 0xf2
> > > +#define PAGE4_CHIP_H 0xf3
> > > +
> > > +#define PAGE0_DP_CNTL 0
> >
> > Unused macro.
> >
> > > +#define PAGE1_VDO_BDG 1
> > > +#define PAGE2_TOP_CNTL 2
> > > +#define PAGE3_DSI_CNTL1 3
> > > +#define PAGE4_MIPI_PHY 4
> >
> > Ditto... maybe others as well?
> >
>
> I removed all the unused macros.
>
In this case, given these PAGEX_XXX refer
to the I2C ancillaries, maybe you can leave them.
Moreover, I'd put them in an enum, to emphasize
their relationship.
Regards,
Ezequiel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
drinkcat@chromium.org, Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, hsinyi@chromium.org,
matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Wed, 18 Dec 2019 14:22:00 -0300 [thread overview]
Message-ID: <980c181ad15153ee0af4ea20ac2a7265cd2b56f1.camel@collabora.com> (raw)
In-Reply-To: <9e38774d-0028-6988-1be1-2e726c5ed4ab@collabora.com>
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote:
> Hi Ezequiel,
>
> Many thanks for the review, I am just preparing the next version to send.
>
[..]
> > > +
> > > +#define PAGE1_VSTART 0x6b
> > > +#define PAGE2_SPI_CFG3 0x82
> > > +#define I2C_TO_SPI_RESET 0x20
> > > +#define PAGE2_ROMADD_BYTE1 0x8e
> > > +#define PAGE2_ROMADD_BYTE2 0x8f
> > > +#define PAGE2_SWSPI_WDATA 0x90
> > > +#define PAGE2_SWSPI_RDATA 0x91
> > > +#define PAGE2_SWSPI_LEN 0x92
> > > +#define PAGE2_SWSPI_CTL 0x93
> > > +#define TRIGGER_NO_READBACK 0x05
> > > +#define TRIGGER_READBACK 0x01
> > > +#define PAGE2_SPI_STATUS 0x9e
> > > +#define SPI_READY 0x0c
> > > +#define PAGE2_GPIO_L 0xa6
> > > +#define PAGE2_GPIO_H 0xa7
> > > +#define PS_GPIO9 BIT(1)
> > > +#define PAGE2_IROM_CTRL 0xb0
> > > +#define IROM_ENABLE 0xc0
> > > +#define IROM_DISABLE 0x80
> > > +#define PAGE2_SW_RESET 0xbc
> > > +#define SPI_SW_RESET BIT(7)
> > > +#define MPU_SW_RESET BIT(6)
> > > +#define PAGE2_ENCTLSPI_WR 0xda
> > > +#define PAGE2_I2C_BYPASS 0xea
> > > +#define I2C_BYPASS_EN 0xd0
> > > +#define PAGE2_MCS_EN 0xf3
> > > +#define MCS_EN BIT(0)
> > > +#define PAGE3_SET_ADD 0xfe
> > > +#define PAGE3_SET_VAL 0xff
> > > +#define VDO_CTL_ADD 0x13
> > > +#define VDO_DIS 0x18
> > > +#define VDO_EN 0x1c
> > > +#define PAGE4_REV_L 0xf0
> > > +#define PAGE4_REV_H 0xf1
> > > +#define PAGE4_CHIP_L 0xf2
> > > +#define PAGE4_CHIP_H 0xf3
> > > +
> > > +#define PAGE0_DP_CNTL 0
> >
> > Unused macro.
> >
> > > +#define PAGE1_VDO_BDG 1
> > > +#define PAGE2_TOP_CNTL 2
> > > +#define PAGE3_DSI_CNTL1 3
> > > +#define PAGE4_MIPI_PHY 4
> >
> > Ditto... maybe others as well?
> >
>
> I removed all the unused macros.
>
In this case, given these PAGEX_XXX refer
to the I2C ancillaries, maybe you can leave them.
Moreover, I'd put them in an enum, to emphasize
their relationship.
Regards,
Ezequiel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-18 17:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 13:58 [PATCH v21 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` [PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-17 14:28 ` Maxime Ripard
2019-12-17 14:28 ` Maxime Ripard
2019-12-17 14:28 ` Maxime Ripard
2019-12-17 14:28 ` Maxime Ripard
2019-12-18 15:24 ` Enric Balletbo i Serra
2019-12-18 15:24 ` Enric Balletbo i Serra
2019-12-18 15:24 ` Enric Balletbo i Serra
2019-12-18 15:24 ` Enric Balletbo i Serra
2019-12-16 13:58 ` [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 13:58 ` Enric Balletbo i Serra
2019-12-16 16:32 ` Laurent Pinchart
2019-12-16 16:32 ` Laurent Pinchart
2019-12-16 16:32 ` Laurent Pinchart
2019-12-16 16:32 ` Laurent Pinchart
2019-12-18 12:14 ` Enric Balletbo i Serra
2019-12-18 12:14 ` Enric Balletbo i Serra
2019-12-18 12:14 ` Enric Balletbo i Serra
2019-12-18 12:14 ` Enric Balletbo i Serra
2019-12-16 17:07 ` Ezequiel Garcia
2019-12-16 17:07 ` Ezequiel Garcia
2019-12-16 17:07 ` Ezequiel Garcia
2019-12-16 17:07 ` Ezequiel Garcia
2019-12-18 15:21 ` Enric Balletbo i Serra
2019-12-18 15:21 ` Enric Balletbo i Serra
2019-12-18 15:21 ` Enric Balletbo i Serra
2019-12-18 15:21 ` Enric Balletbo i Serra
2019-12-18 17:22 ` Ezequiel Garcia [this message]
2019-12-18 17:22 ` Ezequiel Garcia
2019-12-18 17:22 ` Ezequiel Garcia
2019-12-18 17:22 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980c181ad15153ee0af4ea20ac2a7265cd2b56f1.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jitao.shi@mediatek.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=uli@fpond.eu \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.