All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@redhat.com>
To: "Christian König" <christian.koenig@amd.com>,
	daniel@ffwll.ch, airlied@redhat.com, bskeggs@redhat.com,
	jason@jlekstrand.net, tzimmermann@suse.de, mripard@kernel.org,
	corbet@lwn.net
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Subject: Re: [Nouveau] [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()
Date: Wed, 18 Jan 2023 20:00:00 +0100	[thread overview]
Message-ID: <9830b666-b78c-9794-0d4a-7de31b9fd9b5@redhat.com> (raw)
In-Reply-To: <3c3bd64a-164b-7ff2-ebf0-c8f9c2f94b72@amd.com>

On 1/18/23 09:51, Christian König wrote:
> That one should probably be squashed into the original patch.

Yes, just wanted to make it obvious for you to pick it up in case you 
did not fix it already yourself.

> 
> Christian.
> 
> Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
>> Don't call drm_gem_object_get() unconditionally.
>>
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>> ---
>>   drivers/gpu/drm/drm_exec.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
>> index ed2106c22786..5713a589a6a3 100644
>> --- a/drivers/gpu/drm/drm_exec.c
>> +++ b/drivers/gpu/drm/drm_exec.c
>> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, 
>> struct drm_gem_object *obj,
>>               goto error_unlock;
>>       }
>> -    drm_gem_object_get(obj);
>>       return 0;
>>   error_unlock:
> 


WARNING: multiple messages have this Message-ID (diff)
From: Danilo Krummrich <dakr@redhat.com>
To: "Christian König" <christian.koenig@amd.com>,
	daniel@ffwll.ch, airlied@redhat.com, bskeggs@redhat.com,
	jason@jlekstrand.net, tzimmermann@suse.de, mripard@kernel.org,
	corbet@lwn.net
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()
Date: Wed, 18 Jan 2023 20:00:00 +0100	[thread overview]
Message-ID: <9830b666-b78c-9794-0d4a-7de31b9fd9b5@redhat.com> (raw)
In-Reply-To: <3c3bd64a-164b-7ff2-ebf0-c8f9c2f94b72@amd.com>

On 1/18/23 09:51, Christian König wrote:
> That one should probably be squashed into the original patch.

Yes, just wanted to make it obvious for you to pick it up in case you 
did not fix it already yourself.

> 
> Christian.
> 
> Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
>> Don't call drm_gem_object_get() unconditionally.
>>
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>> ---
>>   drivers/gpu/drm/drm_exec.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
>> index ed2106c22786..5713a589a6a3 100644
>> --- a/drivers/gpu/drm/drm_exec.c
>> +++ b/drivers/gpu/drm/drm_exec.c
>> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, 
>> struct drm_gem_object *obj,
>>               goto error_unlock;
>>       }
>> -    drm_gem_object_get(obj);
>>       return 0;
>>   error_unlock:
> 


WARNING: multiple messages have this Message-ID (diff)
From: Danilo Krummrich <dakr@redhat.com>
To: "Christian König" <christian.koenig@amd.com>,
	daniel@ffwll.ch, airlied@redhat.com, bskeggs@redhat.com,
	jason@jlekstrand.net, tzimmermann@suse.de, mripard@kernel.org,
	corbet@lwn.net
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()
Date: Wed, 18 Jan 2023 20:00:00 +0100	[thread overview]
Message-ID: <9830b666-b78c-9794-0d4a-7de31b9fd9b5@redhat.com> (raw)
In-Reply-To: <3c3bd64a-164b-7ff2-ebf0-c8f9c2f94b72@amd.com>

On 1/18/23 09:51, Christian König wrote:
> That one should probably be squashed into the original patch.

Yes, just wanted to make it obvious for you to pick it up in case you 
did not fix it already yourself.

> 
> Christian.
> 
> Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
>> Don't call drm_gem_object_get() unconditionally.
>>
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>> ---
>>   drivers/gpu/drm/drm_exec.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
>> index ed2106c22786..5713a589a6a3 100644
>> --- a/drivers/gpu/drm/drm_exec.c
>> +++ b/drivers/gpu/drm/drm_exec.c
>> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, 
>> struct drm_gem_object *obj,
>>               goto error_unlock;
>>       }
>> -    drm_gem_object_get(obj);
>>       return 0;
>>   error_unlock:
> 


  reply	other threads:[~2023-01-18 19:00 UTC|newest]

Thread overview: 229+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  6:12 [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Danilo Krummrich
2023-01-18  6:12 ` Danilo Krummrich
2023-01-18  6:12 ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 01/14] drm: execution context for GEM buffers Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj() Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  8:51   ` [Nouveau] " Christian König
2023-01-18  8:51     ` Christian König
2023-01-18  8:51     ` Christian König
2023-01-18 19:00     ` Danilo Krummrich [this message]
2023-01-18 19:00       ` Danilo Krummrich
2023-01-18 19:00       ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-19  4:14   ` Bagas Sanjaya
2023-01-19  4:14     ` [Nouveau] " Bagas Sanjaya
2023-01-19  4:14     ` Bagas Sanjaya
2023-01-20 18:32     ` Danilo Krummrich
2023-01-23 23:23   ` Niranjana Vishwanathapura
2023-01-23 23:23     ` Niranjana Vishwanathapura
2023-01-24  0:11     ` [Nouveau] " Danilo Krummrich
2023-01-24  0:11       ` Danilo Krummrich
2023-01-24 17:26       ` Niranjana Vishwanathapura
2023-01-26 23:43   ` Matthew Brost
2023-01-26 23:43     ` Matthew Brost
2023-01-27  0:24   ` Matthew Brost
2023-01-27  0:24     ` Matthew Brost
2023-01-28  1:51     ` Danilo Krummrich
2023-02-03 17:37   ` Matthew Brost
2023-02-03 17:37     ` Matthew Brost
2023-02-06 13:35     ` Christian König
2023-02-06 13:35       ` Christian König
2023-02-06 13:35       ` [Nouveau] " Christian König
2023-02-06 13:46       ` Danilo Krummrich
2023-02-06 13:46         ` Danilo Krummrich
2023-02-06 13:46         ` Danilo Krummrich
2023-02-14 11:52     ` [Nouveau] " Danilo Krummrich
2023-02-14 11:52       ` Danilo Krummrich
2023-02-14 11:52       ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 04/14] drm: debugfs: provide infrastructure to dump a DRM GPU VA space Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18 13:55   ` kernel test robot
2023-01-18 13:55     ` kernel test robot
2023-01-18 13:55     ` [Nouveau] " kernel test robot
2023-01-18 15:47   ` kernel test robot
2023-01-18 15:47     ` kernel test robot
2023-01-18 15:47     ` kernel test robot
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-27  1:05   ` Matthew Brost
2023-01-27  1:05     ` Matthew Brost
2023-01-27  1:26     ` [Nouveau] " Danilo Krummrich
2023-01-27  1:26       ` Danilo Krummrich
2023-01-27  1:26       ` Danilo Krummrich
2023-01-27  7:55       ` Christian König
2023-01-27  7:55         ` Christian König
2023-01-27  7:55         ` [Nouveau] " Christian König
2023-01-27 13:12         ` Danilo Krummrich
2023-01-27 13:12           ` Danilo Krummrich
2023-01-27 13:12           ` [Nouveau] " Danilo Krummrich
2023-01-27 13:23           ` Christian König
2023-01-27 13:23             ` Christian König
2023-01-27 13:23             ` [Nouveau] " Christian König
2023-01-27 14:44             ` Danilo Krummrich
2023-01-27 14:44               ` Danilo Krummrich
2023-01-27 14:44               ` Danilo Krummrich
2023-01-27 15:17               ` Christian König
2023-01-27 15:17                 ` Christian König
2023-01-27 15:17                 ` [Nouveau] " Christian König
2023-01-27 20:25                 ` David Airlie
2023-01-27 20:25                   ` David Airlie
2023-01-27 20:25                   ` [Nouveau] " David Airlie
2023-01-30 12:58                   ` Christian König
2023-01-30 12:58                     ` Christian König
2023-01-30 12:58                     ` Christian König
2023-01-27 21:09                 ` [Nouveau] " Danilo Krummrich
2023-01-27 21:09                   ` Danilo Krummrich
2023-01-27 21:09                   ` Danilo Krummrich
2023-01-29 18:46                   ` Danilo Krummrich
2023-01-29 18:46                     ` Danilo Krummrich
2023-01-29 18:46                     ` [Nouveau] " Danilo Krummrich
2023-01-30 13:02                     ` Christian König
2023-01-30 13:02                       ` Christian König
2023-01-30 13:02                       ` [Nouveau] " Christian König
2023-01-30 23:38                       ` Danilo Krummrich
2023-01-30 23:38                         ` Danilo Krummrich
2023-01-30 23:38                         ` Danilo Krummrich
2023-02-01  8:10                       ` [Nouveau] " Dave Airlie
2023-02-01  8:10                         ` Dave Airlie
2023-02-01  8:10                         ` Dave Airlie
2023-02-02 11:53                         ` Christian König
2023-02-02 11:53                           ` Christian König
2023-02-02 11:53                           ` Christian König
2023-02-02 18:31                           ` Danilo Krummrich
2023-02-02 18:31                             ` Danilo Krummrich
2023-02-02 18:31                             ` Danilo Krummrich
2023-02-06  9:48                             ` Christian König
2023-02-06  9:48                               ` Christian König
2023-02-06  9:48                               ` Christian König
2023-02-06 13:27                               ` Danilo Krummrich
2023-02-06 13:27                                 ` Danilo Krummrich
2023-02-06 13:27                                 ` Danilo Krummrich
2023-02-06 16:14                                 ` Christian König
2023-02-06 16:14                                   ` Christian König
2023-02-06 16:14                                   ` Christian König
2023-02-06 18:20                                   ` Danilo Krummrich
2023-02-06 18:20                                     ` Danilo Krummrich
2023-02-06 18:20                                     ` Danilo Krummrich
2023-02-07  9:35                                     ` Christian König
2023-02-07  9:35                                       ` Christian König
2023-02-07  9:35                                       ` Christian König
2023-02-07 10:50                                       ` Danilo Krummrich
2023-02-07 10:50                                         ` Danilo Krummrich
2023-02-07 10:50                                         ` Danilo Krummrich
2023-02-10 11:50                                         ` Christian König
2023-02-10 11:50                                           ` Christian König
2023-02-10 11:50                                           ` Christian König
2023-02-10 12:47                                           ` Danilo Krummrich
2023-02-10 12:47                                             ` Danilo Krummrich
2023-02-10 12:47                                             ` Danilo Krummrich
2023-01-27  1:43     ` Danilo Krummrich
2023-01-27  1:43       ` Danilo Krummrich
2023-01-27  1:43       ` Danilo Krummrich
2023-01-27  3:21       ` Matthew Brost
2023-01-27  3:21         ` Matthew Brost
2023-01-27  3:33         ` Danilo Krummrich
2023-01-27  3:33           ` Danilo Krummrich
2023-01-27  3:33           ` [Nouveau] " Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 06/14] drm/nouveau: get vmm via nouveau_cli_vmm() Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 07/14] drm/nouveau: bo: initialize GEM GPU VA interface Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 08/14] drm/nouveau: move usercopy helpers to nouveau_drv.h Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 09/14] drm/nouveau: fence: fail to emit when fence context is killed Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 10/14] drm/nouveau: chan: provide nouveau_channel_kill() Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 11/14] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  9:37   ` kernel test robot
2023-01-18  9:37     ` kernel test robot
2023-01-20  3:37   ` kernel test robot
2023-01-20  3:37     ` kernel test robot
2023-01-20  3:37     ` [Nouveau] " kernel test robot
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 12/14] drm/nouveau: implement uvmm for user mode bindings Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  8:37   ` kernel test robot
2023-01-18  8:37     ` kernel test robot
2023-01-18 20:37   ` Thomas Hellström (Intel)
2023-01-18 20:37     ` [Nouveau] " Thomas Hellström (Intel)
2023-01-19  3:44     ` Danilo Krummrich
2023-01-19  3:44       ` Danilo Krummrich
2023-01-19  4:58       ` Matthew Brost
2023-01-19  4:58         ` Matthew Brost
2023-01-19  7:32         ` Thomas Hellström (Intel)
2023-01-19  7:32           ` [Nouveau] " Thomas Hellström (Intel)
2023-01-19  7:32           ` Thomas Hellström (Intel)
2023-01-19 15:36         ` Danilo Krummrich
2023-01-19 16:38           ` Matthew Brost
2023-01-19 17:46             ` Danilo Krummrich
2023-01-19 21:47               ` Matthew Brost
2023-01-19 22:25                 ` Danilo Krummrich
2023-01-20  4:30                   ` Matthew Brost
2023-01-20 10:22             ` Boris Brezillon
2023-01-22 17:48               ` Matthew Brost
2023-01-23 10:01                 ` Boris Brezillon
2023-01-20 10:08         ` Boris Brezillon
2023-01-20 10:08           ` [Nouveau] " Boris Brezillon
2023-01-20 10:08           ` Boris Brezillon
2023-01-18  6:12 ` [Nouveau] [PATCH drm-next 14/14] drm/nouveau: debugfs: implement DRM GPU VA debugfs Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  6:12   ` Danilo Krummrich
2023-01-18  8:53 ` [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Christian König
2023-01-18  8:53   ` Christian König
2023-01-18  8:53   ` Christian König
2023-01-18 15:34   ` [Nouveau] " Danilo Krummrich
2023-01-18 15:34     ` Danilo Krummrich
2023-01-18 15:34     ` Danilo Krummrich
2023-01-18 15:37     ` Christian König
2023-01-18 15:37       ` Christian König
2023-01-18 15:37       ` [Nouveau] " Christian König
2023-01-18 16:19       ` Danilo Krummrich
2023-01-18 16:19         ` Danilo Krummrich
2023-01-18 16:19         ` Danilo Krummrich
2023-01-18 16:30         ` [Nouveau] " Alex Deucher
2023-01-18 16:30           ` Alex Deucher
2023-01-18 16:30           ` Alex Deucher
2023-01-18 16:50           ` [Nouveau] " Danilo Krummrich
2023-01-18 16:50             ` Danilo Krummrich
2023-01-18 16:50             ` Danilo Krummrich
2023-01-18 16:54             ` Alex Deucher
2023-01-18 16:54               ` Alex Deucher
2023-01-18 16:54               ` [Nouveau] " Alex Deucher
2023-01-18 19:17               ` Dave Airlie
2023-01-18 19:17                 ` [Nouveau] " Dave Airlie
2023-01-18 19:17                 ` Dave Airlie
2023-01-18 19:48                 ` Christian König
2023-01-18 19:48                   ` Christian König
2023-01-18 19:48                   ` [Nouveau] " Christian König
2023-01-19  4:04                   ` Danilo Krummrich
2023-01-19  4:04                     ` Danilo Krummrich
2023-01-19  4:04                     ` Danilo Krummrich
2023-01-19  5:23                     ` Matthew Brost
2023-01-19  5:23                       ` Matthew Brost
2023-01-19 11:33                       ` [Nouveau] drm_gpuva_manager requirements (was Re: [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI) Christian König
2023-01-19 11:33                         ` Christian König
2023-01-19 11:33                         ` Christian König
2023-02-06 14:48                       ` [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Oded Gabbay
2023-02-06 14:48                         ` Oded Gabbay
2023-03-16 16:39                         ` [Nouveau] " Danilo Krummrich
2023-03-16 16:39                           ` Danilo Krummrich
2023-03-16 16:39                           ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9830b666-b78c-9794-0d4a-7de31b9fd9b5@redhat.com \
    --to=dakr@redhat.com \
    --cc=airlied@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.