All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <james.quinlan@broadcom.com>, linux-spi@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <ray.jui@broadcom.com>,
	Scott Branden <scott.branden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER
Date: Mon, 16 Dec 2019 15:11:18 -0800	[thread overview]
Message-ID: <98362740-2ce9-41f2-a053-80ade1e72a1b@gmail.com> (raw)
In-Reply-To: <20191216230802.45715-2-jquinlan@broadcom.com>

On 12/16/19 3:08 PM, Jim Quinlan wrote:
> Use dev_dbg() on -EPROBE_DEFER and dev_err() on all
> other errors.
> 
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
>  drivers/spi/spi-bcm2835.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
> index fb61a620effc..e4b57b751ce2 100644
> --- a/drivers/spi/spi-bcm2835.c
> +++ b/drivers/spi/spi-bcm2835.c
> @@ -1305,7 +1305,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
>  	bs->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(bs->clk)) {
>  		err = PTR_ERR(bs->clk);
> -		dev_err(&pdev->dev, "could not get clk: %d\n", err);
> +		if (err == -EPROBE_DEFER)
> +			dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
> +		else
> +			dev_err(&pdev->dev, "could not get clk: %d\n", err);
>  		goto out_controller_put;
>  	}
>  
> 


-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <james.quinlan@broadcom.com>, linux-spi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <scott.branden@broadcom.com>,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Ray Jui <ray.jui@broadcom.com>,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2 1/1] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER
Date: Mon, 16 Dec 2019 15:11:18 -0800	[thread overview]
Message-ID: <98362740-2ce9-41f2-a053-80ade1e72a1b@gmail.com> (raw)
In-Reply-To: <20191216230802.45715-2-jquinlan@broadcom.com>

On 12/16/19 3:08 PM, Jim Quinlan wrote:
> Use dev_dbg() on -EPROBE_DEFER and dev_err() on all
> other errors.
> 
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
>  drivers/spi/spi-bcm2835.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
> index fb61a620effc..e4b57b751ce2 100644
> --- a/drivers/spi/spi-bcm2835.c
> +++ b/drivers/spi/spi-bcm2835.c
> @@ -1305,7 +1305,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
>  	bs->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(bs->clk)) {
>  		err = PTR_ERR(bs->clk);
> -		dev_err(&pdev->dev, "could not get clk: %d\n", err);
> +		if (err == -EPROBE_DEFER)
> +			dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
> +		else
> +			dev_err(&pdev->dev, "could not get clk: %d\n", err);
>  		goto out_controller_put;
>  	}
>  
> 


-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-16 23:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 23:08 [PATCH v2 0/1] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER Jim Quinlan
2019-12-16 23:08 ` Jim Quinlan
2019-12-16 23:08 ` [PATCH v2 1/1] " Jim Quinlan
2019-12-16 23:08   ` Jim Quinlan
2019-12-16 23:11   ` Florian Fainelli [this message]
2019-12-16 23:11     ` Florian Fainelli
2019-12-17  9:30   ` Nicolas Saenz Julienne
2019-12-17  9:30     ` Nicolas Saenz Julienne
2019-12-17 12:39   ` Applied "spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER" to the spi tree Mark Brown
2019-12-17 12:39     ` Mark Brown
2019-12-17 12:39     ` Mark Brown
2019-12-17 11:37 ` [PATCH v2 0/1] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER Mark Brown
2019-12-17 11:37   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98362740-2ce9-41f2-a053-80ade1e72a1b@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=ray.jui@broadcom.com \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.