* [PATCH] net: fec: fix build warning of used uninitialized variable
@ 2013-08-22 10:00 Fugang Duan
2013-08-22 14:15 ` Li Frank-B20596
0 siblings, 1 reply; 4+ messages in thread
From: Fugang Duan @ 2013-08-22 10:00 UTC (permalink / raw)
To: b20596, b45643, davem; +Cc: netdev, shawn.guo, bhutchings, R49496, stephen
drivers/net/ethernet/freescale/fec_main.c:838
warning: 'vlan_tag' may be used uninitialized in this function
note: 'vlan_tag' was declared here
Compiler with the warning option: -Wuninitialized, the warning
will be reported.
Signed-off-by: Fugang Duan <B38611@freescale.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 77ea0db..4ea1555 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget)
int pkt_received = 0;
struct bufdesc_ex *ebdp = NULL;
bool vlan_packet_rcvd = false;
- u16 vlan_tag;
+ u16 vlan_tag = 0;
#ifdef CONFIG_M532x
flush_cache_all();
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] net: fec: fix build warning of used uninitialized variable
2013-08-22 10:00 [PATCH] net: fec: fix build warning of used uninitialized variable Fugang Duan
@ 2013-08-22 14:15 ` Li Frank-B20596
2013-08-30 2:47 ` Duan Fugang-B38611
2013-09-10 1:48 ` Duan Fugang-B38611
0 siblings, 2 replies; 4+ messages in thread
From: Li Frank-B20596 @ 2013-08-22 14:15 UTC (permalink / raw)
To: Duan Fugang-B38611, Zhou Luwei-B45643, davem
Cc: netdev, shawn.guo, bhutchings, Estevam Fabio-R49496, stephen
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 77ea0db..4ea1555 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget)
> int pkt_received = 0;
> struct bufdesc_ex *ebdp = NULL;
> bool vlan_packet_rcvd = false;
> - u16 vlan_tag;
> + u16 vlan_tag = 0;
>
> #ifdef CONFIG_M532x
> flush_cache_all();
Acked
> --
> 1.7.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: fec: fix build warning of used uninitialized variable
2013-08-22 14:15 ` Li Frank-B20596
@ 2013-08-30 2:47 ` Duan Fugang-B38611
2013-09-10 1:48 ` Duan Fugang-B38611
1 sibling, 0 replies; 4+ messages in thread
From: Duan Fugang-B38611 @ 2013-08-30 2:47 UTC (permalink / raw)
To: davem
Cc: netdev, shawn.guo, bhutchings, Estevam Fabio-R49496, stephen,
Li Frank-B20596
Ping...
> -----Original Message-----
> From: Li Frank-B20596
> Sent: Thursday, August 22, 2013 10:16 PM
> To: Duan Fugang-B38611; Zhou Luwei-B45643; davem@davemloft.net
> Cc: netdev@vger.kernel.org; shawn.guo@linaro.org;
> bhutchings@solarflare.com; Estevam Fabio-R49496;
> stephen@networkplumber.org
> Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized
> variable
>
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > b/drivers/net/ethernet/freescale/fec_main.c
> > index 77ea0db..4ea1555 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget)
> > int pkt_received = 0;
> > struct bufdesc_ex *ebdp = NULL;
> > bool vlan_packet_rcvd = false;
> > - u16 vlan_tag;
> > + u16 vlan_tag = 0;
> >
> > #ifdef CONFIG_M532x
> > flush_cache_all();
>
> Acked
>
> > --
> > 1.7.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: fec: fix build warning of used uninitialized variable
2013-08-22 14:15 ` Li Frank-B20596
2013-08-30 2:47 ` Duan Fugang-B38611
@ 2013-09-10 1:48 ` Duan Fugang-B38611
1 sibling, 0 replies; 4+ messages in thread
From: Duan Fugang-B38611 @ 2013-09-10 1:48 UTC (permalink / raw)
To: davem
Cc: netdev, shawn.guo, bhutchings, Estevam Fabio-R49496, stephen,
Li Frank-B20596, Sascha Hauer
Hi, David,
Please don't ignore the patch too.
Thanks,
Andy
> -----Original Message-----
> From: Duan Fugang-B38611
> Sent: Friday, August 30, 2013 10:48 AM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; shawn.guo@linaro.org;
> bhutchings@solarflare.com; Estevam Fabio-R49496;
> stephen@networkplumber.org; Li Frank-B20596
> Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized
> variable
>
> Ping...
>
> > -----Original Message-----
> > From: Li Frank-B20596
> > Sent: Thursday, August 22, 2013 10:16 PM
> > To: Duan Fugang-B38611; Zhou Luwei-B45643; davem@davemloft.net
> > Cc: netdev@vger.kernel.org; shawn.guo@linaro.org;
> > bhutchings@solarflare.com; Estevam Fabio-R49496;
> > stephen@networkplumber.org
> > Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized
> > variable
> >
> > > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > > b/drivers/net/ethernet/freescale/fec_main.c
> > > index 77ea0db..4ea1555 100644
> > > --- a/drivers/net/ethernet/freescale/fec_main.c
> > > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > > @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget)
> > > int pkt_received = 0;
> > > struct bufdesc_ex *ebdp = NULL;
> > > bool vlan_packet_rcvd = false;
> > > - u16 vlan_tag;
> > > + u16 vlan_tag = 0;
> > >
> > > #ifdef CONFIG_M532x
> > > flush_cache_all();
> >
> > Acked
> >
> > > --
> > > 1.7.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-10 1:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-22 10:00 [PATCH] net: fec: fix build warning of used uninitialized variable Fugang Duan
2013-08-22 14:15 ` Li Frank-B20596
2013-08-30 2:47 ` Duan Fugang-B38611
2013-09-10 1:48 ` Duan Fugang-B38611
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.