[Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Giulio Benetti]

Actually genimage fails to create final image with:
```
ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
```

This is because genimage 15 is less permissive than before, so let's add
holes = {"(440; 512)"} to leave room to MBR.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pc/genimage-bios.cfg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
index 26d12d9ab3..54026f6527 100644
--- a/board/pc/genimage-bios.cfg
+++ b/board/pc/genimage-bios.cfg
@@ -7,6 +7,7 @@ image disk.img {
 		image = "boot.img"
 		offset = 0
 		size = 512
+		holes = {"(440; 512)"}
 	}
 
 	partition grub {
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Arnout Vandecappelle]

  Hi Giulio,

On 04/02/2022 01:56, Giulio Benetti wrote:
> Actually genimage fails to create final image with:
> ```
> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> ```
> 
> This is because genimage 15 is less permissive than before, so let's add
> holes = {"(440; 512)"} to leave room to MBR.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   board/pc/genimage-bios.cfg | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
> index 26d12d9ab3..54026f6527 100644
> --- a/board/pc/genimage-bios.cfg
> +++ b/board/pc/genimage-bios.cfg
> @@ -7,6 +7,7 @@ image disk.img {
>   		image = "boot.img"
>   		offset = 0
>   		size = 512
> +		holes = {"(440; 512)"}

  Have you tested this change on an actual board (i.e. a PC :-)?

  Regards,
  Arnout

>   	}
>   
>   	partition grub {
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Giulio Benetti]

Hi Arnout,

> Il giorno 5 feb 2022, alle ore 15:11, Arnout Vandecappelle <arnout@mind.be> ha scritto:
> 
>  Hi Giulio,
> 
>> On 04/02/2022 01:56, Giulio Benetti wrote:
>> Actually genimage fails to create final image with:
>> ```
>> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
>> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
>> ```
>> This is because genimage 15 is less permissive than before, so let's add
>> holes = {"(440; 512)"} to leave room to MBR.
>> Fixes:
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>  board/pc/genimage-bios.cfg | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
>> index 26d12d9ab3..54026f6527 100644
>> --- a/board/pc/genimage-bios.cfg
>> +++ b/board/pc/genimage-bios.cfg
>> @@ -7,6 +7,7 @@ image disk.img {
>>          image = "boot.img"
>>          offset = 0
>>          size = 512
>> +        holes = {"(440; 512)"}
> 
> Have you tested this change on an actual board (i.e. a PC :-)?

I’ve tested it with qemu and it boots the kernel correctly(that is in rootfs), only thing is that it can’t mount the rootfs and I don’t understand why.
I wanted to ask about this but I’ve got lost among all the other patches :-)

Could someone double check if it mounts?

Best regards
Giulio

> 
> Regards,
> Arnout
> 
>>      }
>>        partition grub {
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Giulio Benetti]

Hi again Arnout,

On 05/02/22 16:36, Giulio Benetti wrote:
> Hi Arnout,
> 
>> Il giorno 5 feb 2022, alle ore 15:11, Arnout Vandecappelle <arnout@mind.be> ha scritto:
>>
>>  Hi Giulio,
>>
>>> On 04/02/2022 01:56, Giulio Benetti wrote:
>>> Actually genimage fails to create final image with:
>>> ```
>>> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
>>> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
>>> ```
>>> This is because genimage 15 is less permissive than before, so let's add
>>> holes = {"(440; 512)"} to leave room to MBR.
>>> Fixes:
>>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>>   board/pc/genimage-bios.cfg | 1 +
>>>   1 file changed, 1 insertion(+)
>>> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
>>> index 26d12d9ab3..54026f6527 100644
>>> --- a/board/pc/genimage-bios.cfg
>>> +++ b/board/pc/genimage-bios.cfg
>>> @@ -7,6 +7,7 @@ image disk.img {
>>>           image = "boot.img"
>>>           offset = 0
>>>           size = 512
>>> +        holes = {"(440; 512)"}
>>
>> Have you tested this change on an actual board (i.e. a PC :-)?
> 
> I’ve tested it with qemu and it boots the kernel correctly(that is in rootfs), only thing is that it can’t mount the rootfs and I don’t understand why.
> I wanted to ask about this but I’ve got lost among all the other patches :-)

I've compared the 2 disk.img files, one generated with genimage 14 
without "holes..." and the other generated with genimage 15 and they are 
the same.

The problem here is not that it can't mount using qemu, but it doesn't 
show the shell.

Here is the qemu command:
qemu-system-x86_64 -M pc -drive 
file=images/disk.img,if=virtio,format=raw -net nic,model=virtio -net user

and this is the output:
https://imgur.com/a/ffZBlJR

So it seems like a busybox/init system issue with tty1. I'm digging.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Could someone double check if it mounts?
> 
> Best regards
> Giulio
> 
>>
>> Regards,
>> Arnout
>>
>>>       }
>>>         partition grub {
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Giulio Benetti]

Hi Arnout,

On 05/02/22 18:40, Giulio Benetti wrote:
> Hi again Arnout,
> 
> On 05/02/22 16:36, Giulio Benetti wrote:
>> Hi Arnout,
>>
>>> Il giorno 5 feb 2022, alle ore 15:11, Arnout Vandecappelle <arnout@mind.be> ha scritto:
>>>
>>>  Hi Giulio,
>>>
>>>> On 04/02/2022 01:56, Giulio Benetti wrote:
>>>> Actually genimage fails to create final image with:
>>>> ```
>>>> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
>>>> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
>>>> ```
>>>> This is because genimage 15 is less permissive than before, so let's add
>>>> holes = {"(440; 512)"} to leave room to MBR.
>>>> Fixes:
>>>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>> ---
>>>>    board/pc/genimage-bios.cfg | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
>>>> index 26d12d9ab3..54026f6527 100644
>>>> --- a/board/pc/genimage-bios.cfg
>>>> +++ b/board/pc/genimage-bios.cfg
>>>> @@ -7,6 +7,7 @@ image disk.img {
>>>>            image = "boot.img"
>>>>            offset = 0
>>>>            size = 512
>>>> +        holes = {"(440; 512)"}
>>>
>>> Have you tested this change on an actual board (i.e. a PC :-)?
>>
>> I’ve tested it with qemu and it boots the kernel correctly(that is in rootfs), only thing is that it can’t mount the rootfs and I don’t understand why.
>> I wanted to ask about this but I’ve got lost among all the other patches :-)
> 
> I've compared the 2 disk.img files, one generated with genimage 14
> without "holes..." and the other generated with genimage 15 and they are
> the same.
> 
> The problem here is not that it can't mount using qemu, but it doesn't
> show the shell.
> 
> Here is the qemu command:
> qemu-system-x86_64 -M pc -drive
> file=images/disk.img,if=virtio,format=raw -net nic,model=virtio -net user
> 
> and this is the output:
> https://imgur.com/a/ffZBlJR
> 
> So it seems like a busybox/init system issue with tty1. I'm digging.

I've found the problem. Using the grub.cfg as it is(root=/dev/sda1) 
works only with Virtualbox but not with Qemu that needs s/sda1/vda1.

But it's not so well explained in readme.txt, so I'm going to send a 
patch for that.

So I can give a:
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
[Giulio: tested successfully with Qemu and Virtualbox]

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Giulio Benetti]

On 08/02/22 21:00, Giulio Benetti wrote:
> Hi Arnout,
> 
> On 05/02/22 18:40, Giulio Benetti wrote:
>> Hi again Arnout,
>>
>> On 05/02/22 16:36, Giulio Benetti wrote:
>>> Hi Arnout,
>>>
>>>> Il giorno 5 feb 2022, alle ore 15:11, Arnout Vandecappelle <arnout@mind.be> ha scritto:
>>>>
>>>>  Hi Giulio,
>>>>
>>>>> On 04/02/2022 01:56, Giulio Benetti wrote:
>>>>> Actually genimage fails to create final image with:
>>>>> ```
>>>>> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
>>>>> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
>>>>> ```
>>>>> This is because genimage 15 is less permissive than before, so let's add
>>>>> holes = {"(440; 512)"} to leave room to MBR.
>>>>> Fixes:
>>>>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>>> ---
>>>>>     board/pc/genimage-bios.cfg | 1 +
>>>>>     1 file changed, 1 insertion(+)
>>>>> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
>>>>> index 26d12d9ab3..54026f6527 100644
>>>>> --- a/board/pc/genimage-bios.cfg
>>>>> +++ b/board/pc/genimage-bios.cfg
>>>>> @@ -7,6 +7,7 @@ image disk.img {
>>>>>             image = "boot.img"
>>>>>             offset = 0
>>>>>             size = 512
>>>>> +        holes = {"(440; 512)"}
>>>>
>>>> Have you tested this change on an actual board (i.e. a PC :-)?
>>>
>>> I’ve tested it with qemu and it boots the kernel correctly(that is in rootfs), only thing is that it can’t mount the rootfs and I don’t understand why.
>>> I wanted to ask about this but I’ve got lost among all the other patches :-)
>>
>> I've compared the 2 disk.img files, one generated with genimage 14
>> without "holes..." and the other generated with genimage 15 and they are
>> the same.
>>
>> The problem here is not that it can't mount using qemu, but it doesn't
>> show the shell.
>>
>> Here is the qemu command:
>> qemu-system-x86_64 -M pc -drive
>> file=images/disk.img,if=virtio,format=raw -net nic,model=virtio -net user
>>
>> and this is the output:
>> https://imgur.com/a/ffZBlJR
>>
>> So it seems like a busybox/init system issue with tty1. I'm digging.
> 
> I've found the problem. Using the grub.cfg as it is(root=/dev/sda1)
> works only with Virtualbox but not with Qemu that needs s/sda1/vda1.
> 
> But it's not so well explained in readme.txt, so I'm going to send a
> patch for that.

Pardon, I've only misread. readme.txt is correct.

> So I can give a:
> Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> [Giulio: tested successfully with Qemu and Virtualbox]
> 
> Best regards

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] board/pc: fix build failure due to new genimage 15

[Arnout Vandecappelle]

On 04/02/2022 01:56, Giulio Benetti wrote:
> Actually genimage fails to create final image with:
> ```
> ERROR: hdimage(disk.img): partition [MBR] (offset 0x1b8, size 0x48) overlaps previous partition boot (offset 0x0, size 0x200)
> ERROR: hdimage(disk.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> ```
> 
> This is because genimage 15 is less permissive than before, so let's add
> holes = {"(440; 512)"} to leave room to MBR.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1865935249
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   board/pc/genimage-bios.cfg | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/board/pc/genimage-bios.cfg b/board/pc/genimage-bios.cfg
> index 26d12d9ab3..54026f6527 100644
> --- a/board/pc/genimage-bios.cfg
> +++ b/board/pc/genimage-bios.cfg
> @@ -7,6 +7,7 @@ image disk.img {
>   		image = "boot.img"
>   		offset = 0
>   		size = 512
> +		holes = {"(440; 512)"}
>   	}
>   
>   	partition grub {
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot