* [Qemu-devel] [PATCH] checkpatch: Flag suspicious attribution lines
@ 2019-02-04 21:56 Eric Blake
2019-02-04 22:43 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Eric Blake @ 2019-02-04 21:56 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
Flag commit attribution tags that are unusual (often because they
were a typo), but only as a warning (because sometimes a humorous
or otherwise useful tag is intentionally supplied).
This picks the 6-most popular tags, each with 700 or more uses (well,
S-o-b was already checked for case-sensitivity and typos, leaving
only 5 new tags being checked), as determined by:
$ git log | sed -n 's/^ *\([A-Za-z-]*-by:\).*/\1/p' | \
sort | uniq -c | sort -k1,1n | tail
Most of the rejected lines were obvious typos (among others, we've
had 4 cases of someone being burnt, based on Singed-off-by; and 2
cases of list-reading via an e-reader, based on eviewed-by; there
are also lines forgetting a space after the ':') or otherwise
tongue-in-check (3 Approximately-suggested-by). A few lines not
whitelisted here may be legitimate, but as they are orders of
magnitude rarer, it is therefore not worth worrying about
(7 Requested-by, 3 Co-authored-by, 1 Inspired-by, etc.).
Signed-off-by: Eric Blake <eblake@redhat.com>
---
scripts/checkpatch.pl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 88682cb0a9f..51d55f80621 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1456,7 +1456,7 @@ sub process {
ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
}
-#check the patch for a signoff:
+#check the patch for a signoff, and that other attribution lines are typical:
if ($line =~ /^\s*signed-off-by:/i) {
# This is a signoff, if ugly, so do not double report.
$signoff++;
@@ -1470,6 +1470,10 @@ sub process {
ERROR("space required after Signed-off-by:\n" .
$herecurr);
}
+ } elsif($line =~ /^\s*([A-Za-z-])*-by:/ &&
+ ($1 !~ /(Suggest|Report|Test|Ack|Review)ed/ ||
+ $line !~ /^\s[a-z-]*-by:\S/i)) {
+ WARN("suspicious attribution tag:\n" . $herecurr);
}
# Check if MAINTAINERS is being updated. If so, there's probably no need to
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] checkpatch: Flag suspicious attribution lines
2019-02-04 21:56 [Qemu-devel] [PATCH] checkpatch: Flag suspicious attribution lines Eric Blake
@ 2019-02-04 22:43 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2019-02-04 22:43 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]
On 2/4/19 3:56 PM, Eric Blake wrote:
> Flag commit attribution tags that are unusual (often because they
> were a typo), but only as a warning (because sometimes a humorous
> or otherwise useful tag is intentionally supplied).
>
> This picks the 6-most popular tags, each with 700 or more uses (well,
> S-o-b was already checked for case-sensitivity and typos, leaving
> only 5 new tags being checked), as determined by:
> $ git log | sed -n 's/^ *\([A-Za-z-]*-by:\).*/\1/p' | \
> sort | uniq -c | sort -k1,1n | tail
>
> Most of the rejected lines were obvious typos (among others, we've
> had 4 cases of someone being burnt, based on Singed-off-by; and 2
> cases of list-reading via an e-reader, based on eviewed-by; there
> are also lines forgetting a space after the ':') or otherwise
> tongue-in-check (3 Approximately-suggested-by). A few lines not
> whitelisted here may be legitimate, but as they are orders of
> magnitude rarer, it is therefore not worth worrying about
> (7 Requested-by, 3 Co-authored-by, 1 Inspired-by, etc.).
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> }
> + } elsif($line =~ /^\s*([A-Za-z-])*-by:/ &&
> + ($1 !~ /(Suggest|Report|Test|Ack|Review)ed/ ||
> + $line !~ /^\s[a-z-]*-by:\S/i)) {
Oops, that last one is supposed to be =~, to flag lines that forget the
space between *-by: and the email address.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-04 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 21:56 [Qemu-devel] [PATCH] checkpatch: Flag suspicious attribution lines Eric Blake
2019-02-04 22:43 ` Eric Blake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.