All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/vma: Move VM_NO_KHUGEPAGED into generic header
Date: Wed, 26 Feb 2020 12:34:39 +0100	[thread overview]
Message-ID: <9899b82b-1295-97de-27da-a0a20dbe1a60@suse.cz> (raw)
In-Reply-To: <1582692658-3294-2-git-send-email-anshuman.khandual@arm.com>

On 2/26/20 5:50 AM, Anshuman Khandual wrote:
> Move VM_NO_KHUGEPAGED into generic header (include/linux/mm.h). This just
> makes sure that no VMA flag is scattered in individual function files any
> longer. While at this, fix an old comment which is no longer valid.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  include/linux/mm.h | 3 ++-
>  mm/khugepaged.c    | 2 --
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 52269e56c514..6f7e400e6ea3 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -287,6 +287,8 @@ extern unsigned int kobjsize(const void *objp);
>  #define VM_NOHUGEPAGE	0x40000000	/* MADV_NOHUGEPAGE marked this vma */
>  #define VM_MERGEABLE	0x80000000	/* KSM may merge identical pages */
>  
> +#define VM_NO_KHUGEPAGED (VM_SPECIAL | VM_HUGETLB)

While the preprocessor doesn't mind that VM_SPECIAL is only defined later, I
would have moved this below VM_SPECIAL definition anyway, where it fits better,
and add a comment like other defines there do?

  reply	other threads:[~2020-02-26 11:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  4:50 [PATCH 0/3] mm/vma: some more minor changes Anshuman Khandual
2020-02-26  4:50 ` Anshuman Khandual
2020-02-26  4:50 ` [PATCH 1/3] mm/vma: Move VM_NO_KHUGEPAGED into generic header Anshuman Khandual
2020-02-26 11:34   ` Vlastimil Babka [this message]
2020-02-27  0:06     ` Anshuman Khandual
2020-02-26  4:50 ` [PATCH 2/3] mm/vma: Make vma_is_foreign() available for general use Anshuman Khandual
2020-02-26  4:50   ` Anshuman Khandual
2020-02-26 13:59   ` Vlastimil Babka
2020-02-26 13:59     ` Vlastimil Babka
2020-02-26  4:50 ` [PATCH 3/3] mm/vma: Make is_vma_temporary_stack() " Anshuman Khandual
2020-02-26 14:03   ` Vlastimil Babka
2020-02-27  0:08     ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9899b82b-1295-97de-27da-a0a20dbe1a60@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.