All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  3:31 ` Irui Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  3:31 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, Irui Wang, allen-kh.cheng,
	linux-media, devicetree, linux-kernel, linux-arm-kernel,
	srv_heupstream, linux-mediatek,
	Project_Global_Chrome_Upstream_Group

Adds encoder power domain property.

Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index deb5b657a2d5..2d1e0c9bd6ee 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  3:31 ` Irui Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  3:31 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, Irui Wang, allen-kh.cheng,
	linux-media, devicetree, linux-kernel, linux-arm-kernel,
	srv_heupstream, linux-mediatek,
	Project_Global_Chrome_Upstream_Group

Adds encoder power domain property.

Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index deb5b657a2d5..2d1e0c9bd6ee 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };
-- 
2.18.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  3:31 ` Irui Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  3:31 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, Irui Wang, allen-kh.cheng,
	linux-media, devicetree, linux-kernel, linux-arm-kernel,
	srv_heupstream, linux-mediatek,
	Project_Global_Chrome_Upstream_Group

Adds encoder power domain property.

Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index deb5b657a2d5..2d1e0c9bd6ee 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
  2022-04-27  3:31 ` Irui Wang
  (?)
@ 2022-04-27  7:43   ` Hans Verkuil
  -1 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2022-04-27  7:43 UTC (permalink / raw)
  To: Irui Wang, Rob Herring, Mauro Carvalho Chehab, Matthias Brugger,
	Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/

If you still want the other changes you made in this patch merged, then please make
a v3 on top of Nícolas' patch.

Regards,

	Hans

On 27/04/2022 05:31, Irui Wang wrote:
> Adds encoder power domain property.
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> changes compared with v1:
> - set "power-domains" as a non-required property
> 
> The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index deb5b657a2d5..2d1e0c9bd6ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -132,6 +135,7 @@ examples:
>      #include <dt-bindings/clock/mt8173-clk.h>
>      #include <dt-bindings/memory/mt8173-larb-port.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/mt8173-power.h>
>  
>      vcodec_enc_avc: vcodec@18002000 {
>        compatible = "mediatek,mt8173-vcodec-enc";
> @@ -153,6 +157,7 @@ examples:
>        clock-names = "venc_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
>      };
>  
>      vcodec_enc_vp8: vcodec@19002000 {
> @@ -173,4 +178,5 @@ examples:
>        clock-names = "venc_lt_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
>      };


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  7:43   ` Hans Verkuil
  0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2022-04-27  7:43 UTC (permalink / raw)
  To: Irui Wang, Rob Herring, Mauro Carvalho Chehab, Matthias Brugger,
	Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/

If you still want the other changes you made in this patch merged, then please make
a v3 on top of Nícolas' patch.

Regards,

	Hans

On 27/04/2022 05:31, Irui Wang wrote:
> Adds encoder power domain property.
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> changes compared with v1:
> - set "power-domains" as a non-required property
> 
> The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index deb5b657a2d5..2d1e0c9bd6ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -132,6 +135,7 @@ examples:
>      #include <dt-bindings/clock/mt8173-clk.h>
>      #include <dt-bindings/memory/mt8173-larb-port.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/mt8173-power.h>
>  
>      vcodec_enc_avc: vcodec@18002000 {
>        compatible = "mediatek,mt8173-vcodec-enc";
> @@ -153,6 +157,7 @@ examples:
>        clock-names = "venc_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
>      };
>  
>      vcodec_enc_vp8: vcodec@19002000 {
> @@ -173,4 +178,5 @@ examples:
>        clock-names = "venc_lt_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
>      };


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  7:43   ` Hans Verkuil
  0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2022-04-27  7:43 UTC (permalink / raw)
  To: Irui Wang, Rob Herring, Mauro Carvalho Chehab, Matthias Brugger,
	Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/

If you still want the other changes you made in this patch merged, then please make
a v3 on top of Nícolas' patch.

Regards,

	Hans

On 27/04/2022 05:31, Irui Wang wrote:
> Adds encoder power domain property.
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> changes compared with v1:
> - set "power-domains" as a non-required property
> 
> The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index deb5b657a2d5..2d1e0c9bd6ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -132,6 +135,7 @@ examples:
>      #include <dt-bindings/clock/mt8173-clk.h>
>      #include <dt-bindings/memory/mt8173-larb-port.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/mt8173-power.h>
>  
>      vcodec_enc_avc: vcodec@18002000 {
>        compatible = "mediatek,mt8173-vcodec-enc";
> @@ -153,6 +157,7 @@ examples:
>        clock-names = "venc_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
>      };
>  
>      vcodec_enc_vp8: vcodec@19002000 {
> @@ -173,4 +178,5 @@ examples:
>        clock-names = "venc_lt_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
>      };


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
  2022-04-27  7:43   ` Hans Verkuil
  (?)
@ 2022-04-27  8:00     ` Irui Wang
  -1 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  8:00 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Dear Hans,

On Wed, 2022-04-27 at 09:43 +0200, Hans Verkuil wrote:
> Hi Irui,
> 
> I'm merging this patch from Nícolas F. R. A. Prado, which has already
> been Acked by Rob:
> 
> 
https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/
> 
> If you still want the other changes you made in this patch merged,
> then please make
> a v3 on top of Nícolas' patch.

Thanks for your information and Nícolas' patch, we will check it and
would send a v3 patch if needed.

Thanks
Best Regards.
> 
> Regards,
> 
> 	Hans
> 
> On 27/04/2022 05:31, Irui Wang wrote:
> > Adds encoder power domain property.
> > 
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> > changes compared with v1:
> > - set "power-domains" as a non-required property
> > 
> > The 'make dtbs_check' warnings('mediatek,larb') can be fixed by
> > patch:
> > 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> > ---
> >  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6
> > ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index deb5b657a2d5..2d1e0c9bd6ee 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -41,6 +41,9 @@ properties:
> >  
> >    assigned-clock-parents: true
> >  
> > +  power-domains:
> > +    maxItems: 1
> > +
> >    iommus:
> >      minItems: 1
> >      maxItems: 32
> > @@ -132,6 +135,7 @@ examples:
> >      #include <dt-bindings/clock/mt8173-clk.h>
> >      #include <dt-bindings/memory/mt8173-larb-port.h>
> >      #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/power/mt8173-power.h>
> >  
> >      vcodec_enc_avc: vcodec@18002000 {
> >        compatible = "mediatek,mt8173-vcodec-enc";
> > @@ -153,6 +157,7 @@ examples:
> >        clock-names = "venc_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
> >        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
> >      };
> >  
> >      vcodec_enc_vp8: vcodec@19002000 {
> > @@ -173,4 +178,5 @@ examples:
> >        clock-names = "venc_lt_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
> >        assigned-clock-parents = <&topckgen
> > CLK_TOP_VCODECPLL_370P5>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
> >      };
> 
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  8:00     ` Irui Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  8:00 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Dear Hans,

On Wed, 2022-04-27 at 09:43 +0200, Hans Verkuil wrote:
> Hi Irui,
> 
> I'm merging this patch from Nícolas F. R. A. Prado, which has already
> been Acked by Rob:
> 
> 
https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/
> 
> If you still want the other changes you made in this patch merged,
> then please make
> a v3 on top of Nícolas' patch.

Thanks for your information and Nícolas' patch, we will check it and
would send a v3 patch if needed.

Thanks
Best Regards.
> 
> Regards,
> 
> 	Hans
> 
> On 27/04/2022 05:31, Irui Wang wrote:
> > Adds encoder power domain property.
> > 
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> > changes compared with v1:
> > - set "power-domains" as a non-required property
> > 
> > The 'make dtbs_check' warnings('mediatek,larb') can be fixed by
> > patch:
> > 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> > ---
> >  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6
> > ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index deb5b657a2d5..2d1e0c9bd6ee 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -41,6 +41,9 @@ properties:
> >  
> >    assigned-clock-parents: true
> >  
> > +  power-domains:
> > +    maxItems: 1
> > +
> >    iommus:
> >      minItems: 1
> >      maxItems: 32
> > @@ -132,6 +135,7 @@ examples:
> >      #include <dt-bindings/clock/mt8173-clk.h>
> >      #include <dt-bindings/memory/mt8173-larb-port.h>
> >      #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/power/mt8173-power.h>
> >  
> >      vcodec_enc_avc: vcodec@18002000 {
> >        compatible = "mediatek,mt8173-vcodec-enc";
> > @@ -153,6 +157,7 @@ examples:
> >        clock-names = "venc_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
> >        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
> >      };
> >  
> >      vcodec_enc_vp8: vcodec@19002000 {
> > @@ -173,4 +178,5 @@ examples:
> >        clock-names = "venc_lt_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
> >        assigned-clock-parents = <&topckgen
> > CLK_TOP_VCODECPLL_370P5>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
> >      };
> 
> 
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property
@ 2022-04-27  8:00     ` Irui Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Irui Wang @ 2022-04-27  8:00 UTC (permalink / raw)
  To: Hans Verkuil, Rob Herring, Mauro Carvalho Chehab,
	Matthias Brugger, Yunfei Dong
  Cc: Maoguang Meng, Longfei Wang, allen-kh.cheng, linux-media,
	devicetree, linux-kernel, linux-arm-kernel, srv_heupstream,
	linux-mediatek, Project_Global_Chrome_Upstream_Group

Dear Hans,

On Wed, 2022-04-27 at 09:43 +0200, Hans Verkuil wrote:
> Hi Irui,
> 
> I'm merging this patch from Nícolas F. R. A. Prado, which has already
> been Acked by Rob:
> 
> 
https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@collabora.com/
> 
> If you still want the other changes you made in this patch merged,
> then please make
> a v3 on top of Nícolas' patch.

Thanks for your information and Nícolas' patch, we will check it and
would send a v3 patch if needed.

Thanks
Best Regards.
> 
> Regards,
> 
> 	Hans
> 
> On 27/04/2022 05:31, Irui Wang wrote:
> > Adds encoder power domain property.
> > 
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> > changes compared with v1:
> > - set "power-domains" as a non-required property
> > 
> > The 'make dtbs_check' warnings('mediatek,larb') can be fixed by
> > patch:
> > 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> > ---
> >  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6
> > ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index deb5b657a2d5..2d1e0c9bd6ee 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -41,6 +41,9 @@ properties:
> >  
> >    assigned-clock-parents: true
> >  
> > +  power-domains:
> > +    maxItems: 1
> > +
> >    iommus:
> >      minItems: 1
> >      maxItems: 32
> > @@ -132,6 +135,7 @@ examples:
> >      #include <dt-bindings/clock/mt8173-clk.h>
> >      #include <dt-bindings/memory/mt8173-larb-port.h>
> >      #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/power/mt8173-power.h>
> >  
> >      vcodec_enc_avc: vcodec@18002000 {
> >        compatible = "mediatek,mt8173-vcodec-enc";
> > @@ -153,6 +157,7 @@ examples:
> >        clock-names = "venc_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
> >        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
> >      };
> >  
> >      vcodec_enc_vp8: vcodec@19002000 {
> > @@ -173,4 +178,5 @@ examples:
> >        clock-names = "venc_lt_sel";
> >        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
> >        assigned-clock-parents = <&topckgen
> > CLK_TOP_VCODECPLL_370P5>;
> > +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
> >      };
> 
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-04-27  8:01 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27  3:31 [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property Irui Wang
2022-04-27  3:31 ` Irui Wang
2022-04-27  3:31 ` Irui Wang
2022-04-27  7:43 ` Hans Verkuil
2022-04-27  7:43   ` Hans Verkuil
2022-04-27  7:43   ` Hans Verkuil
2022-04-27  8:00   ` Irui Wang
2022-04-27  8:00     ` Irui Wang
2022-04-27  8:00     ` Irui Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.