All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm: stm32: Disable ATAGs support
@ 2021-09-02 10:02 Patrick Delaunay
  2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Patrick Delaunay @ 2021-09-02 10:02 UTC (permalink / raw)
  To: u-boot
  Cc: Patrick Delaunay, Marek Vasut, Tom Rini, Alexandru Gagniuc,
	Jean-Philippe ROMAIN, Patrice Chotard, Simon Glass, U-Boot STM32,
	dillon min

These platforms never had to support an ATAGs-based Linux Kernel, so
remove the options.

Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
Hi,

this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].

I also update the new file include/configs/stm32h750-art-pi.h

[1] [13/13] arm: stm32: Disable ATAGs support
https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/

[2] arm: nanopi2: Remove unused code
    https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*

Patrick


 include/configs/stm32f429-discovery.h  | 5 -----
 include/configs/stm32f429-evaluation.h | 5 -----
 include/configs/stm32f469-discovery.h  | 5 -----
 include/configs/stm32f746-disco.h      | 5 -----
 include/configs/stm32h743-disco.h      | 5 -----
 include/configs/stm32h743-eval.h       | 5 -----
 include/configs/stm32h750-art-pi.h     | 5 -----
 include/configs/stm32mp1.h             | 5 -----
 8 files changed, 40 deletions(-)

diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
index 9d029fbcc6..dbbce49475 100644
--- a/include/configs/stm32f429-discovery.h
+++ b/include/configs/stm32f429-discovery.h
@@ -27,11 +27,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_CBSIZE		1024
 
 #define CONFIG_SYS_MALLOC_LEN		(2 << 20)
diff --git a/include/configs/stm32f429-evaluation.h b/include/configs/stm32f429-evaluation.h
index fefdb2dd15..29a41e8067 100644
--- a/include/configs/stm32f429-evaluation.h
+++ b/include/configs/stm32f429-evaluation.h
@@ -29,11 +29,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_CBSIZE		1024
 
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
diff --git a/include/configs/stm32f469-discovery.h b/include/configs/stm32f469-discovery.h
index ba9f05a61b..b9b932c651 100644
--- a/include/configs/stm32f469-discovery.h
+++ b/include/configs/stm32f469-discovery.h
@@ -29,11 +29,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_CBSIZE		1024
 
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h
index 08d050adfa..b72b989c2c 100644
--- a/include/configs/stm32f746-disco.h
+++ b/include/configs/stm32f746-disco.h
@@ -36,11 +36,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_CBSIZE		1024
 
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
diff --git a/include/configs/stm32h743-disco.h b/include/configs/stm32h743-disco.h
index 6e10dbdfe9..e5bb08eec7 100644
--- a/include/configs/stm32h743-disco.h
+++ b/include/configs/stm32h743-disco.h
@@ -24,11 +24,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_MAXARGS		16
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
 
diff --git a/include/configs/stm32h743-eval.h b/include/configs/stm32h743-eval.h
index 268d39c7ad..89169f85d5 100644
--- a/include/configs/stm32h743-eval.h
+++ b/include/configs/stm32h743-eval.h
@@ -24,11 +24,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_MAXARGS		16
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
 
diff --git a/include/configs/stm32h750-art-pi.h b/include/configs/stm32h750-art-pi.h
index 3fd5461167..a9006e224a 100644
--- a/include/configs/stm32h750-art-pi.h
+++ b/include/configs/stm32h750-art-pi.h
@@ -24,11 +24,6 @@
 
 #define CONFIG_SYS_HZ_CLOCK		1000000
 
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-#define CONFIG_REVISION_TAG
-
 #define CONFIG_SYS_MAXARGS		16
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
 
diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
index b372838be8..fb4e4fb0bc 100644
--- a/include/configs/stm32mp1.h
+++ b/include/configs/stm32mp1.h
@@ -33,11 +33,6 @@
 #define CONFIG_LOADADDR			0xc2000000
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
-/* ATAGs */
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_INITRD_TAG
-
 /*
  * For booting Linux, use the first 256 MB of memory, since this is
  * the maximum mapped by the Linux kernel during initialization.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization
  2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
@ 2021-09-02 10:02 ` Patrick Delaunay
  2021-09-02 12:53   ` Patrice CHOTARD
  2021-09-03 14:51   ` Alex G.
  2021-09-02 12:52 ` [PATCH 1/2] arm: stm32: Disable ATAGs support Patrice CHOTARD
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 9+ messages in thread
From: Patrick Delaunay @ 2021-09-02 10:02 UTC (permalink / raw)
  To: u-boot
  Cc: Patrick Delaunay, Giulio Benetti, Jaehoon Chung, Jagan Teki,
	Manuel Reis, Marek Vasut, Patrice Chotard, Simon Glass,
	U-Boot STM32, dillon min

The stm32 platforms never had to support an ATAGs-based Linux Kernel,
so remove the bi_boot_params initialization.

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 board/dhelectronics/dh_stm32mp1/board.c              | 3 ---
 board/engicam/stm32mp1/stm32mp1.c                    | 3 ---
 board/st/stm32f429-discovery/stm32f429-discovery.c   | 2 --
 board/st/stm32f429-evaluation/stm32f429-evaluation.c | 2 --
 board/st/stm32f469-discovery/stm32f469-discovery.c   | 2 --
 board/st/stm32f746-disco/stm32f746-disco.c           | 2 --
 board/st/stm32h743-disco/stm32h743-disco.c           | 1 -
 board/st/stm32h743-eval/stm32h743-eval.c             | 1 -
 board/st/stm32h750-art-pi/stm32h750-art-pi.c         | 1 -
 board/st/stm32mp1/stm32mp1.c                         | 3 ---
 10 files changed, 20 deletions(-)

diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
index d7c1857c16..765b54a4a4 100644
--- a/board/dhelectronics/dh_stm32mp1/board.c
+++ b/board/dhelectronics/dh_stm32mp1/board.c
@@ -590,9 +590,6 @@ static void board_init_fmc2(void)
 /* board dependent setup after realloc */
 int board_init(void)
 {
-	/* address of boot parameters */
-	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
-
 	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
 		gpio_hog_probe_all();
 
diff --git a/board/engicam/stm32mp1/stm32mp1.c b/board/engicam/stm32mp1/stm32mp1.c
index 8bf9c9c67d..20d8603c78 100644
--- a/board/engicam/stm32mp1/stm32mp1.c
+++ b/board/engicam/stm32mp1/stm32mp1.c
@@ -40,9 +40,6 @@ int checkboard(void)
 /* board dependent setup after realloc */
 int board_init(void)
 {
-	/* address of boot parameters */
-	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
-
 	if (IS_ENABLED(CONFIG_DM_REGULATOR))
 		regulators_enable_boot_on(_DEBUG);
 
diff --git a/board/st/stm32f429-discovery/stm32f429-discovery.c b/board/st/stm32f429-discovery/stm32f429-discovery.c
index 46fcf907fc..5a50e98dd0 100644
--- a/board/st/stm32f429-discovery/stm32f429-discovery.c
+++ b/board/st/stm32f429-discovery/stm32f429-discovery.c
@@ -53,8 +53,6 @@ u32 get_board_rev(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
-
 	return 0;
 }
 
diff --git a/board/st/stm32f429-evaluation/stm32f429-evaluation.c b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
index 3b6df1f3ab..cf3056163c 100644
--- a/board/st/stm32f429-evaluation/stm32f429-evaluation.c
+++ b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
@@ -47,8 +47,6 @@ u32 get_board_rev(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
-
 	return 0;
 }
 
diff --git a/board/st/stm32f469-discovery/stm32f469-discovery.c b/board/st/stm32f469-discovery/stm32f469-discovery.c
index c5df9b0d9c..056c9dff2a 100644
--- a/board/st/stm32f469-discovery/stm32f469-discovery.c
+++ b/board/st/stm32f469-discovery/stm32f469-discovery.c
@@ -47,8 +47,6 @@ u32 get_board_rev(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
-
 	return 0;
 }
 
diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c
index efa38a0e26..2543e2a5f8 100644
--- a/board/st/stm32f746-disco/stm32f746-disco.c
+++ b/board/st/stm32f746-disco/stm32f746-disco.c
@@ -122,8 +122,6 @@ int board_late_init(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
-
 #ifdef CONFIG_ETH_DESIGNWARE
 	const char *phy_mode;
 	int node;
diff --git a/board/st/stm32h743-disco/stm32h743-disco.c b/board/st/stm32h743-disco/stm32h743-disco.c
index 4091d5f9fd..e493786f11 100644
--- a/board/st/stm32h743-disco/stm32h743-disco.c
+++ b/board/st/stm32h743-disco/stm32h743-disco.c
@@ -43,6 +43,5 @@ u32 get_board_rev(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
 	return 0;
 }
diff --git a/board/st/stm32h743-eval/stm32h743-eval.c b/board/st/stm32h743-eval/stm32h743-eval.c
index 4091d5f9fd..e493786f11 100644
--- a/board/st/stm32h743-eval/stm32h743-eval.c
+++ b/board/st/stm32h743-eval/stm32h743-eval.c
@@ -43,6 +43,5 @@ u32 get_board_rev(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
 	return 0;
 }
diff --git a/board/st/stm32h750-art-pi/stm32h750-art-pi.c b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
index 5785b2e575..bec26465d2 100644
--- a/board/st/stm32h750-art-pi/stm32h750-art-pi.c
+++ b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
@@ -53,6 +53,5 @@ int board_late_init(void)
 
 int board_init(void)
 {
-	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
 	return 0;
 }
diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index 032f08d795..1bceb41494 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -646,9 +646,6 @@ static void board_ev1_init(void)
 /* board dependent setup after realloc */
 int board_init(void)
 {
-	/* address of boot parameters */
-	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
-
 	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
 		gpio_hog_probe_all();
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm: stm32: Disable ATAGs support
  2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
  2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
@ 2021-09-02 12:52 ` Patrice CHOTARD
  2021-09-02 13:12 ` Tom Rini
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Patrice CHOTARD @ 2021-09-02 12:52 UTC (permalink / raw)
  To: Patrick Delaunay, u-boot
  Cc: Marek Vasut, Tom Rini, Alexandru Gagniuc, Jean-Philippe ROMAIN,
	Simon Glass, U-Boot STM32, dillon min

Hi Patrick

On 9/2/21 12:02 PM, Patrick Delaunay wrote:
> These platforms never had to support an ATAGs-based Linux Kernel, so
> remove the options.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> Hi,
> 
> this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].
> 
> I also update the new file include/configs/stm32h750-art-pi.h
> 
> [1] [13/13] arm: stm32: Disable ATAGs support
> https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/
> 
> [2] arm: nanopi2: Remove unused code
>     https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*
> 
> Patrick
> 
> 
>  include/configs/stm32f429-discovery.h  | 5 -----
>  include/configs/stm32f429-evaluation.h | 5 -----
>  include/configs/stm32f469-discovery.h  | 5 -----
>  include/configs/stm32f746-disco.h      | 5 -----
>  include/configs/stm32h743-disco.h      | 5 -----
>  include/configs/stm32h743-eval.h       | 5 -----
>  include/configs/stm32h750-art-pi.h     | 5 -----
>  include/configs/stm32mp1.h             | 5 -----
>  8 files changed, 40 deletions(-)
> 
> diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
> index 9d029fbcc6..dbbce49475 100644
> --- a/include/configs/stm32f429-discovery.h
> +++ b/include/configs/stm32f429-discovery.h
> @@ -27,11 +27,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(2 << 20)
> diff --git a/include/configs/stm32f429-evaluation.h b/include/configs/stm32f429-evaluation.h
> index fefdb2dd15..29a41e8067 100644
> --- a/include/configs/stm32f429-evaluation.h
> +++ b/include/configs/stm32f429-evaluation.h
> @@ -29,11 +29,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f469-discovery.h b/include/configs/stm32f469-discovery.h
> index ba9f05a61b..b9b932c651 100644
> --- a/include/configs/stm32f469-discovery.h
> +++ b/include/configs/stm32f469-discovery.h
> @@ -29,11 +29,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h
> index 08d050adfa..b72b989c2c 100644
> --- a/include/configs/stm32f746-disco.h
> +++ b/include/configs/stm32f746-disco.h
> @@ -36,11 +36,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32h743-disco.h b/include/configs/stm32h743-disco.h
> index 6e10dbdfe9..e5bb08eec7 100644
> --- a/include/configs/stm32h743-disco.h
> +++ b/include/configs/stm32h743-disco.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32h743-eval.h b/include/configs/stm32h743-eval.h
> index 268d39c7ad..89169f85d5 100644
> --- a/include/configs/stm32h743-eval.h
> +++ b/include/configs/stm32h743-eval.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32h750-art-pi.h b/include/configs/stm32h750-art-pi.h
> index 3fd5461167..a9006e224a 100644
> --- a/include/configs/stm32h750-art-pi.h
> +++ b/include/configs/stm32h750-art-pi.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
> index b372838be8..fb4e4fb0bc 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -33,11 +33,6 @@
>  #define CONFIG_LOADADDR			0xc2000000
>  #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
>  
> -/* ATAGs */
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -
>  /*
>   * For booting Linux, use the first 256 MB of memory, since this is
>   * the maximum mapped by the Linux kernel during initialization.
> 
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com> 

Thanks
Patrice+


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization
  2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
@ 2021-09-02 12:53   ` Patrice CHOTARD
  2021-09-03 14:51   ` Alex G.
  1 sibling, 0 replies; 9+ messages in thread
From: Patrice CHOTARD @ 2021-09-02 12:53 UTC (permalink / raw)
  To: Patrick Delaunay, u-boot
  Cc: Giulio Benetti, Jaehoon Chung, Jagan Teki, Manuel Reis,
	Marek Vasut, Simon Glass, U-Boot STM32, dillon min

Hi Patrick

On 9/2/21 12:02 PM, Patrick Delaunay wrote:
> The stm32 platforms never had to support an ATAGs-based Linux Kernel,
> so remove the bi_boot_params initialization.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  board/dhelectronics/dh_stm32mp1/board.c              | 3 ---
>  board/engicam/stm32mp1/stm32mp1.c                    | 3 ---
>  board/st/stm32f429-discovery/stm32f429-discovery.c   | 2 --
>  board/st/stm32f429-evaluation/stm32f429-evaluation.c | 2 --
>  board/st/stm32f469-discovery/stm32f469-discovery.c   | 2 --
>  board/st/stm32f746-disco/stm32f746-disco.c           | 2 --
>  board/st/stm32h743-disco/stm32h743-disco.c           | 1 -
>  board/st/stm32h743-eval/stm32h743-eval.c             | 1 -
>  board/st/stm32h750-art-pi/stm32h750-art-pi.c         | 1 -
>  board/st/stm32mp1/stm32mp1.c                         | 3 ---
>  10 files changed, 20 deletions(-)
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
> index d7c1857c16..765b54a4a4 100644
> --- a/board/dhelectronics/dh_stm32mp1/board.c
> +++ b/board/dhelectronics/dh_stm32mp1/board.c
> @@ -590,9 +590,6 @@ static void board_init_fmc2(void)
>  /* board dependent setup after realloc */
>  int board_init(void)
>  {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>  	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>  		gpio_hog_probe_all();
>  
> diff --git a/board/engicam/stm32mp1/stm32mp1.c b/board/engicam/stm32mp1/stm32mp1.c
> index 8bf9c9c67d..20d8603c78 100644
> --- a/board/engicam/stm32mp1/stm32mp1.c
> +++ b/board/engicam/stm32mp1/stm32mp1.c
> @@ -40,9 +40,6 @@ int checkboard(void)
>  /* board dependent setup after realloc */
>  int board_init(void)
>  {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>  	if (IS_ENABLED(CONFIG_DM_REGULATOR))
>  		regulators_enable_boot_on(_DEBUG);
>  
> diff --git a/board/st/stm32f429-discovery/stm32f429-discovery.c b/board/st/stm32f429-discovery/stm32f429-discovery.c
> index 46fcf907fc..5a50e98dd0 100644
> --- a/board/st/stm32f429-discovery/stm32f429-discovery.c
> +++ b/board/st/stm32f429-discovery/stm32f429-discovery.c
> @@ -53,8 +53,6 @@ u32 get_board_rev(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>  	return 0;
>  }
>  
> diff --git a/board/st/stm32f429-evaluation/stm32f429-evaluation.c b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> index 3b6df1f3ab..cf3056163c 100644
> --- a/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> +++ b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> @@ -47,8 +47,6 @@ u32 get_board_rev(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>  	return 0;
>  }
>  
> diff --git a/board/st/stm32f469-discovery/stm32f469-discovery.c b/board/st/stm32f469-discovery/stm32f469-discovery.c
> index c5df9b0d9c..056c9dff2a 100644
> --- a/board/st/stm32f469-discovery/stm32f469-discovery.c
> +++ b/board/st/stm32f469-discovery/stm32f469-discovery.c
> @@ -47,8 +47,6 @@ u32 get_board_rev(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>  	return 0;
>  }
>  
> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c
> index efa38a0e26..2543e2a5f8 100644
> --- a/board/st/stm32f746-disco/stm32f746-disco.c
> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> @@ -122,8 +122,6 @@ int board_late_init(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>  #ifdef CONFIG_ETH_DESIGNWARE
>  	const char *phy_mode;
>  	int node;
> diff --git a/board/st/stm32h743-disco/stm32h743-disco.c b/board/st/stm32h743-disco/stm32h743-disco.c
> index 4091d5f9fd..e493786f11 100644
> --- a/board/st/stm32h743-disco/stm32h743-disco.c
> +++ b/board/st/stm32h743-disco/stm32h743-disco.c
> @@ -43,6 +43,5 @@ u32 get_board_rev(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>  	return 0;
>  }
> diff --git a/board/st/stm32h743-eval/stm32h743-eval.c b/board/st/stm32h743-eval/stm32h743-eval.c
> index 4091d5f9fd..e493786f11 100644
> --- a/board/st/stm32h743-eval/stm32h743-eval.c
> +++ b/board/st/stm32h743-eval/stm32h743-eval.c
> @@ -43,6 +43,5 @@ u32 get_board_rev(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>  	return 0;
>  }
> diff --git a/board/st/stm32h750-art-pi/stm32h750-art-pi.c b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> index 5785b2e575..bec26465d2 100644
> --- a/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> +++ b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> @@ -53,6 +53,5 @@ int board_late_init(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>  	return 0;
>  }
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 032f08d795..1bceb41494 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -646,9 +646,6 @@ static void board_ev1_init(void)
>  /* board dependent setup after realloc */
>  int board_init(void)
>  {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>  	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>  		gpio_hog_probe_all();
>  
> 

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm: stm32: Disable ATAGs support
  2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
  2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
  2021-09-02 12:52 ` [PATCH 1/2] arm: stm32: Disable ATAGs support Patrice CHOTARD
@ 2021-09-02 13:12 ` Tom Rini
  2021-09-03  8:28   ` Patrick DELAUNAY
  2021-09-03 14:50 ` Alex G.
  2021-10-08  6:18 ` Patrice CHOTARD
  4 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2021-09-02 13:12 UTC (permalink / raw)
  To: Patrick Delaunay
  Cc: u-boot, Marek Vasut, Alexandru Gagniuc, Jean-Philippe ROMAIN,
	Patrice Chotard, Simon Glass, U-Boot STM32, dillon min

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

On Thu, Sep 02, 2021 at 12:02:06PM +0200, Patrick Delaunay wrote:

> These platforms never had to support an ATAGs-based Linux Kernel, so
> remove the options.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> Hi,
> 
> this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].
> 
> I also update the new file include/configs/stm32h750-art-pi.h
> 
> [1] [13/13] arm: stm32: Disable ATAGs support
> https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/
> 
> [2] arm: nanopi2: Remove unused code
>     https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*

Note that I've posted
https://patchwork.ozlabs.org/project/uboot/list/?series=260161&state=*
recently and that includes this change.  2/2 of this series is good to
see.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm: stm32: Disable ATAGs support
  2021-09-02 13:12 ` Tom Rini
@ 2021-09-03  8:28   ` Patrick DELAUNAY
  0 siblings, 0 replies; 9+ messages in thread
From: Patrick DELAUNAY @ 2021-09-03  8:28 UTC (permalink / raw)
  To: Tom Rini
  Cc: u-boot, Marek Vasut, Alexandru Gagniuc, Jean-Philippe ROMAIN,
	Patrice Chotard, Simon Glass, U-Boot STM32, dillon min

Hi Tom,

On 9/2/21 3:12 PM, Tom Rini wrote:
> On Thu, Sep 02, 2021 at 12:02:06PM +0200, Patrick Delaunay wrote:
>
>> These platforms never had to support an ATAGs-based Linux Kernel, so
>> remove the options.
>>
>> Cc: Marek Vasut <marex@denx.de>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>> Hi,
>>
>> this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].
>>
>> I also update the new file include/configs/stm32h750-art-pi.h
>>
>> [1] [13/13] arm: stm32: Disable ATAGs support
>> https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/
>>
>> [2] arm: nanopi2: Remove unused code
>>      https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*
> Note that I've posted
> https://patchwork.ozlabs.org/project/uboot/list/?series=260161&state=*
> recently and that includes this change.  2/2 of this series is good to
> see.
>

It is noted.

and I also  propose a cleanup the code with CONFIG_SUPPORT_PASSING_ATAGS 
introduction:

"arm: use CONFIG_SUPPORT_PASSING_ATAGS"

http://patchwork.ozlabs.org/project/uboot/list/?series=260843&state=*


regards

Patrick


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm: stm32: Disable ATAGs support
  2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
                   ` (2 preceding siblings ...)
  2021-09-02 13:12 ` Tom Rini
@ 2021-09-03 14:50 ` Alex G.
  2021-10-08  6:18 ` Patrice CHOTARD
  4 siblings, 0 replies; 9+ messages in thread
From: Alex G. @ 2021-09-03 14:50 UTC (permalink / raw)
  To: Patrick Delaunay, u-boot
  Cc: Marek Vasut, Tom Rini, Jean-Philippe ROMAIN, Patrice Chotard,
	Simon Glass, U-Boot STM32, dillon min



On 9/2/21 5:02 AM, Patrick Delaunay wrote:
> These platforms never had to support an ATAGs-based Linux Kernel, so
> remove the options.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

Slowly, but surely, configs/*.h will grow to zero.

> ---
> Hi,
> 
> this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].
> 
> I also update the new file include/configs/stm32h750-art-pi.h
> 
> [1] [13/13] arm: stm32: Disable ATAGs support
> https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/
> 
> [2] arm: nanopi2: Remove unused code
>      https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*
> 
> Patrick
> 
> 
>   include/configs/stm32f429-discovery.h  | 5 -----
>   include/configs/stm32f429-evaluation.h | 5 -----
>   include/configs/stm32f469-discovery.h  | 5 -----
>   include/configs/stm32f746-disco.h      | 5 -----
>   include/configs/stm32h743-disco.h      | 5 -----
>   include/configs/stm32h743-eval.h       | 5 -----
>   include/configs/stm32h750-art-pi.h     | 5 -----
>   include/configs/stm32mp1.h             | 5 -----
>   8 files changed, 40 deletions(-)
> 
> diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
> index 9d029fbcc6..dbbce49475 100644
> --- a/include/configs/stm32f429-discovery.h
> +++ b/include/configs/stm32f429-discovery.h
> @@ -27,11 +27,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_CBSIZE		1024
>   
>   #define CONFIG_SYS_MALLOC_LEN		(2 << 20)
> diff --git a/include/configs/stm32f429-evaluation.h b/include/configs/stm32f429-evaluation.h
> index fefdb2dd15..29a41e8067 100644
> --- a/include/configs/stm32f429-evaluation.h
> +++ b/include/configs/stm32f429-evaluation.h
> @@ -29,11 +29,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_CBSIZE		1024
>   
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f469-discovery.h b/include/configs/stm32f469-discovery.h
> index ba9f05a61b..b9b932c651 100644
> --- a/include/configs/stm32f469-discovery.h
> +++ b/include/configs/stm32f469-discovery.h
> @@ -29,11 +29,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_CBSIZE		1024
>   
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h
> index 08d050adfa..b72b989c2c 100644
> --- a/include/configs/stm32f746-disco.h
> +++ b/include/configs/stm32f746-disco.h
> @@ -36,11 +36,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_CBSIZE		1024
>   
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32h743-disco.h b/include/configs/stm32h743-disco.h
> index 6e10dbdfe9..e5bb08eec7 100644
> --- a/include/configs/stm32h743-disco.h
> +++ b/include/configs/stm32h743-disco.h
> @@ -24,11 +24,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_MAXARGS		16
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>   
> diff --git a/include/configs/stm32h743-eval.h b/include/configs/stm32h743-eval.h
> index 268d39c7ad..89169f85d5 100644
> --- a/include/configs/stm32h743-eval.h
> +++ b/include/configs/stm32h743-eval.h
> @@ -24,11 +24,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_MAXARGS		16
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>   
> diff --git a/include/configs/stm32h750-art-pi.h b/include/configs/stm32h750-art-pi.h
> index 3fd5461167..a9006e224a 100644
> --- a/include/configs/stm32h750-art-pi.h
> +++ b/include/configs/stm32h750-art-pi.h
> @@ -24,11 +24,6 @@
>   
>   #define CONFIG_SYS_HZ_CLOCK		1000000
>   
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>   #define CONFIG_SYS_MAXARGS		16
>   #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>   
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
> index b372838be8..fb4e4fb0bc 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -33,11 +33,6 @@
>   #define CONFIG_LOADADDR			0xc2000000
>   #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
>   
> -/* ATAGs */
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -
>   /*
>    * For booting Linux, use the first 256 MB of memory, since this is
>    * the maximum mapped by the Linux kernel during initialization.
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization
  2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
  2021-09-02 12:53   ` Patrice CHOTARD
@ 2021-09-03 14:51   ` Alex G.
  1 sibling, 0 replies; 9+ messages in thread
From: Alex G. @ 2021-09-03 14:51 UTC (permalink / raw)
  To: Patrick Delaunay, u-boot
  Cc: Giulio Benetti, Jaehoon Chung, Jagan Teki, Manuel Reis,
	Marek Vasut, Patrice Chotard, Simon Glass, U-Boot STM32,
	dillon min



On 9/2/21 5:02 AM, Patrick Delaunay wrote:
> The stm32 platforms never had to support an ATAGs-based Linux Kernel,
> so remove the bi_boot_params initialization.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Tested-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

> ---
> 
>   board/dhelectronics/dh_stm32mp1/board.c              | 3 ---
>   board/engicam/stm32mp1/stm32mp1.c                    | 3 ---
>   board/st/stm32f429-discovery/stm32f429-discovery.c   | 2 --
>   board/st/stm32f429-evaluation/stm32f429-evaluation.c | 2 --
>   board/st/stm32f469-discovery/stm32f469-discovery.c   | 2 --
>   board/st/stm32f746-disco/stm32f746-disco.c           | 2 --
>   board/st/stm32h743-disco/stm32h743-disco.c           | 1 -
>   board/st/stm32h743-eval/stm32h743-eval.c             | 1 -
>   board/st/stm32h750-art-pi/stm32h750-art-pi.c         | 1 -
>   board/st/stm32mp1/stm32mp1.c                         | 3 ---
>   10 files changed, 20 deletions(-)
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
> index d7c1857c16..765b54a4a4 100644
> --- a/board/dhelectronics/dh_stm32mp1/board.c
> +++ b/board/dhelectronics/dh_stm32mp1/board.c
> @@ -590,9 +590,6 @@ static void board_init_fmc2(void)
>   /* board dependent setup after realloc */
>   int board_init(void)
>   {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>   	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>   		gpio_hog_probe_all();
>   
> diff --git a/board/engicam/stm32mp1/stm32mp1.c b/board/engicam/stm32mp1/stm32mp1.c
> index 8bf9c9c67d..20d8603c78 100644
> --- a/board/engicam/stm32mp1/stm32mp1.c
> +++ b/board/engicam/stm32mp1/stm32mp1.c
> @@ -40,9 +40,6 @@ int checkboard(void)
>   /* board dependent setup after realloc */
>   int board_init(void)
>   {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>   	if (IS_ENABLED(CONFIG_DM_REGULATOR))
>   		regulators_enable_boot_on(_DEBUG);
>   
> diff --git a/board/st/stm32f429-discovery/stm32f429-discovery.c b/board/st/stm32f429-discovery/stm32f429-discovery.c
> index 46fcf907fc..5a50e98dd0 100644
> --- a/board/st/stm32f429-discovery/stm32f429-discovery.c
> +++ b/board/st/stm32f429-discovery/stm32f429-discovery.c
> @@ -53,8 +53,6 @@ u32 get_board_rev(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>   	return 0;
>   }
>   
> diff --git a/board/st/stm32f429-evaluation/stm32f429-evaluation.c b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> index 3b6df1f3ab..cf3056163c 100644
> --- a/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> +++ b/board/st/stm32f429-evaluation/stm32f429-evaluation.c
> @@ -47,8 +47,6 @@ u32 get_board_rev(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>   	return 0;
>   }
>   
> diff --git a/board/st/stm32f469-discovery/stm32f469-discovery.c b/board/st/stm32f469-discovery/stm32f469-discovery.c
> index c5df9b0d9c..056c9dff2a 100644
> --- a/board/st/stm32f469-discovery/stm32f469-discovery.c
> +++ b/board/st/stm32f469-discovery/stm32f469-discovery.c
> @@ -47,8 +47,6 @@ u32 get_board_rev(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>   	return 0;
>   }
>   
> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c
> index efa38a0e26..2543e2a5f8 100644
> --- a/board/st/stm32f746-disco/stm32f746-disco.c
> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> @@ -122,8 +122,6 @@ int board_late_init(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
> -
>   #ifdef CONFIG_ETH_DESIGNWARE
>   	const char *phy_mode;
>   	int node;
> diff --git a/board/st/stm32h743-disco/stm32h743-disco.c b/board/st/stm32h743-disco/stm32h743-disco.c
> index 4091d5f9fd..e493786f11 100644
> --- a/board/st/stm32h743-disco/stm32h743-disco.c
> +++ b/board/st/stm32h743-disco/stm32h743-disco.c
> @@ -43,6 +43,5 @@ u32 get_board_rev(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>   	return 0;
>   }
> diff --git a/board/st/stm32h743-eval/stm32h743-eval.c b/board/st/stm32h743-eval/stm32h743-eval.c
> index 4091d5f9fd..e493786f11 100644
> --- a/board/st/stm32h743-eval/stm32h743-eval.c
> +++ b/board/st/stm32h743-eval/stm32h743-eval.c
> @@ -43,6 +43,5 @@ u32 get_board_rev(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>   	return 0;
>   }
> diff --git a/board/st/stm32h750-art-pi/stm32h750-art-pi.c b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> index 5785b2e575..bec26465d2 100644
> --- a/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> +++ b/board/st/stm32h750-art-pi/stm32h750-art-pi.c
> @@ -53,6 +53,5 @@ int board_late_init(void)
>   
>   int board_init(void)
>   {
> -	gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;
>   	return 0;
>   }
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 032f08d795..1bceb41494 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -646,9 +646,6 @@ static void board_ev1_init(void)
>   /* board dependent setup after realloc */
>   int board_init(void)
>   {
> -	/* address of boot parameters */
> -	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
> -
>   	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>   		gpio_hog_probe_all();
>   
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm: stm32: Disable ATAGs support
  2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
                   ` (3 preceding siblings ...)
  2021-09-03 14:50 ` Alex G.
@ 2021-10-08  6:18 ` Patrice CHOTARD
  4 siblings, 0 replies; 9+ messages in thread
From: Patrice CHOTARD @ 2021-10-08  6:18 UTC (permalink / raw)
  To: Patrick Delaunay, u-boot
  Cc: Marek Vasut, Tom Rini, Alexandru Gagniuc, Jean-Philippe ROMAIN,
	Simon Glass, U-Boot STM32, dillon min

Hi Patrick

On 9/2/21 12:02 PM, Patrick Delaunay wrote:
> These platforms never had to support an ATAGs-based Linux Kernel, so
> remove the options.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> Hi,
> 
> this patch is a rebased version of the STM32 part [1] of Tom's patchset [2].
> 
> I also update the new file include/configs/stm32h750-art-pi.h
> 
> [1] [13/13] arm: stm32: Disable ATAGs support
> https://patchwork.ozlabs.org/project/uboot/patch/20210204022415.20589-13-trini@konsulko.com/
> 
> [2] arm: nanopi2: Remove unused code
>     https://patchwork.ozlabs.org/project/uboot/list/?series=227910&state=*
> 
> Patrick
> 
> 
>  include/configs/stm32f429-discovery.h  | 5 -----
>  include/configs/stm32f429-evaluation.h | 5 -----
>  include/configs/stm32f469-discovery.h  | 5 -----
>  include/configs/stm32f746-disco.h      | 5 -----
>  include/configs/stm32h743-disco.h      | 5 -----
>  include/configs/stm32h743-eval.h       | 5 -----
>  include/configs/stm32h750-art-pi.h     | 5 -----
>  include/configs/stm32mp1.h             | 5 -----
>  8 files changed, 40 deletions(-)
> 
> diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
> index 9d029fbcc6..dbbce49475 100644
> --- a/include/configs/stm32f429-discovery.h
> +++ b/include/configs/stm32f429-discovery.h
> @@ -27,11 +27,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(2 << 20)
> diff --git a/include/configs/stm32f429-evaluation.h b/include/configs/stm32f429-evaluation.h
> index fefdb2dd15..29a41e8067 100644
> --- a/include/configs/stm32f429-evaluation.h
> +++ b/include/configs/stm32f429-evaluation.h
> @@ -29,11 +29,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f469-discovery.h b/include/configs/stm32f469-discovery.h
> index ba9f05a61b..b9b932c651 100644
> --- a/include/configs/stm32f469-discovery.h
> +++ b/include/configs/stm32f469-discovery.h
> @@ -29,11 +29,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h
> index 08d050adfa..b72b989c2c 100644
> --- a/include/configs/stm32f746-disco.h
> +++ b/include/configs/stm32f746-disco.h
> @@ -36,11 +36,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_CBSIZE		1024
>  
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
> diff --git a/include/configs/stm32h743-disco.h b/include/configs/stm32h743-disco.h
> index 6e10dbdfe9..e5bb08eec7 100644
> --- a/include/configs/stm32h743-disco.h
> +++ b/include/configs/stm32h743-disco.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32h743-eval.h b/include/configs/stm32h743-eval.h
> index 268d39c7ad..89169f85d5 100644
> --- a/include/configs/stm32h743-eval.h
> +++ b/include/configs/stm32h743-eval.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32h750-art-pi.h b/include/configs/stm32h750-art-pi.h
> index 3fd5461167..a9006e224a 100644
> --- a/include/configs/stm32h750-art-pi.h
> +++ b/include/configs/stm32h750-art-pi.h
> @@ -24,11 +24,6 @@
>  
>  #define CONFIG_SYS_HZ_CLOCK		1000000
>  
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -#define CONFIG_REVISION_TAG
> -
>  #define CONFIG_SYS_MAXARGS		16
>  #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
>  
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
> index b372838be8..fb4e4fb0bc 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -33,11 +33,6 @@
>  #define CONFIG_LOADADDR			0xc2000000
>  #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
>  
> -/* ATAGs */
> -#define CONFIG_CMDLINE_TAG
> -#define CONFIG_SETUP_MEMORY_TAGS
> -#define CONFIG_INITRD_TAG
> -
>  /*
>   * For booting Linux, use the first 256 MB of memory, since this is
>   * the maximum mapped by the Linux kernel during initialization.
> 

Applied on u-boot-stm32 for next

Thanks
Patrice

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-10-08  6:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 10:02 [PATCH 1/2] arm: stm32: Disable ATAGs support Patrick Delaunay
2021-09-02 10:02 ` [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization Patrick Delaunay
2021-09-02 12:53   ` Patrice CHOTARD
2021-09-03 14:51   ` Alex G.
2021-09-02 12:52 ` [PATCH 1/2] arm: stm32: Disable ATAGs support Patrice CHOTARD
2021-09-02 13:12 ` Tom Rini
2021-09-03  8:28   ` Patrick DELAUNAY
2021-09-03 14:50 ` Alex G.
2021-10-08  6:18 ` Patrice CHOTARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.