* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-22 23:04 [PATCH] clk: tegra: fix pllu rate configuration Marcel Ziswiler
@ 2018-02-22 23:47 ` Stephen Warren
2018-02-23 6:28 ` Marcel Ziswiler
2018-02-26 12:42 ` Dmitry Osipenko
` (2 subsequent siblings)
3 siblings, 1 reply; 20+ messages in thread
From: Stephen Warren @ 2018-02-22 23:47 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: linux-tegra, Dmitry Osipenko, Marcel Ziswiler, Thierry Reding,
Stephen Boyd, linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Jonathan Hunter, Michael Turquette, linux-clk
On 02/22/2018 04:04 PM, Marcel Ziswiler wrote:
> Turns out latest upstream U-Boot does not configure/enable pllu which
> leaves it at some default rate of 500 kHz:
I assume this is only because U-Boot just happened not to access any USB
devices. In other words, if you break into the U-Boot boot flow and
explicitly initialize/access USB, then USB works both in U-Boot and in
the kernel even without this patch? If that's not the case, it seems
there's a bug in U-Boot.
Either way, I have no issue with this patch. I just want to make sure
there weren't other bugs in U-Boot that needed fixing.
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-22 23:47 ` Stephen Warren
@ 2018-02-23 6:28 ` Marcel Ziswiler
0 siblings, 0 replies; 20+ messages in thread
From: Marcel Ziswiler @ 2018-02-23 6:28 UTC (permalink / raw)
To: Stephen Warren
Cc: linux-tegra, Dmitry Osipenko, Marcel Ziswiler, Thierry Reding,
Stephen Boyd, linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Jonathan Hunter, Michael Turquette, linux-clk
On February 23, 2018 12:47:56 AM GMT+01:00, Stephen Warren <swarren@wwwdotorg.org> wrote:
>On 02/22/2018 04:04 PM, Marcel Ziswiler wrote:
>> Turns out latest upstream U-Boot does not configure/enable pllu which
>> leaves it at some default rate of 500 kHz:
>
>I assume this is only because U-Boot just happened not to access any
>USB
>devices. In other words, if you break into the U-Boot boot flow and
>explicitly initialize/access USB, then USB works both in U-Boot and in
>the kernel even without this patch?
Exactly.
> If that's not the case, it seems
>there's a bug in U-Boot.
>
>Either way, I have no issue with this patch. I just want to make sure
>there weren't other bugs in U-Boot that needed fixing.
No, rest assured U-Boot is working just fine on the legacy Tegras. The only thing in need of fixing lately was NAND on Colibri T20 and Harmony.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
@ 2018-02-23 6:28 ` Marcel Ziswiler
0 siblings, 0 replies; 20+ messages in thread
From: Marcel Ziswiler @ 2018-02-23 6:28 UTC (permalink / raw)
To: Stephen Warren
Cc: linux-tegra, Dmitry Osipenko, Marcel Ziswiler, Thierry Reding,
Stephen Boyd, linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Jonathan Hunter, Michael Turquette, linux-clk
On February 23, 2018 12:47:56 AM GMT+01:00, Stephen Warren <swarren@wwwdot=
org=2Eorg> wrote:
>On 02/22/2018 04:04 PM, Marcel Ziswiler wrote:
>> Turns out latest upstream U-Boot does not configure/enable pllu which
>> leaves it at some default rate of 500 kHz:
>
>I assume this is only because U-Boot just happened not to access any
>USB=20
>devices=2E In other words, if you break into the U-Boot boot flow and=20
>explicitly initialize/access USB, then USB works both in U-Boot and in=20
>the kernel even without this patch?
Exactly=2E
> If that's not the case, it seems=20
>there's a bug in U-Boot=2E
>
>Either way, I have no issue with this patch=2E I just want to make sure=
=20
>there weren't other bugs in U-Boot that needed fixing=2E
No, rest assured U-Boot is working just fine on the legacy Tegras=2E The o=
nly thing in need of fixing lately was NAND on Colibri T20 and Harmony=2E
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-22 23:04 [PATCH] clk: tegra: fix pllu rate configuration Marcel Ziswiler
2018-02-22 23:47 ` Stephen Warren
@ 2018-02-26 12:42 ` Dmitry Osipenko
2018-02-26 23:04 ` Marcel Ziswiler
2018-03-02 8:56 ` Jon Hunter
2018-03-08 14:57 ` Thierry Reding
3 siblings, 1 reply; 20+ messages in thread
From: Dmitry Osipenko @ 2018-02-26 12:42 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra
Cc: Marcel Ziswiler, Thierry Reding, Stephen Boyd, linux-kernel,
Prashant Gaikwad, Peter De Schrijver, Jonathan Hunter,
Michael Turquette, linux-clk
On 23.02.2018 02:04, Marcel Ziswiler wrote:
> Turns out latest upstream U-Boot does not configure/enable pllu which
> leaves it at some default rate of 500 kHz:
>
> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep pll_u
> pll_u 3 3 0 500000 0
>
> Of course this won't quite work leading to the following messages:
>
> [ 6.559593] usb 2-1: new full-speed USB device number 2 using tegra-
> ehci
> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> [ 27.389217] usb 2-1: new full-speed USB device number 3 using tegra-
> ehci
> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> [ 48.049658] usb usb2-port1: attempt power cycle
> [ 48.759475] usb 2-1: new full-speed USB device number 4 using tegra-
> ehci
> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> [ 59.509449] usb 2-1: new full-speed USB device number 5 using tegra-
> ehci
> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>
> Fix this by actually allowing the rate also being set from within
> the Linux kernel.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/clk/tegra/clk-pll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 7c369e21c91c..830d1c87fa7c 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1151,6 +1151,8 @@ static const struct clk_ops tegra_clk_pllu_ops = {
> .enable = clk_pllu_enable,
> .disable = clk_pll_disable,
> .recalc_rate = clk_pll_recalc_rate,
> + .round_rate = clk_pll_round_rate,
> + .set_rate = clk_pll_set_rate,
> };
>
> static int _pll_fixed_mdiv(struct tegra_clk_pll_params *pll_params,
>
Tegra's USB PHY driver only enables clock and clk driver doesn't specify the
clock rate in the init table. Could you please clarify where in the kernels code
PLL_U rate is getting set?
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-26 12:42 ` Dmitry Osipenko
@ 2018-02-26 23:04 ` Marcel Ziswiler
0 siblings, 0 replies; 20+ messages in thread
From: Marcel Ziswiler @ 2018-02-26 23:04 UTC (permalink / raw)
To: digetx, linux-tegra
Cc: linux-kernel, jonathanh, mturquette, pgaikwad, sboyd,
thierry.reding, pdeschrijver, linux-clk
On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
> On 23.02.2018 02:04, Marcel Ziswiler wrote:
> > Turns out latest upstream U-Boot does not configure/enable pllu
> > which
> > leaves it at some default rate of 500 kHz:
> >
> > root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
> > pll_u
> > pll_u 3 3 0 500000
> > 0
> >
> > Of course this won't quite work leading to the following messages:
> >
> > [ 6.559593] usb 2-1: new full-speed USB device number 2 using
> > tegra-
> > ehci
> > [ 11.759173] usb 2-1: device descriptor read/64, error -110
> > [ 27.119453] usb 2-1: device descriptor read/64, error -110
> > [ 27.389217] usb 2-1: new full-speed USB device number 3 using
> > tegra-
> > ehci
> > [ 32.559454] usb 2-1: device descriptor read/64, error -110
> > [ 47.929777] usb 2-1: device descriptor read/64, error -110
> > [ 48.049658] usb usb2-port1: attempt power cycle
> > [ 48.759475] usb 2-1: new full-speed USB device number 4 using
> > tegra-
> > ehci
> > [ 59.349457] usb 2-1: device not accepting address 4, error -110
> > [ 59.509449] usb 2-1: new full-speed USB device number 5 using
> > tegra-
> > ehci
> > [ 70.069457] usb 2-1: device not accepting address 5, error -110
> > [ 70.079721] usb usb2-port1: unable to enumerate USB device
> >
> > Fix this by actually allowing the rate also being set from within
> > the Linux kernel.
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > drivers/clk/tegra/clk-pll.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-
> > pll.c
> > index 7c369e21c91c..830d1c87fa7c 100644
> > --- a/drivers/clk/tegra/clk-pll.c
> > +++ b/drivers/clk/tegra/clk-pll.c
> > @@ -1151,6 +1151,8 @@ static const struct clk_ops
> > tegra_clk_pllu_ops = {
> > .enable = clk_pllu_enable,
> > .disable = clk_pll_disable,
> > .recalc_rate = clk_pll_recalc_rate,
> > + .round_rate = clk_pll_round_rate,
> > + .set_rate = clk_pll_set_rate,
> > };
> >
> > static int _pll_fixed_mdiv(struct tegra_clk_pll_params
> > *pll_params,
> >
>
> Tegra's USB PHY driver only enables clock and clk driver doesn't
> specify the
> clock rate in the init table. Could you please clarify where in the
> kernels code
> PLL_U rate is getting set?
I guess that would be according to the following table isn't it:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree
/drivers/clk/tegra/clk-tegra30.c?h=v4.16-rc3#n287
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] clk: tegra: fix pllu rate configuration
@ 2018-02-26 23:04 ` Marcel Ziswiler
0 siblings, 0 replies; 20+ messages in thread
From: Marcel Ziswiler @ 2018-02-26 23:04 UTC (permalink / raw)
To: digetx, linux-tegra
Cc: linux-kernel, jonathanh, mturquette, pgaikwad, sboyd,
thierry.reding, pdeschrijver, linux-clk
T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE1OjQyICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6
DQo+IE9uIDIzLjAyLjIwMTggMDI6MDQsIE1hcmNlbCBaaXN3aWxlciB3cm90ZToNCj4gPiBUdXJu
cyBvdXQgbGF0ZXN0IHVwc3RyZWFtIFUtQm9vdCBkb2VzIG5vdCBjb25maWd1cmUvZW5hYmxlIHBs
bHUNCj4gPiB3aGljaA0KPiA+IGxlYXZlcyBpdCBhdCBzb21lIGRlZmF1bHQgcmF0ZSBvZiA1MDAg
a0h6Og0KPiA+IA0KPiA+IHJvb3RAYXBhbGlzLXQzMDp+IyBjYXQgL3N5cy9rZXJuZWwvZGVidWcv
Y2xrL2Nsa19zdW1tYXJ5IHwgZ3JlcA0KPiA+IHBsbF91DQo+ID4gICAgICAgIHBsbF91ICAgICAg
ICAgICAgICAgICAgMyAgICAgICAgMyAgICAgICAgMCAgICAgIDUwMDAwMCAgICAgIA0KPiA+ICAg
ICAwDQo+ID4gDQo+ID4gT2YgY291cnNlIHRoaXMgd29uJ3QgcXVpdGUgd29yayBsZWFkaW5nIHRv
IHRoZSBmb2xsb3dpbmcgbWVzc2FnZXM6DQo+ID4gDQo+ID4gWyAgICA2LjU1OTU5M10gdXNiIDIt
MTogbmV3IGZ1bGwtc3BlZWQgVVNCIGRldmljZSBudW1iZXIgMiB1c2luZw0KPiA+IHRlZ3JhLQ0K
PiA+IGVoY2kNCj4gPiBbICAgMTEuNzU5MTczXSB1c2IgMi0xOiBkZXZpY2UgZGVzY3JpcHRvciBy
ZWFkLzY0LCBlcnJvciAtMTEwDQo+ID4gWyAgIDI3LjExOTQ1M10gdXNiIDItMTogZGV2aWNlIGRl
c2NyaXB0b3IgcmVhZC82NCwgZXJyb3IgLTExMA0KPiA+IFsgICAyNy4zODkyMTddIHVzYiAyLTE6
IG5ldyBmdWxsLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDMgdXNpbmcNCj4gPiB0ZWdyYS0NCj4g
PiBlaGNpDQo+ID4gWyAgIDMyLjU1OTQ1NF0gdXNiIDItMTogZGV2aWNlIGRlc2NyaXB0b3IgcmVh
ZC82NCwgZXJyb3IgLTExMA0KPiA+IFsgICA0Ny45Mjk3NzddIHVzYiAyLTE6IGRldmljZSBkZXNj
cmlwdG9yIHJlYWQvNjQsIGVycm9yIC0xMTANCj4gPiBbICAgNDguMDQ5NjU4XSB1c2IgdXNiMi1w
b3J0MTogYXR0ZW1wdCBwb3dlciBjeWNsZQ0KPiA+IFsgICA0OC43NTk0NzVdIHVzYiAyLTE6IG5l
dyBmdWxsLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDQgdXNpbmcNCj4gPiB0ZWdyYS0NCj4gPiBl
aGNpDQo+ID4gWyAgIDU5LjM0OTQ1N10gdXNiIDItMTogZGV2aWNlIG5vdCBhY2NlcHRpbmcgYWRk
cmVzcyA0LCBlcnJvciAtMTEwDQo+ID4gWyAgIDU5LjUwOTQ0OV0gdXNiIDItMTogbmV3IGZ1bGwt
c3BlZWQgVVNCIGRldmljZSBudW1iZXIgNSB1c2luZw0KPiA+IHRlZ3JhLQ0KPiA+IGVoY2kNCj4g
PiBbICAgNzAuMDY5NDU3XSB1c2IgMi0xOiBkZXZpY2Ugbm90IGFjY2VwdGluZyBhZGRyZXNzIDUs
IGVycm9yIC0xMTANCj4gPiBbICAgNzAuMDc5NzIxXSB1c2IgdXNiMi1wb3J0MTogdW5hYmxlIHRv
IGVudW1lcmF0ZSBVU0IgZGV2aWNlDQo+ID4gDQo+ID4gRml4IHRoaXMgYnkgYWN0dWFsbHkgYWxs
b3dpbmcgdGhlIHJhdGUgYWxzbyBiZWluZyBzZXQgZnJvbSB3aXRoaW4NCj4gPiB0aGUgTGludXgg
a2VybmVsLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmNlbCBaaXN3aWxlciA8bWFyY2Vs
Lnppc3dpbGVyQHRvcmFkZXguY29tPg0KPiA+IA0KPiA+IC0tLQ0KPiA+IA0KPiA+ICBkcml2ZXJz
L2Nsay90ZWdyYS9jbGstcGxsLmMgfCAyICsrDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy
dGlvbnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvdGVncmEvY2xrLXBs
bC5jIGIvZHJpdmVycy9jbGsvdGVncmEvY2xrLQ0KPiA+IHBsbC5jDQo+ID4gaW5kZXggN2MzNjll
MjFjOTFjLi44MzBkMWM4N2ZhN2MgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9jbGsvdGVncmEv
Y2xrLXBsbC5jDQo+ID4gKysrIGIvZHJpdmVycy9jbGsvdGVncmEvY2xrLXBsbC5jDQo+ID4gQEAg
LTExNTEsNiArMTE1MSw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY2xrX29wcw0KPiA+IHRlZ3Jh
X2Nsa19wbGx1X29wcyA9IHsNCj4gPiAgCS5lbmFibGUgPSBjbGtfcGxsdV9lbmFibGUsDQo+ID4g
IAkuZGlzYWJsZSA9IGNsa19wbGxfZGlzYWJsZSwNCj4gPiAgCS5yZWNhbGNfcmF0ZSA9IGNsa19w
bGxfcmVjYWxjX3JhdGUsDQo+ID4gKwkucm91bmRfcmF0ZSA9IGNsa19wbGxfcm91bmRfcmF0ZSwN
Cj4gPiArCS5zZXRfcmF0ZSA9IGNsa19wbGxfc2V0X3JhdGUsDQo+ID4gIH07DQo+ID4gIA0KPiA+
ICBzdGF0aWMgaW50IF9wbGxfZml4ZWRfbWRpdihzdHJ1Y3QgdGVncmFfY2xrX3BsbF9wYXJhbXMN
Cj4gPiAqcGxsX3BhcmFtcywNCj4gPiANCj4gDQo+IFRlZ3JhJ3MgVVNCIFBIWSBkcml2ZXIgb25s
eSBlbmFibGVzIGNsb2NrIGFuZCBjbGsgZHJpdmVyIGRvZXNuJ3QNCj4gc3BlY2lmeSB0aGUNCj4g
Y2xvY2sgcmF0ZSBpbiB0aGUgaW5pdCB0YWJsZS4gQ291bGQgeW91IHBsZWFzZSBjbGFyaWZ5IHdo
ZXJlIGluIHRoZQ0KPiBrZXJuZWxzIGNvZGUNCj4gUExMX1UgcmF0ZSBpcyBnZXR0aW5nIHNldD8N
Cg0KSSBndWVzcyB0aGF0IHdvdWxkIGJlIGFjY29yZGluZyB0byB0aGUgZm9sbG93aW5nIHRhYmxl
IGlzbid0IGl0Og0KDQpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVs
L2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZQ0KL2RyaXZlcnMvY2xrL3RlZ3JhL2Nsay10ZWdy
YTMwLmM/aD12NC4xNi1yYzMjbjI4Nw==
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-26 23:04 ` Marcel Ziswiler
(?)
@ 2018-02-27 11:59 ` Dmitry Osipenko
2018-02-28 9:36 ` Peter De Schrijver
-1 siblings, 1 reply; 20+ messages in thread
From: Dmitry Osipenko @ 2018-02-27 11:59 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra, pdeschrijver
Cc: linux-kernel, jonathanh, mturquette, pgaikwad, sboyd,
thierry.reding, linux-clk
On 27.02.2018 02:04, Marcel Ziswiler wrote:
> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>> which
>>> leaves it at some default rate of 500 kHz:
>>>
>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>> pll_u
>>> pll_u 3 3 0 500000
>>> 0
>>>
>>> Of course this won't quite work leading to the following messages:
>>>
>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>> tegra-
>>> ehci
>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>> tegra-
>>> ehci
>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>> tegra-
>>> ehci
>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>> tegra-
>>> ehci
>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>
>>> Fix this by actually allowing the rate also being set from within
>>> the Linux kernel.
>>>
>>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> ---
>>>
>>> drivers/clk/tegra/clk-pll.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-
>>> pll.c
>>> index 7c369e21c91c..830d1c87fa7c 100644
>>> --- a/drivers/clk/tegra/clk-pll.c
>>> +++ b/drivers/clk/tegra/clk-pll.c
>>> @@ -1151,6 +1151,8 @@ static const struct clk_ops
>>> tegra_clk_pllu_ops = {
>>> .enable = clk_pllu_enable,
>>> .disable = clk_pll_disable,
>>> .recalc_rate = clk_pll_recalc_rate,
>>> + .round_rate = clk_pll_round_rate,
>>> + .set_rate = clk_pll_set_rate,
>>> };
>>>
>>> static int _pll_fixed_mdiv(struct tegra_clk_pll_params
>>> *pll_params,
>>>
>>
>> Tegra's USB PHY driver only enables clock and clk driver doesn't
>> specify the
>> clock rate in the init table. Could you please clarify where in the
>> kernels code
>> PLL_U rate is getting set?
>
> I guess that would be according to the following table isn't it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree
> /drivers/clk/tegra/clk-tegra30.c?h=v4.16-rc3#n287
>
I see now that T30 has PLL_U in the init table [0], but T20 doesn't.
There is only one 480MHz rate defined in PLL_U lookup table. PLL_U also provides
12MHz and 60MHz outputs using fixed dividers and hence PLL_U shouldn't need
set/round_rate(), we can't change PLL_U rate at all and only enable / disable it.
Looks like for some reason PLL_U enabling fails without set/round_rate, but then
PHY driver should fail to probe [1]. Is it the case? Do you know why PLL_U isn't
actually getting enabled in HW? It is quite fishy, seems like clk driver /
framework bug or I'm missing something.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/tegra/clk-tegra30.c?h=v4.16-rc3#n1274
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/phy/phy-tegra-usb.c?h=v4.16-rc3#n777
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-27 11:59 ` Dmitry Osipenko
@ 2018-02-28 9:36 ` Peter De Schrijver
2018-02-28 12:00 ` Dmitry Osipenko
0 siblings, 1 reply; 20+ messages in thread
From: Peter De Schrijver @ 2018-02-28 9:36 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
> On 27.02.2018 02:04, Marcel Ziswiler wrote:
> > On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
> >> On 23.02.2018 02:04, Marcel Ziswiler wrote:
> >>> Turns out latest upstream U-Boot does not configure/enable pllu
> >>> which
> >>> leaves it at some default rate of 500 kHz:
> >>>
> >>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
> >>> pll_u
> >>> pll_u 3 3 0 500000
> >>> 0
> >>>
> >>> Of course this won't quite work leading to the following messages:
> >>>
> >>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
> >>> tegra-
> >>> ehci
> >>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> >>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> >>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
> >>> tegra-
> >>> ehci
> >>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> >>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> >>> [ 48.049658] usb usb2-port1: attempt power cycle
> >>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
> >>> tegra-
> >>> ehci
> >>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> >>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
> >>> tegra-
> >>> ehci
> >>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> >>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
> >>>
> >>> Fix this by actually allowing the rate also being set from within
> >>> the Linux kernel.
I think the best solution to this problem would be to make pll_u a fixed
clock and enable it and program the rate if it's not enabled at boot.
This is how it's done for Tegra210. The reason is that the USB IP blocks
can control the pll_u state in hw. This means that if sw would disable
and then re-enable the pll_u clock, but there is no USB activity, pll_u
will still be disable and therefor not lock, causing an error. Today
this is worked around by not polling the lock bit for pll_u, but a better
solution would be to just remove all sw controls for pll_u.
Peter.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-28 9:36 ` Peter De Schrijver
@ 2018-02-28 12:00 ` Dmitry Osipenko
2018-02-28 14:14 ` Peter De Schrijver
0 siblings, 1 reply; 20+ messages in thread
From: Dmitry Osipenko @ 2018-02-28 12:00 UTC (permalink / raw)
To: Peter De Schrijver
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On 28.02.2018 12:36, Peter De Schrijver wrote:
> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>>>> which
>>>>> leaves it at some default rate of 500 kHz:
>>>>>
>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>>>> pll_u
>>>>> pll_u 3 3 0 500000
>>>>> 0
>>>>>
>>>>> Of course this won't quite work leading to the following messages:
>>>>>
>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>>>> tegra-
>>>>> ehci
>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>>>> tegra-
>>>>> ehci
>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>>>> tegra-
>>>>> ehci
>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>>>> tegra-
>>>>> ehci
>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>>>
>>>>> Fix this by actually allowing the rate also being set from within
>>>>> the Linux kernel.
>
> I think the best solution to this problem would be to make pll_u a fixed
> clock and enable it and program the rate if it's not enabled at boot.
Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
there.
> This is how it's done for Tegra210. The reason is that the USB IP blocks
> can control the pll_u state in hw. This means that if sw would disable
> and then re-enable the pll_u clock, but there is no USB activity, pll_u
> will still be disable and therefor not lock, causing an error. Today
> this is worked around by not polling the lock bit for pll_u, but a better
> solution would be to just remove all sw controls for pll_u.
SW controls could be removed, but I don't think it is really necessary as in our
case SW is the PHY driver and we know what it does. Alternatively we can enable
PLL_U in the init table to keep it "always" enabled.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-28 12:00 ` Dmitry Osipenko
@ 2018-02-28 14:14 ` Peter De Schrijver
2018-02-28 17:20 ` Dmitry Osipenko
0 siblings, 1 reply; 20+ messages in thread
From: Peter De Schrijver @ 2018-02-28 14:14 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
> On 28.02.2018 12:36, Peter De Schrijver wrote:
> > On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
> >> On 27.02.2018 02:04, Marcel Ziswiler wrote:
> >>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
> >>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
> >>>>> Turns out latest upstream U-Boot does not configure/enable pllu
> >>>>> which
> >>>>> leaves it at some default rate of 500 kHz:
> >>>>>
> >>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
> >>>>> pll_u
> >>>>> pll_u 3 3 0 500000
> >>>>> 0
> >>>>>
> >>>>> Of course this won't quite work leading to the following messages:
> >>>>>
> >>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
> >>>>> tegra-
> >>>>> ehci
> >>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> >>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> >>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
> >>>>> tegra-
> >>>>> ehci
> >>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> >>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> >>>>> [ 48.049658] usb usb2-port1: attempt power cycle
> >>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
> >>>>> tegra-
> >>>>> ehci
> >>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> >>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
> >>>>> tegra-
> >>>>> ehci
> >>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> >>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
> >>>>>
> >>>>> Fix this by actually allowing the rate also being set from within
> >>>>> the Linux kernel.
> >
> > I think the best solution to this problem would be to make pll_u a fixed
> > clock and enable it and program the rate if it's not enabled at boot.
>
> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
> there.
>
AFAIK we only use one rate ever?
> > This is how it's done for Tegra210. The reason is that the USB IP blocks
> > can control the pll_u state in hw. This means that if sw would disable
> > and then re-enable the pll_u clock, but there is no USB activity, pll_u
> > will still be disable and therefor not lock, causing an error. Today
> > this is worked around by not polling the lock bit for pll_u, but a better
> > solution would be to just remove all sw controls for pll_u.
>
> SW controls could be removed, but I don't think it is really necessary as in our
> case SW is the PHY driver and we know what it does. Alternatively we can enable
> PLL_U in the init table to keep it "always" enabled.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-28 14:14 ` Peter De Schrijver
@ 2018-02-28 17:20 ` Dmitry Osipenko
2018-03-01 7:41 ` Peter De Schrijver
0 siblings, 1 reply; 20+ messages in thread
From: Dmitry Osipenko @ 2018-02-28 17:20 UTC (permalink / raw)
To: Peter De Schrijver
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On 28.02.2018 17:14, Peter De Schrijver wrote:
> On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
>> On 28.02.2018 12:36, Peter De Schrijver wrote:
>>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
>>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
>>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>>>>>> which
>>>>>>> leaves it at some default rate of 500 kHz:
>>>>>>>
>>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>>>>>> pll_u
>>>>>>> pll_u 3 3 0 500000
>>>>>>> 0
>>>>>>>
>>>>>>> Of course this won't quite work leading to the following messages:
>>>>>>>
>>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>>>>>> tegra-
>>>>>>> ehci
>>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>>>>>> tegra-
>>>>>>> ehci
>>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>>>>>> tegra-
>>>>>>> ehci
>>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>>>>>> tegra-
>>>>>>> ehci
>>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>>>>>
>>>>>>> Fix this by actually allowing the rate also being set from within
>>>>>>> the Linux kernel.
>>>
>>> I think the best solution to this problem would be to make pll_u a fixed
>>> clock and enable it and program the rate if it's not enabled at boot.
>>
>> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
>> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
>> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
>> there.
>>
>
> AFAIK we only use one rate ever?
IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
>>> This is how it's done for Tegra210. The reason is that the USB IP blocks
>>> can control the pll_u state in hw. This means that if sw would disable
>>> and then re-enable the pll_u clock, but there is no USB activity, pll_u
>>> will still be disable and therefor not lock, causing an error. Today
>>> this is worked around by not polling the lock bit for pll_u, but a better
>>> solution would be to just remove all sw controls for pll_u.
>>
>> SW controls could be removed, but I don't think it is really necessary as in our
>> case SW is the PHY driver and we know what it does. Alternatively we can enable
>> PLL_U in the init table to keep it "always" enabled.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-28 17:20 ` Dmitry Osipenko
@ 2018-03-01 7:41 ` Peter De Schrijver
2018-03-01 13:19 ` Dmitry Osipenko
2018-03-02 9:02 ` Jon Hunter
0 siblings, 2 replies; 20+ messages in thread
From: Peter De Schrijver @ 2018-03-01 7:41 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On Wed, Feb 28, 2018 at 08:20:47PM +0300, Dmitry Osipenko wrote:
> On 28.02.2018 17:14, Peter De Schrijver wrote:
> > On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
> >> On 28.02.2018 12:36, Peter De Schrijver wrote:
> >>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
> >>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
> >>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
> >>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
> >>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
> >>>>>>> which
> >>>>>>> leaves it at some default rate of 500 kHz:
> >>>>>>>
> >>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
> >>>>>>> pll_u
> >>>>>>> pll_u 3 3 0 500000
> >>>>>>> 0
> >>>>>>>
> >>>>>>> Of course this won't quite work leading to the following messages:
> >>>>>>>
> >>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
> >>>>>>> tegra-
> >>>>>>> ehci
> >>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> >>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> >>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
> >>>>>>> tegra-
> >>>>>>> ehci
> >>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> >>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> >>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
> >>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
> >>>>>>> tegra-
> >>>>>>> ehci
> >>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> >>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
> >>>>>>> tegra-
> >>>>>>> ehci
> >>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> >>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
> >>>>>>>
> >>>>>>> Fix this by actually allowing the rate also being set from within
> >>>>>>> the Linux kernel.
> >>>
> >>> I think the best solution to this problem would be to make pll_u a fixed
> >>> clock and enable it and program the rate if it's not enabled at boot.
> >>
> >> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
> >> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
> >> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
> >> there.
> >>
> >
> > AFAIK we only use one rate ever?
>
> IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
> setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
>
Indeed. And given that it's hw controlled anyway, I don't see why we can't make
it a fixed clock and handle the init at kernel boot depending on what the
bootloader has done.
Peter.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-03-01 7:41 ` Peter De Schrijver
@ 2018-03-01 13:19 ` Dmitry Osipenko
2018-03-01 13:44 ` Dmitry Osipenko
2018-03-02 9:02 ` Jon Hunter
1 sibling, 1 reply; 20+ messages in thread
From: Dmitry Osipenko @ 2018-03-01 13:19 UTC (permalink / raw)
To: Peter De Schrijver
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On 01.03.2018 10:41, Peter De Schrijver wrote:
> On Wed, Feb 28, 2018 at 08:20:47PM +0300, Dmitry Osipenko wrote:
>> On 28.02.2018 17:14, Peter De Schrijver wrote:
>>> On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
>>>> On 28.02.2018 12:36, Peter De Schrijver wrote:
>>>>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
>>>>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>>>>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>>>>>>>> which
>>>>>>>>> leaves it at some default rate of 500 kHz:
>>>>>>>>>
>>>>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>>>>>>>> pll_u
>>>>>>>>> pll_u 3 3 0 500000
>>>>>>>>> 0
>>>>>>>>>
>>>>>>>>> Of course this won't quite work leading to the following messages:
>>>>>>>>>
>>>>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>>>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>>>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>>>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>>>>>>>
>>>>>>>>> Fix this by actually allowing the rate also being set from within
>>>>>>>>> the Linux kernel.
>>>>>
>>>>> I think the best solution to this problem would be to make pll_u a fixed
>>>>> clock and enable it and program the rate if it's not enabled at boot.
>>>>
>>>> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
>>>> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
>>>> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
>>>> there.
>>>>
>>>
>>> AFAIK we only use one rate ever?
>>
>> IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
>> setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
>>
>
> Indeed. And given that it's hw controlled anyway, I don't see why we can't make
> it a fixed clock and handle the init at kernel boot depending on what the
> bootloader has done.
We can, I just don't think you can demand from Mark to do it. This patch is fine
on its own, everything else could be done later.
On the other hand, it's USB driver responsibility to do the right thing. Why
just not to correct the driver? It would be kinda weird to mask one driver bug
by adding workaround to another. So I'd even suggest to go other way round by
implementing PLL lock polling and removing PLL_U enabling/disabling from the USB
PHY driver (if it's really fully-controlled by HW).
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-03-01 13:19 ` Dmitry Osipenko
@ 2018-03-01 13:44 ` Dmitry Osipenko
0 siblings, 0 replies; 20+ messages in thread
From: Dmitry Osipenko @ 2018-03-01 13:44 UTC (permalink / raw)
To: Peter De Schrijver
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, jonathanh,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On 01.03.2018 16:19, Dmitry Osipenko wrote:
> On 01.03.2018 10:41, Peter De Schrijver wrote:
>> On Wed, Feb 28, 2018 at 08:20:47PM +0300, Dmitry Osipenko wrote:
>>> On 28.02.2018 17:14, Peter De Schrijver wrote:
>>>> On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
>>>>> On 28.02.2018 12:36, Peter De Schrijver wrote:
>>>>>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
>>>>>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>>>>>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>>>>>>>>> which
>>>>>>>>>> leaves it at some default rate of 500 kHz:
>>>>>>>>>>
>>>>>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>>>>>>>>> pll_u
>>>>>>>>>> pll_u 3 3 0 500000
>>>>>>>>>> 0
>>>>>>>>>>
>>>>>>>>>> Of course this won't quite work leading to the following messages:
>>>>>>>>>>
>>>>>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>>>>>>>>> tegra-
>>>>>>>>>> ehci
>>>>>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>>>>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>>>>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>>>>>>>>> tegra-
>>>>>>>>>> ehci
>>>>>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>>>>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>>>>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>>>>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>>>>>>>>> tegra-
>>>>>>>>>> ehci
>>>>>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>>>>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>>>>>>>>> tegra-
>>>>>>>>>> ehci
>>>>>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>>>>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>>>>>>>>
>>>>>>>>>> Fix this by actually allowing the rate also being set from within
>>>>>>>>>> the Linux kernel.
>>>>>>
>>>>>> I think the best solution to this problem would be to make pll_u a fixed
>>>>>> clock and enable it and program the rate if it's not enabled at boot.
>>>>>
>>>>> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
>>>>> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
>>>>> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
>>>>> there.
>>>>>
>>>>
>>>> AFAIK we only use one rate ever?
>>>
>>> IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
>>> setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
>>>
>>
>> Indeed. And given that it's hw controlled anyway, I don't see why we can't make
>> it a fixed clock and handle the init at kernel boot depending on what the
>> bootloader has done.
>
> We can, I just don't think you can demand from Mark to do it. This patch is fine
> on its own, everything else could be done later.
I meant Marcel.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-03-01 7:41 ` Peter De Schrijver
2018-03-01 13:19 ` Dmitry Osipenko
@ 2018-03-02 9:02 ` Jon Hunter
2018-03-02 11:25 ` Peter De Schrijver
1 sibling, 1 reply; 20+ messages in thread
From: Jon Hunter @ 2018-03-02 9:02 UTC (permalink / raw)
To: Peter De Schrijver, Dmitry Osipenko
Cc: Marcel Ziswiler, linux-tegra, linux-kernel, mturquette, pgaikwad,
sboyd, thierry.reding, linux-clk
On 01/03/18 07:41, Peter De Schrijver wrote:
> On Wed, Feb 28, 2018 at 08:20:47PM +0300, Dmitry Osipenko wrote:
>> On 28.02.2018 17:14, Peter De Schrijver wrote:
>>> On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
>>>> On 28.02.2018 12:36, Peter De Schrijver wrote:
>>>>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
>>>>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
>>>>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
>>>>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
>>>>>>>>> which
>>>>>>>>> leaves it at some default rate of 500 kHz:
>>>>>>>>>
>>>>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
>>>>>>>>> pll_u
>>>>>>>>> pll_u 3 3 0 500000
>>>>>>>>> 0
>>>>>>>>>
>>>>>>>>> Of course this won't quite work leading to the following messages:
>>>>>>>>>
>>>>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
>>>>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
>>>>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
>>>>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
>>>>>>>>> tegra-
>>>>>>>>> ehci
>>>>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
>>>>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>>>>>>>>>
>>>>>>>>> Fix this by actually allowing the rate also being set from within
>>>>>>>>> the Linux kernel.
>>>>>
>>>>> I think the best solution to this problem would be to make pll_u a fixed
>>>>> clock and enable it and program the rate if it's not enabled at boot.
>>>>
>>>> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
>>>> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
>>>> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
>>>> there.
>>>>
>>>
>>> AFAIK we only use one rate ever?
>>
>> IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
>> setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
>>
>
> Indeed. And given that it's hw controlled anyway, I don't see why we can't make
> it a fixed clock and handle the init at kernel boot depending on what the
> bootloader has done.
Peter, are you suggesting we implement the equivalent to
tegra210_init_pllu()? This does look a bit more involved that what this
change is doing. Is there a simple way to do what you are suggesting?
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-03-02 9:02 ` Jon Hunter
@ 2018-03-02 11:25 ` Peter De Schrijver
0 siblings, 0 replies; 20+ messages in thread
From: Peter De Schrijver @ 2018-03-02 11:25 UTC (permalink / raw)
To: Jon Hunter
Cc: Dmitry Osipenko, Marcel Ziswiler, linux-tegra, linux-kernel,
mturquette, pgaikwad, sboyd, thierry.reding, linux-clk
On Fri, Mar 02, 2018 at 09:02:07AM +0000, Jon Hunter wrote:
>
> On 01/03/18 07:41, Peter De Schrijver wrote:
> > On Wed, Feb 28, 2018 at 08:20:47PM +0300, Dmitry Osipenko wrote:
> >> On 28.02.2018 17:14, Peter De Schrijver wrote:
> >>> On Wed, Feb 28, 2018 at 03:00:23PM +0300, Dmitry Osipenko wrote:
> >>>> On 28.02.2018 12:36, Peter De Schrijver wrote:
> >>>>> On Tue, Feb 27, 2018 at 02:59:11PM +0300, Dmitry Osipenko wrote:
> >>>>>> On 27.02.2018 02:04, Marcel Ziswiler wrote:
> >>>>>>> On Mon, 2018-02-26 at 15:42 +0300, Dmitry Osipenko wrote:
> >>>>>>>> On 23.02.2018 02:04, Marcel Ziswiler wrote:
> >>>>>>>>> Turns out latest upstream U-Boot does not configure/enable pllu
> >>>>>>>>> which
> >>>>>>>>> leaves it at some default rate of 500 kHz:
> >>>>>>>>>
> >>>>>>>>> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep
> >>>>>>>>> pll_u
> >>>>>>>>> pll_u 3 3 0 500000
> >>>>>>>>> 0
> >>>>>>>>>
> >>>>>>>>> Of course this won't quite work leading to the following messages:
> >>>>>>>>>
> >>>>>>>>> [ 6.559593] usb 2-1: new full-speed USB device number 2 using
> >>>>>>>>> tegra-
> >>>>>>>>> ehci
> >>>>>>>>> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> >>>>>>>>> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> >>>>>>>>> [ 27.389217] usb 2-1: new full-speed USB device number 3 using
> >>>>>>>>> tegra-
> >>>>>>>>> ehci
> >>>>>>>>> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> >>>>>>>>> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> >>>>>>>>> [ 48.049658] usb usb2-port1: attempt power cycle
> >>>>>>>>> [ 48.759475] usb 2-1: new full-speed USB device number 4 using
> >>>>>>>>> tegra-
> >>>>>>>>> ehci
> >>>>>>>>> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> >>>>>>>>> [ 59.509449] usb 2-1: new full-speed USB device number 5 using
> >>>>>>>>> tegra-
> >>>>>>>>> ehci
> >>>>>>>>> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> >>>>>>>>> [ 70.079721] usb usb2-port1: unable to enumerate USB device
> >>>>>>>>>
> >>>>>>>>> Fix this by actually allowing the rate also being set from within
> >>>>>>>>> the Linux kernel.
> >>>>>
> >>>>> I think the best solution to this problem would be to make pll_u a fixed
> >>>>> clock and enable it and program the rate if it's not enabled at boot.
> >>>>
> >>>> Oh, right. PLL_U rate is actually configurable, somehow I missed it in TRM
> >>>> yesterday.. So set/round_rate() for PLL_U are actually needed and the patch is
> >>>> correct. Seems only T20 misses PLL_U in the init table, probably worth to add it
> >>>> there.
> >>>>
> >>>
> >>> AFAIK we only use one rate ever?
> >>
> >> IIUC, PLL_U has 3 outputs and output dividers are fixed in HW. So yes, we are
> >> setting PLL_U to one rate - 480MHz to get out1-480MHz, out2-60MHz and out3-12MHz.
> >>
> >
> > Indeed. And given that it's hw controlled anyway, I don't see why we can't make
> > it a fixed clock and handle the init at kernel boot depending on what the
> > bootloader has done.
>
> Peter, are you suggesting we implement the equivalent to
> tegra210_init_pllu()? This does look a bit more involved that what this
> change is doing. Is there a simple way to do what you are suggesting?
>
Basically yes.
Peter.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-22 23:04 [PATCH] clk: tegra: fix pllu rate configuration Marcel Ziswiler
@ 2018-03-02 8:56 ` Jon Hunter
2018-02-26 12:42 ` Dmitry Osipenko
` (2 subsequent siblings)
3 siblings, 0 replies; 20+ messages in thread
From: Jon Hunter @ 2018-03-02 8:56 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra
Cc: Dmitry Osipenko, Marcel Ziswiler, Thierry Reding, Stephen Boyd,
linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Michael Turquette, linux-clk
On 22/02/18 23:04, Marcel Ziswiler wrote:
> Turns out latest upstream U-Boot does not configure/enable pllu which
> leaves it at some default rate of 500 kHz:
>
> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep pll_u
> pll_u 3 3 0 500000 0
>
> Of course this won't quite work leading to the following messages:
>
> [ 6.559593] usb 2-1: new full-speed USB device number 2 using tegra-
> ehci
> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> [ 27.389217] usb 2-1: new full-speed USB device number 3 using tegra-
> ehci
> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> [ 48.049658] usb usb2-port1: attempt power cycle
> [ 48.759475] usb 2-1: new full-speed USB device number 4 using tegra-
> ehci
> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> [ 59.509449] usb 2-1: new full-speed USB device number 5 using tegra-
> ehci
> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>
> Fix this by actually allowing the rate also being set from within
> the Linux kernel.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/clk/tegra/clk-pll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 7c369e21c91c..830d1c87fa7c 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1151,6 +1151,8 @@ static const struct clk_ops tegra_clk_pllu_ops = {
> .enable = clk_pllu_enable,
> .disable = clk_pll_disable,
> .recalc_rate = clk_pll_recalc_rate,
> + .round_rate = clk_pll_round_rate,
> + .set_rate = clk_pll_set_rate,
> };
>
> static int _pll_fixed_mdiv(struct tegra_clk_pll_params *pll_params,
Thanks for the fix. I have tested this on Tegra30 cardhu and this
resolves a problem booting this board with the upstream uboot bootloader.
We just need to align with Peter on the best way to fix.
Cheers,
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] clk: tegra: fix pllu rate configuration
@ 2018-03-02 8:56 ` Jon Hunter
0 siblings, 0 replies; 20+ messages in thread
From: Jon Hunter @ 2018-03-02 8:56 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra
Cc: Dmitry Osipenko, Marcel Ziswiler, Thierry Reding, Stephen Boyd,
linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Michael Turquette, linux-clk
On 22/02/18 23:04, Marcel Ziswiler wrote:
> Turns out latest upstream U-Boot does not configure/enable pllu which
> leaves it at some default rate of 500 kHz:
>
> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep pll_u
> pll_u 3 3 0 500000 0
>
> Of course this won't quite work leading to the following messages:
>
> [ 6.559593] usb 2-1: new full-speed USB device number 2 using tegra-
> ehci
> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> [ 27.389217] usb 2-1: new full-speed USB device number 3 using tegra-
> ehci
> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> [ 48.049658] usb usb2-port1: attempt power cycle
> [ 48.759475] usb 2-1: new full-speed USB device number 4 using tegra-
> ehci
> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> [ 59.509449] usb 2-1: new full-speed USB device number 5 using tegra-
> ehci
> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>
> Fix this by actually allowing the rate also being set from within
> the Linux kernel.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/clk/tegra/clk-pll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 7c369e21c91c..830d1c87fa7c 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1151,6 +1151,8 @@ static const struct clk_ops tegra_clk_pllu_ops = {
> .enable = clk_pllu_enable,
> .disable = clk_pll_disable,
> .recalc_rate = clk_pll_recalc_rate,
> + .round_rate = clk_pll_round_rate,
> + .set_rate = clk_pll_set_rate,
> };
>
> static int _pll_fixed_mdiv(struct tegra_clk_pll_params *pll_params,
Thanks for the fix. I have tested this on Tegra30 cardhu and this
resolves a problem booting this board with the upstream uboot bootloader.
We just need to align with Peter on the best way to fix.
Cheers,
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] clk: tegra: fix pllu rate configuration
2018-02-22 23:04 [PATCH] clk: tegra: fix pllu rate configuration Marcel Ziswiler
` (2 preceding siblings ...)
2018-03-02 8:56 ` Jon Hunter
@ 2018-03-08 14:57 ` Thierry Reding
3 siblings, 0 replies; 20+ messages in thread
From: Thierry Reding @ 2018-03-08 14:57 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: linux-tegra, Dmitry Osipenko, Marcel Ziswiler, Stephen Boyd,
linux-kernel, Prashant Gaikwad, Peter De Schrijver,
Jonathan Hunter, Michael Turquette, linux-clk
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
On Fri, Feb 23, 2018 at 12:04:51AM +0100, Marcel Ziswiler wrote:
> Turns out latest upstream U-Boot does not configure/enable pllu which
> leaves it at some default rate of 500 kHz:
>
> root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep pll_u
> pll_u 3 3 0 500000 0
>
> Of course this won't quite work leading to the following messages:
>
> [ 6.559593] usb 2-1: new full-speed USB device number 2 using tegra-
> ehci
> [ 11.759173] usb 2-1: device descriptor read/64, error -110
> [ 27.119453] usb 2-1: device descriptor read/64, error -110
> [ 27.389217] usb 2-1: new full-speed USB device number 3 using tegra-
> ehci
> [ 32.559454] usb 2-1: device descriptor read/64, error -110
> [ 47.929777] usb 2-1: device descriptor read/64, error -110
> [ 48.049658] usb usb2-port1: attempt power cycle
> [ 48.759475] usb 2-1: new full-speed USB device number 4 using tegra-
> ehci
> [ 59.349457] usb 2-1: device not accepting address 4, error -110
> [ 59.509449] usb 2-1: new full-speed USB device number 5 using tegra-
> ehci
> [ 70.069457] usb 2-1: device not accepting address 5, error -110
> [ 70.079721] usb usb2-port1: unable to enumerate USB device
>
> Fix this by actually allowing the rate also being set from within
> the Linux kernel.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/clk/tegra/clk-pll.c | 2 ++
> 1 file changed, 2 insertions(+)
I'm aware of the discussion about how best to implement this, but this
seems like a reasonable fix until we have something better.
Peter, Jon: if you want to fix this more properly, please take point on
this.
Applied this to for-4.17/clk, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread