From: Dan Murphy <dmurphy@ti.com> To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, linux-leds@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, robh@kernel.org, Baolin Wang <baolin.wang@linaro.org>, Daniel Mack <daniel@zonque.org>, Linus Walleij <linus.walleij@linaro.org>, Oleh Kravchenko <oleg@kaa.org.ua>, Sakari Ailus <sakari.ailus@linux.intel.com>, Simon Shields <simon@lineageos.org> Subject: Re: [PATCH 05/25] dt-bindings: leds: Add function and color properties Date: Mon, 11 Mar 2019 07:26:43 -0500 [thread overview] Message-ID: <98c1a41e-77bb-5ffd-b5b3-772a28c0f0a6@ti.com> (raw) In-Reply-To: <20190310182836.20841-6-jacek.anaszewski@gmail.com> On 3/10/19 1:28 PM, Jacek Anaszewski wrote: > Introduce dedicated properties for conveying information about > LED function and color. Mark old "label" property as deprecated. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Daniel Mack <daniel@zonque.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Simon Shields <simon@lineageos.org> > --- > Documentation/devicetree/bindings/leds/common.txt | 55 +++++++++++++++++++---- > 1 file changed, 47 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index aa1399814a2a..3402b0e1cec9 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -10,14 +10,23 @@ can influence the way of the LED device initialization, the LED components > have to be tightly coupled with the LED device binding. They are represented > by child nodes of the parent LED device binding. > > + > Optional properties for child nodes: > - led-sources : List of device current outputs the LED is connected to. The > outputs are identified by the numbers that must be defined > in the LED device binding documentation. > +- function: LED functon. Use one of the LED_FUNCTION_* prefixed definitions > + from the header include/dt-bindings/leds/common.h. > + If there is no matching LED_FUNCTION available, add a new one. > +- color : Color of the LED. Use one of the LED_COLOR_NAME_* prefixed definitions > + from the header include/dt-bindings/leds/common.h. > + If there is no matching LED_COLOR_NAME available, add a new one. > + I am assuming multi color can re-use this property as well? > - label : The label for this LED. If omitted, the label is taken from the node > name (excluding the unit address). It has to uniquely identify > a device, i.e. no other LED class device can be assigned the same > - label. > + label. This property is deprecated - use 'function' and 'color' > + properties instead. > > - default-state : The initial state of the LED. Valid values are "on", "off", > and "keep". If the LED is already on or off and the default-state property is > @@ -87,29 +96,59 @@ Required properties for trigger source: > > * Examples > > -gpio-leds { > +#include <dt-bindings/leds/common.h> > + > +led-controller@0 { > compatible = "gpio-leds"; > > - system-status { > - label = "Status"; > + led0 { > + function = LED_FUNCTION_STATUS; Missing color for example unless there is a reason to omit it for GPIO LEDs Also missing reg here > linux,default-trigger = "heartbeat"; > gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > }; > > - usb { > + led1 { > + function = LED_FUNCTION_USB; Same as above Also missing reg here > gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; > trigger-sources = <&ohci_port1>, <&ehci_port1>; > }; > }; > > -max77693-led { > +led-controller@0 { > compatible = "maxim,max77693-led"; > > - camera-flash { > - label = "Flash"; > + led { > + function = LED_FUNCTION_FLASH; > + color = LED_COLOR_NAME_WHITE; > led-sources = <0>, <1>; > led-max-microamp = <50000>; > flash-max-microamp = <320000>; > flash-max-timeout-us = <500000>; > }; > }; > + > +led-controller@30 { > + compatible = "panasonic,an30259a"; > + reg = <0x30>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + linux,default-trigger = "heartbeat"; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_RED; > + }; > + > + led@2 { > + reg = <2>; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_GREEN; > + }; > + > + led@3 { > + reg = <3>; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_BLUE; > + }; > +}; > -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, <linux-leds@vger.kernel.org> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <pavel@ucw.cz>, <robh@kernel.org>, Baolin Wang <baolin.wang@linaro.org>, Daniel Mack <daniel@zonque.org>, Linus Walleij <linus.walleij@linaro.org>, Oleh Kravchenko <oleg@kaa.org.ua>, Sakari Ailus <sakari.ailus@linux.intel.com>, Simon Shields <simon@lineageos.org> Subject: Re: [PATCH 05/25] dt-bindings: leds: Add function and color properties Date: Mon, 11 Mar 2019 07:26:43 -0500 [thread overview] Message-ID: <98c1a41e-77bb-5ffd-b5b3-772a28c0f0a6@ti.com> (raw) In-Reply-To: <20190310182836.20841-6-jacek.anaszewski@gmail.com> On 3/10/19 1:28 PM, Jacek Anaszewski wrote: > Introduce dedicated properties for conveying information about > LED function and color. Mark old "label" property as deprecated. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Daniel Mack <daniel@zonque.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Simon Shields <simon@lineageos.org> > --- > Documentation/devicetree/bindings/leds/common.txt | 55 +++++++++++++++++++---- > 1 file changed, 47 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index aa1399814a2a..3402b0e1cec9 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -10,14 +10,23 @@ can influence the way of the LED device initialization, the LED components > have to be tightly coupled with the LED device binding. They are represented > by child nodes of the parent LED device binding. > > + > Optional properties for child nodes: > - led-sources : List of device current outputs the LED is connected to. The > outputs are identified by the numbers that must be defined > in the LED device binding documentation. > +- function: LED functon. Use one of the LED_FUNCTION_* prefixed definitions > + from the header include/dt-bindings/leds/common.h. > + If there is no matching LED_FUNCTION available, add a new one. > +- color : Color of the LED. Use one of the LED_COLOR_NAME_* prefixed definitions > + from the header include/dt-bindings/leds/common.h. > + If there is no matching LED_COLOR_NAME available, add a new one. > + I am assuming multi color can re-use this property as well? > - label : The label for this LED. If omitted, the label is taken from the node > name (excluding the unit address). It has to uniquely identify > a device, i.e. no other LED class device can be assigned the same > - label. > + label. This property is deprecated - use 'function' and 'color' > + properties instead. > > - default-state : The initial state of the LED. Valid values are "on", "off", > and "keep". If the LED is already on or off and the default-state property is > @@ -87,29 +96,59 @@ Required properties for trigger source: > > * Examples > > -gpio-leds { > +#include <dt-bindings/leds/common.h> > + > +led-controller@0 { > compatible = "gpio-leds"; > > - system-status { > - label = "Status"; > + led0 { > + function = LED_FUNCTION_STATUS; Missing color for example unless there is a reason to omit it for GPIO LEDs Also missing reg here > linux,default-trigger = "heartbeat"; > gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > }; > > - usb { > + led1 { > + function = LED_FUNCTION_USB; Same as above Also missing reg here > gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; > trigger-sources = <&ohci_port1>, <&ehci_port1>; > }; > }; > > -max77693-led { > +led-controller@0 { > compatible = "maxim,max77693-led"; > > - camera-flash { > - label = "Flash"; > + led { > + function = LED_FUNCTION_FLASH; > + color = LED_COLOR_NAME_WHITE; > led-sources = <0>, <1>; > led-max-microamp = <50000>; > flash-max-microamp = <320000>; > flash-max-timeout-us = <500000>; > }; > }; > + > +led-controller@30 { > + compatible = "panasonic,an30259a"; > + reg = <0x30>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + linux,default-trigger = "heartbeat"; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_RED; > + }; > + > + led@2 { > + reg = <2>; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_GREEN; > + }; > + > + led@3 { > + reg = <3>; > + function = LED_FUNCTION_INDICATOR; > + color = LED_COLOR_NAME_BLUE; > + }; > +}; > -- ------------------ Dan Murphy
next prev parent reply other threads:[~2019-03-11 12:26 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-10 18:28 [PATCH v2 00/25] Add generic support for composing LED class device name Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 01/25] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski 2019-03-10 20:18 ` Oleh Kravchenko 2019-03-10 18:28 ` [PATCH 02/25] leds: core: Add support for composing LED class device names Jacek Anaszewski 2019-03-12 16:56 ` Jacek Anaszewski 2019-03-12 17:15 ` Dan Murphy 2019-03-12 17:15 ` Dan Murphy 2019-03-12 17:28 ` Jacek Anaszewski 2019-03-12 17:46 ` Dan Murphy 2019-03-12 17:46 ` Dan Murphy 2019-03-12 18:19 ` Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 03/25] dt-bindings: leds: Add LED_FUNCTION definitions Jacek Anaszewski 2019-03-11 12:22 ` Dan Murphy 2019-03-11 12:22 ` Dan Murphy 2019-03-11 17:22 ` Jacek Anaszewski 2019-03-28 0:03 ` Rob Herring 2019-03-28 20:01 ` Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 04/25] dt-bindings: leds: Add LED_COLOR_NAME definitions Jacek Anaszewski 2019-03-11 12:23 ` Dan Murphy 2019-03-11 12:23 ` Dan Murphy 2019-03-11 17:23 ` Jacek Anaszewski 2019-03-22 8:35 ` Pavel Machek 2019-03-28 0:08 ` Rob Herring 2019-03-10 18:28 ` [PATCH 05/25] dt-bindings: leds: Add function and color properties Jacek Anaszewski 2019-03-11 12:26 ` Dan Murphy [this message] 2019-03-11 12:26 ` Dan Murphy 2019-03-11 17:24 ` Jacek Anaszewski 2019-03-12 16:43 ` Jacek Anaszewski 2019-03-28 0:23 ` Rob Herring 2019-04-04 13:21 ` Pavel Machek 2019-03-10 18:28 ` [PATCH 06/25] dt-bindings: sc27xx-blt: " Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 07/25] leds: sc27xx-blt: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 08/25] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 09/25] leds: lt3593: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 10/25] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 11/25] leds: lp8860: Use led_compose_name() Jacek Anaszewski 2019-03-11 12:28 ` Dan Murphy 2019-03-11 12:28 ` Dan Murphy 2019-03-11 17:24 ` Jacek Anaszewski 2019-03-11 17:26 ` Dan Murphy 2019-03-11 17:26 ` Dan Murphy 2019-03-10 18:28 ` [PATCH 12/25] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 13/25] leds: lm3692x: Use led_compose_name() Jacek Anaszewski 2019-03-11 12:38 ` Dan Murphy 2019-03-11 12:38 ` Dan Murphy 2019-03-11 17:24 ` Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 14/25] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 15/25] leds: lm3601x: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 16/25] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 17/25] leds: cr0014114: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 18/25] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 19/25] leds: aat1290: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 20/25] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 21/25] leds: as3645a: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 22/25] dt-bindings: leds-gpio: Add function and color properties Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 23/25] leds: gpio: Use led_compose_name() Jacek Anaszewski 2019-03-10 18:28 ` [PATCH 24/25] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski 2019-03-22 8:33 ` Pavel Machek 2019-03-10 18:28 ` [PATCH 25/25] leds: an30259a: Use led_compose_name() Jacek Anaszewski 2019-03-28 0:19 ` [PATCH v2 00/25] Add generic support for composing LED class device name Rob Herring 2019-03-28 20:54 ` Jacek Anaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=98c1a41e-77bb-5ffd-b5b3-772a28c0f0a6@ti.com \ --to=dmurphy@ti.com \ --cc=baolin.wang@linaro.org \ --cc=daniel@zonque.org \ --cc=devicetree@vger.kernel.org \ --cc=jacek.anaszewski@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=oleg@kaa.org.ua \ --cc=pavel@ucw.cz \ --cc=robh@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=simon@lineageos.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.