All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree
@ 2018-05-01 22:33 gregkh
  2018-05-02  9:23 ` Juergen Gross
  0 siblings, 1 reply; 3+ messages in thread
From: gregkh @ 2018-05-01 22:33 UTC (permalink / raw)
  To: 20180219100906.14265-4-jgross, alexander.levin, andy.shevchenko,
	boris.ostrovsky, bp, ebiederm, gregkh, hpa
  Cc: stable-commits


This is a note to let you know that I've just added the patch titled

    x86/xen: Add pvh specific rsdp address retrieval function

to the 4.16-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     x86-xen-add-pvh-specific-rsdp-address-retrieval-function.patch
and it can be found in the queue-4.16 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From foo@baz Tue May  1 14:59:18 PDT 2018
From: Juergen Gross <jgross@suse.com>
Date: Mon, 19 Feb 2018 11:09:06 +0100
Subject: x86/xen: Add pvh specific rsdp address retrieval function

From: Juergen Gross <jgross@suse.com>

[ Upstream commit b17d9d1df3c33a4f1d2bf397e2257aecf9dc56d4 ]

Add pvh_get_root_pointer() for Xen PVH guests to communicate the
address of the RSDP table given to the kernel via Xen start info.

This makes the kernel boot again in PVH mode after on recent Xen the
RSDP was moved to higher addresses. So up to that change it was pure
luck that the legacy method to locate the RSDP was working when
running as PVH mode.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: boris.ostrovsky@oracle.com
Cc: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org
Link: http://lkml.kernel.org/r/20180219100906.14265-4-jgross@suse.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 arch/x86/xen/enlighten_pvh.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

--- a/arch/x86/xen/enlighten_pvh.c
+++ b/arch/x86/xen/enlighten_pvh.c
@@ -6,6 +6,7 @@
 #include <asm/io_apic.h>
 #include <asm/hypervisor.h>
 #include <asm/e820/api.h>
+#include <asm/x86_init.h>
 
 #include <asm/xen/interface.h>
 #include <asm/xen/hypercall.h>
@@ -16,15 +17,20 @@
 /*
  * PVH variables.
  *
- * xen_pvh and pvh_bootparams need to live in data segment since they
- * are used after startup_{32|64}, which clear .bss, are invoked.
+ * xen_pvh pvh_bootparams and pvh_start_info need to live in data segment
+ * since they are used after startup_{32|64}, which clear .bss, are invoked.
  */
 bool xen_pvh __attribute__((section(".data"))) = 0;
 struct boot_params pvh_bootparams __attribute__((section(".data")));
+struct hvm_start_info pvh_start_info __attribute__((section(".data")));
 
-struct hvm_start_info pvh_start_info;
 unsigned int pvh_start_info_sz = sizeof(pvh_start_info);
 
+static u64 pvh_get_root_pointer(void)
+{
+	return pvh_start_info.rsdp_paddr;
+}
+
 static void __init init_pvh_bootparams(void)
 {
 	struct xen_memory_map memmap;
@@ -71,6 +77,8 @@ static void __init init_pvh_bootparams(v
 	 */
 	pvh_bootparams.hdr.version = 0x212;
 	pvh_bootparams.hdr.type_of_loader = (9 << 4) | 0; /* Xen loader */
+
+	x86_init.acpi.get_root_pointer = pvh_get_root_pointer;
 }
 
 /*


Patches currently in stable-queue which might be from jgross@suse.com are

queue-4.16/x86-xen-add-pvh-specific-rsdp-address-retrieval-function.patch
queue-4.16/x86-mm-do-not-forbid-_page_rw-before-init-for-__ro_after_init.patch
queue-4.16/xen-acpi-off-by-one-in-read_acpi_id.patch
queue-4.16/x86-pgtable-don-t-set-huge-pud-pmd-on-non-leaf-entries.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree
  2018-05-01 22:33 Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree gregkh
@ 2018-05-02  9:23 ` Juergen Gross
  2018-05-02 15:34   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2018-05-02  9:23 UTC (permalink / raw)
  To: gregkh, 20180219100906.14265-4-jgross, alexander.levin,
	andy.shevchenko, boris.ostrovsky, bp, ebiederm, hpa, keescook,
	kirill.shutemov, lenb, mingo, peterz, rafael.j.wysocki, tglx,
	torvalds, xen-devel
  Cc: stable-commits

On 02/05/18 00:33, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     x86/xen: Add pvh specific rsdp address retrieval function
> 
> to the 4.16-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      x86-xen-add-pvh-specific-rsdp-address-retrieval-function.patch
> and it can be found in the queue-4.16 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> From foo@baz Tue May  1 14:59:18 PDT 2018
> From: Juergen Gross <jgross@suse.com>
> Date: Mon, 19 Feb 2018 11:09:06 +0100
> Subject: x86/xen: Add pvh specific rsdp address retrieval function
> 
> From: Juergen Gross <jgross@suse.com>
> 
> [ Upstream commit b17d9d1df3c33a4f1d2bf397e2257aecf9dc56d4 ]
> 
> Add pvh_get_root_pointer() for Xen PVH guests to communicate the
> address of the RSDP table given to the kernel via Xen start info.
> 
> This makes the kernel boot again in PVH mode after on recent Xen the
> RSDP was moved to higher addresses. So up to that change it was pure
> luck that the legacy method to locate the RSDP was working when
> running as PVH mode.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Eric Biederman <ebiederm@xmission.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: boris.ostrovsky@oracle.com
> Cc: lenb@kernel.org
> Cc: linux-acpi@vger.kernel.org
> Cc: xen-devel@lists.xenproject.org
> Link: http://lkml.kernel.org/r/20180219100906.14265-4-jgross@suse.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for adding this patch.

For making it compile I think you'll need upstream commits
038bac2b02989acf1fc938cedcb7944c02672b9f and
dfc9327ab7c99bc13e12106448615efba833886b.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree
  2018-05-02  9:23 ` Juergen Gross
@ 2018-05-02 15:34   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-05-02 15:34 UTC (permalink / raw)
  Cc: tglx, keescook, peterz, rafael.j.wysocki,
	20180219100906.14265-4-jgross, alexander.levin, stable-commits,
	andy.shevchenko, bp, ebiederm, hpa, xen-devel, boris.ostrovsky,
	torvalds, mingo, kirill.shutemov, lenb

On Wed, May 02, 2018 at 11:23:12AM +0200, Juergen Gross wrote:
> On 02/05/18 00:33, gregkh@linuxfoundation.org wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     x86/xen: Add pvh specific rsdp address retrieval function
> > 
> > to the 4.16-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      x86-xen-add-pvh-specific-rsdp-address-retrieval-function.patch
> > and it can be found in the queue-4.16 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> > 
> > From foo@baz Tue May  1 14:59:18 PDT 2018
> > From: Juergen Gross <jgross@suse.com>
> > Date: Mon, 19 Feb 2018 11:09:06 +0100
> > Subject: x86/xen: Add pvh specific rsdp address retrieval function
> > 
> > From: Juergen Gross <jgross@suse.com>
> > 
> > [ Upstream commit b17d9d1df3c33a4f1d2bf397e2257aecf9dc56d4 ]
> > 
> > Add pvh_get_root_pointer() for Xen PVH guests to communicate the
> > address of the RSDP table given to the kernel via Xen start info.
> > 
> > This makes the kernel boot again in PVH mode after on recent Xen the
> > RSDP was moved to higher addresses. So up to that change it was pure
> > luck that the legacy method to locate the RSDP was working when
> > running as PVH mode.
> > 
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Eric Biederman <ebiederm@xmission.com>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: boris.ostrovsky@oracle.com
> > Cc: lenb@kernel.org
> > Cc: linux-acpi@vger.kernel.org
> > Cc: xen-devel@lists.xenproject.org
> > Link: http://lkml.kernel.org/r/20180219100906.14265-4-jgross@suse.com
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Thanks for adding this patch.
> 
> For making it compile I think you'll need upstream commits
> 038bac2b02989acf1fc938cedcb7944c02672b9f and
> dfc9327ab7c99bc13e12106448615efba833886b.

I'll just drop this and if Sasha thinks it is worth it, he can backport
these other two patches and resend them.  Especially as I think we
already talked about this in the past :)

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-02 15:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 22:33 Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree gregkh
2018-05-02  9:23 ` Juergen Gross
2018-05-02 15:34   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.