* [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages
@ 2015-09-09 0:32 Alistair Francis
2015-09-09 0:55 ` Peter Crosthwaite
2015-09-11 15:36 ` Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Alistair Francis @ 2015-09-09 0:32 UTC (permalink / raw)
To: qemu-devel, peter.maydell
Cc: edgar.iglesias, edgar.iglesias, crosthwaitepeter, alistair.francis
The errp and err variable have unnecessary brackets around them,
so remove the brackets.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
hw/arm/xlnx-zynqmp.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 2955f3b..2185542 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw/arm/xlnx-zynqmp.c
@@ -128,7 +128,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
qdev_prop_set_uint32(DEVICE(&s->gic), "num-cpu", XLNX_ZYNQMP_NUM_APU_CPUS);
object_property_set_bool(OBJECT(&s->gic), true, "realized", &err);
if (err) {
- error_propagate((errp), (err));
+ error_propagate(errp, err);
return;
}
assert(ARRAY_SIZE(xlnx_zynqmp_gic_regions) == XLNX_ZYNQMP_GIC_REGIONS);
@@ -173,7 +173,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
object_property_set_bool(OBJECT(&s->apu_cpu[i]), true, "realized",
&err);
if (err) {
- error_propagate((errp), (err));
+ error_propagate(errp, err);
return;
}
@@ -206,7 +206,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
object_property_set_bool(OBJECT(&s->rpu_cpu[i]), true, "realized",
&err);
if (err) {
- error_propagate((errp), (err));
+ error_propagate(errp, err);
return;
}
}
@@ -229,7 +229,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
}
object_property_set_bool(OBJECT(&s->gem[i]), true, "realized", &err);
if (err) {
- error_propagate((errp), (err));
+ error_propagate(errp, err);
return;
}
sysbus_mmio_map(SYS_BUS_DEVICE(&s->gem[i]), 0, gem_addr[i]);
@@ -240,7 +240,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
for (i = 0; i < XLNX_ZYNQMP_NUM_UARTS; i++) {
object_property_set_bool(OBJECT(&s->uart[i]), true, "realized", &err);
if (err) {
- error_propagate((errp), (err));
+ error_propagate(errp, err);
return;
}
sysbus_mmio_map(SYS_BUS_DEVICE(&s->uart[i]), 0, uart_addr[i]);
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages
2015-09-09 0:32 [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages Alistair Francis
@ 2015-09-09 0:55 ` Peter Crosthwaite
2015-09-11 15:36 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Crosthwaite @ 2015-09-09 0:55 UTC (permalink / raw)
To: Alistair Francis
Cc: Edgar Iglesias, Peter Maydell, qemu-devel@nongnu.org Developers,
Edgar E. Iglesias
On Tue, Sep 8, 2015 at 5:32 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> The errp and err variable have unnecessary brackets around them,
> so remove the brackets.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
>
> hw/arm/xlnx-zynqmp.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index 2955f3b..2185542 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -128,7 +128,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
> qdev_prop_set_uint32(DEVICE(&s->gic), "num-cpu", XLNX_ZYNQMP_NUM_APU_CPUS);
> object_property_set_bool(OBJECT(&s->gic), true, "realized", &err);
> if (err) {
> - error_propagate((errp), (err));
> + error_propagate(errp, err);
> return;
> }
> assert(ARRAY_SIZE(xlnx_zynqmp_gic_regions) == XLNX_ZYNQMP_GIC_REGIONS);
> @@ -173,7 +173,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
> object_property_set_bool(OBJECT(&s->apu_cpu[i]), true, "realized",
> &err);
> if (err) {
> - error_propagate((errp), (err));
> + error_propagate(errp, err);
> return;
> }
>
> @@ -206,7 +206,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
> object_property_set_bool(OBJECT(&s->rpu_cpu[i]), true, "realized",
> &err);
> if (err) {
> - error_propagate((errp), (err));
> + error_propagate(errp, err);
> return;
> }
> }
> @@ -229,7 +229,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
> }
> object_property_set_bool(OBJECT(&s->gem[i]), true, "realized", &err);
> if (err) {
> - error_propagate((errp), (err));
> + error_propagate(errp, err);
> return;
> }
> sysbus_mmio_map(SYS_BUS_DEVICE(&s->gem[i]), 0, gem_addr[i]);
> @@ -240,7 +240,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
> for (i = 0; i < XLNX_ZYNQMP_NUM_UARTS; i++) {
> object_property_set_bool(OBJECT(&s->uart[i]), true, "realized", &err);
> if (err) {
> - error_propagate((errp), (err));
> + error_propagate(errp, err);
> return;
> }
> sysbus_mmio_map(SYS_BUS_DEVICE(&s->uart[i]), 0, uart_addr[i]);
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages
2015-09-09 0:32 [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages Alistair Francis
2015-09-09 0:55 ` Peter Crosthwaite
@ 2015-09-11 15:36 ` Peter Maydell
2015-09-11 15:56 ` Alistair Francis
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2015-09-11 15:36 UTC (permalink / raw)
To: Alistair Francis
Cc: Edgar Iglesias, Edgar E. Iglesias, Peter Crosthwaite, QEMU Developers
On 9 September 2015 at 01:32, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> The errp and err variable have unnecessary brackets around them,
> so remove the brackets.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>
> hw/arm/xlnx-zynqmp.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages
2015-09-11 15:36 ` Peter Maydell
@ 2015-09-11 15:56 ` Alistair Francis
0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2015-09-11 15:56 UTC (permalink / raw)
To: Peter Maydell
Cc: Edgar Iglesias, Edgar E. Iglesias, Peter Crosthwaite,
QEMU Developers, Alistair Francis
On Fri, Sep 11, 2015 at 8:36 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 September 2015 at 01:32, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
>> The errp and err variable have unnecessary brackets around them,
>> so remove the brackets.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>>
>> hw/arm/xlnx-zynqmp.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>
>
> Applied to target-arm.next, thanks.
Thanks Peter and Peter
Alistair
>
> -- PMM
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-11 15:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-09 0:32 [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages Alistair Francis
2015-09-09 0:55 ` Peter Crosthwaite
2015-09-11 15:36 ` Peter Maydell
2015-09-11 15:56 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.