All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org,
	Vincent Chen <vincent.chen@sifive.com>
Subject: Re: [PATCH] riscv: sifive: fix Kconfig errata warning
Date: Sun, 6 Jun 2021 16:46:15 -0700	[thread overview]
Message-ID: <990a9263-dc33-e616-12eb-173e6872c93a@infradead.org> (raw)
In-Reply-To: <20210522212036.5513-1-rdunlap@infradead.org>

ping. anyone?
thanks.

On 5/22/21 2:20 PM, Randy Dunlap wrote:
> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
> not set, so SOC_SIFIVE should either depend on or select
> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
> warning.
> 
> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
>   Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
>   Selected by [y]:
>   - SOC_SIFIVE [=y]
> 
> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Cc: Vincent Chen <vincent.chen@sifive.com>
> ---
>  arch/riscv/Kconfig.socs |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
> +++ linux-next-20210521/arch/riscv/Kconfig.socs
> @@ -14,6 +14,7 @@ config SOC_SIFIVE
>  	select CLK_SIFIVE
>  	select CLK_SIFIVE_PRCI
>  	select SIFIVE_PLIC
> +	select RISCV_ERRATA_ALTERNATIVE
>  	select ERRATA_SIFIVE
>  	help
>  	  This enables support for SiFive SoC platform hardware.
> 


-- 
~Randy


WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org,
	Vincent Chen <vincent.chen@sifive.com>
Subject: Re: [PATCH] riscv: sifive: fix Kconfig errata warning
Date: Sun, 6 Jun 2021 16:46:15 -0700	[thread overview]
Message-ID: <990a9263-dc33-e616-12eb-173e6872c93a@infradead.org> (raw)
In-Reply-To: <20210522212036.5513-1-rdunlap@infradead.org>

ping. anyone?
thanks.

On 5/22/21 2:20 PM, Randy Dunlap wrote:
> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
> not set, so SOC_SIFIVE should either depend on or select
> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
> warning.
> 
> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
>   Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
>   Selected by [y]:
>   - SOC_SIFIVE [=y]
> 
> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Cc: Vincent Chen <vincent.chen@sifive.com>
> ---
>  arch/riscv/Kconfig.socs |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
> +++ linux-next-20210521/arch/riscv/Kconfig.socs
> @@ -14,6 +14,7 @@ config SOC_SIFIVE
>  	select CLK_SIFIVE
>  	select CLK_SIFIVE_PRCI
>  	select SIFIVE_PLIC
> +	select RISCV_ERRATA_ALTERNATIVE
>  	select ERRATA_SIFIVE
>  	help
>  	  This enables support for SiFive SoC platform hardware.
> 


-- 
~Randy


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2021-06-06 23:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 21:20 [PATCH] riscv: sifive: fix Kconfig errata warning Randy Dunlap
2021-05-22 21:20 ` Randy Dunlap
2021-06-06 23:46 ` Randy Dunlap [this message]
2021-06-06 23:46   ` Randy Dunlap
2021-06-13  0:23   ` Palmer Dabbelt
2021-06-13  0:23     ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=990a9263-dc33-e616-12eb-173e6872c93a@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.