[THERMAL] INT3403 and new 0x91 thermal events in dmesg

[THERMAL] INT3403 and new 0x91 thermal events in dmesg

[Alex Hung]

Hi,

A user reported int3403 was flooding his dmesg like following

[ 8.112761] int3403 thermal INT3403:00: Unsupported event [0x91]
[ 10.121722] int3403 thermal INT3403:00: Unsupported event [0x91]
[ 12.165233] int3403 thermal INT3403:00: Unsupported event [0x91]

Buglink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1882823

In int3403_thermal.c the events are defined up to INT3403_THERMAL_EVENT
(0x90), and thus int3403 complains 0x91 is not supported.

I did a quick search online and found this is not the only case:
https://www.spinics.net/lists/ibm-acpi-devel/msg04629.html (though the
0x91 was unrelated to this problem).

This is likely a new feature in int3403 but I wasn't able to find any
specifications or documents. Does anyone know what it is and how this
can be added to int3403_thermal.c ?

Cheers,
Alex Hung

Re: [THERMAL] INT3403 and new 0x91 thermal events in dmesg

[Zhang Rui]

On Fri, 2020-06-12 at 15:02 -0600, Alex Hung wrote:
> Hi,
> 
> A user reported int3403 was flooding his dmesg like following
> 
> [ 8.112761] int3403 thermal INT3403:00: Unsupported event [0x91]
> [ 10.121722] int3403 thermal INT3403:00: Unsupported event [0x91]
> [ 12.165233] int3403 thermal INT3403:00: Unsupported event [0x91]
> 
> Buglink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1882823
> 
> In int3403_thermal.c the events are defined up to
> INT3403_THERMAL_EVENT
> (0x90), and thus int3403 complains 0x91 is not supported.
> 
> I did a quick search online and found this is not the only case:
> https://www.spinics.net/lists/ibm-acpi-devel/msg04629.html (though
> the
> 0x91 was unrelated to this problem).
> 
> This is likely a new feature in int3403 but I wasn't able to find any
> specifications or documents. Does anyone know what it is and how this
> can be added to int3403_thermal.c ?
> 
I'm not sure if this is a new feature that we have to support or not,
but before that, we can downgrade the error message just like what we
did in 44c0c23725a1("drivers: thermal: processor_thermal: Downgrade
error message").

thanks,
rui

Re: [THERMAL] INT3403 and new 0x91 thermal events in dmesg

[Alex Hung]

On 2020-06-13 8:44 p.m., Zhang Rui wrote:
> On Fri, 2020-06-12 at 15:02 -0600, Alex Hung wrote:
>> Hi,
>>
>> A user reported int3403 was flooding his dmesg like following
>>
>> [ 8.112761] int3403 thermal INT3403:00: Unsupported event [0x91]
>> [ 10.121722] int3403 thermal INT3403:00: Unsupported event [0x91]
>> [ 12.165233] int3403 thermal INT3403:00: Unsupported event [0x91]
>>
>> Buglink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1882823
>>
>> In int3403_thermal.c the events are defined up to
>> INT3403_THERMAL_EVENT
>> (0x90), and thus int3403 complains 0x91 is not supported.
>>
>> I did a quick search online and found this is not the only case:
>> https://www.spinics.net/lists/ibm-acpi-devel/msg04629.html (though
>> the
>> 0x91 was unrelated to this problem).
>>
>> This is likely a new feature in int3403 but I wasn't able to find any
>> specifications or documents. Does anyone know what it is and how this
>> can be added to int3403_thermal.c ?
>>
> I'm not sure if this is a new feature that we have to support or not,
> but before that, we can downgrade the error message just like what we
> did in 44c0c23725a1("drivers: thermal: processor_thermal: Downgrade
> error message").

Thanks for suggestions. I will send a patch to downgrade the error message.

Would it be a good idea to cc stable?


Cheers,
Alex Hung

> 
> thanks,
> rui
> 
> 

Re: [THERMAL] INT3403 and new 0x91 thermal events in dmesg

[srinivas pandruvada]

On Sun, 2020-06-14 at 22:16 -0600, Alex Hung wrote:
> On 2020-06-13 8:44 p.m., Zhang Rui wrote:
> > On Fri, 2020-06-12 at 15:02 -0600, Alex Hung wrote:
> > > Hi,
> > > 
> > > A user reported int3403 was flooding his dmesg like following
> > > 
> > > [ 8.112761] int3403 thermal INT3403:00: Unsupported event [0x91]
> > > [ 10.121722] int3403 thermal INT3403:00: Unsupported event [0x91]
> > > [ 12.165233] int3403 thermal INT3403:00: Unsupported event [0x91]
> > > 
> > > Buglink: 
> > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1882823
> > > 
> > > In int3403_thermal.c the events are defined up to
> > > INT3403_THERMAL_EVENT
> > > (0x90), and thus int3403 complains 0x91 is not supported.
> > > 
> > > I did a quick search online and found this is not the only case:
> > > https://www.spinics.net/lists/ibm-acpi-devel/msg04629.html
> > > (though
> > > the
> > > 0x91 was unrelated to this problem).
> > > 
> > > This is likely a new feature in int3403 but I wasn't able to find
> > > any
> > > specifications or documents. Does anyone know what it is and how
> > > this
> > > can be added to int3403_thermal.c ?
> > > 
> > I'm not sure if this is a new feature that we have to support or
> > not,
> > but before that, we can downgrade the error message just like what
> > we
> > did in 44c0c23725a1("drivers: thermal: processor_thermal: Downgrade
> > error message").
> 
> Thanks for suggestions. I will send a patch to downgrade the error
> message.
> 
> Would it be a good idea to cc stable?
Downgrade and CC to stable is fine.

Thanks,
Srinivas

> 
> 
> Cheers,
> Alex Hung
> 
> > thanks,
> > rui
> > 
> >