* [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()
@ 2017-11-29 16:22 ` Vasyl Gomonovych
0 siblings, 0 replies; 5+ messages in thread
From: Vasyl Gomonovych @ 2017-11-29 16:22 UTC (permalink / raw)
To: linux-omap, linux-fbdev, dri-devel
Cc: Vasyl Gomonovych, Tomi Valkeinen, Bartlomiej Zolnierkiewicz,
Laurent Pinchart, Mark Brown, linux-kernel
Fix ptr_ret.cocci warnings:
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:676:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
index ec78d61bc551..28de56e21c74 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
@@ -673,10 +673,7 @@ static int hdmi_audio_register(struct device *dev)
dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO,
&pdata, sizeof(pdata));
- if (IS_ERR(hdmi.audio_pdev))
- return PTR_ERR(hdmi.audio_pdev);
-
- return 0;
+ return PTR_ERR_OR_ZERO(hdmi.audio_pdev);
}
/* HDMI HW IP initialisation */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()
@ 2017-11-29 16:22 ` Vasyl Gomonovych
0 siblings, 0 replies; 5+ messages in thread
From: Vasyl Gomonovych @ 2017-11-29 16:22 UTC (permalink / raw)
To: linux-omap, linux-fbdev, dri-devel
Cc: Vasyl Gomonovych, Tomi Valkeinen, Bartlomiej Zolnierkiewicz,
Laurent Pinchart, Mark Brown, linux-kernel
Fix ptr_ret.cocci warnings:
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:676:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
index ec78d61bc551..28de56e21c74 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
@@ -673,10 +673,7 @@ static int hdmi_audio_register(struct device *dev)
dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO,
&pdata, sizeof(pdata));
- if (IS_ERR(hdmi.audio_pdev))
- return PTR_ERR(hdmi.audio_pdev);
-
- return 0;
+ return PTR_ERR_OR_ZERO(hdmi.audio_pdev);
}
/* HDMI HW IP initialisation */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()
2017-11-29 16:22 ` Vasyl Gomonovych
(?)
@ 2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 13:58 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: linux-omap, linux-fbdev, dri-devel, Tomi Valkeinen,
Laurent Pinchart, Mark Brown, linux-kernel
On Wednesday, November 29, 2017 05:22:48 PM Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:676:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()
@ 2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 13:58 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: linux-fbdev, Mark Brown, linux-kernel, dri-devel, Tomi Valkeinen,
Laurent Pinchart, linux-omap
On Wednesday, November 29, 2017 05:22:48 PM Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:676:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()
@ 2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 13:58 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: linux-fbdev, Mark Brown, linux-kernel, dri-devel, Tomi Valkeinen,
Laurent Pinchart, linux-omap
On Wednesday, November 29, 2017 05:22:48 PM Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:676:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-04 13:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171129162304epcas5p4874d26ebbc84f3e2a9804548b6deb762@epcas5p4.samsung.com>
2017-11-29 16:22 ` [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 16:22 ` Vasyl Gomonovych
2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
2018-01-04 13:58 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.