From: Tudor Ambarus <tudor.ambarus@microchip.com> To: <boris.brezillon@bootlin.com> Cc: <marek.vasut@gmail.com>, <dwmw2@infradead.org>, <computersforpeace@gmail.com>, <richard@nod.at>, <linux-mtd@lists.infradead.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <cyrille.pitchen@microchip.com>, <nicolas.ferre@microchip.com>, <Cristian.Birsan@microchip.com> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Date: Mon, 17 Sep 2018 20:03:21 +0300 [thread overview] Message-ID: <9953d6e5-1049-5645-31e3-7c05071c09aa@microchip.com> (raw) In-Reply-To: <20180911154007.17195-2-tudor.ambarus@microchip.com> Hi, Boris, On 09/11/2018 06:40 PM, Tudor Ambarus wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c [cut] > /* I missed to use the opening comment mark for kernel-doc comments: "/**". This observation applies to all newly introduced function descriptions, in this patch and in the next as well. > + * spi_nor_div_by_erase_size() - calculate remainder and update new dividend > + * @erase: pointer to a structure that describes a SPI NOR erase type > + * @dividend: dividend value > + * @remainder: pointer to u32 remainder (will be updated) > + * > + * Returns two values: remainder and the new dividend I should have used "Return: describe the return value" in order to be aligned with the example from kernel-doc. This also applies to most of the function descriptions. [cut] > +/* > + *spi_nor_init_uniform_erase_map() - Initialize uniform erase map add a space after that "*" I will gladly submit a new version if there are no other comments. Please let me know. Cheers, ta
WARNING: multiple messages have this Message-ID (diff)
From: tudor.ambarus@microchip.com (Tudor Ambarus) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Date: Mon, 17 Sep 2018 20:03:21 +0300 [thread overview] Message-ID: <9953d6e5-1049-5645-31e3-7c05071c09aa@microchip.com> (raw) In-Reply-To: <20180911154007.17195-2-tudor.ambarus@microchip.com> Hi, Boris, On 09/11/2018 06:40 PM, Tudor Ambarus wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c [cut] > /* I missed to use the opening comment mark for kernel-doc comments: "/**". This observation applies to all newly introduced function descriptions, in this patch and in the next as well. > + * spi_nor_div_by_erase_size() - calculate remainder and update new dividend > + * @erase: pointer to a structure that describes a SPI NOR erase type > + * @dividend: dividend value > + * @remainder: pointer to u32 remainder (will be updated) > + * > + * Returns two values: remainder and the new dividend I should have used "Return: describe the return value" in order to be aligned with the example from kernel-doc. This also applies to most of the function descriptions. [cut] > +/* > + *spi_nor_init_uniform_erase_map() - Initialize uniform erase map add a space after that "*" I will gladly submit a new version if there are no other comments. Please let me know. Cheers, ta
next prev parent reply other threads:[~2018-09-17 17:03 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-11 15:40 [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 15:40 ` [PATCH v3 1/2] mtd: spi-nor: " Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 18:55 ` Marek Vasut 2018-09-11 18:55 ` Marek Vasut 2018-09-17 17:03 ` Tudor Ambarus [this message] 2018-09-17 17:03 ` Tudor Ambarus 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:17 ` Boris Brezillon 2018-10-16 12:17 ` Boris Brezillon 2018-10-16 12:17 ` Boris Brezillon 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:52 ` Boris Brezillon 2018-10-22 11:52 ` Boris Brezillon 2018-10-22 11:52 ` Boris Brezillon 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-17 9:06 ` Cyrille Pitchen 2018-10-17 9:06 ` Cyrille Pitchen 2018-10-17 9:06 ` Cyrille Pitchen 2018-09-11 15:40 ` [PATCH v3 2/2] mtd: spi-nor: parse SFDP Sector Map Parameter Table Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 18:56 ` Marek Vasut 2018-09-11 18:56 ` Marek Vasut 2018-09-18 13:09 ` [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Boris Brezillon 2018-09-18 13:09 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9953d6e5-1049-5645-31e3-7c05071c09aa@microchip.com \ --to=tudor.ambarus@microchip.com \ --cc=Cristian.Birsan@microchip.com \ --cc=boris.brezillon@bootlin.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@microchip.com \ --cc=dwmw2@infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=nicolas.ferre@microchip.com \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.