All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: fix call_kern.cocci warnings (fwd)
@ 2018-10-24 18:57 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2018-10-24 18:57 UTC (permalink / raw)
  To: Chunming Zhou
  Cc: kbuild-all, intel-gfx, dri-devel, Christian König,
	Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie,
	dri-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

The containing function is called with a spin_lock held, so GFP_KERNEL
can't be used.

julia

---------- Forwarded message ----------
Date: Tue, 23 Oct 2018 17:14:25 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] drm: fix call_kern.cocci warnings

CC: kbuild-all@01.org
CC: intel-gfx@lists.freedesktop.org
CC: dri-devel@lists.freedesktop.org
TO: Chunming Zhou <david1.zhou@amd.com>
CC: "Christian König" <easy2remember.chk@googlemail.com>
CC: Gustavo Padovan <gustavo@padovan.org>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Sean Paul <sean@poorly.run>
CC: David Airlie <airlied@linux.ie>
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org

From: kbuild test robot <fengguang.wu@intel.com>

drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line 389 but uses GFP_KERNEL

 Find functions that refer to GFP_KERNEL but are called with locks held.

Semantic patch information:
 The proposed change of converting the GFP_KERNEL is not necessarily the
 correct one.  It may be desired to unlock the lock, or to not call the
 function under the lock in the first place.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
CC: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

tree:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
head:   8d7ffd2298c607c3e1a16f94d51450d7940fd6a7
commit: 48197bc564c7a1888c86024a1ba4f956e0ec2300 [1968/2033] drm: add syncobj timeline support v9
:::::: branch date: 4 hours ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 drm_syncobj.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -199,7 +199,7 @@ static struct dma_fence
 	    (point <= syncobj->timeline)) {
 		struct drm_syncobj_stub_fence *fence =
 			kzalloc(sizeof(struct drm_syncobj_stub_fence),
-				GFP_KERNEL);
+				GFP_ATOMIC);

 		if (!fence)
 			return NULL;

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2018-10-25  8:32 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 18:57 [PATCH] drm: fix call_kern.cocci warnings (fwd) Julia Lawall
2018-10-24 18:57 ` Julia Lawall
2018-10-24 19:19 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-10-24 19:47 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-25  1:24 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-25  1:28 ` [PATCH] " Zhou, David(ChunMing)
2018-10-25  1:28   ` Zhou, David(ChunMing)
2018-10-25  6:53   ` Christian König
2018-10-25  7:51     ` Maarten Lankhorst
2018-10-25  7:57       ` Koenig, Christian
2018-10-25  7:57         ` Koenig, Christian
2018-10-25  8:31         ` zhoucm1
2018-10-25  8:31           ` zhoucm1
2018-10-25  7:50 ` Maarten Lankhorst
2018-10-25  7:50   ` Maarten Lankhorst
2018-10-25  7:55   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.