From: paul.devriendt@amd.com
To: linux@brodo.de, davej@codemonkey.org.uk,
cpufreq@www.linux.org.uk, mark.langsdorf@amd.com
Subject: RE: [PATCH] BUGFIX for powernow-k8
Date: Tue, 4 Nov 2003 11:29:15 -0600 [thread overview]
Message-ID: <99F2150714F93F448942F9A9F112634C080EF215@txexmtae.amd.com> (raw)
Ok, thanks Dominik. I am intending to fix the policy stuff to use
the callbacks in the next major rev of the driver, which I am hoping
to get out in December. Paul.
> -----Original Message-----
> From: Dominik Brodowski [mailto:linux@brodo.de]
> Sent: Tuesday, November 04, 2003 8:51 AM
> To: davej@codemonkey.org.uk; Devriendt, Paul; cpufreq@www.linux.org.uk
> Subject: [PATCH] BUGFIX for powernow-k8
>
>
> Hi Dave, Paul,
>
> Here is an important bugfix for powernow-k8.c in its current form
> (2.6.0-test9).
>
> Problem description:
> As the powernow-k8 driver uses the ->target and not the
> ->setpolicy callback, cpufreq_policy->policy is always zero.
> Checking for it
> in the powernow-k8 driver always returned "false". So we can
> easily remove
> this invalid check (and the #warning added to denote this).
>
> diff -ruN
> linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> --- linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> 2003-11-04 15:27:33.609957704 +0100
> +++ linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> 2003-11-04 15:39:36.410075384 +0100
> @@ -935,10 +935,8 @@
> return -ENODEV;
> }
>
> -#warning pol->policy is in undefined state here
> res = find_match(&targ, &min, &max,
> - pol->policy == CPUFREQ_POLICY_POWERSAVE ?
> - SEARCH_DOWN : SEARCH_UP, 0, 0);
> + SEARCH_DOWN, 0, 0);
> if (!res) {
> pol->min = min * 1000;
> pol->max = max * 1000;
>
next reply other threads:[~2003-11-04 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-04 17:29 paul.devriendt [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-11-04 14:51 [PATCH] BUGFIX for powernow-k8 Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99F2150714F93F448942F9A9F112634C080EF215@txexmtae.amd.com \
--to=paul.devriendt@amd.com \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=linux@brodo.de \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.