RE: [PATCH] BUGFIX for powernow-k8

RE: [PATCH] BUGFIX for powernow-k8

[paul.devriendt]

Ok, thanks Dominik. I am intending to fix the policy stuff to use
the callbacks in the next major rev of the driver, which I am hoping 
to get out in December. Paul.

> -----Original Message-----
> From: Dominik Brodowski [mailto:linux@brodo.de]
> Sent: Tuesday, November 04, 2003 8:51 AM
> To: davej@codemonkey.org.uk; Devriendt, Paul; cpufreq@www.linux.org.uk
> Subject: [PATCH] BUGFIX for powernow-k8
> 
> 
> Hi Dave, Paul,
> 
> Here is an important bugfix for powernow-k8.c in its current form
> (2.6.0-test9).
> 
> Problem description:
> As the powernow-k8 driver uses the ->target and not the 
> ->setpolicy callback, cpufreq_policy->policy is always zero. 
> Checking for it
> in the powernow-k8 driver always returned "false". So we can 
> easily remove
> this invalid check (and the #warning added to denote this).
> 
> diff -ruN 
> linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c 
> linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> --- linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	
> 2003-11-04 15:27:33.609957704 +0100
> +++ linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	
> 2003-11-04 15:39:36.410075384 +0100
> @@ -935,10 +935,8 @@
>  		return -ENODEV;
>  	}
>  
> -#warning pol->policy is in undefined state here
>  	res = find_match(&targ, &min, &max,
> -			 pol->policy == CPUFREQ_POLICY_POWERSAVE ?
> -			 SEARCH_DOWN : SEARCH_UP, 0, 0);
> +			 SEARCH_DOWN, 0, 0);
>  	if (!res) {
>  		pol->min = min * 1000;
>  		pol->max = max * 1000;
> 

[PATCH] BUGFIX for powernow-k8

[Dominik Brodowski]

[-- Attachment #1.1: Type: text/plain, Size: 1027 bytes --]

Hi Dave, Paul,

Here is an important bugfix for powernow-k8.c in its current form
(2.6.0-test9).

Problem description:
As the powernow-k8 driver uses the ->target and not the 
->setpolicy callback, cpufreq_policy->policy is always zero. Checking for it
in the powernow-k8 driver always returned "false". So we can easily remove
this invalid check (and the #warning added to denote this).

diff -ruN linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
--- linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	2003-11-04 15:27:33.609957704 +0100
+++ linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	2003-11-04 15:39:36.410075384 +0100
@@ -935,10 +935,8 @@
 		return -ENODEV;
 	}
 
-#warning pol->policy is in undefined state here
 	res = find_match(&targ, &min, &max,
-			 pol->policy == CPUFREQ_POLICY_POWERSAVE ?
-			 SEARCH_DOWN : SEARCH_UP, 0, 0);
+			 SEARCH_DOWN, 0, 0);
 	if (!res) {
 		pol->min = min * 1000;
 		pol->max = max * 1000;

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq