From: Richard Henderson <richard.henderson@linaro.org>
To: Stafford Horne <shorne@gmail.com>,
QEMU Development <qemu-devel@nongnu.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target/openrisc: Fix delay slot exception flag to match spec
Date: Sun, 1 Jul 2018 07:19:37 -0700 [thread overview]
Message-ID: <99a76cbb-c711-70f2-75db-a966259438ff@linaro.org> (raw)
In-Reply-To: <20180701051147.31649-1-shorne@gmail.com>
On 06/30/2018 10:11 PM, Stafford Horne wrote:
> The delay slot exception flag is only set on the SR register during
> exception. Previously it was being set on both the ESR and SR this
> caused QEMU to differ from the spec. The was apparent as the linux
> kernel had a bug where it could boot on QEMU but not on real hardware.
>
> The fixed logic now matches hardware.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> target/openrisc/interrupt.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [Qemu-devel] [PATCH] target/openrisc: Fix delay slot exception flag to match spec
Date: Sun, 1 Jul 2018 07:19:37 -0700 [thread overview]
Message-ID: <99a76cbb-c711-70f2-75db-a966259438ff@linaro.org> (raw)
In-Reply-To: <20180701051147.31649-1-shorne@gmail.com>
On 06/30/2018 10:11 PM, Stafford Horne wrote:
> The delay slot exception flag is only set on the SR register during
> exception. Previously it was being set on both the ESR and SR this
> caused QEMU to differ from the spec. The was apparent as the linux
> kernel had a bug where it could boot on QEMU but not on real hardware.
>
> The fixed logic now matches hardware.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> target/openrisc/interrupt.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-07-01 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 5:11 [Qemu-devel] [PATCH] target/openrisc: Fix delay slot exception flag to match spec Stafford Horne
2018-07-01 5:11 ` [OpenRISC] " Stafford Horne
2018-07-01 14:19 ` Richard Henderson [this message]
2018-07-01 14:19 ` [OpenRISC] [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a76cbb-c711-70f2-75db-a966259438ff@linaro.org \
--to=richard.henderson@linaro.org \
--cc=openrisc@lists.librecores.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.