From: Joao Pinto <Joao.Pinto@synopsys.com> To: <subhashj@codeaurora.org>, Kiwoong Kim <kwmad.kim@samsung.com> Cc: "'Shaun Tancheff'" <shaun.tancheff@seagate.com>, "'Joao Pinto'" <Joao.Pinto@synopsys.com>, <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-scsi-owner@vger.kernel.org> Subject: Re: UFS API in the kernel Date: Wed, 28 Sep 2016 10:06:00 +0100 [thread overview] Message-ID: <99ac538d-5123-a58b-247d-160176f63a3d@synopsys.com> (raw) In-Reply-To: <7275e74a9689721ea612fbc6eca555be@codeaurora.org> Hi Subhash, On 9/28/2016 12:05 AM, subhashj@codeaurora.org wrote: > Hi Joao, > > > On 2016-09-26 18:10, Kiwoong Kim wrote: >> Hi. >> >> If you want to declare some things for user interface, >> is it be better to put those thing include/uapi/linux/ than include/linux? >> >> Agreed with Mr. Pinto's opinion with respect to implementing additional ioctls. > > Yes, "scsi_host_template" allows the LLD's to export their ioctl callback and > then you can use the sg interface to issue UFS specific ioctls. We had > implemented similar ioctl for our use, here is the reference code: > https://source.codeaurora.org/quic/la/kernel/msm-3.18/tree/drivers/scsi/ufs/ufshcd.c?h=LA.HB.1.1.1.c2#n6791. > This was mainly done to export the UFS query request interface to user space. > Declarations where exported under include/uapi/scsi/ufs/ . If you want to build > upon this already existing functionality, i can post the formal patch on mailing > list. Yes, of course I have interest on building on top of what you have done already. Did yu submit this patch to the kernel already? Could you please send me the patch and kernel version to apply? Thanks, Joao > > Regards, > Subhash > > >> >> Regards. >> >>> -----Original Message----- >>> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- >>> owner@vger.kernel.org] On Behalf Of Shaun Tancheff >>> Sent: Tuesday, September 27, 2016 4:23 AM >>> To: Joao Pinto >>> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org >>> Subject: Re: UFS API in the kernel >>> >>> On Thu, Sep 22, 2016 at 10:21 AM, Joao Pinto <Joao.Pinto@synopsys.com> >>> wrote: >>> > Hi! >>> > >>> > I am designing an application that has the goal to be an utility for >>> > Unipro and UFS testing purposes. This application is going to run on >>> > top of a recent Linux Kernel containing the new UFS stack (including the >>> new DWC drivers). >>> > >>> > I am considering doing the following: >>> > a) Create a new config item called CONFIG_UFS_CHARDEV which is going >>> > to create a char device responsible to make some IOCTL available for >>> > user-space applications >>> > b) Create a linux/ufs.h header file that contains data structures >>> > declarations that will be needed in user-space applications >>> >>> I am not very familiar with UFS devices, that said you should have an sgX >>> chardev being created already so you can handle SG_IO requests. >>> There also appear to be some sysfs entries being created. >>> >>> So between sg and sysfs you should be able to handle any user-space out of >>> band requests without resorting to making a new chardev. >>> >>> Adding more sysfs entries, if you need them, should be fine. >>> >>> You may find it easier to expand on the existing interfaces than to get >>> consensus on a new driver and ioctls. >>> >>> Hope this helps, >>> Shaun >>> >>> > Could you please advise me about what the correct approach should be >>> > to make it as standard as possible and usable in the future? >>> > >>> > Thank you very much for your help! >>> > >>> > regards, >>> > Joao >>> > -- >>> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" >>> > in the body of a message to majordomo@vger.kernel.org More majordomo >>> > info at >>> > https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_ma >>> > jordomo-2Dinfo.html&d=DQICaQ&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ug >>> > l8V50qIHLe856QW0qfG3WVYGOrWzA&m=vJFB6pCywWtdvkgHz9Vc0jQz0xzeyZlr-7eCWY >>> > u88nM&s=yiQLPFpqmMrbqLZz1Jb3aNqOje2dRMLJHEzUDobwcXc&e= >>> >>> >>> >>> -- >>> Shaun Tancheff >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >>> the body of a message to majordomo@vger.kernel.org More majordomo info at >>> http://vger.kernel.org/majordomo-info.html >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joao Pinto <Joao.Pinto@synopsys.com> To: subhashj@codeaurora.org, Kiwoong Kim <kwmad.kim@samsung.com> Cc: 'Shaun Tancheff' <shaun.tancheff@seagate.com>, 'Joao Pinto' <Joao.Pinto@synopsys.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org Subject: Re: UFS API in the kernel Date: Wed, 28 Sep 2016 10:06:00 +0100 [thread overview] Message-ID: <99ac538d-5123-a58b-247d-160176f63a3d@synopsys.com> (raw) In-Reply-To: <7275e74a9689721ea612fbc6eca555be@codeaurora.org> Hi Subhash, On 9/28/2016 12:05 AM, subhashj@codeaurora.org wrote: > Hi Joao, > > > On 2016-09-26 18:10, Kiwoong Kim wrote: >> Hi. >> >> If you want to declare some things for user interface, >> is it be better to put those thing include/uapi/linux/ than include/linux? >> >> Agreed with Mr. Pinto's opinion with respect to implementing additional ioctls. > > Yes, "scsi_host_template" allows the LLD's to export their ioctl callback and > then you can use the sg interface to issue UFS specific ioctls. We had > implemented similar ioctl for our use, here is the reference code: > https://source.codeaurora.org/quic/la/kernel/msm-3.18/tree/drivers/scsi/ufs/ufshcd.c?h=LA.HB.1.1.1.c2#n6791. > This was mainly done to export the UFS query request interface to user space. > Declarations where exported under include/uapi/scsi/ufs/ . If you want to build > upon this already existing functionality, i can post the formal patch on mailing > list. Yes, of course I have interest on building on top of what you have done already. Did yu submit this patch to the kernel already? Could you please send me the patch and kernel version to apply? Thanks, Joao > > Regards, > Subhash > > >> >> Regards. >> >>> -----Original Message----- >>> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- >>> owner@vger.kernel.org] On Behalf Of Shaun Tancheff >>> Sent: Tuesday, September 27, 2016 4:23 AM >>> To: Joao Pinto >>> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org >>> Subject: Re: UFS API in the kernel >>> >>> On Thu, Sep 22, 2016 at 10:21 AM, Joao Pinto <Joao.Pinto@synopsys.com> >>> wrote: >>> > Hi! >>> > >>> > I am designing an application that has the goal to be an utility for >>> > Unipro and UFS testing purposes. This application is going to run on >>> > top of a recent Linux Kernel containing the new UFS stack (including the >>> new DWC drivers). >>> > >>> > I am considering doing the following: >>> > a) Create a new config item called CONFIG_UFS_CHARDEV which is going >>> > to create a char device responsible to make some IOCTL available for >>> > user-space applications >>> > b) Create a linux/ufs.h header file that contains data structures >>> > declarations that will be needed in user-space applications >>> >>> I am not very familiar with UFS devices, that said you should have an sgX >>> chardev being created already so you can handle SG_IO requests. >>> There also appear to be some sysfs entries being created. >>> >>> So between sg and sysfs you should be able to handle any user-space out of >>> band requests without resorting to making a new chardev. >>> >>> Adding more sysfs entries, if you need them, should be fine. >>> >>> You may find it easier to expand on the existing interfaces than to get >>> consensus on a new driver and ioctls. >>> >>> Hope this helps, >>> Shaun >>> >>> > Could you please advise me about what the correct approach should be >>> > to make it as standard as possible and usable in the future? >>> > >>> > Thank you very much for your help! >>> > >>> > regards, >>> > Joao >>> > -- >>> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" >>> > in the body of a message to majordomo@vger.kernel.org More majordomo >>> > info at >>> > https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_ma >>> > jordomo-2Dinfo.html&d=DQICaQ&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ug >>> > l8V50qIHLe856QW0qfG3WVYGOrWzA&m=vJFB6pCywWtdvkgHz9Vc0jQz0xzeyZlr-7eCWY >>> > u88nM&s=yiQLPFpqmMrbqLZz1Jb3aNqOje2dRMLJHEzUDobwcXc&e= >>> >>> >>> >>> -- >>> Shaun Tancheff >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >>> the body of a message to majordomo@vger.kernel.org More majordomo info at >>> http://vger.kernel.org/majordomo-info.html >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-28 9:37 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-22 15:21 UFS API in the kernel Joao Pinto 2016-09-26 19:22 ` Shaun Tancheff 2016-09-27 1:10 ` Kiwoong Kim 2016-09-27 23:05 ` subhashj 2016-09-28 9:06 ` Joao Pinto [this message] 2016-09-28 9:06 ` Joao Pinto 2016-09-28 9:19 ` Joao Pinto 2016-09-28 9:19 ` Joao Pinto 2016-09-28 9:57 ` Joao Pinto 2016-09-28 9:57 ` Joao Pinto 2016-09-28 22:46 ` subhashj 2016-09-28 23:04 ` subhashj
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=99ac538d-5123-a58b-247d-160176f63a3d@synopsys.com \ --to=joao.pinto@synopsys.com \ --cc=kwmad.kim@samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi-owner@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=shaun.tancheff@seagate.com \ --cc=subhashj@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.