All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Yao HongBo <yaohongbo@huawei.com>,
	linuxarm@huawei.com, yangyingliang@huawei.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] irqchip/gicv3-its: fix some definitions of inner cacheability attributes
Date: Tue, 16 Apr 2019 09:06:28 +0100	[thread overview]
Message-ID: <99bf3b0d-1814-7d01-0e25-5fdf6af6df04@arm.com> (raw)
In-Reply-To: <311479a8-0d6f-ec17-8f51-a4545e0929b1@huawei.com>

Hi Hongbo,

On 16/04/2019 02:14, Yao HongBo wrote:
> Hi Marc,
> 
> sorry for ping you...
> 
> What's your suggestion for this patch? I look forward to your reply.

This patch looks fine, although it doesn't fix anything as far as I know
(doing write-through instead of write-back cannot lead to any data loss,
and nobody reported any performance issue because of this typo).

I plan to queue it for 5.2.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Yao HongBo <yaohongbo@huawei.com>,
	linuxarm@huawei.com, yangyingliang@huawei.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] irqchip/gicv3-its: fix some definitions of inner cacheability attributes
Date: Tue, 16 Apr 2019 09:06:28 +0100	[thread overview]
Message-ID: <99bf3b0d-1814-7d01-0e25-5fdf6af6df04@arm.com> (raw)
In-Reply-To: <311479a8-0d6f-ec17-8f51-a4545e0929b1@huawei.com>

Hi Hongbo,

On 16/04/2019 02:14, Yao HongBo wrote:
> Hi Marc,
> 
> sorry for ping you...
> 
> What's your suggestion for this patch? I look forward to your reply.

This patch looks fine, although it doesn't fix anything as far as I know
(doing write-through instead of write-back cannot lead to any data loss,
and nobody reported any performance issue because of this typo).

I plan to queue it for 5.2.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-16  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 14:01 [PATCH v2] irqchip/gicv3-its: fix some definitions of inner cacheability attributes Hongbo Yao
2019-04-08 14:01 ` Hongbo Yao
2019-04-16  1:14 ` Yao HongBo
2019-04-16  1:14   ` Yao HongBo
2019-04-16  8:06   ` Marc Zyngier [this message]
2019-04-16  8:06     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99bf3b0d-1814-7d01-0e25-5fdf6af6df04@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=yangyingliang@huawei.com \
    --cc=yaohongbo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.