* [PATCH] NFC: nxp-nci: remove unnecessary label
@ 2021-06-18 7:44 samirweng1979
2021-06-18 8:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: samirweng1979 @ 2021-06-18 7:44 UTC (permalink / raw)
To: charles.gorand, krzysztof.kozlowski; +Cc: netdev, linux-kernel, wengjianfeng
From: wengjianfeng <wengjianfeng@yulong.com>
Label chunk_exit is unnecessary, so we delete it and
directly return -ENOMEM.
Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
---
drivers/nfc/nxp-nci/firmware.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/nfc/nxp-nci/firmware.c b/drivers/nfc/nxp-nci/firmware.c
index dae0c80..119bf30 100644
--- a/drivers/nfc/nxp-nci/firmware.c
+++ b/drivers/nfc/nxp-nci/firmware.c
@@ -95,10 +95,8 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info)
int r;
skb = nci_skb_alloc(info->ndev, info->max_payload, GFP_KERNEL);
- if (!skb) {
- r = -ENOMEM;
- goto chunk_exit;
- }
+ if (!skb)
+ return -ENOMEM;
chunk_len = info->max_payload - NXP_NCI_FW_HDR_LEN - NXP_NCI_FW_CRC_LEN;
remaining_len = fw_info->frame_size - fw_info->written;
@@ -124,7 +122,6 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info)
kfree_skb(skb);
-chunk_exit:
return r;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFC: nxp-nci: remove unnecessary label
2021-06-18 7:44 [PATCH] NFC: nxp-nci: remove unnecessary label samirweng1979
@ 2021-06-18 8:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-18 8:20 UTC (permalink / raw)
To: samirweng1979, charles.gorand; +Cc: netdev, linux-kernel, wengjianfeng
On 18/06/2021 09:44, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> Label chunk_exit is unnecessary, so we delete it and
> directly return -ENOMEM.
There is no plural here, no collective "we". Please, use simple statements:
"Remove unnecessary label chunk_exit and return directly."
You could add here the explanation for question "why doing this?", e.g.
"Simplify the code by removing unnecessary label chunk_exit and
returning directly."
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> ---
> drivers/nfc/nxp-nci/firmware.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nfc/nxp-nci/firmware.c b/drivers/nfc/nxp-nci/firmware.c
> index dae0c80..119bf30 100644
> --- a/drivers/nfc/nxp-nci/firmware.c
> +++ b/drivers/nfc/nxp-nci/firmware.c
> @@ -95,10 +95,8 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info)
> int r;
>
> skb = nci_skb_alloc(info->ndev, info->max_payload, GFP_KERNEL);
> - if (!skb) {
> - r = -ENOMEM;
> - goto chunk_exit;
> - }
> + if (!skb)
> + return -ENOMEM;
>
> chunk_len = info->max_payload - NXP_NCI_FW_HDR_LEN - NXP_NCI_FW_CRC_LEN;
> remaining_len = fw_info->frame_size - fw_info->written;
> @@ -124,7 +122,6 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info)
>
> kfree_skb(skb);
>
> -chunk_exit:
> return r;
> }
>
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 7:44 [PATCH] NFC: nxp-nci: remove unnecessary label samirweng1979
2021-06-18 8:20 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.