From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com>
To: Michal Simek <michal.simek@amd.com>, u-boot@lists.denx.de
Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Subject: Re: [PATCH 09/10] tools: zynqmp_psu_init_minimize: Add serdes_illcalib forward declaration
Date: Mon, 20 Jun 2022 15:38:40 +0200 [thread overview]
Message-ID: <99d03a39-dfb7-2667-af7b-84d6949d7be0@weidmueller.com> (raw)
In-Reply-To: <34e16b11-8e27-7557-aae3-795d49a4fc68@amd.com>
Am 20.06.2022 um 09:18 schrieb Michal Simek:
> On 6/20/22 09:07, Stefan Herbrechtsmeier wrote:
>> Am 16.06.2022 um 17:13 schrieb Michal Simek:
>>> On 6/8/22 18:20, Stefan Herbrechtsmeier wrote:
>>>> [CAUTION: External Email]
>>>>
>>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> A forward declaration for the serdes_illcalib function.
>>>>
>>>> Signed-off-by: Stefan Herbrechtsmeier
>>>> <stefan.herbrechtsmeier@weidmueller.com>
>>>> ---
>>>>
>>>> tools/zynqmp_psu_init_minimize.sh | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/tools/zynqmp_psu_init_minimize.sh
>>>> b/tools/zynqmp_psu_init_minimize.sh
>>>> index 31fbeac327..8411065e13 100755
>>>> --- a/tools/zynqmp_psu_init_minimize.sh
>>>> +++ b/tools/zynqmp_psu_init_minimize.sh
>>>> @@ -108,6 +108,11 @@ cat << EOF >${TMP}
>>>> #include <asm/arch/psu_init_gpl.h>
>>>> #include <xil_io.h>
>>>>
>>>> +static int serdes_illcalib(u32 lane3_protocol, u32 lane3_rate,
>>>> + u32 lane2_protocol, u32 lane2_rate,
>>>> + u32 lane1_protocol, u32 lane1_rate,
>>>> + u32 lane0_protocol, u32 lane0_rate);
>>>> +
>>>
>>> Better to resort that functions to avoid these additional lines.
>>
>> Do you propose to move the serdes_illcalib and
>> serdes_illcalib_pcie_gen1 functions via sed?
>
> swapping that functions should be enough. Whatever tool which does this
> job is fine.
Does the swap need to check for the serdes_illcalib function inside the
psu_serdes_init_data function or is a general reorder okay?
>> The psu_init_gpl.c for e-a2197-00-revA, zcu208-revA and zcu216-revA
>> already use a forward declaration. Would it be okay to add the forward
>> declaration if the function is used inside the source file?
>
> Better to just fix this. Can you please send the patch?
The e-a2197-00-revA/psu_init_gpl.c file has an additional forward
declaration of the dpll_prog function.
Regards
Stefan
next prev parent reply other threads:[~2022-06-20 13:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 16:20 [PATCH 00/10] xilinx: zynqmp: Support foreign vendor boards Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 01/10] firmware: firmware-zynqmp: Check if rx channel dev pointer is valid Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 02/10] firmware: firmware-zynqmp: Probe driver before use Stefan Herbrechtsmeier
2022-06-16 14:22 ` Michal Simek
2022-06-20 6:40 ` Stefan Herbrechtsmeier
2022-06-20 6:51 ` Michal Simek
2022-06-20 9:33 ` Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 03/10] soc: xilinx: zynqmp: Add machine identification support Stefan Herbrechtsmeier
2022-06-17 10:41 ` Michal Simek
2022-06-20 9:16 ` Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 04/10] xilinx: zynqmp: Use soc machine function to get silicon idcode name Stefan Herbrechtsmeier
2022-06-17 10:41 ` Michal Simek
2022-06-08 16:20 ` [PATCH 05/10] xilinx: cpuinfo: Print soc machine Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 06/10] xilinx: common: Separate display cpu info function Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 07/10] xilinx: zynqmp: make spi flash support optional Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 08/10] tools: zynqmp_psu_init_minimize: Remove low level uart settings Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 09/10] tools: zynqmp_psu_init_minimize: Add serdes_illcalib forward declaration Stefan Herbrechtsmeier
2022-06-16 15:13 ` Michal Simek
2022-06-20 7:07 ` Stefan Herbrechtsmeier
2022-06-20 7:18 ` Michal Simek
2022-06-20 13:38 ` Stefan Herbrechtsmeier [this message]
2022-06-20 13:53 ` Michal Simek
2022-06-08 16:20 ` [PATCH 10/10] xilinx: zynqmp: Support vendor specific board_init Stefan Herbrechtsmeier
2022-06-16 15:12 ` Michal Simek
2022-06-20 6:48 ` Stefan Herbrechtsmeier
2022-06-20 6:53 ` Michal Simek
2022-06-20 9:36 ` Stefan Herbrechtsmeier
2022-06-17 11:06 ` [PATCH 00/10] xilinx: zynqmp: Support foreign vendor boards Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d03a39-dfb7-2667-af7b-84d6949d7be0@weidmueller.com \
--to=stefan.herbrechtsmeier-oss@weidmueller.com \
--cc=michal.simek@amd.com \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.