All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com>
To: Michal Simek <michal.simek@amd.com>, u-boot@lists.denx.de
Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
	Adrian Fiergolski <adrian.fiergolski@fastree3d.com>,
	Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	T Karthik Reddy <t.karthik.reddy@xilinx.com>
Subject: Re: [PATCH 02/10] firmware: firmware-zynqmp: Probe driver before use
Date: Mon, 20 Jun 2022 11:33:20 +0200	[thread overview]
Message-ID: <271d770a-a69a-4438-d8a0-31c4b3784859@weidmueller.com> (raw)
In-Reply-To: <fed170c2-347e-3158-5264-ebdbc55c468e@amd.com>



Am 20.06.2022 um 08:51 schrieb Michal Simek:
> Hi,
> 
> On 6/20/22 08:40, Stefan Herbrechtsmeier wrote:
>> Am 16.06.2022 um 16:22 schrieb Michal Simek:
>>> On 6/8/22 18:20, Stefan Herbrechtsmeier wrote:
>>>> [CAUTION: External Email]
>>>>
>>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> Probe the driver before use to ensure that the global data are valid.
>>>
>>> It is not clear what the issue is. And this function is called in SPL 
>>> or EL3 and likely multiple times.
>>> Can you please clarify?
>>
>> The driver only works if it is used after u-boot,dm-pre-reloc. This 
>> change is needed to support a usage by other drivers like 
>> xlnx,zynqmp-firmware.
> 
> Can you please describe the case, execution path where it is used before?

I released the problem with the soc_xilinx_zynqmp driver. The driver was 
probed before the firmware-zynqmp driver.

At the moment every user of xilinx_pm_request function have to ensure 
that the firmware-zynqmp driver was probed.

> 
> Also that calling multiple times is just adding overhead for boot up 
> time. We should try to avoid it as much as possible.

Should I zero zynqmp_power and only probe if it is zero?

The solution is based on the psci driver.

Regards
   Stefan

  reply	other threads:[~2022-06-20  9:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 16:20 [PATCH 00/10] xilinx: zynqmp: Support foreign vendor boards Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 01/10] firmware: firmware-zynqmp: Check if rx channel dev pointer is valid Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 02/10] firmware: firmware-zynqmp: Probe driver before use Stefan Herbrechtsmeier
2022-06-16 14:22   ` Michal Simek
2022-06-20  6:40     ` Stefan Herbrechtsmeier
2022-06-20  6:51       ` Michal Simek
2022-06-20  9:33         ` Stefan Herbrechtsmeier [this message]
2022-06-08 16:20 ` [PATCH 03/10] soc: xilinx: zynqmp: Add machine identification support Stefan Herbrechtsmeier
2022-06-17 10:41   ` Michal Simek
2022-06-20  9:16     ` Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 04/10] xilinx: zynqmp: Use soc machine function to get silicon idcode name Stefan Herbrechtsmeier
2022-06-17 10:41   ` Michal Simek
2022-06-08 16:20 ` [PATCH 05/10] xilinx: cpuinfo: Print soc machine Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 06/10] xilinx: common: Separate display cpu info function Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 07/10] xilinx: zynqmp: make spi flash support optional Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 08/10] tools: zynqmp_psu_init_minimize: Remove low level uart settings Stefan Herbrechtsmeier
2022-06-08 16:20 ` [PATCH 09/10] tools: zynqmp_psu_init_minimize: Add serdes_illcalib forward declaration Stefan Herbrechtsmeier
2022-06-16 15:13   ` Michal Simek
2022-06-20  7:07     ` Stefan Herbrechtsmeier
2022-06-20  7:18       ` Michal Simek
2022-06-20 13:38         ` Stefan Herbrechtsmeier
2022-06-20 13:53           ` Michal Simek
2022-06-08 16:20 ` [PATCH 10/10] xilinx: zynqmp: Support vendor specific board_init Stefan Herbrechtsmeier
2022-06-16 15:12   ` Michal Simek
2022-06-20  6:48     ` Stefan Herbrechtsmeier
2022-06-20  6:53       ` Michal Simek
2022-06-20  9:36         ` Stefan Herbrechtsmeier
2022-06-17 11:06 ` [PATCH 00/10] xilinx: zynqmp: Support foreign vendor boards Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=271d770a-a69a-4438-d8a0-31c4b3784859@weidmueller.com \
    --to=stefan.herbrechtsmeier-oss@weidmueller.com \
    --cc=adrian.fiergolski@fastree3d.com \
    --cc=ashok.reddy.soma@xilinx.com \
    --cc=jh80.chung@samsung.com \
    --cc=michal.simek@amd.com \
    --cc=stefan.herbrechtsmeier@weidmueller.com \
    --cc=t.karthik.reddy@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.