[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Álvaro Fernández Rojas]

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 configs/comtrend_ar5315u_ram_defconfig   | 2 +-
 configs/comtrend_ar5387un_ram_defconfig  | 2 +-
 configs/comtrend_ct5361_ram_defconfig    | 2 +-
 configs/comtrend_vr3032u_ram_defconfig   | 2 +-
 configs/comtrend_wap5813n_ram_defconfig  | 2 +-
 configs/huawei_hg556a_ram_defconfig      | 2 +-
 configs/netgear_cg3100d_ram_defconfig    | 1 -
 configs/netgear_dgnd3700v2_ram_defconfig | 2 +-
 configs/sagem_f at st1704_ram_defconfig     | 1 -
 configs/sfr_nb4-ser_ram_defconfig        | 2 +-
 10 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/configs/comtrend_ar5315u_ram_defconfig b/configs/comtrend_ar5315u_ram_defconfig
index 1b8e4e43c4..948bd5206a 100644
--- a/configs/comtrend_ar5315u_ram_defconfig
+++ b/configs/comtrend_ar5315u_ram_defconfig
@@ -31,10 +31,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ar-5315u"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
diff --git a/configs/comtrend_ar5387un_ram_defconfig b/configs/comtrend_ar5387un_ram_defconfig
index 5ba401a441..845adafae2 100644
--- a/configs/comtrend_ar5387un_ram_defconfig
+++ b/configs/comtrend_ar5387un_ram_defconfig
@@ -31,10 +31,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ar-5387un"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
diff --git a/configs/comtrend_ct5361_ram_defconfig b/configs/comtrend_ct5361_ram_defconfig
index 6297e78fd9..280323e345 100644
--- a/configs/comtrend_ct5361_ram_defconfig
+++ b/configs/comtrend_ct5361_ram_defconfig
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ct-5361"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
diff --git a/configs/comtrend_vr3032u_ram_defconfig b/configs/comtrend_vr3032u_ram_defconfig
index 47f53998e1..be9177d741 100644
--- a/configs/comtrend_vr3032u_ram_defconfig
+++ b/configs/comtrend_vr3032u_ram_defconfig
@@ -29,10 +29,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,vr-3032u"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
diff --git a/configs/comtrend_wap5813n_ram_defconfig b/configs/comtrend_wap5813n_ram_defconfig
index fd5107bb7d..68199afb36 100644
--- a/configs/comtrend_wap5813n_ram_defconfig
+++ b/configs/comtrend_wap5813n_ram_defconfig
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,wap-5813n"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
diff --git a/configs/huawei_hg556a_ram_defconfig b/configs/huawei_hg556a_ram_defconfig
index d4e6144319..14205142a6 100644
--- a/configs/huawei_hg556a_ram_defconfig
+++ b/configs/huawei_hg556a_ram_defconfig
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="huawei,hg556a"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
diff --git a/configs/netgear_cg3100d_ram_defconfig b/configs/netgear_cg3100d_ram_defconfig
index 83e82247ab..5fada57c80 100644
--- a/configs/netgear_cg3100d_ram_defconfig
+++ b/configs/netgear_cg3100d_ram_defconfig
@@ -27,7 +27,6 @@ CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="netgear,cg3100d"
 # CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
diff --git a/configs/netgear_dgnd3700v2_ram_defconfig b/configs/netgear_dgnd3700v2_ram_defconfig
index 0f3914fe7e..cef0f673b4 100644
--- a/configs/netgear_dgnd3700v2_ram_defconfig
+++ b/configs/netgear_dgnd3700v2_ram_defconfig
@@ -30,10 +30,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="netgear,dgnd3700v2"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
diff --git a/configs/sagem_f at st1704_ram_defconfig b/configs/sagem_f at st1704_ram_defconfig
index 8c36f5dbf8..da19b613d5 100644
--- a/configs/sagem_f at st1704_ram_defconfig
+++ b/configs/sagem_f at st1704_ram_defconfig
@@ -30,7 +30,6 @@ CONFIG_CMD_SPI=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="sagem,f at st1704"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
diff --git a/configs/sfr_nb4-ser_ram_defconfig b/configs/sfr_nb4-ser_ram_defconfig
index 39622875b1..3df1edc257 100644
--- a/configs/sfr_nb4-ser_ram_defconfig
+++ b/configs/sfr_nb4-ser_ram_defconfig
@@ -29,10 +29,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="sfr,nb4-ser"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
-- 
2.11.0

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Tom Rini]

On Tue, Jan 01, 2019 at 07:45:03PM +0100, Álvaro Fernández Rojas wrote:

> - Fixes CONFIG_OF_EMBED warning.
> - Fixes missing CONFIG_BLK warning for CONFIG_USB.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

To be clear, some number of these have been boot tested too, right?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190101/7be1bab7/attachment.sig>

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Marek Vasut]

On 1/1/19 7:45 PM, Álvaro Fernández Rojas wrote:
> - Fixes CONFIG_OF_EMBED warning.
> - Fixes missing CONFIG_BLK warning for CONFIG_USB.

More details on those warnings that are supposedly fixed would be
appreciated. It's really unclear what this patch does.

-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Álvaro Fernández Rojas]

I only tested it on Comtrend AR-5387un, I will test it on other boards 
and report back.

El 01/01/2019 a las 20:19, Tom Rini escribió:
> On Tue, Jan 01, 2019 at 07:45:03PM +0100, Álvaro Fernández Rojas wrote:
>
>> - Fixes CONFIG_OF_EMBED warning.
>> - Fixes missing CONFIG_BLK warning for CONFIG_USB.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> To be clear, some number of these have been boot tested too, right?
> Thanks!
>

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Álvaro Fernández Rojas]

Hi Marek,

Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and 
109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41 


http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7


El 01/01/2019 a las 21:24, Marek Vasut escribió:
> On 1/1/19 7:45 PM, Álvaro Fernández Rojas wrote:
>> - Fixes CONFIG_OF_EMBED warning.
>> - Fixes missing CONFIG_BLK warning for CONFIG_USB.
> More details on those warnings that are supposedly fixed would be
> appreciated. It's really unclear what this patch does.
>

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Tom Rini]

On Wed, Jan 02, 2019 at 11:11:09PM +0100, Álvaro Fernández Rojas wrote:

> Hi Marek,
> 
> Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and
> 109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.
> 
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41
> 
> 
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7

Right.  But Marek is asking for something more like:
- Use of CONFIG_OF_EMBED isn't intended for deployment use, switch to
  CONFIG_OF_SEPARATE instead.
- We can fully migrate to CONIG_DM_USB so enable CONFIG_BLK now.

ie why we're changing things, not just that we're fixing the warning.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/7ea30314/attachment.sig>

[U-Boot] [PATCH] bmips: fix config warnings from 2019.01

[Daniel Schwierzeck]

Am 02.01.19 um 23:14 schrieb Tom Rini:
> On Wed, Jan 02, 2019 at 11:11:09PM +0100, Álvaro Fernández Rojas wrote:
> 
>> Hi Marek,
>>
>> Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and
>> 109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.
>>
>> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41
>>
>>
>> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7
> 
> Right.  But Marek is asking for something more like:
> - Use of CONFIG_OF_EMBED isn't intended for deployment use, switch to
>   CONFIG_OF_SEPARATE instead.
> - We can fully migrate to CONIG_DM_USB so enable CONFIG_BLK now.
> 
> ie why we're changing things, not just that we're fixing the warning.
> 

two patches would be good. In each one you could add a "Fixes:
841d5fbae4e993476fa87d8933db0cd58d3c2d41" or "Fixes:
109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7".

-- 
- Daniel