* [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet
@ 2019-12-02 8:56 Hans de Goede
2019-12-02 10:16 ` Bastien Nocera
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2019-12-02 8:56 UTC (permalink / raw)
To: Dmitry Torokhov, Bastien Nocera; +Cc: Hans de Goede, linux-input
The touchscreen on the Teclast X89 is mounted upside down in relation to
the display orientation (the touchscreen itself is mounted upright, but the
display is mounted upside-down). Add a quirk for this so that we send
coordinates which match the display orientation.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/touchscreen/goodix.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index fb43aa708660..0403102e807e 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -128,6 +128,15 @@ static const unsigned long goodix_irq_flags[] = {
*/
static const struct dmi_system_id rotated_screen[] = {
#if defined(CONFIG_DMI) && defined(CONFIG_X86)
+ {
+ .ident = "Teclast X89",
+ .matches = {
+ /* tPAD is too generic, also match on bios date */
+ DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
+ DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
+ DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
+ },
+ },
{
.ident = "WinBook TW100",
.matches = {
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet
2019-12-02 8:56 [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet Hans de Goede
@ 2019-12-02 10:16 ` Bastien Nocera
2019-12-07 20:28 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Bastien Nocera @ 2019-12-02 10:16 UTC (permalink / raw)
To: Hans de Goede, Dmitry Torokhov; +Cc: linux-input
On Mon, 2019-12-02 at 09:56 +0100, Hans de Goede wrote:
> The touchscreen on the Teclast X89 is mounted upside down in relation
> to
> the display orientation (the touchscreen itself is mounted upright,
> but the
> display is mounted upside-down). Add a quirk for this so that we send
> coordinates which match the display orientation.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Looks good
Reviewed-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/input/touchscreen/goodix.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa708660..0403102e807e 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -128,6 +128,15 @@ static const unsigned long goodix_irq_flags[] =
> {
> */
> static const struct dmi_system_id rotated_screen[] = {
> #if defined(CONFIG_DMI) && defined(CONFIG_X86)
> + {
> + .ident = "Teclast X89",
> + .matches = {
> + /* tPAD is too generic, also match on bios date
> */
> + DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> + DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
> + DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
> + },
> + },
> {
> .ident = "WinBook TW100",
> .matches = {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet
2019-12-02 10:16 ` Bastien Nocera
@ 2019-12-07 20:28 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2019-12-07 20:28 UTC (permalink / raw)
To: Bastien Nocera; +Cc: Hans de Goede, linux-input
On Mon, Dec 02, 2019 at 11:16:35AM +0100, Bastien Nocera wrote:
> On Mon, 2019-12-02 at 09:56 +0100, Hans de Goede wrote:
> > The touchscreen on the Teclast X89 is mounted upside down in relation
> > to
> > the display orientation (the touchscreen itself is mounted upright,
> > but the
> > display is mounted upside-down). Add a quirk for this so that we send
> > coordinates which match the display orientation.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Looks good
>
> Reviewed-by: Bastien Nocera <hadess@hadess.net>
Applied, thank you.
>
> > ---
> > drivers/input/touchscreen/goodix.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/input/touchscreen/goodix.c
> > b/drivers/input/touchscreen/goodix.c
> > index fb43aa708660..0403102e807e 100644
> > --- a/drivers/input/touchscreen/goodix.c
> > +++ b/drivers/input/touchscreen/goodix.c
> > @@ -128,6 +128,15 @@ static const unsigned long goodix_irq_flags[] =
> > {
> > */
> > static const struct dmi_system_id rotated_screen[] = {
> > #if defined(CONFIG_DMI) && defined(CONFIG_X86)
> > + {
> > + .ident = "Teclast X89",
> > + .matches = {
> > + /* tPAD is too generic, also match on bios date
> > */
> > + DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> > + DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
> > + DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
> > + },
> > + },
> > {
> > .ident = "WinBook TW100",
> > .matches = {
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-07 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 8:56 [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet Hans de Goede
2019-12-02 10:16 ` Bastien Nocera
2019-12-07 20:28 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.