* [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
@ 2013-12-16 2:45 Wei Yongjun
2013-12-16 9:40 ` Paul Durrant
2013-12-16 9:40 ` Paul Durrant
0 siblings, 2 replies; 8+ messages in thread
From: Wei Yongjun @ 2013-12-16 2:45 UTC (permalink / raw)
To: ian.campbell, wei.liu2, paul.durrant, zoltan.kiss, davem
Cc: yongjun_wei, xen-devel, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum setup')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/xen-netback/netback.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 800496b..773b731 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
err = -EPROTO;
+ if (fragment)
+ goto out;
+
switch (ip_hdr(skb)->protocol) {
case IPPROTO_TCP:
err = maybe_pull_tail(skb,
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 2:45 [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip() Wei Yongjun
@ 2013-12-16 9:40 ` Paul Durrant
2013-12-16 11:52 ` Ian Campbell
` (3 more replies)
2013-12-16 9:40 ` Paul Durrant
1 sibling, 4 replies; 8+ messages in thread
From: Paul Durrant @ 2013-12-16 9:40 UTC (permalink / raw)
To: Wei Yongjun, Ian Campbell, Wei Liu, Zoltan Kiss, davem
Cc: yongjun_wei, xen-devel, netdev
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: 16 December 2013 02:45
> To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
> Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
> netdev@vger.kernel.org
> Subject: [PATCH -next] xen-netback: fix fragments error handling in
> checksum_setup_ip()
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
>
> Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> setup')
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/xen-netback/netback.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> netback/netback.c
> index 800496b..773b731 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> struct sk_buff *skb,
>
> err = -EPROTO;
>
> + if (fragment)
> + goto out;
> +
Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> switch (ip_hdr(skb)->protocol) {
> case IPPROTO_TCP:
> err = maybe_pull_tail(skb,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 2:45 [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip() Wei Yongjun
2013-12-16 9:40 ` Paul Durrant
@ 2013-12-16 9:40 ` Paul Durrant
1 sibling, 0 replies; 8+ messages in thread
From: Paul Durrant @ 2013-12-16 9:40 UTC (permalink / raw)
To: Wei Yongjun, Ian Campbell, Wei Liu, Zoltan Kiss, davem
Cc: xen-devel, yongjun_wei, netdev
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: 16 December 2013 02:45
> To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
> Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
> netdev@vger.kernel.org
> Subject: [PATCH -next] xen-netback: fix fragments error handling in
> checksum_setup_ip()
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
>
> Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> setup')
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/xen-netback/netback.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> netback/netback.c
> index 800496b..773b731 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> struct sk_buff *skb,
>
> err = -EPROTO;
>
> + if (fragment)
> + goto out;
> +
Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> switch (ip_hdr(skb)->protocol) {
> case IPPROTO_TCP:
> err = maybe_pull_tail(skb,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 9:40 ` Paul Durrant
2013-12-16 11:52 ` Ian Campbell
@ 2013-12-16 11:52 ` Ian Campbell
2013-12-17 21:18 ` David Miller
2013-12-17 21:18 ` David Miller
3 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2013-12-16 11:52 UTC (permalink / raw)
To: Paul Durrant
Cc: Wei Yongjun, Wei Liu, Zoltan Kiss, davem, yongjun_wei, xen-devel, netdev
On Mon, 2013-12-16 at 09:40 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> > Sent: 16 December 2013 02:45
> > To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
> > Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
> > netdev@vger.kernel.org
> > Subject: [PATCH -next] xen-netback: fix fragments error handling in
> > checksum_setup_ip()
> >
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
> >
> > Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> > setup')
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > ---
> > drivers/net/xen-netback/netback.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> > netback/netback.c
> > index 800496b..773b731 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> > struct sk_buff *skb,
> >
> > err = -EPROTO;
> >
> > + if (fragment)
> > + goto out;
> > +
>
> Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 9:40 ` Paul Durrant
@ 2013-12-16 11:52 ` Ian Campbell
2013-12-16 11:52 ` Ian Campbell
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2013-12-16 11:52 UTC (permalink / raw)
To: Paul Durrant
Cc: Wei Liu, netdev, yongjun_wei, Zoltan Kiss, xen-devel, Wei Yongjun, davem
On Mon, 2013-12-16 at 09:40 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> > Sent: 16 December 2013 02:45
> > To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
> > Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
> > netdev@vger.kernel.org
> > Subject: [PATCH -next] xen-netback: fix fragments error handling in
> > checksum_setup_ip()
> >
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
> >
> > Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> > setup')
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > ---
> > drivers/net/xen-netback/netback.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> > netback/netback.c
> > index 800496b..773b731 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> > struct sk_buff *skb,
> >
> > err = -EPROTO;
> >
> > + if (fragment)
> > + goto out;
> > +
>
> Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 9:40 ` Paul Durrant
` (2 preceding siblings ...)
2013-12-17 21:18 ` David Miller
@ 2013-12-17 21:18 ` David Miller
3 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-12-17 21:18 UTC (permalink / raw)
To: Paul.Durrant
Cc: weiyj.lk, Ian.Campbell, wei.liu2, zoltan.kiss, yongjun_wei,
xen-devel, netdev
From: Paul Durrant <Paul.Durrant@citrix.com>
Date: Mon, 16 Dec 2013 09:40:37 +0000
>> -----Original Message-----
>> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
>> Sent: 16 December 2013 02:45
>> To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
>> Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
>> netdev@vger.kernel.org
>> Subject: [PATCH -next] xen-netback: fix fragments error handling in
>> checksum_setup_ip()
>>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
>>
>> Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
>> setup')
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> ---
>> drivers/net/xen-netback/netback.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
>> netback/netback.c
>> index 800496b..773b731 100644
>> --- a/drivers/net/xen-netback/netback.c
>> +++ b/drivers/net/xen-netback/netback.c
>> @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
>> struct sk_buff *skb,
>>
>> err = -EPROTO;
>>
>> + if (fragment)
>> + goto out;
>> +
>
> Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Why is this targetted at -next? The guilty commit this is fixing is present
in Linus's tree.
I'm going to apply it to 'net', but please take the time to specify
the correct destination tree in the future.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
2013-12-16 9:40 ` Paul Durrant
2013-12-16 11:52 ` Ian Campbell
2013-12-16 11:52 ` Ian Campbell
@ 2013-12-17 21:18 ` David Miller
2013-12-17 21:18 ` David Miller
3 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-12-17 21:18 UTC (permalink / raw)
To: Paul.Durrant
Cc: wei.liu2, Ian.Campbell, netdev, yongjun_wei, zoltan.kiss,
xen-devel, weiyj.lk
From: Paul Durrant <Paul.Durrant@citrix.com>
Date: Mon, 16 Dec 2013 09:40:37 +0000
>> -----Original Message-----
>> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
>> Sent: 16 December 2013 02:45
>> To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@davemloft.net
>> Cc: yongjun_wei@trendmicro.com.cn; xen-devel@lists.xenproject.org;
>> netdev@vger.kernel.org
>> Subject: [PATCH -next] xen-netback: fix fragments error handling in
>> checksum_setup_ip()
>>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
>>
>> Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
>> setup')
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> ---
>> drivers/net/xen-netback/netback.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
>> netback/netback.c
>> index 800496b..773b731 100644
>> --- a/drivers/net/xen-netback/netback.c
>> +++ b/drivers/net/xen-netback/netback.c
>> @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
>> struct sk_buff *skb,
>>
>> err = -EPROTO;
>>
>> + if (fragment)
>> + goto out;
>> +
>
> Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...
>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Why is this targetted at -next? The guilty commit this is fixing is present
in Linus's tree.
I'm going to apply it to 'net', but please take the time to specify
the correct destination tree in the future.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()
@ 2013-12-16 2:45 Wei Yongjun
0 siblings, 0 replies; 8+ messages in thread
From: Wei Yongjun @ 2013-12-16 2:45 UTC (permalink / raw)
To: ian.campbell, wei.liu2, paul.durrant, zoltan.kiss, davem
Cc: xen-devel, yongjun_wei, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum setup')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/xen-netback/netback.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 800496b..773b731 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
err = -EPROTO;
+ if (fragment)
+ goto out;
+
switch (ip_hdr(skb)->protocol) {
case IPPROTO_TCP:
err = maybe_pull_tail(skb,
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-12-17 21:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-16 2:45 [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip() Wei Yongjun
2013-12-16 9:40 ` Paul Durrant
2013-12-16 11:52 ` Ian Campbell
2013-12-16 11:52 ` Ian Campbell
2013-12-17 21:18 ` David Miller
2013-12-17 21:18 ` David Miller
2013-12-16 9:40 ` Paul Durrant
-- strict thread matches above, loose matches on Subject: below --
2013-12-16 2:45 Wei Yongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.