* [PATCH v2] net/i40e: fix uninitialized variable
@ 2017-10-10 11:24 Yong Wang
2017-10-10 13:24 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2017-10-10 11:24 UTC (permalink / raw)
To: jingjing.wu; +Cc: dev, Yong Wang, stable
In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
Fixes: 2a73125b7041 ("i40evf: fix link info update")
Cc: stable@dpdk.org
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
v2 change:
set it by checking link_speeds of dev.
---
drivers/net/i40e/i40e_ethdev_vf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 111ac39..46a566f 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2100,6 +2100,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
new_link.link_status = vf->link_up ? ETH_LINK_UP :
ETH_LINK_DOWN;
+ new_link.link_autoneg = dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;
i40evf_dev_atomic_write_link_status(dev, &new_link);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net/i40e: fix uninitialized variable
2017-10-10 11:24 [PATCH v2] net/i40e: fix uninitialized variable Yong Wang
@ 2017-10-10 13:24 ` Wu, Jingjing
2017-10-10 23:17 ` [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2017-10-10 13:24 UTC (permalink / raw)
To: Yong Wang; +Cc: dev, stable
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Tuesday, October 10, 2017 7:24 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix uninitialized variable
>
> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
>
> Fixes: 2a73125b7041 ("i40evf: fix link info update")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Thanks
Jingjing
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/i40e: fix uninitialized variable
2017-10-10 13:24 ` Wu, Jingjing
@ 2017-10-10 23:17 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-10 23:17 UTC (permalink / raw)
To: Wu, Jingjing, Yong Wang; +Cc: dev, stable
On 10/10/2017 2:24 PM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
>> Sent: Tuesday, October 10, 2017 7:24 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>; stable@dpdk.org
>> Subject: [PATCH v2] net/i40e: fix uninitialized variable
>>
>> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
>> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
>>
>> Fixes: 2a73125b7041 ("i40evf: fix link info update")
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-10 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 11:24 [PATCH v2] net/i40e: fix uninitialized variable Yong Wang
2017-10-10 13:24 ` Wu, Jingjing
2017-10-10 23:17 ` [dpdk-stable] " Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.