[PATCH] resolve: fix runtime error if netconfig is not enabled

[PATCH] resolve: fix runtime error if netconfig is not enabled

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

If the resolve module was not enabled in the config file, IWD fails
to start since resolve_init was returning -EINVAL. Since netconfig
is optional, we just return successfully here.
---
 src/resolve.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/resolve.c b/src/resolve.c
index 83ac3547..fea9c2bd 100644
--- a/src/resolve.c
+++ b/src/resolve.c
@@ -427,8 +427,9 @@ void __resolve_set_config(struct l_settings *config)
 
 static int resolve_init(void)
 {
+	/* This module is not enabled in config */
 	if (!method.ops)
-		return -EINVAL;
+		return 0;
 
 	if (method.ops->init)
 		method.data = method.ops->init();
-- 
2.17.1

Re: [PATCH] resolve: fix runtime error if netconfig is not enabled

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

Hi James,

> If the resolve module was not enabled in the config file, IWD fails
> to start since resolve_init was returning -EINVAL. Since netconfig
> is optional, we just return successfully here.
> ---
> src/resolve.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied.

Regards

Marcel