* [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO
@ 2019-07-26 16:27 Zhang Chen
2019-08-08 2:44 ` Zhang, Chen
0 siblings, 1 reply; 4+ messages in thread
From: Zhang Chen @ 2019-07-26 16:27 UTC (permalink / raw)
To: Ian Jackson, Wei Liu, Anthony PERARD, xen-devel; +Cc: Zhang Chen, Zhang Chen
From: Zhang Chen <chen.zhang@intel.com>
Xen COLO and KVM COLO shared lots of code in Qemu.
The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11.
Detail:
https://wiki.qemu.org/Features/COLO
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libxl/libxl_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index f4fc96415d..839c5ac2cd 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1634,8 +1634,10 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
nics[i].colo_compare_out &&
nics[i].colo_compare_notify_dev) {
flexarray_append(dm_args, "-object");
+ flexarray_append(dm_args, "iothread,id=colo-compare-iothread-1");
+ flexarray_append(dm_args, "-object");
flexarray_append(dm_args,
- GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
+ GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s,iothread=colo-compare-iothread-1",
nics[i].colo_compare_pri_in,
nics[i].colo_compare_sec_in,
nics[i].colo_compare_out,
--
2.17.GIT
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO
2019-07-26 16:27 [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO Zhang Chen
@ 2019-08-08 2:44 ` Zhang, Chen
2019-08-08 9:08 ` Anthony PERARD
0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Chen @ 2019-08-08 2:44 UTC (permalink / raw)
To: Ian Jackson, Wei Liu, Anthony PERARD, xen-devel; +Cc: Zhang Chen
Ping...
Any comments?
Thanks
Zhang Chen
> -----Original Message-----
> From: Zhang, Chen
> Sent: Saturday, July 27, 2019 12:27 AM
> To: Ian Jackson <ian.jackson@eu.citrix.com>; Wei Liu <wl@xen.org>; Anthony
> PERARD <anthony.perard@citrix.com>; xen-devel@lists.xenproject.org
> Cc: Zhang Chen <zhangckid@gmail.com>; Zhang, Chen <chen.zhang@intel.com>
> Subject: [PATCH V4] tools/libxl: Add iothread support for COLO
>
> From: Zhang Chen <chen.zhang@intel.com>
>
> Xen COLO and KVM COLO shared lots of code in Qemu.
> The colo-compare object in Qemu now requires an 'iothread' property since
> QEMU 2.11.
>
> Detail:
> https://wiki.qemu.org/Features/COLO
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> tools/libxl/libxl_dm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index
> f4fc96415d..839c5ac2cd 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1634,8 +1634,10 @@ static int
> libxl__build_device_model_args_new(libxl__gc *gc,
> nics[i].colo_compare_out &&
> nics[i].colo_compare_notify_dev) {
> flexarray_append(dm_args, "-object");
> + flexarray_append(dm_args, "iothread,id=colo-compare-
> iothread-1");
> + flexarray_append(dm_args, "-object");
> flexarray_append(dm_args,
> - GCSPRINTF("colo-
> compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
> +
> + GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,
> + notify_dev=%s,iothread=colo-compare-iothread-1",
> nics[i].colo_compare_pri_in,
> nics[i].colo_compare_sec_in,
> nics[i].colo_compare_out,
> --
> 2.17.GIT
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO
2019-08-08 2:44 ` Zhang, Chen
@ 2019-08-08 9:08 ` Anthony PERARD
2019-08-08 10:29 ` Zhang, Chen
0 siblings, 1 reply; 4+ messages in thread
From: Anthony PERARD @ 2019-08-08 9:08 UTC (permalink / raw)
To: Zhang, Chen; +Cc: xen-devel, Ian Jackson, Wei Liu, Zhang Chen
On Thu, Aug 08, 2019 at 02:44:42AM +0000, Zhang, Chen wrote:
> Ping...
> Any comments?
For your information, that patch have been pushed, see commit
174db28bb823e8c98c319fdbdc6d4cbe1050ba14 ;-)
Cheers,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO
2019-08-08 9:08 ` Anthony PERARD
@ 2019-08-08 10:29 ` Zhang, Chen
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Chen @ 2019-08-08 10:29 UTC (permalink / raw)
To: Anthony PERARD; +Cc: xen-devel, Ian Jackson, Wei Liu, Zhang Chen
Thank you Anthony PERARD.
Thanks
Zhang Chen
> -----Original Message-----
> From: Anthony PERARD [mailto:anthony.perard@citrix.com]
> Sent: Thursday, August 8, 2019 5:08 PM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>; Wei Liu <wl@xen.org>; xen-
> devel@lists.xenproject.org; Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH V4] tools/libxl: Add iothread support for COLO
>
> On Thu, Aug 08, 2019 at 02:44:42AM +0000, Zhang, Chen wrote:
> > Ping...
> > Any comments?
>
> For your information, that patch have been pushed, see commit
> 174db28bb823e8c98c319fdbdc6d4cbe1050ba14 ;-)
>
> Cheers,
>
> --
> Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-08 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-26 16:27 [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO Zhang Chen
2019-08-08 2:44 ` Zhang, Chen
2019-08-08 9:08 ` Anthony PERARD
2019-08-08 10:29 ` Zhang, Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.