[PATCH] oeqa/runtime: Add tests for gstreamer CLI

[PATCH] oeqa/runtime: Add tests for gstreamer CLI

[Yeoh Ee Peng]

We should not be finding GStreamer issues right around
release time but that's what we seem to do.

Port gstreamer tests from Intel Ref Kit.
https://github.com/intel/intel-iot-refkit/blob/master/meta-iotqa/
lib/oeqa/runtime/multimedia/gstreamer/gstreamer_cli.py

Add tests for gstreamer commandline tools (gst-inspect-1.0
& gst-launch-1.0).

[YOCTO #11418]

Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
---
 meta/lib/oeqa/runtime/cases/gstreamer.py | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 meta/lib/oeqa/runtime/cases/gstreamer.py

diff --git a/meta/lib/oeqa/runtime/cases/gstreamer.py b/meta/lib/oeqa/runtime/cases/gstreamer.py
new file mode 100644
index 0000000..3adeeb5
--- /dev/null
+++ b/meta/lib/oeqa/runtime/cases/gstreamer.py
@@ -0,0 +1,11 @@
+from oeqa.runtime.case import OERuntimeTestCase
+
+class GstreamerCliTest(OERuntimeTestCase):
+
+    def test_gst_inspect_can_list_all_plugins(self):
+        status, output = self.target.run('gst-inspect-1.0')
+        self.assertEqual(status, 0, 'gst-inspect-1.0 does not appear to be running.')
+
+    def test_gst_launch_can_create_video_pipeline(self):
+        status, output = self.target.run('gst-launch-1.0 -v fakesrc silent=false num-buffers=3 ! fakesink silent=false')
+        self.assertEqual(status, 0, 'gst-launch-1.0 does not appear to be running.')
-- 
2.7.4

Re: [PATCH] oeqa/runtime: Add tests for gstreamer CLI

[Richard Purdie]

On Thu, 2018-11-08 at 16:02 +0800, Yeoh Ee Peng wrote:
> We should not be finding GStreamer issues right around
> release time but that's what we seem to do.
> 
> Port gstreamer tests from Intel Ref Kit.
> https://github.com/intel/intel-iot-refkit/blob/master/meta-iotqa/
> lib/oeqa/runtime/multimedia/gstreamer/gstreamer_cli.py
> 
> Add tests for gstreamer commandline tools (gst-inspect-1.0
> & gst-launch-1.0).
> 
> [YOCTO #11418]
> 
> Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
> ---
>  meta/lib/oeqa/runtime/cases/gstreamer.py | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 meta/lib/oeqa/runtime/cases/gstreamer.py
> 
> diff --git a/meta/lib/oeqa/runtime/cases/gstreamer.py
> b/meta/lib/oeqa/runtime/cases/gstreamer.py
> new file mode 100644
> index 0000000..3adeeb5
> --- /dev/null
> +++ b/meta/lib/oeqa/runtime/cases/gstreamer.py
> @@ -0,0 +1,11 @@
> +from oeqa.runtime.case import OERuntimeTestCase
> +
> +class GstreamerCliTest(OERuntimeTestCase):
> +
> +    def test_gst_inspect_can_list_all_plugins(self):
> +        status, output = self.target.run('gst-inspect-1.0')
> +        self.assertEqual(status, 0, 'gst-inspect-1.0 does not appear
> to be running.')
> +
> +    def test_gst_launch_can_create_video_pipeline(self):
> +        status, output = self.target.run('gst-launch-1.0 -v fakesrc
> silent=false num-buffers=3 ! fakesink silent=false')
> +        self.assertEqual(status, 0, 'gst-launch-1.0 does not appear
> to be running.')

This looks good and I like the idea of this a lot but I think it needs
some kind of:

@OEHasPackage(['<somepackage>'])

decorator so we know where the test needs to run?

Cheers,

Richard

Re: [PATCH] oeqa/runtime: Add tests for gstreamer CLI

[ChenQi]

Hi Peng,

Does it require some gstreamer packages to be available on target?
Maybe some @OEHasPackage decorator needs to be added?

Best Regards,
Chen Qi

On 11/08/2018 04:02 PM, Yeoh Ee Peng wrote:
> We should not be finding GStreamer issues right around
> release time but that's what we seem to do.
>
> Port gstreamer tests from Intel Ref Kit.
> https://github.com/intel/intel-iot-refkit/blob/master/meta-iotqa/
> lib/oeqa/runtime/multimedia/gstreamer/gstreamer_cli.py
>
> Add tests for gstreamer commandline tools (gst-inspect-1.0
> & gst-launch-1.0).
>
> [YOCTO #11418]
>
> Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
> ---
>   meta/lib/oeqa/runtime/cases/gstreamer.py | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>   create mode 100644 meta/lib/oeqa/runtime/cases/gstreamer.py
>
> diff --git a/meta/lib/oeqa/runtime/cases/gstreamer.py b/meta/lib/oeqa/runtime/cases/gstreamer.py
> new file mode 100644
> index 0000000..3adeeb5
> --- /dev/null
> +++ b/meta/lib/oeqa/runtime/cases/gstreamer.py
> @@ -0,0 +1,11 @@
> +from oeqa.runtime.case import OERuntimeTestCase
> +
> +class GstreamerCliTest(OERuntimeTestCase):
> +
> +    def test_gst_inspect_can_list_all_plugins(self):
> +        status, output = self.target.run('gst-inspect-1.0')
> +        self.assertEqual(status, 0, 'gst-inspect-1.0 does not appear to be running.')
> +
> +    def test_gst_launch_can_create_video_pipeline(self):
> +        status, output = self.target.run('gst-launch-1.0 -v fakesrc silent=false num-buffers=3 ! fakesink silent=false')
> +        self.assertEqual(status, 0, 'gst-launch-1.0 does not appear to be running.')

Re: [PATCH] oeqa/runtime: Add tests for gstreamer CLI

[Yeoh, Ee Peng]

Hi Richard & ChenQi,

Thank you for your inputs!
I had submitted v2 patch that include the @OEHasPackage decorator.
Please let me know if any more question or input. 

Thanks,
Ee Peng 

-----Original Message-----
From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] 
Sent: Thursday, November 8, 2018 4:33 PM
To: Yeoh, Ee Peng <ee.peng.yeoh@intel.com>; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] oeqa/runtime: Add tests for gstreamer CLI

On Thu, 2018-11-08 at 16:02 +0800, Yeoh Ee Peng wrote:
> We should not be finding GStreamer issues right around release time 
> but that's what we seem to do.
> 
> Port gstreamer tests from Intel Ref Kit.
> https://github.com/intel/intel-iot-refkit/blob/master/meta-iotqa/
> lib/oeqa/runtime/multimedia/gstreamer/gstreamer_cli.py
> 
> Add tests for gstreamer commandline tools (gst-inspect-1.0 & 
> gst-launch-1.0).
> 
> [YOCTO #11418]
> 
> Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
> ---
>  meta/lib/oeqa/runtime/cases/gstreamer.py | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 meta/lib/oeqa/runtime/cases/gstreamer.py
> 
> diff --git a/meta/lib/oeqa/runtime/cases/gstreamer.py
> b/meta/lib/oeqa/runtime/cases/gstreamer.py
> new file mode 100644
> index 0000000..3adeeb5
> --- /dev/null
> +++ b/meta/lib/oeqa/runtime/cases/gstreamer.py
> @@ -0,0 +1,11 @@
> +from oeqa.runtime.case import OERuntimeTestCase
> +
> +class GstreamerCliTest(OERuntimeTestCase):
> +
> +    def test_gst_inspect_can_list_all_plugins(self):
> +        status, output = self.target.run('gst-inspect-1.0')
> +        self.assertEqual(status, 0, 'gst-inspect-1.0 does not appear
> to be running.')
> +
> +    def test_gst_launch_can_create_video_pipeline(self):
> +        status, output = self.target.run('gst-launch-1.0 -v fakesrc
> silent=false num-buffers=3 ! fakesink silent=false')
> +        self.assertEqual(status, 0, 'gst-launch-1.0 does not appear
> to be running.')

This looks good and I like the idea of this a lot but I think it needs some kind of:

@OEHasPackage(['<somepackage>'])

decorator so we know where the test needs to run?

Cheers,

Richard