* [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration
@ 2008-08-23 6:52 Nick Spence
2008-08-25 22:26 ` Kim Phillips
0 siblings, 1 reply; 3+ messages in thread
From: Nick Spence @ 2008-08-23 6:52 UTC (permalink / raw)
To: u-boot
Set DAT value before DIR values to avoid creating glitches on the
GPIO signals.
---
cpu/mpc83xx/cpu_init.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c
index 67c9e57..4514dbb 100644
--- a/cpu/mpc83xx/cpu_init.c
+++ b/cpu/mpc83xx/cpu_init.c
@@ -283,12 +283,12 @@ void cpu_init_f (volatile immap_t * im)
im->sysconf.lblaw[7].ar = CFG_LBLAWAR7_PRELIM;
#endif
#ifdef CFG_GPIO1_PRELIM
- im->gpio[0].dir = CFG_GPIO1_DIR;
im->gpio[0].dat = CFG_GPIO1_DAT;
+ im->gpio[0].dir = CFG_GPIO1_DIR;
#endif
#ifdef CFG_GPIO2_PRELIM
- im->gpio[1].dir = CFG_GPIO2_DIR;
im->gpio[1].dat = CFG_GPIO2_DAT;
+ im->gpio[1].dir = CFG_GPIO2_DIR;
#endif
}
--
1.5.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration
2008-08-23 6:52 [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration Nick Spence
@ 2008-08-25 22:26 ` Kim Phillips
2008-08-25 22:44 ` Spence Nick-RXTD10
0 siblings, 1 reply; 3+ messages in thread
From: Kim Phillips @ 2008-08-25 22:26 UTC (permalink / raw)
To: u-boot
On Fri, 22 Aug 2008 23:52:50 -0700
Nick Spence <nick.spence@freescale.com> wrote:
> Set DAT value before DIR values to avoid creating glitches on the
> GPIO signals.
> ---
I need a sign off before I can apply this.
Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration
2008-08-25 22:26 ` Kim Phillips
@ 2008-08-25 22:44 ` Spence Nick-RXTD10
0 siblings, 0 replies; 3+ messages in thread
From: Spence Nick-RXTD10 @ 2008-08-25 22:44 UTC (permalink / raw)
To: u-boot
Kim Phillips wrote:
On Fri, 22 Aug 2008 23:52:50 -0700
> Nick Spence <nick.spence@freescale.com> wrote:
>
> > Set DAT value before DIR values to avoid creating glitches
> on the GPIO
> > signals.
> > ---
>
> I need a sign off before I can apply this.
>
> Kim
>
Signed-off-by: Nick Spence <nick.spence@freescale.com>
Thanks,
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-25 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-23 6:52 [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration Nick Spence
2008-08-25 22:26 ` Kim Phillips
2008-08-25 22:44 ` Spence Nick-RXTD10
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.