All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 5/5] colibri_t20: enable dfu also for nand
Date: Mon, 12 Sep 2016 12:24:01 -0600	[thread overview]
Message-ID: <9a1d3f3d-91fb-1043-b102-cdb489ec1eaf@wwwdotorg.org> (raw)
In-Reply-To: <1473437441-938-6-git-send-email-marcel.ziswiler@toradex.com>

On 09/09/2016 10:10 AM, Marcel Ziswiler wrote:
> Enable USB gadget DFU functionality for NAND as well.

> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h

> +/* USB DFU */
> +#define CONFIG_DFU_NAND

Oh, I see this file already includes tegra-common-usb-gadget.h, so USB 
device-mode is already enabled for this board. Does that make sense 
given that it doesn't actually work?

> +#define DFU_ALT_NAND_INFO	"u-boot part 0,1;ubi part 0,4"
> +
>  #define BOARD_EXTRA_ENV_SETTINGS \
> +	"dfu_alt_info=" DFU_ALT_NAND_INFO "\0" \

I would defer this to the user, since people may choose different flash 
layouts.

  reply	other threads:[~2016-09-12 18:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 16:10 [U-Boot] [PATCH v1 0/5] various fixes mainly for colibri_t20 Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 1/5] tegra: usb gadget: fix ci udc operation if not hostpc capable Marcel Ziswiler
2016-09-12 18:13   ` Stephen Warren
2016-09-14 14:45     ` Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 2/5] simple panel: fix spelling of debug message Marcel Ziswiler
2016-09-09 16:16   ` Anatolij Gustschin
2016-09-09 16:10 ` [U-Boot] [PATCH v1 3/5] colibri_t20: fix display configuration Marcel Ziswiler
2016-09-12 18:18   ` Stephen Warren
2016-09-14 15:20     ` Marcel Ziswiler
2016-09-14 17:19       ` Stephen Warren
2016-09-14 21:44         ` Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 4/5] colibri_t20: fix usb operation and controller order Marcel Ziswiler
2016-09-12 18:20   ` Stephen Warren
2016-09-14 15:34     ` Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 5/5] colibri_t20: enable dfu also for nand Marcel Ziswiler
2016-09-12 18:24   ` Stephen Warren [this message]
2016-09-14 15:41     ` Marcel Ziswiler
2016-09-14 17:23       ` Stephen Warren
2016-09-14 21:22         ` Marcel Ziswiler
2016-09-12 18:13 ` [U-Boot] [PATCH v1 0/5] various fixes mainly for colibri_t20 Stephen Warren
2016-09-14 15:45   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a1d3f3d-91fb-1043-b102-cdb489ec1eaf@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.