All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/70] tcg: Remove tcg_const_*
@ 2023-02-27  5:41 Richard Henderson
  2023-02-27  5:41 ` [PATCH 01/70] target/arm: Use rmode >= 0 for need_rmode Richard Henderson
                   ` (69 more replies)
  0 siblings, 70 replies; 140+ messages in thread
From: Richard Henderson @ 2023-02-27  5:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-arm, qemu-ppc, qemu-riscv, qemu-s390x, jcmvbkbc, kbastian,
	ysato, gaosong, jiaxun.yang, tsimpson, ale, mrolnik,
	edgar.iglesias

This completes the transition from tcg_const_* to
tcg_constant_* that started in 2020.

This isn't hard, but non-mechanical.  One must identify when the
variable is used only for the constant, or if it is also written
as a general purpose temporary.  For the most part, breaking this
apart makes the code easier to understand.

Based-on: 20230227052505.352889-1-richard.henderson@linaro.org
("[PATCH v2 00/76] tcg: Drop tcg_temp_free from translators")

which I've just realized is actualy based on v4 not v3 of

Message-Id: 20230227053701.368744-1-richard.henderson@linaro.org
("[PATCH v4 00/31] tcg: Simplify temporary usage")

so for avoidance of doubt:

https://gitlab.com/rth7680/qemu/-/tree/tcg-const (c44933e0)


r~


Richard Henderson (70):
  target/arm: Use rmode >= 0 for need_rmode
  target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf
  target/arm: Improve arm_rmode_to_sf
  target/arm: Consistently use ARMFPRounding during translation
  target/arm: Create gen_set_rmode, gen_restore_rmode
  target/arm: Improve trans_BFCI
  target/arm: Avoid tcg_const_ptr in gen_sve_{ldr,str}
  target/arm: Avoid tcg_const_* in translate-mve.c
  target/arm: Avoid tcg_const_ptr in disas_simd_zip_trn
  target/arm: Avoid tcg_const_ptr in handle_vec_simd_sqshrn
  target/arm: Avoid tcg_const_ptr in handle_rev
  target/avr: Avoid use of tcg_const_i32 in SBIC, SBIS
  target/avr: Avoid use of tcg_const_i32 throughout
  target/cris: Avoid use of tcg_const_i32 throughout
  target/hexagon: Use tcg_constant_* for gen_constant_from_imm
  target/hexagon/idef-parser: Use gen_tmp for LPCFG
  target/hexagon/idef-parser: Use gen_tmp for gen_pred_assign
  target/hexagon/idef-parser: Use gen_tmp for gen_rvalue_pred
  target/hexagon/idef-parser: Use gen_constant for
    gen_extend_tcg_width_op
  target/hppa: Avoid tcg_const_i64 in trans_fid_f
  target/hppa: Avoid use of tcg_const_i32 throughout
  target/i386: Simplify POPF
  target/i386: Avoid use of tcg_const_* throughout
  target/m68k: Reject immediate as destination in gen_ea_mode
  target/m68k: Use tcg_constant_i32 in gen_ea_mode
  target/m68k: Avoid tcg_const_i32 when modified
  target/m68k: Avoid tcg_const_i32 in bfop_reg
  target/m68k: Avoid tcg_const_* throughout
  target/microblaze: Avoid tcg_const_* throughout
  target/mips: Split out gen_lxl
  target/mips: Split out gen_lxr
  target/mips: Avoid tcg_const_tl in gen_r6_ld
  target/mips: Avoid tcg_const_* throughout
  target/ppc: Split out gen_vx_vmul10
  target/ppc: Avoid tcg_const_i64 in do_vector_shift_quad
  target/ppc: Avoid tcg_const_i64 in do_vcntmb
  target/ppc: Avoid tcg_const_* in vmx-impl.c.inc
  target/ppc: Avoid tcg_const_* in xxeval
  target/ppc: Avoid tcg_const_* in vsx-impl.c.inc
  target/ppc: Avoid tcg_const_* in fp-impl.c.inc
  target/ppc: Avoid tcg_const_* in power8-pmu-regs.c.inc
  target/ppc: Rewrite trans_ADDG6S
  target/ppc: Fix gen_tlbsx_booke206
  target/ppc: Avoid tcg_const_* in translate.c
  target/riscv: Avoid tcg_const_*
  target/rx: Use tcg_gen_abs_i32
  target/rx: Use cpu_psw_z as temp in flags computation
  target/rx: Avoid tcg_const_i32 when new temp needed
  target/rx: Avoid tcg_const_i32
  target/s390x: Split out gen_ri2
  target/s390x: Avoid tcg_const_i64
  target/sh4: Avoid tcg_const_i32 for TAS.B
  target/sh4: Avoid tcg_const_i32
  tcg/sparc: Avoid tcg_const_tl in gen_edge
  target/sparc: Avoid tcg_const_{tl,i32}
  target/tricore: Split t_n as constant from temp as variable
  target/tricore: Rename t_off10 and use tcg_constant_i32
  target/tricore: Use min/max for saturate
  target/tricore: Use setcondi instead of explicit allocation
  target/tricore: Drop some temp initialization
  target/tricore: Avoid tcg_const_i32
  target/xtensa: Tidy translate_bb
  target/xtensa: Tidy translate_clamps
  target/xtensa: Avoid tcg_const_i32 in translate_l32r
  target/xtensa: Use tcg_gen_subfi_i32 in translate_sll
  target/xtensa: Split constant in bit shift
  target/xtensa: Avoid tcg_const_i32
  tcg: Replace tcg_const_i64 in tcg-op.c
  tcg: Drop tcg_const_*_vec
  tcg: Drop tcg_const_*

 include/tcg/tcg-op.h                        |   4 -
 include/tcg/tcg.h                           |  10 -
 target/arm/internals.h                      |  12 +-
 target/arm/translate.h                      |  17 +
 target/hexagon/idef-parser/parser-helpers.h |   6 -
 target/arm/translate-a64.c                  | 168 +++----
 target/arm/translate-mve.c                  |  56 +--
 target/arm/translate-sve.c                  |  28 +-
 target/arm/translate-vfp.c                  |  26 +-
 target/arm/translate.c                      |  13 +-
 target/arm/vfp_helper.c                     |  35 +-
 target/avr/translate.c                      |  48 +-
 target/cris/translate.c                     |  46 +-
 target/hexagon/idef-parser/parser-helpers.c |  49 +-
 target/hppa/translate.c                     |  35 +-
 target/i386/tcg/translate.c                 | 138 +++---
 target/m68k/translate.c                     | 235 +++++-----
 target/microblaze/translate.c               |  35 +-
 target/mips/tcg/mxu_translate.c             |   4 +-
 target/mips/tcg/translate.c                 | 282 +++++-------
 target/mips/tcg/tx79_translate.c            |   4 +-
 target/ppc/translate.c                      | 148 +++---
 target/riscv/translate.c                    |   4 +-
 target/rx/translate.c                       |  84 ++--
 target/s390x/tcg/translate.c                |  43 +-
 target/sh4/translate.c                      |  35 +-
 target/sparc/translate.c                    |  94 ++--
 target/tricore/translate.c                  | 476 ++++++++++----------
 target/xtensa/translate.c                   |  50 +-
 tcg/tcg-op-vec.c                            |  34 +-
 tcg/tcg-op.c                                |  12 +-
 tcg/tcg.c                                   |  16 -
 target/cris/translate_v10.c.inc             |  26 +-
 target/mips/tcg/micromips_translate.c.inc   |   4 +-
 target/mips/tcg/nanomips_translate.c.inc    |  16 +-
 target/ppc/power8-pmu-regs.c.inc            |   4 +-
 target/ppc/translate/fixedpoint-impl.c.inc  |  44 +-
 target/ppc/translate/fp-impl.c.inc          |  26 +-
 target/ppc/translate/vmx-impl.c.inc         | 130 +++---
 target/ppc/translate/vsx-impl.c.inc         |  36 +-
 target/riscv/insn_trans/trans_rvv.c.inc     |   4 +-
 target/riscv/insn_trans/trans_rvzfh.c.inc   |   2 +-
 tcg/i386/tcg-target.c.inc                   |   9 +-
 target/hexagon/idef-parser/idef-parser.y    |   2 +-
 44 files changed, 1158 insertions(+), 1392 deletions(-)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 140+ messages in thread
end of thread, other threads:[~2023-03-07 10:21 UTC | newest]

Thread overview: 140+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-27  5:41 [PATCH 00/70] tcg: Remove tcg_const_* Richard Henderson
2023-02-27  5:41 ` [PATCH 01/70] target/arm: Use rmode >= 0 for need_rmode Richard Henderson
2023-03-06 13:54   ` Philippe Mathieu-Daudé
2023-03-06 13:56     ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 02/70] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf Richard Henderson
2023-02-27  5:41 ` [PATCH 03/70] target/arm: Improve arm_rmode_to_sf Richard Henderson
2023-03-06 14:00   ` Philippe Mathieu-Daudé
2023-03-06 19:20     ` Richard Henderson
2023-02-27  5:41 ` [PATCH 04/70] target/arm: Consistently use ARMFPRounding during translation Richard Henderson
2023-03-06 13:58   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 05/70] target/arm: Create gen_set_rmode, gen_restore_rmode Richard Henderson
2023-02-27  5:41 ` [PATCH 06/70] target/arm: Improve trans_BFCI Richard Henderson
2023-02-27  5:41 ` [PATCH 07/70] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr,str} Richard Henderson
2023-03-06 15:11   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 08/70] target/arm: Avoid tcg_const_* in translate-mve.c Richard Henderson
2023-02-27  5:41 ` [PATCH 09/70] target/arm: Avoid tcg_const_ptr in disas_simd_zip_trn Richard Henderson
2023-02-27  5:41 ` [PATCH 10/70] target/arm: Avoid tcg_const_ptr in handle_vec_simd_sqshrn Richard Henderson
2023-03-06 15:15   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 11/70] target/arm: Avoid tcg_const_ptr in handle_rev Richard Henderson
2023-03-06 15:22   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 12/70] target/avr: Avoid use of tcg_const_i32 in SBIC, SBIS Richard Henderson
2023-03-06 13:51   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 13/70] target/avr: Avoid use of tcg_const_i32 throughout Richard Henderson
2023-03-06 23:49   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 14/70] target/cris: " Richard Henderson
2023-03-07  0:30   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 15/70] target/hexagon: Use tcg_constant_* for gen_constant_from_imm Richard Henderson
2023-02-27 21:55   ` Taylor Simpson
2023-02-27  5:41 ` [PATCH 16/70] target/hexagon/idef-parser: Use gen_tmp for LPCFG Richard Henderson
2023-02-27 21:55   ` Taylor Simpson
2023-02-27  5:41 ` [PATCH 17/70] target/hexagon/idef-parser: Use gen_tmp for gen_pred_assign Richard Henderson
2023-02-27 21:55   ` Taylor Simpson
2023-02-27  5:41 ` [PATCH 18/70] target/hexagon/idef-parser: Use gen_tmp for gen_rvalue_pred Richard Henderson
2023-02-27 21:55   ` Taylor Simpson
2023-02-27  5:41 ` [PATCH 19/70] target/hexagon/idef-parser: Use gen_constant for gen_extend_tcg_width_op Richard Henderson
2023-02-27 21:55   ` Taylor Simpson
2023-02-27 22:00     ` Richard Henderson
2023-02-27 22:38       ` Taylor Simpson
2023-02-27  5:41 ` [PATCH 20/70] target/hppa: Avoid tcg_const_i64 in trans_fid_f Richard Henderson
2023-03-06 13:50   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 21/70] target/hppa: Avoid use of tcg_const_i32 throughout Richard Henderson
2023-03-06 23:51   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 22/70] target/i386: Simplify POPF Richard Henderson
2023-02-27  9:04   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 23/70] target/i386: Avoid use of tcg_const_* throughout Richard Henderson
2023-03-07  0:37   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 24/70] target/m68k: Reject immediate as destination in gen_ea_mode Richard Henderson
2023-02-27  5:41 ` [PATCH 25/70] target/m68k: Use tcg_constant_i32 " Richard Henderson
2023-03-06 14:14   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 26/70] target/m68k: Avoid tcg_const_i32 when modified Richard Henderson
2023-03-06 23:53   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 27/70] target/m68k: Avoid tcg_const_i32 in bfop_reg Richard Henderson
2023-03-07  0:03   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 28/70] target/m68k: Avoid tcg_const_* throughout Richard Henderson
2023-03-06 23:59   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 29/70] target/microblaze: " Richard Henderson
2023-02-27  8:56   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 30/70] target/mips: Split out gen_lxl Richard Henderson
2023-03-06 13:31   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 31/70] target/mips: Split out gen_lxr Richard Henderson
2023-03-06 13:40   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 32/70] target/mips: Avoid tcg_const_tl in gen_r6_ld Richard Henderson
2023-03-06 13:41   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 33/70] target/mips: Avoid tcg_const_* throughout Richard Henderson
2023-03-06 13:46   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 34/70] target/ppc: Split out gen_vx_vmul10 Richard Henderson
2023-03-06 15:08   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 35/70] target/ppc: Avoid tcg_const_i64 in do_vector_shift_quad Richard Henderson
2023-03-06 14:16   ` Philippe Mathieu-Daudé
2023-02-27  5:41 ` [PATCH 36/70] target/ppc: Avoid tcg_const_i64 in do_vcntmb Richard Henderson
2023-02-27  5:42 ` [PATCH 37/70] target/ppc: Avoid tcg_const_* in vmx-impl.c.inc Richard Henderson
2023-02-27  5:42 ` [PATCH 38/70] target/ppc: Avoid tcg_const_* in xxeval Richard Henderson
2023-02-27  5:42 ` [PATCH 39/70] target/ppc: Avoid tcg_const_* in vsx-impl.c.inc Richard Henderson
2023-02-27  5:42 ` [PATCH 40/70] target/ppc: Avoid tcg_const_* in fp-impl.c.inc Richard Henderson
2023-02-27  5:42 ` [PATCH 41/70] target/ppc: Avoid tcg_const_* in power8-pmu-regs.c.inc Richard Henderson
2023-02-27  5:42 ` [PATCH 42/70] target/ppc: Rewrite trans_ADDG6S Richard Henderson
2023-02-27  5:42 ` [PATCH 43/70] target/ppc: Fix gen_tlbsx_booke206 Richard Henderson
2023-02-27  5:42 ` [PATCH 44/70] target/ppc: Avoid tcg_const_* in translate.c Richard Henderson
2023-02-27  5:42 ` [PATCH 45/70] target/riscv: Avoid tcg_const_* Richard Henderson
2023-02-27  9:05   ` Philippe Mathieu-Daudé
2023-03-06 13:53   ` liweiwei
2023-02-27  5:42 ` [PATCH 46/70] target/rx: Use tcg_gen_abs_i32 Richard Henderson
2023-03-06 13:48   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 47/70] target/rx: Use cpu_psw_z as temp in flags computation Richard Henderson
2023-03-07  0:32   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 48/70] target/rx: Avoid tcg_const_i32 when new temp needed Richard Henderson
2023-03-06 14:18   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 49/70] target/rx: Avoid tcg_const_i32 Richard Henderson
2023-03-07  0:27   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 50/70] target/s390x: Split out gen_ri2 Richard Henderson
2023-02-27  9:09   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 51/70] target/s390x: Avoid tcg_const_i64 Richard Henderson
2023-03-07  0:21   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 52/70] target/sh4: Avoid tcg_const_i32 for TAS.B Richard Henderson
2023-03-07  0:23   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 53/70] target/sh4: Avoid tcg_const_i32 Richard Henderson
2023-03-07  0:21   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 54/70] tcg/sparc: Avoid tcg_const_tl in gen_edge Richard Henderson
2023-03-06 15:36   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 55/70] target/sparc: Avoid tcg_const_{tl,i32} Richard Henderson
2023-03-01 17:02   ` Mark Cave-Ayland
2023-03-06 15:37   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 56/70] target/tricore: Split t_n as constant from temp as variable Richard Henderson
2023-03-07  0:19   ` Philippe Mathieu-Daudé
2023-03-07  2:24     ` Richard Henderson
2023-03-07 10:20       ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 57/70] target/tricore: Rename t_off10 and use tcg_constant_i32 Richard Henderson
2023-03-06 15:38   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 58/70] target/tricore: Use min/max for saturate Richard Henderson
2023-02-27  5:53   ` Richard Henderson
2023-02-27  5:42 ` [PATCH 59/70] target/tricore: Use setcondi instead of explicit allocation Richard Henderson
2023-03-06 15:39   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 60/70] target/tricore: Drop some temp initialization Richard Henderson
2023-03-06 15:25   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 61/70] target/tricore: Avoid tcg_const_i32 Richard Henderson
2023-03-07  0:10   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 62/70] target/xtensa: Tidy translate_bb Richard Henderson
2023-02-27  9:19   ` Max Filippov
2023-03-07  0:07   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 63/70] target/xtensa: Tidy translate_clamps Richard Henderson
2023-02-27  9:22   ` Max Filippov
2023-03-07  0:24   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 64/70] target/xtensa: Avoid tcg_const_i32 in translate_l32r Richard Henderson
2023-02-27  9:23   ` Max Filippov
2023-03-06 15:01   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 65/70] target/xtensa: Use tcg_gen_subfi_i32 in translate_sll Richard Henderson
2023-02-27  9:26   ` Max Filippov
2023-03-06 15:01   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 66/70] target/xtensa: Split constant in bit shift Richard Henderson
2023-02-27  9:27   ` Max Filippov
2023-03-06 15:01   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 67/70] target/xtensa: Avoid tcg_const_i32 Richard Henderson
2023-02-27  9:31   ` Max Filippov
2023-03-07  0:06   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 68/70] tcg: Replace tcg_const_i64 in tcg-op.c Richard Henderson
2023-03-06 15:33   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 69/70] tcg: Drop tcg_const_*_vec Richard Henderson
2023-03-06 15:32   ` Philippe Mathieu-Daudé
2023-02-27  5:42 ` [PATCH 70/70] tcg: Drop tcg_const_* Richard Henderson
2023-03-06 15:30   ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.