All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Oliver Neukum <oneukum@suse.com>,
	Jason-ch Chen <jason-ch.chen@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"Project_Global_Chrome_Upstream_Group@mediatek.com" 
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"hsinyi@google.com" <hsinyi@google.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Thu, 30 Sep 2021 16:13:14 +0000	[thread overview]
Message-ID: <9a23368b27bd42299e74235f1f8be3fa@realtek.com> (raw)
In-Reply-To: <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com>

Oliver Neukum <oneukum@suse.com>
> Sent: Thursday, September 30, 2021 5:30 PM
[...]
> Hi,
> 
> Hayes proposed a solution. Basically you solve this the way HID or WDM do it
> delaying resubmission. This makes me wonder whether this problem is specific
> to any driver. If it is not, as I would argue, do we have a deficiency
> in our API?

I think the major question is that the driver doesn't know whether
it is necessary to stop submitting bulk transfer or not. There are
two situations with the same error code. One needs to resubmit
the bulk transfer. The other needs to stop the transfer. The original
idea is that the disconnect event would stop submitting transfer for
the second situation. However, for this case, the disconnect event
comes very late, so the submission couldn't be stopped in time.
The best solution is the driver could get another error code which
indicates the device is disappear for the second situation.  Then,
I don't need to do delayed resubmission.

Best Regards,
Hayes

WARNING: multiple messages have this Message-ID (diff)
From: Hayes Wang <hayeswang@realtek.com>
To: Oliver Neukum <oneukum@suse.com>,
	Jason-ch Chen <jason-ch.chen@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Project_Global_Chrome_Upstream_Group@mediatek.com"
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"hsinyi@google.com" <hsinyi@google.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Thu, 30 Sep 2021 16:13:14 +0000	[thread overview]
Message-ID: <9a23368b27bd42299e74235f1f8be3fa@realtek.com> (raw)
In-Reply-To: <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com>

Oliver Neukum <oneukum@suse.com>
> Sent: Thursday, September 30, 2021 5:30 PM
[...]
> Hi,
> 
> Hayes proposed a solution. Basically you solve this the way HID or WDM do it
> delaying resubmission. This makes me wonder whether this problem is specific
> to any driver. If it is not, as I would argue, do we have a deficiency
> in our API?

I think the major question is that the driver doesn't know whether
it is necessary to stop submitting bulk transfer or not. There are
two situations with the same error code. One needs to resubmit
the bulk transfer. The other needs to stop the transfer. The original
idea is that the disconnect event would stop submitting transfer for
the second situation. However, for this case, the disconnect event
comes very late, so the submission couldn't be stopped in time.
The best solution is the driver could get another error code which
indicates the device is disappear for the second situation.  Then,
I don't need to do delayed resubmission.

Best Regards,
Hayes
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Hayes Wang <hayeswang@realtek.com>
To: Oliver Neukum <oneukum@suse.com>,
	Jason-ch Chen <jason-ch.chen@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Project_Global_Chrome_Upstream_Group@mediatek.com"
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"hsinyi@google.com" <hsinyi@google.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Thu, 30 Sep 2021 16:13:14 +0000	[thread overview]
Message-ID: <9a23368b27bd42299e74235f1f8be3fa@realtek.com> (raw)
In-Reply-To: <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com>

Oliver Neukum <oneukum@suse.com>
> Sent: Thursday, September 30, 2021 5:30 PM
[...]
> Hi,
> 
> Hayes proposed a solution. Basically you solve this the way HID or WDM do it
> delaying resubmission. This makes me wonder whether this problem is specific
> to any driver. If it is not, as I would argue, do we have a deficiency
> in our API?

I think the major question is that the driver doesn't know whether
it is necessary to stop submitting bulk transfer or not. There are
two situations with the same error code. One needs to resubmit
the bulk transfer. The other needs to stop the transfer. The original
idea is that the disconnect event would stop submitting transfer for
the second situation. However, for this case, the disconnect event
comes very late, so the submission couldn't be stopped in time.
The best solution is the driver could get another error code which
indicates the device is disappear for the second situation.  Then,
I don't need to do delayed resubmission.

Best Regards,
Hayes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-30 16:13 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  5:18 [PATCH] r8152: stop submitting rx for -EPROTO Jason-ch Chen
2021-09-29  5:18 ` Jason-ch Chen
2021-09-29  5:18 ` Jason-ch Chen
2021-09-29  8:14 ` Hayes Wang
2021-09-29  8:14   ` Hayes Wang
2021-09-29  8:14   ` Hayes Wang
2021-09-29  9:52   ` Jason-ch Chen
2021-09-29  9:52     ` Jason-ch Chen
2021-09-29  9:52     ` Jason-ch Chen
2021-09-30  2:41     ` Hayes Wang
2021-09-30  2:41       ` Hayes Wang
2021-09-30  2:41       ` Hayes Wang
2021-10-01  1:36       ` Jason-ch Chen
2021-10-01  1:36         ` Jason-ch Chen
2021-10-01  1:36         ` Jason-ch Chen
2021-09-30  9:30     ` Oliver Neukum
2021-09-30  9:30       ` Oliver Neukum
2021-09-30  9:30       ` Oliver Neukum
2021-09-30 15:18       ` Alan Stern
2021-09-30 15:18         ` Alan Stern
2021-09-30 15:18         ` Alan Stern
2021-10-01  2:40         ` Hayes Wang
2021-10-01  2:40           ` Hayes Wang
2021-10-01  2:40           ` Hayes Wang
2021-10-01  3:26           ` Hayes Wang
2021-10-01  3:26             ` Hayes Wang
2021-10-01  3:26             ` Hayes Wang
2021-10-01 15:22             ` Alan Stern
2021-10-01 15:22               ` Alan Stern
2021-10-01 15:22               ` Alan Stern
2021-10-04  2:15               ` Hayes Wang
2021-10-04  2:15                 ` Hayes Wang
2021-10-04  2:15                 ` Hayes Wang
2021-10-04 11:44               ` Oliver Neukum
2021-10-04 11:44                 ` Oliver Neukum
2021-10-04 11:44                 ` Oliver Neukum
2021-10-04 14:33                 ` Alan Stern
2021-10-04 14:33                   ` Alan Stern
2021-10-04 14:33                   ` Alan Stern
2021-09-30 16:13       ` Hayes Wang [this message]
2021-09-30 16:13         ` Hayes Wang
2021-09-30 16:13         ` Hayes Wang
2021-10-04  6:28 ` [PATCH net] r8152: avoid to resubmit rx immediately Hayes Wang
2021-10-05 11:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a23368b27bd42299e74235f1f8be3fa@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=hsinyi@google.com \
    --cc=jason-ch.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.