All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 2/3] spapr: fix leak in h_client_architecture_support()
Date: Tue, 12 Jun 2018 17:13:15 -0300	[thread overview]
Message-ID: <9a605b69-a574-337e-b667-f7f8db20c84b@amsat.org> (raw)
In-Reply-To: <152882288685.114328.8550617676763950480.stgit@bahia.lan>

On 06/12/2018 02:01 PM, Greg Kurz wrote:
> If the negotiated compat mode can't be set, but raw mode is supported,
> we decide to ignore the error. An so, we should free it to prevent a
> memory leak.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/ppc/spapr_hcall.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 022f6d810182..8b9a4b577fbf 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1547,6 +1547,7 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu,
>                  error_report_err(local_err);
>                  return H_HARDWARE;
>              }
> +            error_free(local_err);
>              local_err = NULL;
>          }
>      }
> 
> 

  reply	other threads:[~2018-06-12 20:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 16:27 [Qemu-devel] [PATCH 1/3] target/ppc: drop empty #if/#endif block Greg Kurz
2018-06-12 16:43 ` Philippe Mathieu-Daudé
2018-06-12 17:01 ` [Qemu-devel] [PATCH 2/3] spapr: fix leak in h_client_architecture_support() Greg Kurz
2018-06-12 20:13   ` Philippe Mathieu-Daudé [this message]
2018-06-12 23:38   ` David Gibson
2018-06-12 17:04 ` [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG Greg Kurz
2018-06-13  0:45   ` David Gibson
2018-06-13  8:19     ` Greg Kurz
2018-06-13 12:05       ` David Gibson
2018-06-13 14:26         ` Greg Kurz
2018-06-14  1:26           ` David Gibson
2018-06-14 19:52       ` Richard Henderson
2018-06-14 22:00         ` Greg Kurz
2018-06-15  1:45           ` David Gibson
2018-06-15  3:38             ` Richard Henderson
2018-06-15  3:40               ` David Gibson
2018-06-15  8:11             ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-06-12 23:38 ` [Qemu-devel] [PATCH 1/3] target/ppc: drop empty #if/#endif block David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a605b69-a574-337e-b667-f7f8db20c84b@amsat.org \
    --to=f4bug@amsat.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.