* [PATCH] selftest/vm: clarify error statement in gup_test
@ 2022-03-30 21:52 Sidhartha Kumar
2022-03-31 1:54 ` Andrew Morton
2022-03-31 19:28 ` Shuah Khan
0 siblings, 2 replies; 3+ messages in thread
From: Sidhartha Kumar @ 2022-03-30 21:52 UTC (permalink / raw)
To: shuah, akpm
Cc: Sidhartha Kumar, linux-mm, linux-kselftest, linux-kernel, stable
Print two possible reasons /sys/kernel/debug/gup_test
cannot be opened to help users of this test diagnose
failures.
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: stable@vger.kernel.org # 5.15+
---
tools/testing/selftests/vm/gup_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c
index fe043f67798b0..c496bcefa7a0e 100644
--- a/tools/testing/selftests/vm/gup_test.c
+++ b/tools/testing/selftests/vm/gup_test.c
@@ -205,7 +205,9 @@ int main(int argc, char **argv)
gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
if (gup_fd == -1) {
- perror("open");
+ perror("failed to open /sys/kernel/debug/gup_test");
+ printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
+ printf("check if debugfs is mounted at /sys/kernel/debug\n");
exit(1);
}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftest/vm: clarify error statement in gup_test
2022-03-30 21:52 [PATCH] selftest/vm: clarify error statement in gup_test Sidhartha Kumar
@ 2022-03-31 1:54 ` Andrew Morton
2022-03-31 19:28 ` Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2022-03-31 1:54 UTC (permalink / raw)
To: Sidhartha Kumar; +Cc: shuah, linux-mm, linux-kselftest, linux-kernel, stable
On Wed, 30 Mar 2022 21:52:57 +0000 Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> Print two possible reasons /sys/kernel/debug/gup_test
> cannot be opened to help users of this test diagnose
> failures.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Cc: stable@vger.kernel.org # 5.15+
>
> ...
>
> --- a/tools/testing/selftests/vm/gup_test.c
> +++ b/tools/testing/selftests/vm/gup_test.c
> @@ -205,7 +205,9 @@ int main(int argc, char **argv)
>
> gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
> if (gup_fd == -1) {
> - perror("open");
> + perror("failed to open /sys/kernel/debug/gup_test");
> + printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
> + printf("check if debugfs is mounted at /sys/kernel/debug\n");
> exit(1);
> }
Thanks. I don't think this is -stable material...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftest/vm: clarify error statement in gup_test
2022-03-30 21:52 [PATCH] selftest/vm: clarify error statement in gup_test Sidhartha Kumar
2022-03-31 1:54 ` Andrew Morton
@ 2022-03-31 19:28 ` Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2022-03-31 19:28 UTC (permalink / raw)
To: Sidhartha Kumar, shuah, akpm
Cc: linux-mm, linux-kselftest, linux-kernel, stable, Shuah Khan
On 3/30/22 3:52 PM, Sidhartha Kumar wrote:
> Print two possible reasons /sys/kernel/debug/gup_test
> cannot be opened to help users of this test diagnose
> failures.
>
Thank you for the patch to improve rather cryptic error messages.
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Cc: stable@vger.kernel.org # 5.15+
> ---
> tools/testing/selftests/vm/gup_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c
> index fe043f67798b0..c496bcefa7a0e 100644
> --- a/tools/testing/selftests/vm/gup_test.c
> +++ b/tools/testing/selftests/vm/gup_test.c
> @@ -205,7 +205,9 @@ int main(int argc, char **argv)
>
> gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
> if (gup_fd == -1) {
> - perror("open");
> + perror("failed to open /sys/kernel/debug/gup_test");
> + printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
> + printf("check if debugfs is mounted at /sys/kernel/debug\n");
Instead of adding 3 messages in a row, please check the errno to figure
out why it failed and print an appropriate message.
If open fails because CONFIG_GUP_TEST is not enabled, the test should skip
the test instead of fail. Failing will indicate a test failure which is not
the case. The test couldn't be run due to unmet dependencies.
This test requires root access. A check for root privilege and skip the
test for the same reason stated above.
> exit(1);
> }
>
>
Please send v2 with these changes.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-31 19:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30 21:52 [PATCH] selftest/vm: clarify error statement in gup_test Sidhartha Kumar
2022-03-31 1:54 ` Andrew Morton
2022-03-31 19:28 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.