Modesetting (amdgpudrmfb) artifacts on RAVEN APU

Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

Hi list,

I'd like to report a very odd screen artifacts while running both 
4.16-rc3, as well as latest 4.16-rc4 with git linux-firmware.

I am using Ryzen 2400G with the integrate Vega.

I am aware that RAVEN support is yet to be finished, however I've read 
that some people do run it already, so I figured I will report the 
issues, since other does not seems to hit it.

I have amdgpu and all it's symbols built into the kernel image, and the 
firmware added to initrammfs. The moment modesetting is initializing I 
can see that native screen resolution goes, however, I can see only like 
25% of the screen and this very top-left 25% of screen is duplicated to 
top-right. While the bottom half of screen is either black or have 
lines, usually gray, unless some text on screen had another color then 
it's green, blue, etc.

Screenshots:

	https://i.imgur.com/qnDOKY7.jpg
	https://i.imgur.com/XH42zit.jpg

The AMD symbols that I've enabled in kernel:

     CONFIG_CPU_SUP_AMD=y
     CONFIG_X86_MCE_AMD=y
     CONFIG_AMD_NB=y
     CONFIG_NET_VENDOR_AMD=y
     CONFIG_DRM_AMDGPU=y
     CONFIG_DRM_AMDGPU_SI=y
     CONFIG_DRM_AMDGPU_CIK=y
     CONFIG_DRM_AMD_ACP=y
     CONFIG_DRM_AMD_DC=y
     CONFIG_DRM_AMD_DC_FBC=y
     CONFIG_DRM_AMD_DC_DCN1_0=y
     CONFIG_HSA_AMD=y
     CONFIG_AMD_IOMMU=y
     CONFIG_AMD_IOMMU_V2=y

The kernel log that had either drm, amd or firmware in there:

     [    0.000000] RAMDISK: [mem 0x7f88c000-0x7fffffff]
     [    0.000000] ACPI: SSDT 0x000000009BD94908 005367 (v02 AMD 
AmdTable 00000002 MSFT 02000002)
     [    0.000000] ACPI: SSDT 0x000000009BD99C70 00119C (v01 AMD    AMD 
CPU  00000001 AMD  00000001)
     [    0.000000] ACPI: CRAT 0x000000009BD9AE10 000810 (v01 AMD    AMD 
CRAT 00000001 AMD  00000001)
     [    0.000000] ACPI: CDIT 0x000000009BD9B620 000029 (v01 AMD    AMD 
CDIT 00000001 AMD  00000001)
     [    0.000000] ACPI: SSDT 0x000000009BD9B650 002E6E (v01 AMD    AMD 
AOD  00000001 INTL 20120913)
     [    0.000000] ACPI: IVRS 0x000000009BD9E580 0000D0 (v02 AMD    AMD 
IVRS 00000001 AMD  00000000)
     [    0.000000] ACPI: SSDT 0x000000009BD9E650 0000F8 (v01 AMD    AMD 
PT   00001000 INTL 20120913)
     [    0.000000] ACPI: SSDT 0x000000009BD9E748 000E96 (v01 AMD 
AmdTable 00000001 INTL 20120913)
     [    0.000000] ACPI: SSDT 0x000000009BD9F5E0 000850 (v01 AMD 
AmdTable 00000001 INTL 20120913)
     [    0.000000] ACPI: SSDT 0x000000009BD9FE30 001993 (v01 AMD 
AmdTable 00000001 INTL 20120913)
     [    0.000000] Kernel command line: BOOT_IMAGE=/bzImage-4.16.0-rc4 
rootfstype=ext4 luks enc_root=/dev/sda2 lvm 
root=/dev/mapper/megumin-rootfs 
initrd=/initramfs.cpio.gz,/firmware-initramfs.cpio.gz
     [    0.000000] ACPI Error: AE_ALREADY_EXISTS, (SSDT:  AMD PT) while 
loading table (20180105/tbxfload-228)
     [    0.080000] smpboot: CPU0: AMD Ryzen 5 2400G with Radeon Vega 
Graphics (family: 0x17, model: 0x11, stepping: 0x0)
     [    0.080000] Performance Events: Fam17h core perfctr, AMD PMU driver.
     [    0.101786] ACPI: [Firmware Bug]: BIOS _OSI(Linux) query ignored
     [    0.615782] AMD-Vi: IOMMU performance counters supported
     [    0.623179] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
     [    0.623314] AMD-Vi: Extended features (0x4f77ef22294ada):
     [    0.623684] AMD-Vi: Lazy IO/TLB flushing enabled
     [    0.624533] amd_uncore: AMD NB counters detected
     [    0.624666] amd_uncore: AMD LLC counters detected
     [    0.625076] perf/amd_iommu: Detected AMD IOMMU #0 (2 banks, 4 
counters/bank).
     [    0.636229] AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
     [    0.637179] [drm] amdgpu kernel modesetting enabled.
     [    0.637409] [drm] initializing kernel modesetting (RAVEN 
0x1002:0x15DD 0x1458:0xD000 0xC6).
     [    0.637583] [drm] register mmio base: 0xFE500000
     [    0.637709] [drm] register mmio size: 524288
     [    0.637852] [drm] probing gen 2 caps for device 1022:15db = 700d03/e
     [    0.638005] [drm] probing mlw for device 1022:15db = 700d03
     [    0.638213] [drm] VCN decode is enabled in VM mode
     [    0.638341] [drm] VCN encode is enabled in VM mode
     [    0.660265] [drm] BIOS signature incorrect 74 7
     [    0.660422] [drm] vm size is 262144 GB, 4 levels, block size is 
9-bit, fragment size is 9-bit
     [    0.660515] amdgpu 0000:09:00.0: VRAM: 1024M 0x000000F400000000 
- 0x000000F43FFFFFFF (1024M used)
     [    0.660607] amdgpu 0000:09:00.0: GTT: 1024M 0x000000F500000000 - 
0x000000F53FFFFFFF
     [    0.660689] [drm] Detected VRAM RAM=1024M, BAR=256M
     [    0.660756] [drm] RAM width 128bits UNKNOWN
     [    0.661653] [drm] amdgpu: 1024M of VRAM memory ready
     [    0.661720] [drm] amdgpu: 3072M of GTT memory ready.
     [    0.661793] [drm] GART: num cpu pages 262144, num gpu pages 262144
     [    0.662027] [drm] PCIE GART of 1024M enabled (table at 
0x000000F400800000).
     [    0.663093] [drm] use_doorbell being set to: [true]
     [    0.663229] [drm] Found VCN firmware Version: 1.73 Family ID: 18
     [    1.011745] [drm:construct] *ERROR* construct: Invalid Connector 
ObjectID from Adapter Service for connector index:1! type 0 expected 3
     [    1.011969] [drm:construct] *ERROR* construct: Invalid Connector 
ObjectID from Adapter Service for connector index:2! type 0 expected 3
     [    1.025959] [drm] Display Core initialized with v3.1.27!
     [    1.051053] [drm] Supports vblank timestamp caching Rev 2 
(21.10.2013).
     [    1.051128] [drm] Driver supports precise vblank timestamp query.
     [    1.074231] [drm] VCN decode and encode initialized successfully.
     [    1.081965] [drm] fb mappable at 0xE1000000
     [    1.082029] [drm] vram apper at 0xE0000000
     [    1.082095] [drm] size 8294400
     [    1.082155] [drm] fb depth is 24
     [    1.082216] [drm]    pitch is 7680
     [    1.082323] fbcon: amdgpudrmfb (fb0) is primary device
     [    1.200687] amdgpu 0000:09:00.0: fb0: amdgpudrmfb frame buffer 
device
     [    1.200734] amdgpu 0000:09:00.0: ring 0(gfx) uses VM inv eng 4 
on hub 0
     [    1.200752] amdgpu 0000:09:00.0: ring 1(comp_1.0.0) uses VM inv 
eng 5 on hub 0
     [    1.200770] amdgpu 0000:09:00.0: ring 2(comp_1.1.0) uses VM inv 
eng 6 on hub 0
     [    1.200788] amdgpu 0000:09:00.0: ring 3(comp_1.2.0) uses VM inv 
eng 7 on hub 0
     [    1.200806] amdgpu 0000:09:00.0: ring 4(comp_1.3.0) uses VM inv 
eng 8 on hub 0
     [    1.200824] amdgpu 0000:09:00.0: ring 5(comp_1.0.1) uses VM inv 
eng 9 on hub 0
     [    1.200845] amdgpu 0000:09:00.0: ring 6(comp_1.1.1) uses VM inv 
eng 10 on hub 0
     [    1.200863] amdgpu 0000:09:00.0: ring 7(comp_1.2.1) uses VM inv 
eng 11 on hub 0
     [    1.200881] amdgpu 0000:09:00.0: ring 8(comp_1.3.1) uses VM inv 
eng 12 on hub 0
     [    1.200900] amdgpu 0000:09:00.0: ring 9(kiq_2.1.0) uses VM inv 
eng 13 on hub 0
     [    1.200918] amdgpu 0000:09:00.0: ring 10(sdma0) uses VM inv eng 
4 on hub 1
     [    1.200935] amdgpu 0000:09:00.0: ring 11(vcn_dec) uses VM inv 
eng 5 on hub 1
     [    1.200952] amdgpu 0000:09:00.0: ring 12(vcn_enc0) uses VM inv 
eng 6 on hub 1
     [    1.200970] amdgpu 0000:09:00.0: ring 13(vcn_enc1) uses VM inv 
eng 7 on hub 1
     [    1.204453] [drm] Initialized amdgpu 3.23.0 20150101 for 
0000:09:00.0 on minor 0

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Tom St Denis]

[-- Attachment #1: Type: text/plain, Size: 8560 bytes --]

I believe this is the same issue I had which is a VGA handoff problem.

Can you try this patch the display team sent me?

Harry:  Will this patch be promoted in the next cycle?

Tom

On 03/05/2018 11:40 AM, KARBOWSKI Piotr wrote:
> Hi list,
> 
> I'd like to report a very odd screen artifacts while running both 
> 4.16-rc3, as well as latest 4.16-rc4 with git linux-firmware.
> 
> I am using Ryzen 2400G with the integrate Vega.
> 
> I am aware that RAVEN support is yet to be finished, however I've read 
> that some people do run it already, so I figured I will report the 
> issues, since other does not seems to hit it.
> 
> I have amdgpu and all it's symbols built into the kernel image, and the 
> firmware added to initrammfs. The moment modesetting is initializing I 
> can see that native screen resolution goes, however, I can see only like 
> 25% of the screen and this very top-left 25% of screen is duplicated to 
> top-right. While the bottom half of screen is either black or have 
> lines, usually gray, unless some text on screen had another color then 
> it's green, blue, etc.
> 
> Screenshots:
> 
>      https://i.imgur.com/qnDOKY7.jpg
>      https://i.imgur.com/XH42zit.jpg
> 
> The AMD symbols that I've enabled in kernel:
> 
>      CONFIG_CPU_SUP_AMD=y
>      CONFIG_X86_MCE_AMD=y
>      CONFIG_AMD_NB=y
>      CONFIG_NET_VENDOR_AMD=y
>      CONFIG_DRM_AMDGPU=y
>      CONFIG_DRM_AMDGPU_SI=y
>      CONFIG_DRM_AMDGPU_CIK=y
>      CONFIG_DRM_AMD_ACP=y
>      CONFIG_DRM_AMD_DC=y
>      CONFIG_DRM_AMD_DC_FBC=y
>      CONFIG_DRM_AMD_DC_DCN1_0=y
>      CONFIG_HSA_AMD=y
>      CONFIG_AMD_IOMMU=y
>      CONFIG_AMD_IOMMU_V2=y
> 
> The kernel log that had either drm, amd or firmware in there:
> 
>      [    0.000000] RAMDISK: [mem 0x7f88c000-0x7fffffff]
>      [    0.000000] ACPI: SSDT 0x000000009BD94908 005367 (v02 AMD 
> AmdTable 00000002 MSFT 02000002)
>      [    0.000000] ACPI: SSDT 0x000000009BD99C70 00119C (v01 AMD    AMD 
> CPU  00000001 AMD  00000001)
>      [    0.000000] ACPI: CRAT 0x000000009BD9AE10 000810 (v01 AMD    AMD 
> CRAT 00000001 AMD  00000001)
>      [    0.000000] ACPI: CDIT 0x000000009BD9B620 000029 (v01 AMD    AMD 
> CDIT 00000001 AMD  00000001)
>      [    0.000000] ACPI: SSDT 0x000000009BD9B650 002E6E (v01 AMD    AMD 
> AOD  00000001 INTL 20120913)
>      [    0.000000] ACPI: IVRS 0x000000009BD9E580 0000D0 (v02 AMD    AMD 
> IVRS 00000001 AMD  00000000)
>      [    0.000000] ACPI: SSDT 0x000000009BD9E650 0000F8 (v01 AMD    AMD 
> PT   00001000 INTL 20120913)
>      [    0.000000] ACPI: SSDT 0x000000009BD9E748 000E96 (v01 AMD 
> AmdTable 00000001 INTL 20120913)
>      [    0.000000] ACPI: SSDT 0x000000009BD9F5E0 000850 (v01 AMD 
> AmdTable 00000001 INTL 20120913)
>      [    0.000000] ACPI: SSDT 0x000000009BD9FE30 001993 (v01 AMD 
> AmdTable 00000001 INTL 20120913)
>      [    0.000000] Kernel command line: BOOT_IMAGE=/bzImage-4.16.0-rc4 
> rootfstype=ext4 luks enc_root=/dev/sda2 lvm 
> root=/dev/mapper/megumin-rootfs 
> initrd=/initramfs.cpio.gz,/firmware-initramfs.cpio.gz
>      [    0.000000] ACPI Error: AE_ALREADY_EXISTS, (SSDT:  AMD PT) while 
> loading table (20180105/tbxfload-228)
>      [    0.080000] smpboot: CPU0: AMD Ryzen 5 2400G with Radeon Vega 
> Graphics (family: 0x17, model: 0x11, stepping: 0x0)
>      [    0.080000] Performance Events: Fam17h core perfctr, AMD PMU 
> driver.
>      [    0.101786] ACPI: [Firmware Bug]: BIOS _OSI(Linux) query ignored
>      [    0.615782] AMD-Vi: IOMMU performance counters supported
>      [    0.623179] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
>      [    0.623314] AMD-Vi: Extended features (0x4f77ef22294ada):
>      [    0.623684] AMD-Vi: Lazy IO/TLB flushing enabled
>      [    0.624533] amd_uncore: AMD NB counters detected
>      [    0.624666] amd_uncore: AMD LLC counters detected
>      [    0.625076] perf/amd_iommu: Detected AMD IOMMU #0 (2 banks, 4 
> counters/bank).
>      [    0.636229] AMD IOMMUv2 driver by Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
>      [    0.637179] [drm] amdgpu kernel modesetting enabled.
>      [    0.637409] [drm] initializing kernel modesetting (RAVEN 
> 0x1002:0x15DD 0x1458:0xD000 0xC6).
>      [    0.637583] [drm] register mmio base: 0xFE500000
>      [    0.637709] [drm] register mmio size: 524288
>      [    0.637852] [drm] probing gen 2 caps for device 1022:15db = 
> 700d03/e
>      [    0.638005] [drm] probing mlw for device 1022:15db = 700d03
>      [    0.638213] [drm] VCN decode is enabled in VM mode
>      [    0.638341] [drm] VCN encode is enabled in VM mode
>      [    0.660265] [drm] BIOS signature incorrect 74 7
>      [    0.660422] [drm] vm size is 262144 GB, 4 levels, block size is 
> 9-bit, fragment size is 9-bit
>      [    0.660515] amdgpu 0000:09:00.0: VRAM: 1024M 0x000000F400000000 
> - 0x000000F43FFFFFFF (1024M used)
>      [    0.660607] amdgpu 0000:09:00.0: GTT: 1024M 0x000000F500000000 - 
> 0x000000F53FFFFFFF
>      [    0.660689] [drm] Detected VRAM RAM=1024M, BAR=256M
>      [    0.660756] [drm] RAM width 128bits UNKNOWN
>      [    0.661653] [drm] amdgpu: 1024M of VRAM memory ready
>      [    0.661720] [drm] amdgpu: 3072M of GTT memory ready.
>      [    0.661793] [drm] GART: num cpu pages 262144, num gpu pages 262144
>      [    0.662027] [drm] PCIE GART of 1024M enabled (table at 
> 0x000000F400800000).
>      [    0.663093] [drm] use_doorbell being set to: [true]
>      [    0.663229] [drm] Found VCN firmware Version: 1.73 Family ID: 18
>      [    1.011745] [drm:construct] *ERROR* construct: Invalid Connector 
> ObjectID from Adapter Service for connector index:1! type 0 expected 3
>      [    1.011969] [drm:construct] *ERROR* construct: Invalid Connector 
> ObjectID from Adapter Service for connector index:2! type 0 expected 3
>      [    1.025959] [drm] Display Core initialized with v3.1.27!
>      [    1.051053] [drm] Supports vblank timestamp caching Rev 2 
> (21.10.2013).
>      [    1.051128] [drm] Driver supports precise vblank timestamp query.
>      [    1.074231] [drm] VCN decode and encode initialized successfully.
>      [    1.081965] [drm] fb mappable at 0xE1000000
>      [    1.082029] [drm] vram apper at 0xE0000000
>      [    1.082095] [drm] size 8294400
>      [    1.082155] [drm] fb depth is 24
>      [    1.082216] [drm]    pitch is 7680
>      [    1.082323] fbcon: amdgpudrmfb (fb0) is primary device
>      [    1.200687] amdgpu 0000:09:00.0: fb0: amdgpudrmfb frame buffer 
> device
>      [    1.200734] amdgpu 0000:09:00.0: ring 0(gfx) uses VM inv eng 4 
> on hub 0
>      [    1.200752] amdgpu 0000:09:00.0: ring 1(comp_1.0.0) uses VM inv 
> eng 5 on hub 0
>      [    1.200770] amdgpu 0000:09:00.0: ring 2(comp_1.1.0) uses VM inv 
> eng 6 on hub 0
>      [    1.200788] amdgpu 0000:09:00.0: ring 3(comp_1.2.0) uses VM inv 
> eng 7 on hub 0
>      [    1.200806] amdgpu 0000:09:00.0: ring 4(comp_1.3.0) uses VM inv 
> eng 8 on hub 0
>      [    1.200824] amdgpu 0000:09:00.0: ring 5(comp_1.0.1) uses VM inv 
> eng 9 on hub 0
>      [    1.200845] amdgpu 0000:09:00.0: ring 6(comp_1.1.1) uses VM inv 
> eng 10 on hub 0
>      [    1.200863] amdgpu 0000:09:00.0: ring 7(comp_1.2.1) uses VM inv 
> eng 11 on hub 0
>      [    1.200881] amdgpu 0000:09:00.0: ring 8(comp_1.3.1) uses VM inv 
> eng 12 on hub 0
>      [    1.200900] amdgpu 0000:09:00.0: ring 9(kiq_2.1.0) uses VM inv 
> eng 13 on hub 0
>      [    1.200918] amdgpu 0000:09:00.0: ring 10(sdma0) uses VM inv eng 
> 4 on hub 1
>      [    1.200935] amdgpu 0000:09:00.0: ring 11(vcn_dec) uses VM inv 
> eng 5 on hub 1
>      [    1.200952] amdgpu 0000:09:00.0: ring 12(vcn_enc0) uses VM inv 
> eng 6 on hub 1
>      [    1.200970] amdgpu 0000:09:00.0: ring 13(vcn_enc1) uses VM inv 
> eng 7 on hub 1
>      [    1.204453] [drm] Initialized amdgpu 3.23.0 20150101 for 
> 0000:09:00.0 on minor 0
> 
> -- Piotr.
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #2: 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch --]
[-- Type: text/x-patch, Size: 3021 bytes --]

>From d8b5b07a417df123ed5eda909a266b0632f2b0d8 Mon Sep 17 00:00:00 2001
From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
Date: Tue, 27 Feb 2018 10:15:56 -0500
Subject: [PATCH] drm/amd/display: Fix takeover from VGA mode

HW Engineer's Notes:
During switch from vga->extended, if we set the VGA_TEST_ENABLE and then
hit the VGA_TEST_RENDER_START, then the DCHUBP timing gets updated correctly.
Then vBIOS will have it poll for the VGA_TEST_RENDER_DONE and unset
VGA_TEST_ENABLE, to leave it in the same state as before.

Signed-off-by: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h            | 10 ++++++++--
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c |  2 ++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h b/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h
index 3336428b1fed..4448cf926179 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h
@@ -190,6 +190,7 @@
 	SR(D2VGA_CONTROL), \
 	SR(D3VGA_CONTROL), \
 	SR(D4VGA_CONTROL), \
+	SR(VGA_TEST_CONTROL), \
 	SR(DC_IP_REQUEST_CNTL), \
 	BL_REG_LIST()
 
@@ -261,6 +262,7 @@ struct dce_hwseq_registers {
 	uint32_t D2VGA_CONTROL;
 	uint32_t D3VGA_CONTROL;
 	uint32_t D4VGA_CONTROL;
+	uint32_t VGA_TEST_CONTROL;
 	/* MMHUB registers. read only. temporary hack */
 	uint32_t VM_CONTEXT0_PAGE_TABLE_BASE_ADDR_HI32;
 	uint32_t VM_CONTEXT0_PAGE_TABLE_BASE_ADDR_LO32;
@@ -358,7 +360,9 @@ struct dce_hwseq_registers {
 	HWSEQ_PIXEL_RATE_MASK_SH_LIST(mask_sh, OTG0_),\
 	HWS_SF1(OTG0_, PHYPLL_PIXEL_RATE_CNTL, PHYPLL_PIXEL_RATE_SOURCE, mask_sh), \
 	HWS_SF(, DCHUBBUB_GLOBAL_TIMER_CNTL, DCHUBBUB_GLOBAL_TIMER_ENABLE, mask_sh), \
-	HWS_SF(, DCFCLK_CNTL, DCFCLK_GATE_DIS, mask_sh)
+	HWS_SF(, DCFCLK_CNTL, DCFCLK_GATE_DIS, mask_sh),\
+	HWS_SF(, VGA_TEST_CONTROL, VGA_TEST_ENABLE, mask_sh),\
+	HWS_SF(, VGA_TEST_CONTROL, VGA_TEST_RENDER_START, mask_sh)
 
 #define HWSEQ_DCN1_MASK_SH_LIST(mask_sh)\
 	HWSEQ_DCN_MASK_SH_LIST(mask_sh), \
@@ -483,7 +487,9 @@ struct dce_hwseq_registers {
 	type DCFCLK_GATE_DIS; \
 	type DCHUBBUB_GLOBAL_TIMER_REFDIV; \
 	type DENTIST_DPPCLK_WDIVIDER; \
-	type DENTIST_DISPCLK_WDIVIDER;
+	type DENTIST_DISPCLK_WDIVIDER; \
+	type VGA_TEST_ENABLE; \
+	type VGA_TEST_RENDER_START;
 
 struct dce_hwseq_shift {
 	HWSEQ_REG_FIELD_LIST(uint8_t)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 1907ade1574a..eedf83078751 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -224,6 +224,8 @@ static void disable_vga(
 	REG_WRITE(D2VGA_CONTROL, 0);
 	REG_WRITE(D3VGA_CONTROL, 0);
 	REG_WRITE(D4VGA_CONTROL, 0);
+	REG_UPDATE(VGA_TEST_CONTROL, VGA_TEST_ENABLE, 1);
+	REG_UPDATE(VGA_TEST_CONTROL, VGA_TEST_RENDER_START, 1);
 }
 
 static void dpp_pg_control(
-- 
2.14.3


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Alex Deucher]

On Tue, Mar 6, 2018 at 6:18 AM, Tom St Denis <tstdenis@amd.com> wrote:
> I believe this is the same issue I had which is a VGA handoff problem.
>
> Can you try this patch the display team sent me?
>
> Harry:  Will this patch be promoted in the next cycle?

I think it will eventually.  IIRC, there were some regressions with it
that are still being worked out.

Alex

>
> Tom
>
>
> On 03/05/2018 11:40 AM, KARBOWSKI Piotr wrote:
>>
>> Hi list,
>>
>> I'd like to report a very odd screen artifacts while running both
>> 4.16-rc3, as well as latest 4.16-rc4 with git linux-firmware.
>>
>> I am using Ryzen 2400G with the integrate Vega.
>>
>> I am aware that RAVEN support is yet to be finished, however I've read
>> that some people do run it already, so I figured I will report the issues,
>> since other does not seems to hit it.
>>
>> I have amdgpu and all it's symbols built into the kernel image, and the
>> firmware added to initrammfs. The moment modesetting is initializing I can
>> see that native screen resolution goes, however, I can see only like 25% of
>> the screen and this very top-left 25% of screen is duplicated to top-right.
>> While the bottom half of screen is either black or have lines, usually gray,
>> unless some text on screen had another color then it's green, blue, etc.
>>
>> Screenshots:
>>
>>      https://i.imgur.com/qnDOKY7.jpg
>>      https://i.imgur.com/XH42zit.jpg
>>
>> The AMD symbols that I've enabled in kernel:
>>
>>      CONFIG_CPU_SUP_AMD=y
>>      CONFIG_X86_MCE_AMD=y
>>      CONFIG_AMD_NB=y
>>      CONFIG_NET_VENDOR_AMD=y
>>      CONFIG_DRM_AMDGPU=y
>>      CONFIG_DRM_AMDGPU_SI=y
>>      CONFIG_DRM_AMDGPU_CIK=y
>>      CONFIG_DRM_AMD_ACP=y
>>      CONFIG_DRM_AMD_DC=y
>>      CONFIG_DRM_AMD_DC_FBC=y
>>      CONFIG_DRM_AMD_DC_DCN1_0=y
>>      CONFIG_HSA_AMD=y
>>      CONFIG_AMD_IOMMU=y
>>      CONFIG_AMD_IOMMU_V2=y
>>
>> The kernel log that had either drm, amd or firmware in there:
>>
>>      [    0.000000] RAMDISK: [mem 0x7f88c000-0x7fffffff]
>>      [    0.000000] ACPI: SSDT 0x000000009BD94908 005367 (v02 AMD AmdTable
>> 00000002 MSFT 02000002)
>>      [    0.000000] ACPI: SSDT 0x000000009BD99C70 00119C (v01 AMD    AMD
>> CPU  00000001 AMD  00000001)
>>      [    0.000000] ACPI: CRAT 0x000000009BD9AE10 000810 (v01 AMD    AMD
>> CRAT 00000001 AMD  00000001)
>>      [    0.000000] ACPI: CDIT 0x000000009BD9B620 000029 (v01 AMD    AMD
>> CDIT 00000001 AMD  00000001)
>>      [    0.000000] ACPI: SSDT 0x000000009BD9B650 002E6E (v01 AMD    AMD
>> AOD  00000001 INTL 20120913)
>>      [    0.000000] ACPI: IVRS 0x000000009BD9E580 0000D0 (v02 AMD    AMD
>> IVRS 00000001 AMD  00000000)
>>      [    0.000000] ACPI: SSDT 0x000000009BD9E650 0000F8 (v01 AMD    AMD
>> PT   00001000 INTL 20120913)
>>      [    0.000000] ACPI: SSDT 0x000000009BD9E748 000E96 (v01 AMD AmdTable
>> 00000001 INTL 20120913)
>>      [    0.000000] ACPI: SSDT 0x000000009BD9F5E0 000850 (v01 AMD AmdTable
>> 00000001 INTL 20120913)
>>      [    0.000000] ACPI: SSDT 0x000000009BD9FE30 001993 (v01 AMD AmdTable
>> 00000001 INTL 20120913)
>>      [    0.000000] Kernel command line: BOOT_IMAGE=/bzImage-4.16.0-rc4
>> rootfstype=ext4 luks enc_root=/dev/sda2 lvm root=/dev/mapper/megumin-rootfs
>> initrd=/initramfs.cpio.gz,/firmware-initramfs.cpio.gz
>>      [    0.000000] ACPI Error: AE_ALREADY_EXISTS, (SSDT:  AMD PT) while
>> loading table (20180105/tbxfload-228)
>>      [    0.080000] smpboot: CPU0: AMD Ryzen 5 2400G with Radeon Vega
>> Graphics (family: 0x17, model: 0x11, stepping: 0x0)
>>      [    0.080000] Performance Events: Fam17h core perfctr, AMD PMU
>> driver.
>>      [    0.101786] ACPI: [Firmware Bug]: BIOS _OSI(Linux) query ignored
>>      [    0.615782] AMD-Vi: IOMMU performance counters supported
>>      [    0.623179] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
>>      [    0.623314] AMD-Vi: Extended features (0x4f77ef22294ada):
>>      [    0.623684] AMD-Vi: Lazy IO/TLB flushing enabled
>>      [    0.624533] amd_uncore: AMD NB counters detected
>>      [    0.624666] amd_uncore: AMD LLC counters detected
>>      [    0.625076] perf/amd_iommu: Detected AMD IOMMU #0 (2 banks, 4
>> counters/bank).
>>      [    0.636229] AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
>>      [    0.637179] [drm] amdgpu kernel modesetting enabled.
>>      [    0.637409] [drm] initializing kernel modesetting (RAVEN
>> 0x1002:0x15DD 0x1458:0xD000 0xC6).
>>      [    0.637583] [drm] register mmio base: 0xFE500000
>>      [    0.637709] [drm] register mmio size: 524288
>>      [    0.637852] [drm] probing gen 2 caps for device 1022:15db =
>> 700d03/e
>>      [    0.638005] [drm] probing mlw for device 1022:15db = 700d03
>>      [    0.638213] [drm] VCN decode is enabled in VM mode
>>      [    0.638341] [drm] VCN encode is enabled in VM mode
>>      [    0.660265] [drm] BIOS signature incorrect 74 7
>>      [    0.660422] [drm] vm size is 262144 GB, 4 levels, block size is
>> 9-bit, fragment size is 9-bit
>>      [    0.660515] amdgpu 0000:09:00.0: VRAM: 1024M 0x000000F400000000 -
>> 0x000000F43FFFFFFF (1024M used)
>>      [    0.660607] amdgpu 0000:09:00.0: GTT: 1024M 0x000000F500000000 -
>> 0x000000F53FFFFFFF
>>      [    0.660689] [drm] Detected VRAM RAM=1024M, BAR=256M
>>      [    0.660756] [drm] RAM width 128bits UNKNOWN
>>      [    0.661653] [drm] amdgpu: 1024M of VRAM memory ready
>>      [    0.661720] [drm] amdgpu: 3072M of GTT memory ready.
>>      [    0.661793] [drm] GART: num cpu pages 262144, num gpu pages 262144
>>      [    0.662027] [drm] PCIE GART of 1024M enabled (table at
>> 0x000000F400800000).
>>      [    0.663093] [drm] use_doorbell being set to: [true]
>>      [    0.663229] [drm] Found VCN firmware Version: 1.73 Family ID: 18
>>      [    1.011745] [drm:construct] *ERROR* construct: Invalid Connector
>> ObjectID from Adapter Service for connector index:1! type 0 expected 3
>>      [    1.011969] [drm:construct] *ERROR* construct: Invalid Connector
>> ObjectID from Adapter Service for connector index:2! type 0 expected 3
>>      [    1.025959] [drm] Display Core initialized with v3.1.27!
>>      [    1.051053] [drm] Supports vblank timestamp caching Rev 2
>> (21.10.2013).
>>      [    1.051128] [drm] Driver supports precise vblank timestamp query.
>>      [    1.074231] [drm] VCN decode and encode initialized successfully.
>>      [    1.081965] [drm] fb mappable at 0xE1000000
>>      [    1.082029] [drm] vram apper at 0xE0000000
>>      [    1.082095] [drm] size 8294400
>>      [    1.082155] [drm] fb depth is 24
>>      [    1.082216] [drm]    pitch is 7680
>>      [    1.082323] fbcon: amdgpudrmfb (fb0) is primary device
>>      [    1.200687] amdgpu 0000:09:00.0: fb0: amdgpudrmfb frame buffer
>> device
>>      [    1.200734] amdgpu 0000:09:00.0: ring 0(gfx) uses VM inv eng 4 on
>> hub 0
>>      [    1.200752] amdgpu 0000:09:00.0: ring 1(comp_1.0.0) uses VM inv
>> eng 5 on hub 0
>>      [    1.200770] amdgpu 0000:09:00.0: ring 2(comp_1.1.0) uses VM inv
>> eng 6 on hub 0
>>      [    1.200788] amdgpu 0000:09:00.0: ring 3(comp_1.2.0) uses VM inv
>> eng 7 on hub 0
>>      [    1.200806] amdgpu 0000:09:00.0: ring 4(comp_1.3.0) uses VM inv
>> eng 8 on hub 0
>>      [    1.200824] amdgpu 0000:09:00.0: ring 5(comp_1.0.1) uses VM inv
>> eng 9 on hub 0
>>      [    1.200845] amdgpu 0000:09:00.0: ring 6(comp_1.1.1) uses VM inv
>> eng 10 on hub 0
>>      [    1.200863] amdgpu 0000:09:00.0: ring 7(comp_1.2.1) uses VM inv
>> eng 11 on hub 0
>>      [    1.200881] amdgpu 0000:09:00.0: ring 8(comp_1.3.1) uses VM inv
>> eng 12 on hub 0
>>      [    1.200900] amdgpu 0000:09:00.0: ring 9(kiq_2.1.0) uses VM inv eng
>> 13 on hub 0
>>      [    1.200918] amdgpu 0000:09:00.0: ring 10(sdma0) uses VM inv eng 4
>> on hub 1
>>      [    1.200935] amdgpu 0000:09:00.0: ring 11(vcn_dec) uses VM inv eng
>> 5 on hub 1
>>      [    1.200952] amdgpu 0000:09:00.0: ring 12(vcn_enc0) uses VM inv eng
>> 6 on hub 1
>>      [    1.200970] amdgpu 0000:09:00.0: ring 13(vcn_enc1) uses VM inv eng
>> 7 on hub 1
>>      [    1.204453] [drm] Initialized amdgpu 3.23.0 20150101 for
>> 0000:09:00.0 on minor 0
>>
>> -- Piotr.
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

On 2018-03-06 11:13 AM, Alex Deucher wrote:
> On Tue, Mar 6, 2018 at 6:18 AM, Tom St Denis <tstdenis@amd.com> wrote:
>> I believe this is the same issue I had which is a VGA handoff problem.
>>
>> Can you try this patch the display team sent me?
>>
>> Harry:  Will this patch be promoted in the next cycle?
> 
> I think it will eventually.  IIRC, there were some regressions with it
> that are still being worked out.
> 

Should be in next set of DC patches.

Harry

> Alex
> 
>>
>> Tom
>>
>>
>> On 03/05/2018 11:40 AM, KARBOWSKI Piotr wrote:
>>>
>>> Hi list,
>>>
>>> I'd like to report a very odd screen artifacts while running both
>>> 4.16-rc3, as well as latest 4.16-rc4 with git linux-firmware.
>>>
>>> I am using Ryzen 2400G with the integrate Vega.
>>>
>>> I am aware that RAVEN support is yet to be finished, however I've read
>>> that some people do run it already, so I figured I will report the issues,
>>> since other does not seems to hit it.
>>>
>>> I have amdgpu and all it's symbols built into the kernel image, and the
>>> firmware added to initrammfs. The moment modesetting is initializing I can
>>> see that native screen resolution goes, however, I can see only like 25% of
>>> the screen and this very top-left 25% of screen is duplicated to top-right.
>>> While the bottom half of screen is either black or have lines, usually gray,
>>> unless some text on screen had another color then it's green, blue, etc.
>>>
>>> Screenshots:
>>>
>>>      https://i.imgur.com/qnDOKY7.jpg
>>>      https://i.imgur.com/XH42zit.jpg
>>>
>>> The AMD symbols that I've enabled in kernel:
>>>
>>>      CONFIG_CPU_SUP_AMD=y
>>>      CONFIG_X86_MCE_AMD=y
>>>      CONFIG_AMD_NB=y
>>>      CONFIG_NET_VENDOR_AMD=y
>>>      CONFIG_DRM_AMDGPU=y
>>>      CONFIG_DRM_AMDGPU_SI=y
>>>      CONFIG_DRM_AMDGPU_CIK=y
>>>      CONFIG_DRM_AMD_ACP=y
>>>      CONFIG_DRM_AMD_DC=y
>>>      CONFIG_DRM_AMD_DC_FBC=y
>>>      CONFIG_DRM_AMD_DC_DCN1_0=y
>>>      CONFIG_HSA_AMD=y
>>>      CONFIG_AMD_IOMMU=y
>>>      CONFIG_AMD_IOMMU_V2=y
>>>
>>> The kernel log that had either drm, amd or firmware in there:
>>>
>>>      [    0.000000] RAMDISK: [mem 0x7f88c000-0x7fffffff]
>>>      [    0.000000] ACPI: SSDT 0x000000009BD94908 005367 (v02 AMD AmdTable
>>> 00000002 MSFT 02000002)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD99C70 00119C (v01 AMD    AMD
>>> CPU  00000001 AMD  00000001)
>>>      [    0.000000] ACPI: CRAT 0x000000009BD9AE10 000810 (v01 AMD    AMD
>>> CRAT 00000001 AMD  00000001)
>>>      [    0.000000] ACPI: CDIT 0x000000009BD9B620 000029 (v01 AMD    AMD
>>> CDIT 00000001 AMD  00000001)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD9B650 002E6E (v01 AMD    AMD
>>> AOD  00000001 INTL 20120913)
>>>      [    0.000000] ACPI: IVRS 0x000000009BD9E580 0000D0 (v02 AMD    AMD
>>> IVRS 00000001 AMD  00000000)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD9E650 0000F8 (v01 AMD    AMD
>>> PT   00001000 INTL 20120913)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD9E748 000E96 (v01 AMD AmdTable
>>> 00000001 INTL 20120913)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD9F5E0 000850 (v01 AMD AmdTable
>>> 00000001 INTL 20120913)
>>>      [    0.000000] ACPI: SSDT 0x000000009BD9FE30 001993 (v01 AMD AmdTable
>>> 00000001 INTL 20120913)
>>>      [    0.000000] Kernel command line: BOOT_IMAGE=/bzImage-4.16.0-rc4
>>> rootfstype=ext4 luks enc_root=/dev/sda2 lvm root=/dev/mapper/megumin-rootfs
>>> initrd=/initramfs.cpio.gz,/firmware-initramfs.cpio.gz
>>>      [    0.000000] ACPI Error: AE_ALREADY_EXISTS, (SSDT:  AMD PT) while
>>> loading table (20180105/tbxfload-228)
>>>      [    0.080000] smpboot: CPU0: AMD Ryzen 5 2400G with Radeon Vega
>>> Graphics (family: 0x17, model: 0x11, stepping: 0x0)
>>>      [    0.080000] Performance Events: Fam17h core perfctr, AMD PMU
>>> driver.
>>>      [    0.101786] ACPI: [Firmware Bug]: BIOS _OSI(Linux) query ignored
>>>      [    0.615782] AMD-Vi: IOMMU performance counters supported
>>>      [    0.623179] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
>>>      [    0.623314] AMD-Vi: Extended features (0x4f77ef22294ada):
>>>      [    0.623684] AMD-Vi: Lazy IO/TLB flushing enabled
>>>      [    0.624533] amd_uncore: AMD NB counters detected
>>>      [    0.624666] amd_uncore: AMD LLC counters detected
>>>      [    0.625076] perf/amd_iommu: Detected AMD IOMMU #0 (2 banks, 4
>>> counters/bank).
>>>      [    0.636229] AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
>>>      [    0.637179] [drm] amdgpu kernel modesetting enabled.
>>>      [    0.637409] [drm] initializing kernel modesetting (RAVEN
>>> 0x1002:0x15DD 0x1458:0xD000 0xC6).
>>>      [    0.637583] [drm] register mmio base: 0xFE500000
>>>      [    0.637709] [drm] register mmio size: 524288
>>>      [    0.637852] [drm] probing gen 2 caps for device 1022:15db =
>>> 700d03/e
>>>      [    0.638005] [drm] probing mlw for device 1022:15db = 700d03
>>>      [    0.638213] [drm] VCN decode is enabled in VM mode
>>>      [    0.638341] [drm] VCN encode is enabled in VM mode
>>>      [    0.660265] [drm] BIOS signature incorrect 74 7
>>>      [    0.660422] [drm] vm size is 262144 GB, 4 levels, block size is
>>> 9-bit, fragment size is 9-bit
>>>      [    0.660515] amdgpu 0000:09:00.0: VRAM: 1024M 0x000000F400000000 -
>>> 0x000000F43FFFFFFF (1024M used)
>>>      [    0.660607] amdgpu 0000:09:00.0: GTT: 1024M 0x000000F500000000 -
>>> 0x000000F53FFFFFFF
>>>      [    0.660689] [drm] Detected VRAM RAM=1024M, BAR=256M
>>>      [    0.660756] [drm] RAM width 128bits UNKNOWN
>>>      [    0.661653] [drm] amdgpu: 1024M of VRAM memory ready
>>>      [    0.661720] [drm] amdgpu: 3072M of GTT memory ready.
>>>      [    0.661793] [drm] GART: num cpu pages 262144, num gpu pages 262144
>>>      [    0.662027] [drm] PCIE GART of 1024M enabled (table at
>>> 0x000000F400800000).
>>>      [    0.663093] [drm] use_doorbell being set to: [true]
>>>      [    0.663229] [drm] Found VCN firmware Version: 1.73 Family ID: 18
>>>      [    1.011745] [drm:construct] *ERROR* construct: Invalid Connector
>>> ObjectID from Adapter Service for connector index:1! type 0 expected 3
>>>      [    1.011969] [drm:construct] *ERROR* construct: Invalid Connector
>>> ObjectID from Adapter Service for connector index:2! type 0 expected 3
>>>      [    1.025959] [drm] Display Core initialized with v3.1.27!
>>>      [    1.051053] [drm] Supports vblank timestamp caching Rev 2
>>> (21.10.2013).
>>>      [    1.051128] [drm] Driver supports precise vblank timestamp query.
>>>      [    1.074231] [drm] VCN decode and encode initialized successfully.
>>>      [    1.081965] [drm] fb mappable at 0xE1000000
>>>      [    1.082029] [drm] vram apper at 0xE0000000
>>>      [    1.082095] [drm] size 8294400
>>>      [    1.082155] [drm] fb depth is 24
>>>      [    1.082216] [drm]    pitch is 7680
>>>      [    1.082323] fbcon: amdgpudrmfb (fb0) is primary device
>>>      [    1.200687] amdgpu 0000:09:00.0: fb0: amdgpudrmfb frame buffer
>>> device
>>>      [    1.200734] amdgpu 0000:09:00.0: ring 0(gfx) uses VM inv eng 4 on
>>> hub 0
>>>      [    1.200752] amdgpu 0000:09:00.0: ring 1(comp_1.0.0) uses VM inv
>>> eng 5 on hub 0
>>>      [    1.200770] amdgpu 0000:09:00.0: ring 2(comp_1.1.0) uses VM inv
>>> eng 6 on hub 0
>>>      [    1.200788] amdgpu 0000:09:00.0: ring 3(comp_1.2.0) uses VM inv
>>> eng 7 on hub 0
>>>      [    1.200806] amdgpu 0000:09:00.0: ring 4(comp_1.3.0) uses VM inv
>>> eng 8 on hub 0
>>>      [    1.200824] amdgpu 0000:09:00.0: ring 5(comp_1.0.1) uses VM inv
>>> eng 9 on hub 0
>>>      [    1.200845] amdgpu 0000:09:00.0: ring 6(comp_1.1.1) uses VM inv
>>> eng 10 on hub 0
>>>      [    1.200863] amdgpu 0000:09:00.0: ring 7(comp_1.2.1) uses VM inv
>>> eng 11 on hub 0
>>>      [    1.200881] amdgpu 0000:09:00.0: ring 8(comp_1.3.1) uses VM inv
>>> eng 12 on hub 0
>>>      [    1.200900] amdgpu 0000:09:00.0: ring 9(kiq_2.1.0) uses VM inv eng
>>> 13 on hub 0
>>>      [    1.200918] amdgpu 0000:09:00.0: ring 10(sdma0) uses VM inv eng 4
>>> on hub 1
>>>      [    1.200935] amdgpu 0000:09:00.0: ring 11(vcn_dec) uses VM inv eng
>>> 5 on hub 1
>>>      [    1.200952] amdgpu 0000:09:00.0: ring 12(vcn_enc0) uses VM inv eng
>>> 6 on hub 1
>>>      [    1.200970] amdgpu 0000:09:00.0: ring 13(vcn_enc1) uses VM inv eng
>>> 7 on hub 1
>>>      [    1.204453] [drm] Initialized amdgpu 3.23.0 20150101 for
>>> 0000:09:00.0 on minor 0
>>>
>>> -- Piotr.
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

Hi,

On 2018-03-06 12:18, Tom St Denis wrote:
> I believe this is the same issue I had which is a VGA handoff problem.
> 
> Can you try this patch the display team sent me?
> 
> Harry:  Will this patch be promoted in the next cycle?

What is the base for this patch? I cannot apply it on the top of any 
4.16-rc I try

     1 out of 4 hunks FAILED -- saving rejects to file 
drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h.rej

is there any tree that contain this fix, that I can clone sources from?

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Tom St Denis]

I routinely rebase this patch on top of our amd-staging-drm-next tree at 
fdo.

https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next


Tom


On 03/06/2018 12:27 PM, KARBOWSKI Piotr wrote:
> Hi,
> 
> On 2018-03-06 12:18, Tom St Denis wrote:
>> I believe this is the same issue I had which is a VGA handoff problem.
>>
>> Can you try this patch the display team sent me?
>>
>> Harry:  Will this patch be promoted in the next cycle?
> 
> What is the base for this patch? I cannot apply it on the top of any 
> 4.16-rc I try
> 
>      1 out of 4 hunks FAILED -- saving rejects to file 
> drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h.rej
> 
> is there any tree that contain this fix, that I can clone sources from?
> 
> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-06 18:28, Tom St Denis wrote:
> I routinely rebase this patch on top of our amd-staging-drm-next tree at 
> fdo.
> 
> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next

Awesome.

So I used this tree, branch amd-staging-drm-next, and applied the patch 
- and my screen works now!

Is there a chance that those changes will still be included in 4.16, 
like, next rc?

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Tom St Denis]

It's in the next set of display patches for drm-next but I don't think 
it'll be in 4.16 at this point unless it gets cherry picked out.

Alex would know for sure since he co-ordinates that with Dave.

Tom

On 03/06/2018 12:38 PM, KARBOWSKI Piotr wrote:
> On 2018-03-06 18:28, Tom St Denis wrote:
>> I routinely rebase this patch on top of our amd-staging-drm-next tree 
>> at fdo.
>>
>> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next
> 
> Awesome.
> 
> So I used this tree, branch amd-staging-drm-next, and applied the patch 
> - and my screen works now!
> 
> Is there a chance that those changes will still be included in 4.16, 
> like, next rc?
> 
> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

I'm prepping some cherry-picks for drm-fixes-4.16, including this. Should've done that a while ago, but shouldn't be too late yet.

Harry

On 2018-03-07 07:55 AM, Tom St Denis wrote:
> It's in the next set of display patches for drm-next but I don't think it'll be in 4.16 at this point unless it gets cherry picked out.
> 
> Alex would know for sure since he co-ordinates that with Dave.
> 
> Tom
> 
> On 03/06/2018 12:38 PM, KARBOWSKI Piotr wrote:
>> On 2018-03-06 18:28, Tom St Denis wrote:
>>> I routinely rebase this patch on top of our amd-staging-drm-next tree at fdo.
>>>
>>> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next
>>
>> Awesome.
>>
>> So I used this tree, branch amd-staging-drm-next, and applied the patch - and my screen works now!
>>
>> Is there a chance that those changes will still be included in 4.16, like, next rc?
>>
>> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

On 2018-03-07 09:55 AM, Harry Wentland wrote:
> I'm prepping some cherry-picks for drm-fixes-4.16, including this. Should've done that a while ago, but shouldn't be too late yet.
> 

Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo at https://cgit.freedesktop.org/~hwentland/linux/ but I don't have a Raven system setup to test this at the moment.

Tom, or Piotr, would you be able to check that the fix works as intended on that branch?

Harry

> Harry
> 
> On 2018-03-07 07:55 AM, Tom St Denis wrote:
>> It's in the next set of display patches for drm-next but I don't think it'll be in 4.16 at this point unless it gets cherry picked out.
>>
>> Alex would know for sure since he co-ordinates that with Dave.
>>
>> Tom
>>
>> On 03/06/2018 12:38 PM, KARBOWSKI Piotr wrote:
>>> On 2018-03-06 18:28, Tom St Denis wrote:
>>>> I routinely rebase this patch on top of our amd-staging-drm-next tree at fdo.
>>>>
>>>> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next
>>>
>>> Awesome.
>>>
>>> So I used this tree, branch amd-staging-drm-next, and applied the patch - and my screen works now!
>>>
>>> Is there a chance that those changes will still be included in 4.16, like, next rc?
>>>
>>> -- Piotr.
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Tom St Denis]

Cloning/building will take a bit.  I'll let you know later this afternoon.

Cheers,
Tom

On 03/07/2018 11:14 AM, Harry Wentland wrote:
> On 2018-03-07 09:55 AM, Harry Wentland wrote:
>> I'm prepping some cherry-picks for drm-fixes-4.16, including this. Should've done that a while ago, but shouldn't be too late yet.
>>
> 
> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo at https://cgit.freedesktop.org/~hwentland/linux/ but I don't have a Raven system setup to test this at the moment.
> 
> Tom, or Piotr, would you be able to check that the fix works as intended on that branch?
> 
> Harry
> 
>> Harry
>>
>> On 2018-03-07 07:55 AM, Tom St Denis wrote:
>>> It's in the next set of display patches for drm-next but I don't think it'll be in 4.16 at this point unless it gets cherry picked out.
>>>
>>> Alex would know for sure since he co-ordinates that with Dave.
>>>
>>> Tom
>>>
>>> On 03/06/2018 12:38 PM, KARBOWSKI Piotr wrote:
>>>> On 2018-03-06 18:28, Tom St Denis wrote:
>>>>> I routinely rebase this patch on top of our amd-staging-drm-next tree at fdo.
>>>>>
>>>>> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next
>>>>
>>>> Awesome.
>>>>
>>>> So I used this tree, branch amd-staging-drm-next, and applied the patch - and my screen works now!
>>>>
>>>> Is there a chance that those changes will still be included in 4.16, like, next rc?
>>>>
>>>> -- Piotr.
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-07 17:14, Harry Wentland wrote:
> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo athttps://cgit.freedesktop.org/~hwentland/linux/  but I don't have a Raven system setup to test this at the moment.
> 
> Tom, or Piotr, would you be able to check that the fix works as intended on that branch?

Tested that branch, confirmed that the VGA patch is there but I got the 
original result of broken video. Rebooted few times. It seems that my 
issue was not the VGA turnover afterall. I will re-test it with vanilla 
amd-staging-drm-next of git://people.freedesktop.org/~agd5f/linux 
without the VGA patch and update you.

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-07 17:48, KARBOWSKI Piotr wrote:
> On 2018-03-07 17:14, Harry Wentland wrote:
>> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo 
>> athttps://cgit.freedesktop.org/~hwentland/linux/  but I don't have a 
>> Raven system setup to test this at the moment.
>>
>> Tom, or Piotr, would you be able to check that the fix works as 
>> intended on that branch?
> 
> Tested that branch, confirmed that the VGA patch is there but I got the 
> original result of broken video. Rebooted few times. It seems that my 
> issue was not the VGA turnover afterall. I will re-test it with vanilla 
> amd-staging-drm-next of git://people.freedesktop.org/~agd5f/linux 
> without the VGA patch and update you.

I re-tested original tree of git://people.freedesktop.org/~agd5f/linux 
on branch amd-staging-drm-next and got the 'double screen' glitches, 
then I applied the patch Tom sent me as the very first response to this 
thread and then it indeed fixed it. So the VGA takeover patch is needed 
it, it seems.

I triple checked and build the images and the drm-fixes-4.16 of 
git://people.freedesktop.org/~hwentland/linux does not fix the problem 
for me.

So far only amd-staging-drm-next with 
0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch does the trick. 
One thing worth note is that the amd-staging-drm-next goes as `rc1` 
where yours fork Harry appears to be rc3, no idea if it's related or not.

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

On 2018-03-07 12:38 PM, KARBOWSKI Piotr wrote:
> On 2018-03-07 17:48, KARBOWSKI Piotr wrote:
>> On 2018-03-07 17:14, Harry Wentland wrote:
>>> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo athttps://cgit.freedesktop.org/~hwentland/linux/  but I don't have a Raven system setup to test this at the moment.
>>>
>>> Tom, or Piotr, would you be able to check that the fix works as intended on that branch?
>>
>> Tested that branch, confirmed that the VGA patch is there but I got the original result of broken video. Rebooted few times. It seems that my issue was not the VGA turnover afterall. I will re-test it with vanilla amd-staging-drm-next of git://people.freedesktop.org/~agd5f/linux without the VGA patch and update you.

Thanks for testing.

What do you mean with broken video? I tried going back in the email thread but I'm not 100% clear what you mean by this.

BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream kernel. amd-staging-drm-next is our development tree and quite a bit farther ahead in development. I'm trying to find fixes to backmerge to 4.16 to make everyone happy when it releases.

Harry

> 
> I re-tested original tree of git://people.freedesktop.org/~agd5f/linux on branch amd-staging-drm-next and got the 'double screen' glitches, then I applied the patch Tom sent me as the very first response to this thread and then it indeed fixed it. So the VGA takeover patch is needed it, it seems.
> 
> I triple checked and build the images and the drm-fixes-4.16 of git://people.freedesktop.org/~hwentland/linux does not fix the problem for me.
> 
> So far only amd-staging-drm-next with 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch does the trick. One thing worth note is that the amd-staging-drm-next goes as `rc1` where yours fork Harry appears to be rc3, no idea if it's related or not.
> 
> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Tom St Denis]

It's an old patch but does drm-fixes-4.16 have this patch

commit e92b44fdee3ec0b679bacdb9c7e95e55699167f0 

Refs: v4.14-rc3-1871-ge92b44fdee3e 

Author:     Tony Cheng <tony.cheng@amd.com> 

AuthorDate: Thu Oct 5 14:38:46 2017 -0400 

Commit:     Alex Deucher <alexander.deucher@amd.com> 

CommitDate: Sat Oct 21 16:52:21 2017 -0400 


     drm/amd/display: default force_single_disp_pipe_split = 1 on RV

     1080p idle, stutter efficiency goes up from 95.8% to 97.8%
     result in 5mW saving from APU and 8mW saving from DDR4

     Signed-off-by: Tony Cheng <tony.cheng@amd.com> 

     Reviewed-by: Yongqiang Sun <yongqiang.sun@amd.com> 

     Acked-by: Harry Wentland <Harry.Wentland@amd.com> 

     Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 


?

Tom

On 03/07/2018 02:12 PM, Harry Wentland wrote:
> On 2018-03-07 12:38 PM, KARBOWSKI Piotr wrote:
>> On 2018-03-07 17:48, KARBOWSKI Piotr wrote:
>>> On 2018-03-07 17:14, Harry Wentland wrote:
>>>> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo athttps://cgit.freedesktop.org/~hwentland/linux/  but I don't have a Raven system setup to test this at the moment.
>>>>
>>>> Tom, or Piotr, would you be able to check that the fix works as intended on that branch?
>>>
>>> Tested that branch, confirmed that the VGA patch is there but I got the original result of broken video. Rebooted few times. It seems that my issue was not the VGA turnover afterall. I will re-test it with vanilla amd-staging-drm-next of git://people.freedesktop.org/~agd5f/linux without the VGA patch and update you.
> 
> Thanks for testing.
> 
> What do you mean with broken video? I tried going back in the email thread but I'm not 100% clear what you mean by this.
> 
> BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream kernel. amd-staging-drm-next is our development tree and quite a bit farther ahead in development. I'm trying to find fixes to backmerge to 4.16 to make everyone happy when it releases.
> 
> Harry
> 
>>
>> I re-tested original tree of git://people.freedesktop.org/~agd5f/linux on branch amd-staging-drm-next and got the 'double screen' glitches, then I applied the patch Tom sent me as the very first response to this thread and then it indeed fixed it. So the VGA takeover patch is needed it, it seems.
>>
>> I triple checked and build the images and the drm-fixes-4.16 of git://people.freedesktop.org/~hwentland/linux does not fix the problem for me.
>>
>> So far only amd-staging-drm-next with 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch does the trick. One thing worth note is that the amd-staging-drm-next goes as `rc1` where yours fork Harry appears to be rc3, no idea if it's related or not.
>>
>> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

Yup, that's there as

commit e92b44fdee3ec0b679bacdb9c7e95e55699167f0
Author: Tony Cheng <tony.cheng@amd.com>
Date:   Thu Oct 5 14:38:46 2017 -0400

    drm/amd/display: default force_single_disp_pipe_split = 1 on RV

...


Harry

On 2018-03-07 02:16 PM, Tom St Denis wrote:
> It's an old patch but does drm-fixes-4.16 have this patch
> 
> commit e92b44fdee3ec0b679bacdb9c7e95e55699167f0
> Refs: v4.14-rc3-1871-ge92b44fdee3e
> Author:     Tony Cheng <tony.cheng@amd.com>
> AuthorDate: Thu Oct 5 14:38:46 2017 -0400
> Commit:     Alex Deucher <alexander.deucher@amd.com>
> CommitDate: Sat Oct 21 16:52:21 2017 -0400
> 
>     drm/amd/display: default force_single_disp_pipe_split = 1 on RV
> 
>     1080p idle, stutter efficiency goes up from 95.8% to 97.8%
>     result in 5mW saving from APU and 8mW saving from DDR4
> 
>     Signed-off-by: Tony Cheng <tony.cheng@amd.com>
>     Reviewed-by: Yongqiang Sun <yongqiang.sun@amd.com>
>     Acked-by: Harry Wentland <Harry.Wentland@amd.com>
>     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> 
> ?
> 
> Tom
> 
> On 03/07/2018 02:12 PM, Harry Wentland wrote:
>> On 2018-03-07 12:38 PM, KARBOWSKI Piotr wrote:
>>> On 2018-03-07 17:48, KARBOWSKI Piotr wrote:
>>>> On 2018-03-07 17:14, Harry Wentland wrote:
>>>>> Pushed a drm-fixes-4.16 branch (based on Alex's) to my FDO repo athttps://cgit.freedesktop.org/~hwentland/linux/  but I don't have a Raven system setup to test this at the moment.
>>>>>
>>>>> Tom, or Piotr, would you be able to check that the fix works as intended on that branch?
>>>>
>>>> Tested that branch, confirmed that the VGA patch is there but I got the original result of broken video. Rebooted few times. It seems that my issue was not the VGA turnover afterall. I will re-test it with vanilla amd-staging-drm-next of git://people.freedesktop.org/~agd5f/linux without the VGA patch and update you.
>>
>> Thanks for testing.
>>
>> What do you mean with broken video? I tried going back in the email thread but I'm not 100% clear what you mean by this.
>>
>> BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream kernel. amd-staging-drm-next is our development tree and quite a bit farther ahead in development. I'm trying to find fixes to backmerge to 4.16 to make everyone happy when it releases.
>>
>> Harry
>>
>>>
>>> I re-tested original tree of git://people.freedesktop.org/~agd5f/linux on branch amd-staging-drm-next and got the 'double screen' glitches, then I applied the patch Tom sent me as the very first response to this thread and then it indeed fixed it. So the VGA takeover patch is needed it, it seems.
>>>
>>> I triple checked and build the images and the drm-fixes-4.16 of git://people.freedesktop.org/~hwentland/linux does not fix the problem for me.
>>>
>>> So far only amd-staging-drm-next with 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch does the trick. One thing worth note is that the amd-staging-drm-next goes as `rc1` where yours fork Harry appears to be rc3, no idea if it's related or not.
>>>
>>> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-07 20:12, Harry Wentland wrote:
> Thanks for testing.
> 
> What do you mean with broken video? I tried going back in the email thread but I'm not 100% clear what you mean by this.
> 
> BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream kernel. amd-staging-drm-next is our development tree and quite a bit farther ahead in development. I'm trying to find fixes to backmerge to 4.16 to make everyone happy when it releases.

Like on those screenshots


     https://i.imgur.com/qnDOKY7.jpg
     https://i.imgur.com/XH42zit.jpg

To describe it better, lets split the screen into 4 segments

+-----+-----+
|  A  |  B  |
+-----+-----+
|  C  |  D  |
+-----+-----+

The screen resolution kicks in as it should, 1080p, then A displays 
proper part of screen, around 25%, then B contain a copy of what A 
displays, so the same 25% of top-left part of screen, then C and D 
remain black, if I scroll the screen a bit, C and D an get a bold 
vertical line of whatever color was on screen, if I had a white/gray 
font, it will be it, if there was some blue text, it will be blue until 
I scroll a bit more.


drm-fixes-4.16 yield the same effect as amd-staging-drm-next without 
0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch, but it seems that 
htis patch is already in drm-fixes-4.16 so I am confused.

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-07 20:31, KARBOWSKI Piotr wrote:
> On 2018-03-07 20:12, Harry Wentland wrote:
>> Thanks for testing.
>>
>> What do you mean with broken video? I tried going back in the email 
>> thread but I'm not 100% clear what you mean by this.
>>
>> BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream 
>> kernel. amd-staging-drm-next is our development tree and quite a bit 
>> farther ahead in development. I'm trying to find fixes to backmerge to 
>> 4.16 to make everyone happy when it releases.
> 
> Like on those screenshots
> 
> 
>      https://i.imgur.com/qnDOKY7.jpg
>      https://i.imgur.com/XH42zit.jpg
> 
> To describe it better, lets split the screen into 4 segments
> 
> +-----+-----+
> |  A  |  B  |
> +-----+-----+
> |  C  |  D  |
> +-----+-----+
> 
> The screen resolution kicks in as it should, 1080p, then A displays 
> proper part of screen, around 25%, then B contain a copy of what A 
> displays, so the same 25% of top-left part of screen, then C and D 
> remain black, if I scroll the screen a bit, C and D an get a bold 
> vertical line of whatever color was on screen, if I had a white/gray 
> font, it will be it, if there was some blue text, it will be blue until 
> I scroll a bit more.
> 
> 
> drm-fixes-4.16 yield the same effect as amd-staging-drm-next without 
> 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch, but it seems that 
> htis patch is already in drm-fixes-4.16 so I am confused.

I was not correct.

The drm-fixes-4.16 is a bit better It fixes half of my issue! So with 
this handy ascii art of mine

   +-----+-----+
   |  A  |  B  |
   +-----+-----+
   |  C  |  D  |
   +-----+-----+

A and C works, so I have full termianl on left side. but B remains copy 
of A and D either is black of have the fancy line.

I compared manually the patch that did worked for me and it seems it was 
not fully applied, the .h and .c does not look the same. Perhaps that's 
the source here.

-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[Harry Wentland]

On 2018-03-07 02:54 PM, KARBOWSKI Piotr wrote:
> On 2018-03-07 20:31, KARBOWSKI Piotr wrote:
>> On 2018-03-07 20:12, Harry Wentland wrote:
>>> Thanks for testing.
>>>
>>> What do you mean with broken video? I tried going back in the email thread but I'm not 100% clear what you mean by this.
>>>
>>> BTW, drm-fixes-4.16 are fixes we intend to get into the 4.16 upstream kernel. amd-staging-drm-next is our development tree and quite a bit farther ahead in development. I'm trying to find fixes to backmerge to 4.16 to make everyone happy when it releases.
>>
>> Like on those screenshots
>>
>>
>>      https://i.imgur.com/qnDOKY7.jpg
>>      https://i.imgur.com/XH42zit.jpg
>>
>> To describe it better, lets split the screen into 4 segments
>>
>> +-----+-----+
>> |  A  |  B  |
>> +-----+-----+
>> |  C  |  D  |
>> +-----+-----+
>>
>> The screen resolution kicks in as it should, 1080p, then A displays proper part of screen, around 25%, then B contain a copy of what A displays, so the same 25% of top-left part of screen, then C and D remain black, if I scroll the screen a bit, C and D an get a bold vertical line of whatever color was on screen, if I had a white/gray font, it will be it, if there was some blue text, it will be blue until I scroll a bit more.
>>
>>
>> drm-fixes-4.16 yield the same effect as amd-staging-drm-next without 0001-drm-amd-display-Fix-takeover-from-VGA-mode.patch, but it seems that htis patch is already in drm-fixes-4.16 so I am confused.
> 
> I was not correct.
> 
> The drm-fixes-4.16 is a bit better It fixes half of my issue! So with this handy ascii art of mine
> 
>   +-----+-----+
>   |  A  |  B  |
>   +-----+-----+
>   |  C  |  D  |
>   +-----+-----+
> 
> A and C works, so I have full termianl on left side. but B remains copy of A and D either is black of have the fancy line.
> 

amd-stg has some other patches relating to DCN pipe-split that I don't fully understand. We might need one or more of those.

As a workaround you can probably set 'force_single_disp_pipe_split' to 'false' in 'debug_defaults_drv' in dc/dcn10/dcn10_resource.c.

Harry

> I compared manually the patch that did worked for me and it seems it was not fully applied, the .h and .c does not look the same. Perhaps that's the source here.
> 
> -- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Modesetting (amdgpudrmfb) artifacts on RAVEN APU

[KARBOWSKI Piotr]

On 2018-03-07 22:15, Harry Wentland wrote:
> amd-stg has some other patches relating to DCN pipe-split that I don't fully understand. We might need one or more of those.
> 
> As a workaround you can probably set 'force_single_disp_pipe_split' to 'false' in 'debug_defaults_drv' in dc/dcn10/dcn10_resource.c.


Thank you for the information. This indeed make it working on 
drm-fixes-4.16.


diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
index 44825e2c9ebb..df5eefbcc854 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
@@ -444,7 +444,7 @@ static const struct dc_debug debug_defaults_drv = {
                 .disable_pplib_wm_range = false,
                 .pplib_wm_report_mode = WM_REPORT_DEFAULT,
                 .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
-               .force_single_disp_pipe_split = true,
+               .force_single_disp_pipe_split = false,
                 .disable_dcc = DCC_ENABLE,
                 .voltage_align_fclk = true,
                 .disable_stereo_support = true,


-- Piotr.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx