* [PATCH 0/2] selftests/damon: trivial fixes @ 2022-02-18 0:10 Yuanchu Xie 2022-02-18 0:10 ` [PATCH 1/2] selftests/damon: add damon to selftests root Makefile Yuanchu Xie 2022-02-18 0:10 ` [PATCH 2/2] selftests/damon: make selftests executable Yuanchu Xie 0 siblings, 2 replies; 10+ messages in thread From: Yuanchu Xie @ 2022-02-18 0:10 UTC (permalink / raw) To: Shuah Khan, Markus Boehme, SeongJae Park Cc: rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel, Yuanchu Xie These patches fixes trivial errors with building and running DAMON selftests. Yuanchu Xie (2): selftests/damon: add damon to selftests root Makefile selftests/damon: make selftests executable tools/testing/selftests/Makefile | 1 + tools/testing/selftests/damon/debugfs_attrs.sh | 0 tools/testing/selftests/damon/debugfs_empty_targets.sh | 0 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0 tools/testing/selftests/damon/debugfs_schemes.sh | 0 tools/testing/selftests/damon/debugfs_target_ids.sh | 0 6 files changed, 1 insertion(+) mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh -- 2.35.1.265.g69c8d7142f-goog ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] selftests/damon: add damon to selftests root Makefile 2022-02-18 0:10 [PATCH 0/2] selftests/damon: trivial fixes Yuanchu Xie @ 2022-02-18 0:10 ` Yuanchu Xie 2022-02-18 7:50 ` SeongJae Park 2022-02-18 0:10 ` [PATCH 2/2] selftests/damon: make selftests executable Yuanchu Xie 1 sibling, 1 reply; 10+ messages in thread From: Yuanchu Xie @ 2022-02-18 0:10 UTC (permalink / raw) To: Shuah Khan, Markus Boehme, SeongJae Park Cc: rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel, Yuanchu Xie Currently the damon selftests are not built with the rest of the selftests. We add damon to the list of targets. Fixes: b348eb7abd09 ("mm/damon: add user space selftests") Signed-off-by: Yuanchu Xie <yuanchu@google.com> --- tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index d08fe4cfe811..ffe453760a12 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -9,6 +9,7 @@ TARGETS += clone3 TARGETS += core TARGETS += cpufreq TARGETS += cpu-hotplug +TARGETS += damon TARGETS += drivers/dma-buf TARGETS += efivarfs TARGETS += exec -- 2.35.1.265.g69c8d7142f-goog ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] selftests/damon: add damon to selftests root Makefile 2022-02-18 0:10 ` [PATCH 1/2] selftests/damon: add damon to selftests root Makefile Yuanchu Xie @ 2022-02-18 7:50 ` SeongJae Park 0 siblings, 0 replies; 10+ messages in thread From: SeongJae Park @ 2022-02-18 7:50 UTC (permalink / raw) To: Yuanchu Xie Cc: Shuah Khan, Markus Boehme, SeongJae Park, rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel Hi Yuanchu, thank you for this patch! On Fri, 18 Feb 2022 00:10:16 +0000 Yuanchu Xie <yuanchu@google.com> wrote: > Currently the damon selftests are not built with the rest of the > selftests. We add damon to the list of targets. > > Fixes: b348eb7abd09 ("mm/damon: add user space selftests") > Signed-off-by: Yuanchu Xie <yuanchu@google.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > tools/testing/selftests/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index d08fe4cfe811..ffe453760a12 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -9,6 +9,7 @@ TARGETS += clone3 > TARGETS += core > TARGETS += cpufreq > TARGETS += cpu-hotplug > +TARGETS += damon > TARGETS += drivers/dma-buf > TARGETS += efivarfs > TARGETS += exec > -- > 2.35.1.265.g69c8d7142f-goog ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 0:10 [PATCH 0/2] selftests/damon: trivial fixes Yuanchu Xie 2022-02-18 0:10 ` [PATCH 1/2] selftests/damon: add damon to selftests root Makefile Yuanchu Xie @ 2022-02-18 0:10 ` Yuanchu Xie 2022-02-18 7:52 ` SeongJae Park 1 sibling, 1 reply; 10+ messages in thread From: Yuanchu Xie @ 2022-02-18 0:10 UTC (permalink / raw) To: Shuah Khan, Markus Boehme, SeongJae Park Cc: rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel, Yuanchu Xie The damon selftests do not have the executable bit on. We fix that by setting the x bits on the .sh files similar to other existing shell selftests. Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") Signed-off-by: Yuanchu Xie <yuanchu@google.com> --- tools/testing/selftests/damon/debugfs_attrs.sh | 0 tools/testing/selftests/damon/debugfs_empty_targets.sh | 0 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0 tools/testing/selftests/damon/debugfs_schemes.sh | 0 tools/testing/selftests/damon/debugfs_target_ids.sh | 0 5 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh old mode 100644 new mode 100755 -- 2.35.1.265.g69c8d7142f-goog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 0:10 ` [PATCH 2/2] selftests/damon: make selftests executable Yuanchu Xie @ 2022-02-18 7:52 ` SeongJae Park 2022-02-18 8:01 ` Greg KH 0 siblings, 1 reply; 10+ messages in thread From: SeongJae Park @ 2022-02-18 7:52 UTC (permalink / raw) To: Yuanchu Xie Cc: Shuah Khan, Markus Boehme, SeongJae Park, rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel Hello Yuanchu, Thank you for this patch! On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote: > The damon selftests do not have the executable bit on. We fix that by > setting the x bits on the .sh files similar to other existing shell > selftests. > > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") > Signed-off-by: Yuanchu Xie <yuanchu@google.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > tools/testing/selftests/damon/debugfs_attrs.sh | 0 > tools/testing/selftests/damon/debugfs_empty_targets.sh | 0 > tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0 > tools/testing/selftests/damon/debugfs_schemes.sh | 0 > tools/testing/selftests/damon/debugfs_target_ids.sh | 0 > 5 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh > > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh > old mode 100644 > new mode 100755 > -- > 2.35.1.265.g69c8d7142f-goog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 7:52 ` SeongJae Park @ 2022-02-18 8:01 ` Greg KH 2022-02-18 8:24 ` SeongJae Park 0 siblings, 1 reply; 10+ messages in thread From: Greg KH @ 2022-02-18 8:01 UTC (permalink / raw) To: SeongJae Park Cc: Yuanchu Xie, Shuah Khan, Markus Boehme, rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: > Hello Yuanchu, > > Thank you for this patch! > > On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote: > > > The damon selftests do not have the executable bit on. We fix that by > > setting the x bits on the .sh files similar to other existing shell > > selftests. > > > > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") > > Signed-off-by: Yuanchu Xie <yuanchu@google.com> > > Reviewed-by: SeongJae Park <sj@kernel.org> This type of change does not work outside of git, so why not just make the tool that calls these scripts not care about the executable bit like we do for other scripts? thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 8:01 ` Greg KH @ 2022-02-18 8:24 ` SeongJae Park 2022-02-18 22:20 ` Shuah Khan 0 siblings, 1 reply; 10+ messages in thread From: SeongJae Park @ 2022-02-18 8:24 UTC (permalink / raw) To: Greg KH Cc: SeongJae Park, Yuanchu Xie, Shuah Khan, Markus Boehme, rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel On Fri, 18 Feb 2022 09:01:11 +0100 Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: > > Hello Yuanchu, > > > > Thank you for this patch! > > > > On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote: > > > > > The damon selftests do not have the executable bit on. We fix that by > > > setting the x bits on the .sh files similar to other existing shell > > > selftests. > > > > > > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") > > > Signed-off-by: Yuanchu Xie <yuanchu@google.com> > > > > Reviewed-by: SeongJae Park <sj@kernel.org> > > This type of change does not work outside of git, so why not just make > the tool that calls these scripts not care about the executable bit like > we do for other scripts? Actually, we made kselftest receives scripts having no executable bit[1], though it still prints warning. I guess Yuanchu wants to remove the warning? To remove the warning, simply making kselftest (runner.sh) stop printing the warning message might make more sense. Nevertheless, it's also true that letting some scripts have executable bits while others not looks inconsistent to me. That's why I left the warning message there. Should we remove the warning from kselftest and remove executable bits from other selftest test scripts? Or, let the inconsistency be? I have no real opinion here, so just wanted to hear others' opinion if possible. BTW, similar issue is also in Kconfig's 'shell' macro. For example, 'runst-version.sh' on -mm tree bothered me before[2], and now 'pahole-version.sh'. I might make change in 'scrips/Kconfig/preprocess.c' later. [1] https://lore.kernel.org/linux-kselftest/20210810164534.25902-1-sj38.park@gmail.com/ [2] https://lore.kernel.org/all/20220110085952.6137-1-sj@kernel.org/ Thanks, SJ > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 8:24 ` SeongJae Park @ 2022-02-18 22:20 ` Shuah Khan 2022-04-18 20:06 ` Yuanchu Xie 0 siblings, 1 reply; 10+ messages in thread From: Shuah Khan @ 2022-02-18 22:20 UTC (permalink / raw) To: SeongJae Park, Greg KH Cc: Yuanchu Xie, Shuah Khan, Markus Boehme, rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel, Shuah Khan On 2/18/22 1:24 AM, SeongJae Park wrote: > On Fri, 18 Feb 2022 09:01:11 +0100 Greg KH <gregkh@linuxfoundation.org> wrote: > >> On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: >>> Hello Yuanchu, >>> >>> Thank you for this patch! >>> >>> On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote: >>> >>>> The damon selftests do not have the executable bit on. We fix that by >>>> setting the x bits on the .sh files similar to other existing shell >>>> selftests. >>>> >>>> Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") >>>> Signed-off-by: Yuanchu Xie <yuanchu@google.com> >>> >>> Reviewed-by: SeongJae Park <sj@kernel.org> >> >> This type of change does not work outside of git, so why not just make >> the tool that calls these scripts not care about the executable bit like >> we do for other scripts? > > Actually, we made kselftest receives scripts having no executable bit[1], > though it still prints warning. I guess Yuanchu wants to remove the warning? > > To remove the warning, simply making kselftest (runner.sh) stop printing the > warning message might make more sense. Nevertheless, it's also true that > letting some scripts have executable bits while others not looks inconsistent > to me. That's why I left the warning message there. Should we remove the > warning from kselftest and remove executable bits from other selftest test > scripts? Or, let the inconsistency be? I have no real opinion here, so just > wanted to hear others' opinion if possible. > I don't recall why we decided to add the check in runner.sh - let's keep them consistent with the rest of the scripts. If we get rid of the check, we can make the change then. thanks, -- Shuah ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-02-18 22:20 ` Shuah Khan @ 2022-04-18 20:06 ` Yuanchu Xie 2022-04-18 20:13 ` Yuanchu Xie 0 siblings, 1 reply; 10+ messages in thread From: Yuanchu Xie @ 2022-04-18 20:06 UTC (permalink / raw) To: Shuah Khan Cc: SeongJae Park, Greg KH, Shuah Khan, Markus Boehme, David Rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1247 bytes --] > > I don't recall why we decided to add the check in runner.sh - let's keep > them > consistent with the rest of the scripts. If we get rid of the check, we can > make the change then. > > thanks, > -- Shuah It seems reasonable to add the x bit for these tests to be consistent with the rest. I also received an email from a patchwork-bot+linux-kselftest@kernel.org telling me my patch series was included in shuah/linux-kselftest.git, but that does not seem to be the case. Is this a bug? Hello: > This series was applied to shuah/linux-kselftest.git (next) by Jakub Kicinski <kuba@kernel.org>: > On Fri, 18 Feb 2022 00:10:15 +0000 you wrote: > > These patches fixes trivial errors with building > > and running DAMON selftests. > > > > Yuanchu Xie (2): > > selftests/damon: add damon to selftests root Makefile > > selftests/damon: make selftests executable > > > > [...] > Here is the summary with links: > - [1/2] selftests/damon: add damon to selftests root Makefile > (no matching commit) > - [2/2] selftests/damon: make selftests executable > https://git.kernel.org/shuah/linux-kselftest/c/1335648f0b6f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html [-- Attachment #2: Type: text/html, Size: 3580 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] selftests/damon: make selftests executable 2022-04-18 20:06 ` Yuanchu Xie @ 2022-04-18 20:13 ` Yuanchu Xie 0 siblings, 0 replies; 10+ messages in thread From: Yuanchu Xie @ 2022-04-18 20:13 UTC (permalink / raw) To: Shuah Khan Cc: Shuah Khan, Markus Boehme, David Rientjes, Andrew Morton, linux-mm, linux-kselftest, linux-kernel, SeongJae Park, Greg KH > I don't recall why we decided to add the check in runner.sh - let's keep them > consistent with the rest of the scripts. If we get rid of the check, we can > make the change then. > > thanks, > -- Shuah It seems reasonable to add the x bit for these tests to be consistent with the rest. I also received an email from a patchwork-bot+linux-kselftest@kernel.org telling me my patch series was included in shuah/linux-kselftest.git, but that does not seem to be the case. Is this a bug? Sorry about the previous non-plain-text email. I never replied to anyone before and didn't know what I was doing. > Hello: > > > This series was applied to shuah/linux-kselftest.git (next) > > by Jakub Kicinski <kuba@kernel.org>: > > > On Fri, 18 Feb 2022 00:10:15 +0000 you wrote: > > These patches fixes trivial errors with building > > and running DAMON selftests. > > > > Yuanchu Xie (2): > > selftests/damon: add damon to selftests root Makefile > > selftests/damon: make selftests executable > > > > [...] > > > Here is the summary with links: > - [1/2] selftests/damon: add damon to selftests root Makefile > (no matching commit) > - [2/2] selftests/damon: make selftests executable > https://git.kernel.org/shuah/linux-kselftest/c/1335648f0b6f > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-04-18 20:13 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-18 0:10 [PATCH 0/2] selftests/damon: trivial fixes Yuanchu Xie 2022-02-18 0:10 ` [PATCH 1/2] selftests/damon: add damon to selftests root Makefile Yuanchu Xie 2022-02-18 7:50 ` SeongJae Park 2022-02-18 0:10 ` [PATCH 2/2] selftests/damon: make selftests executable Yuanchu Xie 2022-02-18 7:52 ` SeongJae Park 2022-02-18 8:01 ` Greg KH 2022-02-18 8:24 ` SeongJae Park 2022-02-18 22:20 ` Shuah Khan 2022-04-18 20:06 ` Yuanchu Xie 2022-04-18 20:13 ` Yuanchu Xie
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.